- Dillo-dev - lists.mailman3.com

Missing dillo.1.in

by Johannes.Hofmann＠gmx.de

On Thu, Mar 07, 2013 at 08:06:13PM +0100, Johannes Hofmann wrote: > On Thu, Mar 07, 2013 at 06:36:17PM +0000, Jeremy Henty wrote: > > > > Did someone forget to add a file? (Build log attached.) > > The file seems to be there: > http://hg.dillo.org/dillo/file/86f817232a5f/doc/dillo.1.in > I think the problem is related to the separate "Build" directory in > your case. How did you set this up? > I'd like to fix that case. Should be fixed now. Please give it a try. Cheers, Johannes

March 7, 2013

Missing dillo.1.in

by Johannes.Hofmann＠gmx.de

On Thu, Mar 07, 2013 at 06:36:17PM +0000, Jeremy Henty wrote: > > Did someone forget to add a file? (Build log attached.) The file seems to be there: http://hg.dillo.org/dillo/file/86f817232a5f/doc/dillo.1.in I think the problem is related to the separate "Build" directory in your case. How did you set this up? I'd like to fix that case. Regards, Johannes > > Regards, > > Jeremy Henty > make all-recursive > make[1]: Entering directory `/home/jeremy/Personal/Geeky/Dillo/Build' > Making all in lout > make[2]: Entering directory `/home/jeremy/Personal/Geeky/Dillo/Build/lout' > make[2]: Nothing to be done for `all'. > make[2]: Leaving directory `/home/jeremy/Personal/Geeky/Dillo/Build/lout' > Making all in dw > make[2]: Entering directory `/home/jeremy/Personal/Geeky/Dillo/Build/dw' > make[2]: Nothing to be done for `all'. > make[2]: Leaving directory `/home/jeremy/Personal/Geeky/Dillo/Build/dw' > Making all in dlib > make[2]: Entering directory `/home/jeremy/Personal/Geeky/Dillo/Build/dlib' > make[2]: Nothing to be done for `all'. > make[2]: Leaving directory `/home/jeremy/Personal/Geeky/Dillo/Build/dlib' > Making all in dpip > make[2]: Entering directory `/home/jeremy/Personal/Geeky/Dillo/Build/dpip' > make[2]: Nothing to be done for `all'. > make[2]: Leaving directory `/home/jeremy/Personal/Geeky/Dillo/Build/dpip' > Making all in src > make[2]: Entering directory `/home/jeremy/Personal/Geeky/Dillo/Build/src' > Making all in IO > make[3]: Entering directory `/home/jeremy/Personal/Geeky/Dillo/Build/src/IO' > make[3]: Nothing to be done for `all'. > make[3]: Leaving directory `/home/jeremy/Personal/Geeky/Dillo/Build/src/IO' > make[3]: Entering directory `/home/jeremy/Personal/Geeky/Dillo/Build/src' > make[3]: Nothing to be done for `all-am'. > make[3]: Leaving directory `/home/jeremy/Personal/Geeky/Dillo/Build/src' > make[2]: Leaving directory `/home/jeremy/Personal/Geeky/Dillo/Build/src' > Making all in doc > make[2]: Entering directory `/home/jeremy/Personal/Geeky/Dillo/Build/doc' > sed 's%/usr/local%/usr%g' < dillo.1.in > dillo.1 > /bin/sh: dillo.1.in: No such file or directory > make[2]: *** [dillo.1] Error 1 > make[2]: Leaving directory `/home/jeremy/Personal/Geeky/Dillo/Build/doc' > make[1]: *** [all-recursive] Error 1 > make[1]: Leaving directory `/home/jeremy/Personal/Geeky/Dillo/Build' > make: *** [all] Error 2 > _______________________________________________ > Dillo-dev mailing list > Dillo-dev at dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

March 7, 2013

Missing dillo.1.in

by onepoint＠starurchin.org

Did someone forget to add a file? (Build log attached.) Regards, Jeremy Henty

March 7, 2013

release preperations

by Johannes.Hofmann＠gmx.de

On Wed, Mar 06, 2013 at 10:28:34PM +0100, Sebastian Geerken wrote: > On Wed, Mar 06, Johannes Hofmann wrote: > > On Tue, Mar 05, 2013 at 11:35:02PM +0100, Sebastian Geerken wrote: > > > "man dillo" shows > > > > > > In order to use the hyphenation feature, pattern files from CTAN need > > > to be installed to ${prefix}/lib/dillo/hyphenation/. This can be done > > > with the script install-hyphenation. Call it with ISO-639-1 language > > > codes as arguments, or without arguments to get more help. > > > > > > "${prefix}" should be replaced here. > > > > Yes. Does someone know how this is best done with automake? > > Move doc/dillo.1 to doc/dillo.1.in and add this to doc/Makefile.am: > > diff -r f37ab8cb8930 doc/Makefile.am > --- a/doc/Makefile.am Tue Mar 05 19:47:09 2013 +0100 > +++ b/doc/Makefile.am Wed Mar 06 22:24:33 2013 +0100 > @@ -39,3 +39,6 @@ > Selection.txt \ > Dpid.txt \ > README > + > +dillo.1: > + sed 's%.{prefix}%${prefix}%g' < dillo.1.in > dillo.1 > > This replaces ${prefix} by the actual value. I could not get the "$" > into the sed expression (therefore the "."), so this is not perfect. Thanks, I pushed it. Johannes

March 6, 2013

release preperations

by sgeerken＠dillo.org

On Wed, Mar 06, Johannes Hofmann wrote: > On Tue, Mar 05, 2013 at 11:35:02PM +0100, Sebastian Geerken wrote: > > "man dillo" shows > > > > In order to use the hyphenation feature, pattern files from CTAN need > > to be installed to ${prefix}/lib/dillo/hyphenation/. This can be done > > with the script install-hyphenation. Call it with ISO-639-1 language > > codes as arguments, or without arguments to get more help. > > > > "${prefix}" should be replaced here. > > Yes. Does someone know how this is best done with automake? Move doc/dillo.1 to doc/dillo.1.in and add this to doc/Makefile.am: diff -r f37ab8cb8930 doc/Makefile.am --- a/doc/Makefile.am Tue Mar 05 19:47:09 2013 +0100 +++ b/doc/Makefile.am Wed Mar 06 22:24:33 2013 +0100 @@ -39,3 +39,6 @@ Selection.txt \ Dpid.txt \ README + +dillo.1: + sed 's%.{prefix}%${prefix}%g' < dillo.1.in > dillo.1 This replaces ${prefix} by the actual value. I could not get the "$" into the sed expression (therefore the "."), so this is not perfect. > > > Also we would need to install the install-hyphenation script, so > > > that it becomes part of binary packages. > > > > There would also some changes neccessary, since the script searches > > "Makefile". > > > > This is an aspect I have not yet thought about: whether the script is > > part of the installation process (as now) or the installation itself > > (as you suggest). > > If we install it it will probabely end up in binary packages and be > available for end users. > If we don't install it, we rely on packagers to deal with the > problem (e.g. to create a separate hyphenation pattern package). > > > > If we do that it would have to be renamed to > > > dillo-install-hyphenation or something like that. > > > Does this sound ok? I'll try to modify the script, so it can be installed to ${prefix}/bin. In any case, this is certainly useful. > [...] > > OTOH, if someone installs dillo from the tarball, and does not notice > > that she should download pattern files. Since hyphenation is inactive, > > when there is no pattern file installed, this feature will be > > invisible. > > > > That's why I thought to put it into the Makefile, so he sees the > > notice when he calls "make install". That's what I meant with my > > question. > > We can of course also add the notice to make install, that should > not harm anyone. Although I must admit that this approach only works for one message. Sebastian

March 6, 2013

release preperations

by Johannes.Hofmann＠gmx.de

On Tue, Mar 05, 2013 at 11:35:02PM +0100, Sebastian Geerken wrote: > Hi, > > I hope I am, as the developer of hyphenation, not biased on this > topic. :-) > > > On Sat, Mar 02, 2013 at 07:57:26PM +0100, Sebastian Geerken wrote: > > > > > As for the way to inform the user, see attached patch, which will let > > > > > "make install" (and friends) print a message. Comments? > > > > > > > > Nice, but most users will get precompiled packages from their > > > > distributions. > > > > > > > > > How is the other work on the release going on? What is still missing? > > > > > > > > I started a couple of times to add some lines to the man page that > > > > explain how to get and install the pattern files, but never came up > > > > with anything good. Should we copy the lines from your patch below? > > > > > > How many people compiling dillo from the tarball are actually reading > > > README and the man page? > > > > At least the man page get's installed with most binary packages. > > I tried to include some info about the pattern files and how > > they can be downloaded - please give it a review. > > "man dillo" shows > > In order to use the hyphenation feature, pattern files from CTAN need > to be installed to ${prefix}/lib/dillo/hyphenation/. This can be done > with the script install-hyphenation. Call it with ISO-639-1 language > codes as arguments, or without arguments to get more help. > > "${prefix}" should be replaced here. Yes. Does someone know how this is best done with automake? > > > Also we would need to install the install-hyphenation script, so > > that it becomes part of binary packages. > > There would also some changes neccessary, since the script searches > "Makefile". > > This is an aspect I have not yet thought about: whether the script is > part of the installation process (as now) or the installation itself > (as you suggest). If we install it it will probabely end up in binary packages and be available for end users. If we don't install it, we rely on packagers to deal with the problem (e.g. to create a separate hyphenation pattern package). > > > If we do that it would have to be renamed to > > dillo-install-hyphenation or something like that. > > Does this sound ok? > > I'd leave the question, how binary packages are handled, to the > maintainers of the binary packages, since they know best how to handle > this. (E. g., Debian provides packages texlive-lang-... for each > language.) > > Perhaps package maintainers may comment on this. That would be really helpful. > > OTOH, if someone installs dillo from the tarball, and does not notice > that she should download pattern files. Since hyphenation is inactive, > when there is no pattern file installed, this feature will be > invisible. > > That's why I thought to put it into the Makefile, so he sees the > notice when he calls "make install". That's what I meant with my > question. We can of course also add the notice to make install, that should not harm anyone. Johannes

March 6, 2013

release preperations

by sgeerken＠dillo.org

Hi, I hope I am, as the developer of hyphenation, not biased on this topic. :-) > On Sat, Mar 02, 2013 at 07:57:26PM +0100, Sebastian Geerken wrote: > > > > As for the way to inform the user, see attached patch, which will let > > > > "make install" (and friends) print a message. Comments? > > > > > > Nice, but most users will get precompiled packages from their > > > distributions. > > > > > > > How is the other work on the release going on? What is still missing? > > > > > > I started a couple of times to add some lines to the man page that > > > explain how to get and install the pattern files, but never came up > > > with anything good. Should we copy the lines from your patch below? > > > > How many people compiling dillo from the tarball are actually reading > > README and the man page? > > At least the man page get's installed with most binary packages. > I tried to include some info about the pattern files and how > they can be downloaded - please give it a review. "man dillo" shows In order to use the hyphenation feature, pattern files from CTAN need to be installed to ${prefix}/lib/dillo/hyphenation/. This can be done with the script install-hyphenation. Call it with ISO-639-1 language codes as arguments, or without arguments to get more help. "${prefix}" should be replaced here. > Also we would need to install the install-hyphenation script, so > that it becomes part of binary packages. There would also some changes neccessary, since the script searches "Makefile". This is an aspect I have not yet thought about: whether the script is part of the installation process (as now) or the installation itself (as you suggest). > If we do that it would have to be renamed to > dillo-install-hyphenation or something like that. > Does this sound ok? I'd leave the question, how binary packages are handled, to the maintainers of the binary packages, since they know best how to handle this. (E. g., Debian provides packages texlive-lang-... for each language.) Perhaps package maintainers may comment on this. OTOH, if someone installs dillo from the tarball, and does not notice that she should download pattern files. Since hyphenation is inactive, when there is no pattern file installed, this feature will be invisible. That's why I thought to put it into the Makefile, so he sees the notice when he calls "make install". That's what I meant with my question. Sebastian

March 5, 2013

release preperations

by Johannes.Hofmann＠gmx.de

Hi, On Sat, Mar 02, 2013 at 07:57:26PM +0100, Sebastian Geerken wrote: > On Sat, Mar 02, Johannes Hofmann wrote: > > > I've pushed a new script, which uses the text versions (and adds the > > > licence information as comments). Should it download directly from > > > CTAN? From mirrors.dotsrc.org? Ask for a mirror? > > > > If mirrors.dotsrc.org works, that's probabely nicer - though I doubt > > we create any significant load. > > Mirrors.dotsrc.org works; I've changed the script. (Look at the > beginning.) > > > > As for the way to inform the user, see attached patch, which will let > > > "make install" (and friends) print a message. Comments? > > > > Nice, but most users will get precompiled packages from their > > distributions. > > > > > How is the other work on the release going on? What is still missing? > > > > I started a couple of times to add some lines to the man page that > > explain how to get and install the pattern files, but never came up > > with anything good. Should we copy the lines from your patch below? > > How many people compiling dillo from the tarball are actually reading > README and the man page? At least the man page get's installed with most binary packages. I tried to include some info about the pattern files and how they can be downloaded - please give it a review. Also we would need to install the install-hyphenation script, so that it becomes part of binary packages. If we do that it would have to be renamed to dillo-install-hyphenation or something like that. Does this sound ok? Cheers, Johannes PS: For me the documentation issue for hyphenation patterns is the only thing left before we could make a release candidate, or am I missing something?

March 5, 2013

https related crash

by jcid＠dillo.org

On Mon, Mar 04, 2013 at 10:07:21PM +0100, Johannes Hofmann wrote: > On Fri, Mar 01, 2013 at 01:37:13PM -0300, Jorge Arellano Cid wrote: > > Hi Johannes, > > > > On Thu, Feb 28, 2013 at 10:44:15PM +0100, Johannes Hofmann wrote: > > > Hi, > > > > > > from time to time I get the crash below. > > > Would a simple NULL check in a_Chain_check() be the correct fix? > > > > I gave it a first review, and it looks like the connection gets closed > > before the dialog sends an answer. So, at resume time, the sending branch > > is gone. It'd be great to have a test case. > > Sorry, I can't reproduce it atm. I keep trying. > > > > > Anyway, in the interim, please try the following patch: > > Will do, once I can reproduce the crash. AFAIR there're a few obscure corner cases not explicitly handled by the CCC (ATM not worth the coding effort), and those are silently caught by the CCC's check code. From a distance, and with the proposed patch, it doesn't look like a show stopper at all. -- Cheers Jorge.-

March 5, 2013

https related crash

by Johannes.Hofmann＠gmx.de

On Fri, Mar 01, 2013 at 01:37:13PM -0300, Jorge Arellano Cid wrote: > Hi Johannes, > > On Thu, Feb 28, 2013 at 10:44:15PM +0100, Johannes Hofmann wrote: > > Hi, > > > > from time to time I get the crash below. > > Would a simple NULL check in a_Chain_check() be the correct fix? > > I gave it a first review, and it looks like the connection gets closed > before the dialog sends an answer. So, at resume time, the sending branch > is gone. It'd be great to have a test case. Sorry, I can't reproduce it atm. I keep trying. > > Anyway, in the interim, please try the following patch: Will do, once I can reproduce the crash. Thanks, Johannes

March 4, 2013