- Dillo-dev - lists.mailman3.com

release preperations

by Johannes.Hofmann＠gmx.de

Hi, On Sat, Mar 02, 2013 at 07:57:26PM +0100, Sebastian Geerken wrote: > On Sat, Mar 02, Johannes Hofmann wrote: > > > I've pushed a new script, which uses the text versions (and adds the > > > licence information as comments). Should it download directly from > > > CTAN? From mirrors.dotsrc.org? Ask for a mirror? > > > > If mirrors.dotsrc.org works, that's probabely nicer - though I doubt > > we create any significant load. > > Mirrors.dotsrc.org works; I've changed the script. (Look at the > beginning.) > > > > As for the way to inform the user, see attached patch, which will let > > > "make install" (and friends) print a message. Comments? > > > > Nice, but most users will get precompiled packages from their > > distributions. > > > > > How is the other work on the release going on? What is still missing? > > > > I started a couple of times to add some lines to the man page that > > explain how to get and install the pattern files, but never came up > > with anything good. Should we copy the lines from your patch below? > > How many people compiling dillo from the tarball are actually reading > README and the man page? At least the man page get's installed with most binary packages. I tried to include some info about the pattern files and how they can be downloaded - please give it a review. Also we would need to install the install-hyphenation script, so that it becomes part of binary packages. If we do that it would have to be renamed to dillo-install-hyphenation or something like that. Does this sound ok? Cheers, Johannes PS: For me the documentation issue for hyphenation patterns is the only thing left before we could make a release candidate, or am I missing something?

March 5, 2013

https related crash

by jcid＠dillo.org

On Mon, Mar 04, 2013 at 10:07:21PM +0100, Johannes Hofmann wrote: > On Fri, Mar 01, 2013 at 01:37:13PM -0300, Jorge Arellano Cid wrote: > > Hi Johannes, > > > > On Thu, Feb 28, 2013 at 10:44:15PM +0100, Johannes Hofmann wrote: > > > Hi, > > > > > > from time to time I get the crash below. > > > Would a simple NULL check in a_Chain_check() be the correct fix? > > > > I gave it a first review, and it looks like the connection gets closed > > before the dialog sends an answer. So, at resume time, the sending branch > > is gone. It'd be great to have a test case. > > Sorry, I can't reproduce it atm. I keep trying. > > > > > Anyway, in the interim, please try the following patch: > > Will do, once I can reproduce the crash. AFAIR there're a few obscure corner cases not explicitly handled by the CCC (ATM not worth the coding effort), and those are silently caught by the CCC's check code. From a distance, and with the proposed patch, it doesn't look like a show stopper at all. -- Cheers Jorge.-

March 5, 2013

https related crash

by Johannes.Hofmann＠gmx.de

On Fri, Mar 01, 2013 at 01:37:13PM -0300, Jorge Arellano Cid wrote: > Hi Johannes, > > On Thu, Feb 28, 2013 at 10:44:15PM +0100, Johannes Hofmann wrote: > > Hi, > > > > from time to time I get the crash below. > > Would a simple NULL check in a_Chain_check() be the correct fix? > > I gave it a first review, and it looks like the connection gets closed > before the dialog sends an answer. So, at resume time, the sending branch > is gone. It'd be great to have a test case. Sorry, I can't reproduce it atm. I keep trying. > > Anyway, in the interim, please try the following patch: Will do, once I can reproduce the crash. Thanks, Johannes

March 4, 2013

Profiling dillo

by p37sitdu＠lavabit.com

On Sat, Mar 02, 2013 at 11:36:16PM +0000, corvid wrote: > Sebastian wrote: > > (According to the man page, "gmon.out" is created in the current > > working directory, when exit() is called.) > > There's a chdir("/tmp") hiding in Paths::init(). > > Why don't remove it? >From ChangeLog: - Fixed Dillo and its dpis to work from "/tmp" (for easy device unmount). There was a thread discussing it: http://lists.auriga.wearlab.de/pipermail/dillo-dev/2011-December/009221.html http://lists.auriga.wearlab.de/pipermail/dillo-dev/2011-December/009223.html http://lists.auriga.wearlab.de/pipermail/dillo-dev/2011-December/009225.html Because of this, open dialog starts in /tmp, and it is a bug. Usually you start dillo from your home directory, why would you want to unmount it? And if you really plan to unmount it, you can change working directory yourself.

March 3, 2013

Profiling dillo

by corvid＠lavabit.com

Sebastian wrote: > (According to the man page, "gmon.out" is created in the current > working directory, when exit() is called.) There's a chdir("/tmp") hiding in Paths::init().

March 2, 2013

Profiling dillo

by sgeerken＠dillo.org

On Sat, Mar 02, Johannes Hofmann wrote: > On Fri, Mar 01, 2013 at 10:49:30AM +0100, Sebastian Geerken wrote: > > Has anyone tried to use gprof for profiling dillo? Using > > "--enable-gprof" for configure seems to work, and calling the tests > > (e. g.. test/dw-example) create the file "gmon.out", but not so > > does starting src/dillo. The option "-pg" is set everywhere, so I do > > not know what the difference is. > > > > Any ideas? > > Did you look in /tmp for the gmon.out file? Cores also end up there. Ah, yes, it is there. Thanks! (According to the man page, "gmon.out" is created in the current working directory, when exit() is called.) Sebastian

March 2, 2013

Profiling dillo

by Johannes.Hofmann＠gmx.de

Hi, On Fri, Mar 01, 2013 at 10:49:30AM +0100, Sebastian Geerken wrote: > Hi! > > Has anyone tried to use gprof for profiling dillo? Using > "--enable-gprof" for configure seems to work, and calling the tests > (e. g.. test/dw-example) create the file "gmon.out", but not so > does starting src/dillo. The option "-pg" is set everywhere, so I do > not know what the difference is. > > Any ideas? Did you look in /tmp for the gmon.out file? Cores also end up there. Johannes

March 2, 2013

https related crash

by jcid＠dillo.org

Hi Johannes, On Thu, Feb 28, 2013 at 10:44:15PM +0100, Johannes Hofmann wrote: > Hi, > > from time to time I get the crash below. > Would a simple NULL check in a_Chain_check() be the correct fix? I gave it a first review, and it looks like the connection gets closed before the dialog sends an answer. So, at resume time, the sending branch is gone. It'd be great to have a test case. Anyway, in the interim, please try the following patch: diff -r 8c8975054b06 src/capi.c --- a/src/capi.c Wed Jan 30 10:04:00 2013 +0100 +++ b/src/capi.c Fri Mar 01 13:32:38 2013 -0300 @@ -571,10 +571,13 @@ int a_Capi_dpi_send_data(const DilloUrl /* Re-use an open connection */ conn = Capi_conn_find(server); if (conn) { - /* found */ - dbuf = a_Chain_dbuf_new(data, data_sz, 0); - a_Capi_ccc(OpSend, 1, BCK, conn->InfoSend, dbuf, NULL); - dFree(dbuf); + if (conn->InfoSend) { + /* found & operative*/ + dbuf = a_Chain_dbuf_new(data, data_sz, 0); + a_Capi_ccc(OpSend, 1, BCK, conn->InfoSend, dbuf, NULL); + dFree(dbuf); + } else + MSG(" ERROR: [a_Capi_dpi_send_data] Connection not operative\n"); } else { MSG(" ERROR: [a_Capi_dpi_send_data] No open connection found\n"); } diff -r 8c8975054b06 src/chain.c --- a/src/chain.c Wed Jan 30 10:04:00 2013 +0100 +++ b/src/chain.c Fri Mar 01 13:32:38 2013 -0300 @@ -189,7 +189,10 @@ int a_Chain_check(char *FuncStr, int Op, /* Show status information */ Chain_debug_msg(FuncStr, Op, Branch, Dir, Info); - if (Info->Flags & (CCC_Ended + CCC_Aborted)) { + if (!Info) { + MSG_WARN("CCC: call on a NULL node.\n" + "Caught as last resort; Most probably a BUG.\n"); + } else if (Info->Flags & (CCC_Ended + CCC_Aborted)) { /* CCC is not operative */ MSG_WARN("CCC: call on already finished chain. Flags=%s%s\n", Info->Flags & CCC_Ended ? "CCC_Ended " : "", -- Cheers Jorge.-

March 1, 2013

Profiling dillo

by sgeerken＠dillo.org

Hi! Has anyone tried to use gprof for profiling dillo? Using "--enable-gprof" for configure seems to work, and calling the tests (e. g.. test/dw-example) create the file "gmon.out", but not so does starting src/dillo. The option "-pg" is set everywhere, so I do not know what the difference is. Any ideas? Sebastian

March 1, 2013

https related crash

by Johannes.Hofmann＠gmx.de

Hi, from time to time I get the crash below. Would a simple NULL check in a_Chain_check() be the correct fix? Cheers, Johannes nated with signal 11, Segmentation fault. #0 0x0805d359 in a_Chain_check (FuncStr=0x81135b3 "a_Capi_ccc", Op=2, Branch=1, Dir=2, Info=0x0) at chain.c:192 192 if (Info->Flags & (CCC_Ended + CCC_Aborted)) { (gdb) p Info $1 = (ChainLink *) 0x0 (gdb) bt #0 0x0805d359 in a_Chain_check (FuncStr=0x81135b3 "a_Capi_ccc", Op=2, Branch=1, Dir=2, Info=0x0) at chain.c:192 #1 0x08062f03 in a_Capi_ccc (Op=2, Branch=1, Dir=2, Info=0x0, Data1=0x28c83670, Data2=0x0) at capi.c:622 #2 0x0806372f in a_Capi_dpi_send_data (url=0x0, bw=0x2871da20, data=0x29563748 "<cmd='answer' to_cmd='dialog' msg='1' '>", data_sz=40, server=0x2940ee70 "proto.https", flags=<optimized out>) at capi.c:576 #3 0x0806381a in a_Capi_dpi_send_cmd (url=0x0, bw=0x2871da20, cmd=0x29563748 "<cmd='answer' to_cmd='dialog' msg='1' '>", server=0x2940ee70 "proto.https", flags=0) at capi.c:593 #4 0x08085bed in Dpiapi_dialog_answer_cb (answer=<optimized out>, bw=<optimized out>) at dpiapi.c:43 #5 a_Dpiapi_dialog (bw=0x2871da20, server=0x2940ee70 "proto.https", dpip_tag=0x286612d0 "<cmd='dialog' title='Dillo HTTPS: Missing issuer certificate!' msg='Unable to get local issuer certificate. The issuer certificate of an untrusted certificate cannot be found.' alt1='Continue' alt2='C"...) at dpiapi.c:74 #6 0x0805d21f in a_Chain_fcb (Op=684209776, Info=0x2878cec0, Data1=0x286612d0, Data2=0x29ecb9d0) at chain.c:114 #7 0x0808b533 in Dpi_parse_token (conn=<optimized out>) at dpi.c:228 #8 Dpi_process_dbuf (conn=<optimized out>, Data1=<optimized out>, Op=<optimized out>) at dpi.c:326 #9 a_Dpi_ccc (Op=2, Branch=2, Dir=1, Info=0x2878cec0, Data1=0x29e55470, Data2=0x0) at dpi.c:713 #10 0x0805d21f in a_Chain_fcb (Op=684209776, Info=0x28788fc0, Data1=0x29e55470, Data2=0x0) at chain.c:114 #11 0x0808ba6e in a_IO_ccc (Op=2, Branch=2, Dir=1, Info=0x28788fc0, Data1=0x292f6d40, Data2=0x0) at IO.c:425 #12 0x0808bc80 in IO_read (io=0x292f6d40) at IO.c:194 #13 0x0808bd88 in IO_callback (io=0x0) at IO.c:259 #14 0x0808be47 in IO_fd_read_cb (fd=6, data=0x6d7) at IO.c:280 #15 0x080e7d15 in fl_wait(double) () #16 0x080c36fc in Fl::wait(double) () #17 0x080c377b in Fl::run() () #18 0x0804e1f1 in main (argc=1, argv=0xbfbff8c4) at dillo.cc:502 (gdb)

Feb. 28, 2013