- Dillo-dev - lists.mailman3.com

Fwd: Re: hypenator.cc errors

by sgeerken＠dillo.org

On Mi, Sep 04, 2013, Chris Sorenson wrote: > > > > Cris: If you run ./autogen.sh && ./configure, you should > > see a line: > > Can't seem to apply the patch: > > chris at starhunter:~/src/dls/dillo-3.0.3$ patch < > var_len_arr_cxx.diff > (Stripping trailing CRs from patch.) > patching file configure.ac > Hunk #1 succeeded at 105 with fuzz 2. > Hunk #2 succeeded at 406 (offset -26 lines). > (Stripping trailing CRs from patch.) > can't find file to patch at input line 38 > Perhaps you should have used the -p or --strip option? > The text leading up to this was: > -------------------------- > |diff -r 808c0a0fc122 dw/hyphenator.cc > |--- a/dw/hyphenator.cc Mon Sep 02 11:31:37 2013 -0400 > |+++ b/dw/hyphenator.cc Wed Sep 04 11:15:02 2013 +0200 > -------------------------- > > Do I need to have a mercurial checked out version to use > this patch? Yes, this patch is against the latest hg version; things may have changed there. Sebastian

Sept. 6, 2013

hypenator.cc errors

by sgeerken＠dillo.org

> > [...] > > Thinking about it again, variable length arrays are a feature of C, > but not of C++, although it seems that most C++ compilers support it. > Since this is a nice feature, but standard C++ should be supported, > I've thought of testing it by the configure script, and then hide two > different implementations behind a macro. See attached patch, which > should be applied to the current hg repository. > > What do you think? [...] Third round: I agree with Jorge that this is quite too complex; and profiling shows no performance gain of using the heap over using the stack, so I've replaced it by new and delete. Cris: please test the latest version from hg, it should compile now. I've tried to force g++ to raise an error in this case, by using this example: --- #include <stdlib.h> int main() { int n = rand() % 10 + 1; char c[n]; } --- but both "g++ -std=c++98 test.cc" and "g++ -std=c++11 test.cc" do not complain. Does someone have an idea? ("g++ --version" => "g++ (Debian 4.7.2-5) 4.7.2") Sebastian

Sept. 6, 2013

hypenator.cc errors

by csoren＠isd.net

Trying it again with `patch -p1` I get: (Stripping trailing CRs from patch.) patching file configure.ac Hunk #1 succeeded at 105 with fuzz 2. Hunk #2 succeeded at 406 (offset -26 lines). (Stripping trailing CRs from patch.) patching file dw/hyphenator.cc Hunk #1 FAILED at 49. Hunk #2 FAILED at 118. 2 out of 5 hunks FAILED -- saving rejects to file dw/hyphenator.cc.rej (Stripping trailing CRs from patch.) patching file lout/misc.hh

Sept. 5, 2013

Fwd: Re: hypenator.cc errors

by csoren＠isd.net

> > Cris: If you run ./autogen.sh && ./configure, you should > see a line: Can't seem to apply the patch: chris at starhunter:~/src/dls/dillo-3.0.3$ patch < var_len_arr_cxx.diff (Stripping trailing CRs from patch.) patching file configure.ac Hunk #1 succeeded at 105 with fuzz 2. Hunk #2 succeeded at 406 (offset -26 lines). (Stripping trailing CRs from patch.) can't find file to patch at input line 38 Perhaps you should have used the -p or --strip option? The text leading up to this was: -------------------------- |diff -r 808c0a0fc122 dw/hyphenator.cc |--- a/dw/hyphenator.cc Mon Sep 02 11:31:37 2013 -0400 |+++ b/dw/hyphenator.cc Wed Sep 04 11:15:02 2013 +0200 -------------------------- Do I need to have a mercurial checked out version to use this patch?

Sept. 5, 2013

hypenator.cc errors

by sgeerken＠dillo.org

On Mo, Sep 02, 2013, Chris Sorenson wrote: > > On Mo, Sep 02, 2013, Chris Sorenson wrote: > > > Greets all, > > > > > > Another sequence of bads that cropped up using the > > > Silicon Graphics MIPSpro compiler, any thoughts? To wit: > > > > > > cc-1028 CC: ERROR File = hyphenator.cc, Line = 147 > > > The expression used must have a constant value. > > > > > > char chars [l + 1]; > > > ^ > > > [more similar cases] > > > > It seems that your compiler does not support arrays with > > variable length, which are standard since C99, as far as I > > see. It could be fixed by replacing this line (as an > > example) by: > > > > char *chars = new char [l + 1]; > > > > and later > > > > delete[] chars; > > > > However, I'd like to check other possibilities. A short > > search lead me to > > <http://www.sgi.com/products/software/irix/tools/c.html>, > > according to which newer versions support C99. Which > > version do you use? > > > > I'm using MIPSpro 7.4.3 (the most current version is 7.4.4) > but in C99 mode it can't compile C++ code. Not to worry I'll > #ifdef my way around the variable length arrays, I guess I > didn't look closely enough to realize that was what those > were, thanks! Thinking about it again, variable length arrays are a feature of C, but not of C++, although it seems that most C++ compilers support it. Since this is a nice feature, but standard C++ should be supported, I've thought of testing it by the configure script, and then hide two different implementations behind a macro. See attached patch, which should be applied to the current hg repository. What do you think? Cris: If you run ./autogen.sh && ./configure, you should see a line: checking for support of variable length arrays in C++... no Is this correct? Sebastian

Sept. 4, 2013

hypenator.cc errors

by csoren＠isd.net

> On Mo, Sep 02, 2013, Chris Sorenson wrote: > > Greets all, > > > > Another sequence of bads that cropped up using the > > Silicon Graphics MIPSpro compiler, any thoughts? To wit: > > > > cc-1028 CC: ERROR File = hyphenator.cc, Line = 147 > > The expression used must have a constant value. > > > > char chars [l + 1]; > > ^ > > [more similar cases] > > It seems that your compiler does not support arrays with > variable length, which are standard since C99, as far as I > see. It could be fixed by replacing this line (as an > example) by: > > char *chars = new char [l + 1]; > > and later > > delete[] chars; > > However, I'd like to check other possibilities. A short > search lead me to > <http://www.sgi.com/products/software/irix/tools/c.html>, > according to which newer versions support C99. Which > version do you use? > I'm using MIPSpro 7.4.3 (the most current version is 7.4.4) but in C99 mode it can't compile C++ code. Not to worry I'll #ifdef my way around the variable length arrays, I guess I didn't look closely enough to realize that was what those were, thanks!

Sept. 2, 2013

Proposed Patch for Zombies Left by Dpi_start_dpid() in dpi.c

by jcid＠dillo.org

On Sun, Sep 01, 2013 at 02:58:02PM -0400, Jorge Arellano Cid wrote: > On Sun, Sep 01, 2013 at 08:49:06PM +0200, Johannes Hofmann wrote: > > Hi Jorge, > > [...] > > Works fine on DragonFlyBSD with the #include <wait.h> line removed. > > Good! > > I'll patch and commit soon. Committed. -- Cheers Jorge.-

Sept. 2, 2013

hypenator.cc errors

by sgeerken＠dillo.org

On Mo, Sep 02, 2013, Chris Sorenson wrote: > Greets all, > > Another sequence of bads that cropped up using the Silicon > Graphics MIPSpro compiler, any thoughts? To wit: > > cc-1028 CC: ERROR File = hyphenator.cc, Line = 147 > The expression used must have a constant value. > > char chars [l + 1]; > ^ > [more similar cases] It seems that your compiler does not support arrays with variable length, which are standard since C99, as far as I see. It could be fixed by replacing this line (as an example) by: char *chars = new char [l + 1]; and later delete[] chars; However, I'd like to check other possibilities. A short search lead me to <http://www.sgi.com/products/software/irix/tools/c.html>, according to which newer versions support C99. Which version do you use? Sebastian

Sept. 2, 2013

hypenator.cc errors

by csoren＠isd.net

Greets all, Another sequence of bads that cropped up using the Silicon Graphics MIPSpro compiler, any thoughts? To wit: cc-1028 CC: ERROR File = hyphenator.cc, Line = 147 The expression used must have a constant value. char chars [l + 1]; ^ cc-1028 CC: ERROR File = hyphenator.cc, Line = 185 The expression used must have a constant value. char noHyphens[len - 2 * breaks->size() + 1]; ^ cc-1028 CC: ERROR File = hyphenator.cc, Line = 185 The expression used must have a constant value. char noHyphens[len - 2 * breaks->size() + 1]; ^ cc-1060 CC: ERROR File = hyphenator.cc, Line = 185 The indicated operator is not allowed in an integral constant expression. char noHyphens[len - 2 * breaks->size() + 1]; ^ cc-1059 CC: ERROR File = hyphenator.cc, Line = 185 A function call is not allowed in a constant expression. char noHyphens[len - 2 * breaks->size() + 1]; ^ cc-1028 CC: ERROR File = hyphenator.cc, Line = 316 The expression used must have a constant value. char work[strlen (wordLc) + 3]; ^ cc-1059 CC: ERROR File = hyphenator.cc, Line = 316 A function call is not allowed in a constant expression. char work[strlen (wordLc) + 3]; ^ cc-1028 CC: ERROR File = hyphenator.cc, Line = 316 The expression used must have a constant value. char work[strlen (wordLc) + 3]; ^ 8 errors detected in the compilation of "hyphenator.cc". make: *** [hyphenator.o] Error 2

Sept. 2, 2013

compilation error in fltkflatview.cc

by csoren＠isd.net

> > > > 2 errors detected in the compilation of > > "fltkflatview.cc". ---------- > > > > I suspect it needs a 'using namespace' or somesuch here, > > thoughts? > > > > I thought this sounded a little familiar, and I was able > to find > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2013-January/009809.html > that we'd been through this before. > > I think last time I was waiting to see whether anyone > reported that it didn't work for them, or that dw > originally had that for a deep reason, and then I > eventually forgot about it. This time I'll commit it, and > we'll find out. > Sorry I didn't realize this was the same question I posted about before since I assumed that that fix had been committed and back then I was working with pre-3.0 sources, anyway thanks!

Sept. 2, 2013