- Dillo-dev - lists.mailman3.com

Google broke recently with 3.0.4 causing repush loop

by james.from.wellington＠gmail.com

Some pages which show lots of 'redirected 0 times', show less when I block *.gravatar.com in domainrc. On 09/05/2015, James C <james.from.wellington at gmail.com> wrote: > All of this is with the cookiesrc below, which lets google have > cookies on two domains. > > If I: > - log out of google > -- it stalls on a meta refresh tag > - select home, which for me is https://mail.google.com/?ui=html > - provide a username and password > -- I am eventually shown my email messages > then the code below redirects: > - once during the logout > - twice before asking for a password > - eight (8) times before showing me my mail > > Adding back the hack to share cookies probably makes no difference to > these figures, but I'm not sure, because I think that I remember > inconsistently getting seven and nine redirects, so I think that > google is A/B testing me. > > This code cannot be put into production, because it produces messages > about redirecting 0 times reasonably often, for reasons that I haven't > tracked down yet. > > -------------------------------- > #host action > DEFAULT DENY > .google.com ACCEPT_SESSION > .google.co.nz ACCEPT_SESSION > -------------------------------- > > render/dillo-jfw01$ hg diff > diff -r 07c0c28f8960 src/cache.c > --- a/src/cache.c Fri Mar 06 13:12:11 2015 +1300 > +++ b/src/cache.c Sat May 09 22:03:31 2015 +1200 > @@ -1007,11 +1007,24 @@ > return 0; > } > > - /* if there's a redirect loop, stop now */ > - if (bw->redirect_level >= 5) > - entry->Flags |= CA_RedirectLoop; > +// if (0 == bw->redirect_level % 5) { > + if (0 == bw->redirect_level % 1) { > + char *redirMessage; > + int choice; > + > + asprintf(&redirMessage, "Dillo: redirected %d times", > bw->redirect_level); > + > + choice = a_Dialog_choice(redirMessage, URL_STR(entry->Url), > + "Stop", "Continue", NULL); > + > + if (1 == choice) > + entry->Flags |= CA_RedirectLoop; > + > + free(redirMessage); > + } > > if (entry->Flags & CA_RedirectLoop) { > + MSG("Redirect loop for: %s\n", URL_STR_(entry->Url)); > a_UIcmd_set_msg(bw, "ERROR: redirect loop for: %s", > URL_STR_(entry->Url)); > bw->redirect_level = 0; > return 0; > diff -r 07c0c28f8960 src/cookies.c > --- a/src/cookies.c Fri Mar 06 13:12:11 2015 +1300 > +++ b/src/cookies.c Sat May 09 22:03:31 2015 +1200 > @@ -196,6 +196,15 @@ > > if (requester == NULL) { > /* request made by user */ > +#if 0 > + } else if (!strcmp("accounts.google.co.nz", URL_HOST(requester)) && > + !strcmp("mail.google.com", URL_HOST(query_url))) { > + MSG("Cookies: sent for google NZ special case 1.\n"); > + } else if (!strcmp("accounts.google.com", URL_HOST(requester)) && > + !strcmp("accounts.google.co.nz", URL_HOST(query_url))) { > + MSG("Cookies: sent for google NZ special case 2.\n"); > + > +#endif > } else if (!a_Url_same_organization(query_url, requester)) { > MSG("Cookies: not sent for request by '%s' for '%s'\n", > URL_HOST(requester), URL_HOST(query_url)); > > > On 09/05/2015, eocene <eocene at gmx.com> wrote: >> James wrote: >>> Here's a guess without justification: it's trying to get confirmation >>> that you accepted a cookie, and failing. >> >> I did make a quick attempt with accept_session in cookiesrc, and it >> didn't appear to make a difference... >> >>> The basis for my guess is that login to gmail is possible, but >>> requires more than five redirects, so I run a hacked up dillo 3.1, >>> with a dialog about whether to keep redirecting. >> >> How many redirects does it need? The only site that I tend to run into >> redirect problems with is nytimes.com (Not logging into any account; >> just looking at articles that people post links to...), and the last >> time I checked it was something like 12 redirects before it will give >> up and provide the page. And I wonder whether raising the redirect >> limit might be good, overall. >> >> Does gmail still need all of those redirects if you let it have a >> cookie? >> >> _______________________________________________ >> Dillo-dev mailing list >> Dillo-dev at dillo.org >> http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev >> >

June 6, 2015

Patch: fix the flowchart diagram in the dw::Table class docs

by sgeerken＠dillo.org

On So, Mai 31, 2015, Jeremy Henty wrote: > The main body of the dw::Table class documentation starts with a > flowchart diagram of some dw::Table method calls. But this diagram > refers to a method dw::Table::calcColumnExtremes() that is no longer > used and has been renamed to dw::Table::_unused_calcColumnExtremes(). > (There is a warning that GROWS made some of this documentation > obsolete.) So I dug into the code and came up with a patch that I > think fixes the diagram. I have attached before and after images of > the diagram so that you can compare. I would love some feedback! > > http://starurchin.org/dillo/patch/doxygen-dw-table-hh-dependency-diagram.ht… > > And this patch removes dw::Table::_unused_calcColumnExtremes(). > > http://starurchin.org/dillo/patch/remove-dw-table-_unused_calcColumnExtreme… > > Comments are welcome. I've committed both, the first (diagram) with some changes. The table code is now stable enough so that it makes sense to update the documentation. (The rest should be reviewed, too.) BTW, there are also some more changes in the repository at <http://flpsed.org/hgweb/dillo_grows>, see the general documentation about widget sizes there. Sebastian

June 2, 2015

Documentation in the tarball?

by sgeerken＠dillo.org

Hi! The documentation is now split: - "doc" contains user documentation, and is included in the tarball. - "devdoc" contains developer documentation, and is only contained in the Hg repository, not in the tarball. Running "doxygen" will still create documentation in the "html" directory. Sebastian

June 1, 2015

Oh, list moderator...

by eocene＠gmx.com

Jorge wrote: > I don't remember who the moderator is these days, AFAIR > sometimes pending messages got to me, and other people have > taken this duty too (along the years). I wouldn't be shocked if it turned out that no one is at present. Sometimes I wonder whether the webmaster mail goes to anyone now.

June 1, 2015

Oh, list moderator...

by jcid＠dillo.org

Hi Jeremy, On Sun, May 31, 2015 at 06:14:12PM +0100, Jeremy Henty wrote: > > (I hope you will take this in the light-hearted tone that I wrote it. > I don't often write poetry.) > > Oh, list moderator, help me please. > I sent the list an email with attached PNGs. > I saw there was a problem, had an itch to scratch. > And that's why I was hoping you would take my patch. > But I knew that you would need some actual evidence > To show you what I'm saying really makes some sense. > > I saw a flowchart image in the HTML page > And noticed with regret that it had rotted with age. > It linked to a method that wasn't there no more > And that's when I decided I should settle this score. > > I made a better version and then sent it to you > And I chose to enclose the original too > But sadly those two images were too big for the list > So now now your mailer's told me I should cease and desist. > > Please, list moderator, let my work through. > Whatever you may think I only did it for you. > I have helped you before, I want to help you once more. > But you've got to tell your mail software to open the door. Hey, I liked your text! ;) I don't remember who the moderator is these days, AFAIR sometimes pending messages got to me, and other people have taken this duty too (along the years). Anyway, I went into the admin interface and allowed your message, but don't remember receiving an authorization request from the system. -- Cheers Jorge.-

June 1, 2015

Oh, list moderator...

by onepoint＠starurchin.org

(I hope you will take this in the light-hearted tone that I wrote it. I don't often write poetry.) Oh, list moderator, help me please. I sent the list an email with attached PNGs. I saw there was a problem, had an itch to scratch. And that's why I was hoping you would take my patch. But I knew that you would need some actual evidence To show you what I'm saying really makes some sense. I saw a flowchart image in the HTML page And noticed with regret that it had rotted with age. It linked to a method that wasn't there no more And that's when I decided I should settle this score. I made a better version and then sent it to you And I chose to enclose the original too But sadly those two images were too big for the list So now now your mailer's told me I should cease and desist. Please, list moderator, let my work through. Whatever you may think I only did it for you. I have helped you before, I want to help you once more. But you've got to tell your mail software to open the door. Regards, Jeremy Henty

May 31, 2015

Patch: fix the flowchart diagram in the dw::Table class docs

by onepoint＠starurchin.org

The main body of the dw::Table class documentation starts with a flowchart diagram of some dw::Table method calls. But this diagram refers to a method dw::Table::calcColumnExtremes() that is no longer used and has been renamed to dw::Table::_unused_calcColumnExtremes(). (There is a warning that GROWS made some of this documentation obsolete.) So I dug into the code and came up with a patch that I think fixes the diagram. I have attached before and after images of the diagram so that you can compare. I would love some feedback! http://starurchin.org/dillo/patch/doxygen-dw-table-hh-dependency-diagram.ht… And this patch removes dw::Table::_unused_calcColumnExtremes(). http://starurchin.org/dillo/patch/remove-dw-table-_unused_calcColumnExtreme… Comments are welcome. Regards, Jeremy Henty

May 31, 2015

Alternative styles support?

by higuita7＠yahoo.co.uk

Hi! On Sun, 24 May 2015 20:39:55 +0000, eocene <eocene at gmx.com> wrote: > Sebastian wrote: > > Iceweasel (Firefox): > > View -> Page Style -> (No Style | Fresh, Revolution) > Only now do I find that it's possible to get the menu bar back. I hehehe, most people don't know about the firefox menu bar, but is easy to get to it, just press "alt" for a temporary access or right click on the existent bar and select that you want to see the menu permanently > believe mine disappeared when firefox decided to move everything into > that stupid three-horizontal-bars icon because they're trend-followers, Not just trend followers, netbooks have a lot less screen size than desktops and the existence of the status bar and menu bar removes precious screen size, so that decision was to increase usable space. Of course i have the opinion that FF should check the screen size and change the default based on that... but i understand that would break consistency. Back to the on-topic: i would also agree that alternative styles support would be good thing. right now i have to switch off embebed or external CSS to be able to read some sites, a way to use other styles or even force a "personal" style would help in many sites. Best regards, higuita -- Naturally the common people don't want war... but after all it is the leaders of a country who determine the policy, and it is always a simple matter to drag the people along, whether it is a democracy, or a fascist dictatorship, or a parliament, or a communist dictatorship. Voice or no voice, the people can always be brought to the bidding of the leaders. That is easy. All you have to do is tell them they are being attacked, and denounce the pacifists for lack of patriotism and exposing the country to danger. It works the same in every country. -- Hermann Goering, Nazi and war criminal, 1883-1946

May 26, 2015

long lines and slowness (common when viewing style sheets)

by sgeerken＠dillo.org

On Di, Mai 26, 2015, eocene wrote: > > Now that everyone likes to send their style sheets as one big long line, > like 250k long, viewing them in dillo is slow. > > gprof says > % cumulative self self total > time seconds seconds calls s/call s/call name > 32.47 1.88 1.88 189407242 0.00 0.00 lout::misc::NotSoSimpleVector<dw::Textblock::Word>::getRef(int) const > 29.36 3.58 1.70 187437456 0.00 0.00 dw::Textblock::BadnessAndPenalty::lineCanBeBroken(int) > 28.15 5.21 1.63 29345 0.00 0.00 dw::Textblock::wrapWordInFlow(int, bool) > > and I wonder whether any optimizations are possible. Yes, I know this bug (you sent it me some time ago), and it is on my todo list. Since this occured first with hyphenation (or rather per-line optimization), there is certainly a way to optimize it. A vague guess is that it has to do with the iteration over the line to find the best break point. (BTW: the functionality used for plain text could also be provided by a new widget which is much simpler than Textblock.) Sebastian

May 26, 2015

long lines and slowness (common when viewing style sheets)

by eocene＠gmx.com

Now that everyone likes to send their style sheets as one big long line, like 250k long, viewing them in dillo is slow. gprof says % cumulative self self total time seconds seconds calls s/call s/call name 32.47 1.88 1.88 189407242 0.00 0.00 lout::misc::NotSoSimpleVector<dw::Textblock::Word>::getRef(int) const 29.36 3.58 1.70 187437456 0.00 0.00 dw::Textblock::BadnessAndPenalty::lineCanBeBroken(int) 28.15 5.21 1.63 29345 0.00 0.00 dw::Textblock::wrapWordInFlow(int, bool) and I wonder whether any optimizations are possible.

May 26, 2015