- Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] temporary bookmark.c fix (was Re: 0.7.1 release)

by Daniel Daboul

On Mon, Mar 10, 2003 at 07:45:18PM +0100, Andreas Schweitzer wrote: > well, your solution is the old version of that function :-) a > fix I sent to Jorge earlier would be (it might even get acceptexd ;-) ...) : Your patch is much better, I'm using it now. The limit of 100 in my malloc() allowed for only short bookmarks anyway ;-) Daniel

March 10, 2003

Re: [Dillo-dev] temporary bookmark.c fix (was Re: 0.7.1 release)

by Andreas Schweitzer

On Mon, Mar 10, 2003 at 08:37:09PM +0200, Daniel Daboul wrote: > I hacked a fix for function "a_Bookmarks_add" in src/bookmark.c that > avoids the seg-fault and allow me to use bookmarks. Since I use > malloc, sprintf and free instead of g_strdup_printf and g_free I don't > submit it as patch, but I hope it'll help to find the clean fix. I > attached the fixed "a_Bookmarks_add" at the bottom. -- Daniel well, your solution is the old version of that function :-) a fix I sent to Jorge earlier would be (it might even get acceptexd ;-) ...) : --- src/bookmark.c.orig Mon Mar 10 19:13:26 2003 +++ src/bookmark.c Mon Mar 10 18:47:22 2003 @@ -80,7 +80,7 @@ BrowserWindow *bw = (BrowserWindow *)client_data; gchar *title; DilloUrl *url; - char *cmd = NULL; + gchar *cmd = NULL; url = a_Menu_popup_get_url(bw); g_return_if_fail(url != NULL); @@ -88,7 +88,7 @@ /* if the page has no title, we'll use the url string */ title = (gchar *) a_History_get_title_by_url(url, 1); - g_strdup_printf(cmd, "<dpi cmd='add_bookmark' url='%s' title='%s'>", + cmd = g_strdup_printf("<dpi cmd='add_bookmark' url='%s' title='%s'>", URL_STR(url), title); a_Bookmarks_chat_add(bw, cmd, NULL); g_free(cmd); Cheers Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

March 10, 2003

temporary bookmark.c fix (was Re: 0.7.1 release)

by Daniel Daboul

I hacked a fix for function "a_Bookmarks_add" in src/bookmark.c that avoids the seg-fault and allow me to use bookmarks. Since I use malloc, sprintf and free instead of g_strdup_printf and g_free I don't submit it as patch, but I hope it'll help to find the clean fix. I attached the fixed "a_Bookmarks_add" at the bottom. -- Daniel On Mon, Mar 10, 2003 at 05:24:25PM +0200, Daniel Daboul wrote: > On Mon, Mar 10, 2003 at 10:13:55AM -0400, Jorge Arellano Cid wrote: > > The new 0.7.1 bugfix release is out. It solves the problem of [...] > whenever I choose "Bookmark this page" I get an immediate > "Segmentation Fault (core dumped)" with no additional message. Below > the top of gdb's output: > > (gdb) where > #0 0xfed81618 in _doprnt () from /usr/lib/libc.so.1 > #1 0xfed85118 in vsprintf () from /usr/lib/libc.so.1 > #2 0xff05229c in g_strdup_vprintf (format=0x0, args1=0xffbee5b8) at gstrfuncs.c:158 > #3 0xff0522c8 in g_strdup_printf (format=0x0) at gstrfuncs.c:172 > #4 0x0002fac4 in a_Bookmarks_add (widget=0x21aca8, client_data=0x140538) at bookmark.c:91 > #5 0xff1c2054 in gtk_marshal_NONE__NONE (object=0x21aca8, func=0x1a87c <a_Commands_addbm_callback>, > > Is that a problem in gdk? Here's what dillo is linked with: [...] void a_Bookmarks_add(GtkWidget *widget, gpointer client_data) { BrowserWindow *bw = (BrowserWindow *)client_data; gchar *title; DilloUrl *url; char *cmd = (char *)malloc(100);//NULL; url = a_Menu_popup_get_url(bw); g_return_if_fail(url != NULL); /* if the page has no title, we'll use the url string */ title = (gchar *) a_History_get_title_by_url(url, 1); sprintf(cmd,"<dpi cmd='add_bookmark' url='%s' title='%s'>",URL_STR(url), title); //g_strdup_printf(cmd,"<dpi cmd='add_bookmark' url='%s' title='%s'>", URL_STR(url), title); a_Bookmarks_chat_add(bw, cmd, NULL); free(cmd); //g_free(cmd); }

March 10, 2003

cannot login to the times

by Eythan Weg

Hi, I am still stunned by the responsiveness of this browser. Thank you! However, there is one irritant. With cookies accepted, dillo 7.0 is not able to login to the New York Times (at nytimes.com) After filling user-name and password, and submitting, the login page returns cleared, as if nothing happened. Is this a known issue? Anything special to do? Thanks, eythan

March 10, 2003

Re: [Dillo-dev] 0.7.1 release

by Daniel Daboul

On Mon, Mar 10, 2003 at 10:13:55AM -0400, Jorge Arellano Cid wrote: > The new 0.7.1 bugfix release is out. It solves the problem of Indeed it now compiles out-of-the-box here on Solaris (SunOS 5.8 Generic_108528-13 sun4u sparc SUNW,Ultra-1) with gcc-3.2.2. But still whenever I choose "Bookmark this page" I get an immediate "Segmentation Fault (core dumped)" with no additional message. Below the top of gdb's output: (gdb) where #0 0xfed81618 in _doprnt () from /usr/lib/libc.so.1 #1 0xfed85118 in vsprintf () from /usr/lib/libc.so.1 #2 0xff05229c in g_strdup_vprintf (format=0x0, args1=0xffbee5b8) at gstrfuncs.c:158 #3 0xff0522c8 in g_strdup_printf (format=0x0) at gstrfuncs.c:172 #4 0x0002fac4 in a_Bookmarks_add (widget=0x21aca8, client_data=0x140538) at bookmark.c:91 #5 0xff1c2054 in gtk_marshal_NONE__NONE (object=0x21aca8, func=0x1a87c <a_Commands_addbm_callback>, Is that a problem in gdk? Here's what dillo is linked with: ldd src/dillo libgtk-1.2.so.0 => /users/danield/.r/lib/libgtk-1.2.so.0 libgdk-1.2.so.0 => /users/danield/.r/lib/libgdk-1.2.so.0 libgmodule-1.2.so.0 => /users/danield/.r/lib/libgmodule-1.2.so.0 libglib-1.2.so.0 => /users/danield/.r/lib/libglib-1.2.so.0

March 10, 2003

0.7.1 release

by Jorge Arellano Cid

Hi! The new 0.7.1 bugfix release is out. It solves the problem of disappearing bookmarks and some other minor things. It works on 64bit machines and some problems remain on _some_ Solaris stations; these should be fixed in 0.7.2. Please upgrade ASAP!!! Cheers Jorge.- PS: I want to thank the few people who helped to debug it and sent some feedback.

March 10, 2003

Coredump

by ennek

I was browsing (using the CVS version of Dillo) and clicking on a link made Dillo coredump. I can't guess what the cause is, but I'll attach a backtrace so the more experienced can tell. (And sorry if it turns out to be a known problem.) I don't have any other information as I don't even remember what page I was browsing.

March 8, 2003

Re: [Dillo-dev] bug fix for floats

by Joe Crayne

On Fri, Mar 07, 2003 at 04:22:27PM +0000, John Bradford wrote: > > > > > > > > > > 1. Disapearing list bullets. -- Solved, I'll make code > > > > available if you are interested. > > > > > > Yes please. > > > > This might be just a temporary fix. I was going to > > hold out until I understood problem #2 better. > > This patch seems to cure the maximizing problem as well :-). > > John. Ah, so just one more bug to squash... *SQUISH* diff -pru source/src/dw_page.c target/src/dw_page.c --- source/src/dw_page.c 2003-03-08 02:25:51.000000000 -0500 +++ target/src/dw_page.c 2003-03-08 02:26:58.000000000 -0500 @@ -1080,7 +1080,7 @@ static void Dw_page_real_word_wrap (DwPa if( page->words[word_ind].place ) { DwPagePlace *p = page->words[word_ind].place; - p->x_left = last_space + page->imp->last_line_width; + p->x_left = (new_line ? 0 : last_space) + page->imp->last_line_width; /* x_left will be changed for floats */ p->line_num = page->imp->num_lines-1; p->word_num = word_ind;

March 8, 2003

Re: [Dillo-dev] float implementation

by hugo hallqvist

On Wed, 05 Mar 2003 08:18:53 -0500 Joe Crayne <to-joe(a)myrealbox.com> wrote: > > I just want to announce the availability of my code to > fix bug #233 which concernes the rendering of > align=left and align=right tables. The patches and > screen shots are at > > http://home.earthlink.net/~crayne2 > > Feedback would be appreciated. :) > Nice work! I tried adding the same to img-tag and it seems to work there too. -- //Hugo Hallqvist

March 8, 2003

Re: [Dillo-dev] mousewheel

by Stephen Lewis

On Fri, 7 Mar 2003 13:47:39 +0100 andi <andi(a)buxach.de> wrote: > I found a new strange thing: > If i position my mouse above a link and roll my mousewheel, it is > marked as visited. This is in the bug DB as #348, attached is a trivial fix for it. -- Stephen Lewis slewis(a)paradise.net.nz

March 7, 2003