- Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] Re: configuration patch

by Jorge Arellano Cid

Andreas, On Wed, 2 Apr 2003, Andreas Schweitzer wrote: > Hi there, > > On Wed, Apr 02, 2003 at 08:19:56PM +0200, Sebastian Geerken wrote: > > On Mon, Mar 31, Jorge Arellano Cid wrote: > > > > The location of the system dillorc should NOT be > > > > put in config.h according to the GNU docs, instead > > > > everything with prefix/sysconfdir and similar stuff > > > > should be defined on the command line. Hence, my > > > > src/Makefile.am patch. This syntax of ' and " works on > > > > a variety of systems (bash, ksh, csh, GNU make) finally. > > > > Also, the current toplevel Makefile.am first tries > > > > $(DESTDIR)$(sysconfdir) and then falls back on /etc > > > > but the code in prefs.c does it the other way round. > > > > One of them should probably be reverted. > > Leaving the above intentionally :-) ... it contains more > explanations (by me originally) for the following. > > > > > And while writing this : the patch supplied on the > > > > list will make dillorc be installed ONLY in > > > > $(DESTDIR)$(sysconfdir) with no fall-back to /etc > > > > but I think $(DESTDIR)$(sysconfdir) will be created > > > > if necessary. > > > > > > I'm not sure of what to do here :(. For now I added Patrice's > > > patch that simply adds: > > > > > > sysconf_DATA = dillorc > > > > > > in Makefile.am, and it works! > > That can be done in conjunction with my suggestions > for src/Makefile.am (NOT the toplevel Makefile.am) Good! > [...] > My original patch had something like that. Precisely : > > AM_CPPFLAGS=-DDILLORC_SYS='"$(sysconfdir)/dillorc"' for src/Makefile.am > > That way you can use fd = open(DILLORC_SYS, O_RDONLY) in src/prefs.c > > THIS combination of quotes worked for me :-) on Linux, FreeBSD and > OpenBSD. It certainly needs testing - but it did take me a while > to get that combo of quotes :-) .... I commited those changes to the CVS (with a new autogen.sh). Testing shows it works! At least dillo knows where the dillorc is placed by means of sysconfdir. Now, if you configure and make dillo, and later reconfigure with another sysconfdir, the data (dillorc) will be installed in the new directory correctly, but the binary will not be rebuilt so dillo will look for it in the old place. :( Touching prefs.c does the trick, but isn't this supossed to happen automagically? Cheers Jorge.-

April 3, 2003

Re: [Dillo-dev] font-colours

by Jorge Arellano Cid

On Thu, 3 Apr 2003, thestar wrote: > What's the latest update about dillo and css? Please read the CSS link for details. > Is this the > reason why this site: http://www.linuxgames.com > is so difficult to read? Yes and No! The page SHOULD render well without any CSS, but as with some Javascript-based sites, some authors forget that. Just write to the webmaster and tell him that the site renders unreadable for browsers without CSS (or disabled). Tell him that the solution is quite simple: Just add: TEXT="#FFFFFF" LINK="#FFAA00" to the BODY line! That is: <BODY BGCOLOR=#2C0000 TEXT="#FFFFFF" LINK="#FFAA00" ... Chances are very good (of them correcting it). Cheers Jorge.-

April 3, 2003

Re: Error DNS can't solve (null)

by Matthias Teege

Joerg Sonnenberger <joerg(a)britannica.bec.de> writes: >> 2003-03-31 17:16:50.880180500 sent 41219 17 >> >> What do I missing? > > You are using dnscache? If yes, it could not the (DNS) query. Yes, I use dnscache. > Everytime I got this, my routing was misconfigured. Can you > access the other network correctly? Yes, without any problems. All other programms run fine. Bis dann Matthias -- Matthias Teege -- http://www.mteege.de make world not war PGP-Key auf Anfrage

April 3, 2003

font-colours

by thestar

What's the latest update about dillo and css? Is this the reason why this site: http://www.linuxgames.com is so difficult to read?

April 3, 2003

Re: [Dillo-dev] Re: configuration patch

by Andreas Schweitzer

Hi there, On Wed, Apr 02, 2003 at 08:19:56PM +0200, Sebastian Geerken wrote: > On Mon, Mar 31, Jorge Arellano Cid wrote: > > > The location of the system dillorc should NOT be > > > put in config.h according to the GNU docs, instead > > > everything with prefix/sysconfdir and similar stuff > > > should be defined on the command line. Hence, my > > > src/Makefile.am patch. This syntax of ' and " works on > > > a variety of systems (bash, ksh, csh, GNU make) finally. > > > Also, the current toplevel Makefile.am first tries > > > $(DESTDIR)$(sysconfdir) and then falls back on /etc > > > but the code in prefs.c does it the other way round. > > > One of them should probably be reverted. Leaving the above intentionally :-) ... it contains more explanations (by me originally) for the following. > > > And while writing this : the patch supplied on the > > > list will make dillorc be installed ONLY in > > > $(DESTDIR)$(sysconfdir) with no fall-back to /etc > > > but I think $(DESTDIR)$(sysconfdir) will be created > > > if necessary. > > > > I'm not sure of what to do here :(. For now I added Patrice's > > patch that simply adds: > > > > sysconf_DATA = dillorc > > > > in Makefile.am, and it works! That can be done in conjunction with my suggestions for src/Makefile.am (NOT the toplevel Makefile.am) > > The problem is we don't know what directory it gets in. :-) > > > > Currently if it is /usr/local/etc/ or /etc, it works, but if > > someone chooses /opt/weird/etc, it won't be found. Yes, it will be found. See below. > Why not use $(sysconfdir) in the code, as in the attached patch? I'm > not sure about the usage of the quotation marks in src/Makefile.am, > they may cause problems on different environments, perhaps someone has > a better idea. My original patch had something like that. Precisely : AM_CPPFLAGS=-DDILLORC_SYS='"$(sysconfdir)/dillorc"' for src/Makefile.am That way you can use fd = open(DILLORC_SYS, O_RDONLY) in src/prefs.c THIS combination of quotes worked for me :-) on Linux, FreeBSD and OpenBSD. It certainly needs testing - but it did take me a while to get that combo of quotes :-) .... Cheers Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

April 2, 2003

Re: [Dillo-dev] Re: configuration patch

by Sebastian Geerken

On Wed, Apr 02, Phil Pennock wrote: > On 2003-04-02 at 20:19 +0200, Sebastian Geerken wrote: > > Why not use $(sysconfdir) in the code, as in the attached patch? > > Uhm, isn't $(sysconfdir) a directory, not a file? > > > diff -pru dillo1/src/prefs.c dillo2/src/prefs.c > > --- dillo1/src/prefs.c Wed Apr 2 19:40:36 2003 > > +++ dillo2/src/prefs.c Wed Apr 2 20:07:10 2003 > > @@ -250,10 +250,9 @@ static gint Prefs_load(void) > > file = a_Misc_prepend_user_home(".dillo/dillorc"); > > fd = open(file, O_RDONLY); > > g_free(file); > > - if (fd < 0 && (fd = open("/etc/dillorc", O_RDONLY)) < 0) > > - if ((fd = open("/usr/local/etc/dillorc", O_RDONLY)) < 0) > > - return FILE_NOT_FOUND; > > - > > + if (fd < 0 && (fd = open(DILLO_SYSCONFDIR, O_RDONLY)) < 0) > > + return FILE_NOT_FOUND; > > + > > fcntl(fd, F_SETFD, FD_CLOEXEC | fcntl(fd, F_GETFD)); > > > > scanner = g_scanner_new(NULL); > > I might be missing something, but your new open() is on a directory > there. Ah, yes, of course. This was just a suggestion, and should be simple to fix. Sebastian

April 2, 2003

Re: [Dillo-dev] Re: configuration patch

by Sebastian Geerken

On Mon, Mar 31, Jorge Arellano Cid wrote: > > The location of the system dillorc should NOT be > > put in config.h according to the GNU docs, instead > > everything with prefix/sysconfdir and similar stuff > > should be defined on the command line. Hence, my > > src/Makefile.am patch. This syntax of ' and " works on > > a variety of systems (bash, ksh, csh, GNU make) finally. > > Also, the current toplevel Makefile.am first tries > > $(DESTDIR)$(sysconfdir) and then falls back on /etc > > but the code in prefs.c does it the other way round. > > One of them should probably be reverted. > > And while writing this : the patch supplied on the > > list will make dillorc be installed ONLY in > > $(DESTDIR)$(sysconfdir) with no fall-back to /etc > > but I think $(DESTDIR)$(sysconfdir) will be created > > if necessary. > > I'm not sure of what to do here :(. For now I added Patrice's > patch that simply adds: > > sysconf_DATA = dillorc > > in Makefile.am, and it works! > > The problem is we don't know what directory it gets in. :-) > > Currently if it is /usr/local/etc/ or /etc, it works, but if > someone chooses /opt/weird/etc, it won't be found. Why not use $(sysconfdir) in the code, as in the attached patch? I'm not sure about the usage of the quotation marks in src/Makefile.am, they may cause problems on different environments, perhaps someone has a better idea. Sebastian

April 2, 2003

VERBATIM and TEXTAREA

by Jorge Arellano Cid

Hi there! I just commited a fix for VERBATIM mode in the parser, and some hopefully final improvements to the code handling TEXTAREA initial values. This could be very important for those of you expecting to be able to use dillo with some sites that use the feature: for instance GNU-mailman! Just give it a try! (was BUG#318 and BUG#400). Cheers Jorge.-

April 2, 2003

Re: [Dillo-dev] Remote control reloading

by Eric GAUDET

>> What about implementing some signals dillo would react on. I.e. SIGHUP >> to make dillo reload the page. > > Additional code must be justified by satisfying a user need. I don't think > very many people are going to send signals to Dillo to reload the page -- > they'll just click the Reload button. > No code needs justification. Only the inclusion to release version does. One person thinks he needs this feature that is trivial to implement. Even if it never goes to the main trunk, let's give it a try: it might prove usefull to some people. Or not, who cares? Dillo is great for this because the code is simple enough to understand and experiment with. Good luck trying this kind of stunt with mozilla! The Sylpheed project experimented embedding dillo, and eventually dillo included the feature. Bottom line: I'll always favor experimental contribution that prove useless to sterile discussion about the value of an hypothetical feature. Eric.

April 2, 2003

Re: [Dillo-dev] Remote control reloading

by Chris Palmer

On 2003-03-23 at 17:46 +0100, Christian W. Zuckschwerdt wrote: > What about implementing some signals dillo would react on. I.e. SIGHUP > to make dillo reload the page. Additional code must be justified by satisfying a user need. I don't think very many people are going to send signals to Dillo to reload the page -- they'll just click the Reload button. -- Chris music is what numbers feel like San Francisco, CA

April 1, 2003