- Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] selection segfault again

by Jamin W. Collins

On Sat, Jul 12, 2003 at 04:58:42PM +0200, Sebastian Geerken wrote: > Since the </table> tag is mandatory, we are not obliged to handle > this. Anyway, a missing </table> tag will leave a well-defined widget > tree, which the selection must be able to handle. While not required to handle it, the application should *never* segfault when provided bad data. -- Jamin W. Collins Linux is not The Answer. Yes is the answer. Linux is The Question. - Neo

July 12, 2003

Re: [Dillo-dev] selection segfault again

by Sebastian Geerken

Hi, FYI: I seem to have fixed the bug, expect it to be committed today. Those interested should look at the differences in the code, it is only a simple coding bug, nothing very interesting. On Fri, Jul 11, Joe Crayne wrote: > <html> <title>Selection Bug</title> > <body> > > <table> > <tr><td></td></tr> > > <tr><td> > Select beyond the end of the text and > Dillo segfaults. > </td></tr> >  > > </body> > </html> The reason, why the missing </table> tag matters, is that Html_close_tag_table() will insert a break after the table, which makes iterators behave different. > [...] > I see 3 possible attacks on this one: > > 1. Add a check for NULL on the return value of > a_Dw_ext_iterator_new_variant(). a_Dw_ext_iterator_new() returns NULL, if the page does not contain any non-widget contents. After it one succeeded, it should always succeed. That it does not, was a bug, and is fixed now. BTW: Actually, this is only true, as long as no contents is *removed* from the page, which does not yet happen. If it happens, the selection will anyway get more complicated, a check in this case would not make much sense. > 2. Do that special empty DwExtIterator idea you > mentioned. Yes, this will probably part of 0.7.4. But in this case, you would have to compare empty with non-empty iterators ;-) > 3. Make html.c clean up the <table> tag better. > The missing closer probably shouldn't make a > difference in this example, but the segfault only > happens if the closer is missing. Since the </table> tag is mandatory, we are not obliged to handle this. Anyway, a missing </table> tag will leave a well-defined widget tree, which the selection must be able to handle. Sebastian

July 12, 2003

Re: [Dillo-dev] Some news...

by Ferdi Franceschini

Lars Segerlund wrote: > I have been looking at the dpid, and from what I can see it looks > good, it would be a piece of cake to whip up some usefull dpi's now :-) That's great! > ... I will however dig a bit more, the issue that I am concearned is if > it prohibits some action to be implemented, ( workarounds are ok for me > :-) ). dpid does not prohibit anything, it simply starts a plugin on demand (similar to inetd). > I also have a related question about the dpi's, whith the new > interface, how it fx. a https dpi supposed to work ? and would it be > possible to make fw a svg dpi ? ( thus enabling the dpi to do the > rendering ? I don't think dillo supports https (other than to check that it is used for cookies), and I don't know what plans there are for https support. Can you explain what "fw" and "svg" stand for. For now, just have the dpi open its own window for rendering, we'll worry about how to integrate this with dillo later, you will also need to do this for GUI controls. > Anyhow, for my stumbling attempts whith dpi's it seems to be fully > adequat. That's good. If you have any further questions please let us know. I plan to make a new version of dpid which supports a dpi directory structure in a few days. Regards Ferdi

July 12, 2003

TIPS!

by Jorge Arellano Cid

Hi there! From time to time I find some remarkable articles. The next couple is in our [Links] section, but as most probably some of us have missed them, I want to recommend them explicitly. The make an excellent read for every developer, regardless of the project they're working on. Please take my advice and spare some time to read them, it's all worth of it! http://www.dillo.org/ui-prefs-tips.html http://ometer.com/features.html (both by Havoc Pennington). -- I also noice that sometimes it gets a bit tedious to dig in the mailing list archives, and there was this ancient email about GMANE, and hey! they have a nice search engine. Now there's a link to it from our [Mailing list] page. Enjoy! Jorge.-

July 11, 2003

selection segfault again

by Joe Crayne

<html> <title>Selection Bug</title> <body> <table> <tr><td></td></tr> <tr><td> Select beyond the end of the text and Dillo segfaults. </td></tr>  </body> </html>

July 11, 2003

Re: [Dillo-dev] Another delay for 0.7.3 :(

by Andreas Schweitzer

Hi, On Thu, Jul 10, 2003 at 01:27:48PM -0400, Jorge Arellano Cid wrote: > So the 0.7.3 release will be held until I have some news about > this bug. > > How to reproduce: > > > [Andreas wrote:] > > > > Well, I found a recently introduced rendering problem : > > For example > > http://bbs.archlinux.org/viewtopic.php?t=771 > > the 4th post has one line extending to the right, w/o a scroll > > bar on the bottom. You need to resize the window to get > > the page re-rendered. Just to clarify for everybody else on the list : This probably affects all boards managed with phpBB - and there are lots of them. Cheers, Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

July 11, 2003

Re: [Dillo-dev] selecting text block larger than window

by Andreas Schweitzer

Hi - also to everybody replying, On Thu, Jul 10, 2003 at 04:33:37AM -0500, Albert Wagner wrote: > I am having difficulty selecting a block of text that is larger than the > window. Moving the cursor above/below the window limits doesn't cause > the window to scroll while selecting. Is this something configurable > that I have overlooked? Or is it still on a TO-DO list? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ As far as I remember one of Sebastian's first mails on selection, this is indeed the case ! I'm too lazy to search the archive, though. Cheers, Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

July 11, 2003

Re: [Dillo-dev] selecting text block larger than window

by Frédéric Bothamy

* George Mason <georgemason(a)mindspring.com> [2003-07-10 22:08] : > On Thu, Jul 10, 2003 at 04:33:37AM -0500, Albert Wagner wrote: > > I am having difficulty selecting a block of text that is larger than the > > window. Moving the cursor above/below the window limits doesn't cause > > the window to scroll while selecting. Is this something configurable > > that I have overlooked? Or is it still on a TO-DO list? > > Its not exactly configurable but after starting the selection you > can still scroll with arrow keys or PgUp PgDown. I've been using > that trick since cut and paste was introduced. Thanks for the tip, this (supposed) limitation was really annoying to me. Maybe this could be documented in the Copy&Paste section in http://www.dillo.org/dillo-help.html? Fred

July 11, 2003

Re: [Dillo-dev] selecting text block larger than window

by Kelson Vibber

On Thursday 10 July 2003 7:08 pm, George Mason wrote: > Its not exactly configurable Why would anyone want this to be configurable? That would be like having an option for whether or not you follow links when you click on them. Or one to flat-out disable selection. Sorry, I recently re-read "Free software and good user interfaces" <http://www106.pair.com/rhp/free-software-ui.html>. The original post reminded me of the section where the author describes people who assume bugs are intentional and request a preference instead of a fix. -- Kelson Vibber www.hyperborea.org

July 11, 2003

Re: [Dillo-dev] selecting text block larger than window

by George Mason

On Thu, Jul 10, 2003 at 04:33:37AM -0500, Albert Wagner wrote: > I am having difficulty selecting a block of text that is larger than the > window. Moving the cursor above/below the window limits doesn't cause > the window to scroll while selecting. Is this something configurable > that I have overlooked? Or is it still on a TO-DO list? Its not exactly configurable but after starting the selection you can still scroll with arrow keys or PgUp PgDown. I've been using that trick since cut and paste was introduced. george

July 11, 2003