- Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] [PATCH] version 7 of tab patch is ready

by Frank de Lange

On Tue, Aug 05, 2003 at 10:04:35AM +0200, Jens Arm wrote: > Hi > > Great work the tab and frame support! > > If I try to open the reiserfs-Homepage (www.namesys.com) Just an addition to my previous reply... Namesys' page does show up as expected (two frames), but navigation does not work as it should yet. The current version of the frames patch ignores the <base target='main'> tag in the left frame, so all content ends up in the left frame instead. This will be fixed in the next version of the patch. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Aug. 5, 2003

Re: [Dillo-dev] [PATCH] version 7 of tab patch is ready

by Frank de Lange

On Tue, Aug 05, 2003 at 10:04:35AM +0200, Jens Arm wrote: > Hi > > Great work the tab and frame support! Thanks... > If I try to open the reiserfs-Homepage (www.namesys.com) > only the menu-frame is shown. > Here is the output of dillo: > > [tux@tux tux]$ dillo > Setting locale to C... > dillo_dns_init: Here we go! > Enabling cookies as from cookiesrc... > Nav_open_url: Url=>about:splash< > Nav_open_url: Url=>http://www.namesys.com< > Dns_server [0]: www.namesys.com is 0x81180b0 > Connecting to 212.16.7.65 > HTML warning: the TITLE element must be inside the HEAD section > Nav_open_url: Url=>http://www.namesys.com/menu.html< > Connecting to 212.16.7.65 > HTML warning: Invalid HTML syntax: too many <frame> tags in <frameset> > > > This I get at other sites, too. It works here... Did you use the latest CVS version of Dillo, did the patch aplpy without problems, do you use a filtering proxy which does weird things to the HTML? Namesys' page comes up in two frames. Size of frames is wrong (but that was to be expected), content is OK. This is what I get with 'View Page Source' on Namesys' page: <html> <TITLE>NAMESYS</TITLE> <frameset cols="160,*" frameborder=0 framespacing=0 border=0> <frame name="menu" src="menu.html" scrolling="auto" noresize border=0 frameborder=0 marginheight=0 marginwidth=0> <frame name="main" src="content_table.html" noresize border=0 frameborder=0 marginheight=0 marginwidth=0> </frameset> </html> So yes, that IS invalid HTML (TITLE tag outside of HEAD), but Dillo renders it OK here. It tells me about the errors in the page: Nav_open_url: Url=>http://www.namesys.com< Connecting to 212.16.7.65 HTML warning: the TITLE element must be inside the HEAD section Nav_open_url: Url=>http://www.namesys.com/menu.html< Nav_open_url: Url=>http://www.namesys.com/content_table.html< Are there any others out there who have problems like this? Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Aug. 5, 2003

Re: [Dillo-dev] [PATCH] version 7 of tab patch is ready

by Jens Arm

Hi Great work the tab and frame support! If I try to open the reiserfs-Homepage (www.namesys.com) only the menu-frame is shown. Here is the output of dillo: [tux@tux tux]$ dillo Setting locale to C... dillo_dns_init: Here we go! Enabling cookies as from cookiesrc... Nav_open_url: Url=>about:splash< Nav_open_url: Url=>http://www.namesys.com< Dns_server [0]: www.namesys.com is 0x81180b0 Connecting to 212.16.7.65 HTML warning: the TITLE element must be inside the HEAD section Nav_open_url: Url=>http://www.namesys.com/menu.html< Connecting to 212.16.7.65 HTML warning: Invalid HTML syntax: too many <frame> tags in <frameset> This I get at other sites, too. Jens

Aug. 5, 2003

Re: [Dillo-dev] Question about frames (have them working, but...)

by Andreas Schweitzer

Hi, <size problems> > <...> If anyone has any > bright ideas on how to assign widgets sizes which are relative to their > container, speak up... Or, if anyone has already created (or at least thought > about creating) a 'frameset' widget, please let me know. No need to re-invent > the wheel... About a week ago I decided to look into Frames with your tabs patch put was overwhelmed by my non-knowledge of GTK. Luckily I saw your note "Now working on frames" in one of your e-mails and I figured at the rate Frank produces code I will never have anything ready ;-) And the description sounds great ! Great work ! I'll try it out now. Anyways, getting to the point. What about tracking the sizes of the widgets ? E.g. putting the sizes in DilloDoc And also maybe putting the parent widget in DilloDoc ? That way one could "cascade" down the sizes. I haven't looked at the new patch though - just some ideas. The problem might be that all these sizes would only be calculated sizes and that GTK may calculate the sizes differently and hence may be getting different rounding errors. A lot of resizing may be getting the actual sizes and the calculated sizes heavily out of sync. One would have to see. > The patch is made against 20030804 CVS. It can be downloaded from the usual > (ad-happy, but...) Geocities site: > > http://www.geocities.com/ikbenfrank/ > > More specifically, it can be found here: > > http://www.geocities.com/ikbenfrank/dillo-20030804-tabs.patch.gz > size: 53262 bytes (gzipped, as downloaded) > 220519 bytes (uncompressed) > md5sum: 5c218077382d6c6e7300f1dd7d41e024 (gzipped, as downloaded) > f6242c4f01f0eed60645db91a8882b2c (uncompressed) And again at http://www.hs.uni-hamburg.de/~stcd102/dillo-20030804-tabs.patch.gz Cheers Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

Aug. 5, 2003

Re: [Dillo-dev] Question about frames (have them working, but...)

by Melvin Hadasht

Hi Frank, You wrote: > If anyone has any > bright ideas on how to assign widgets sizes which are relative to their > container, speak up... I don't know Dillo internal widgets, but Gtk provides the GtkFixed widget where you can specify where the widgets are to be positioned. The API reference says that in that case the size is also fixed (but it does not say how). Check also the Gtk2 reference for this widget, as it looks more complete there. HTH -- Melvin Hadasht

Aug. 5, 2003

[PATCH] version 7 of tab patch is ready

by Frank de Lange

Oops... I seem to have messed up the subject of my last message. Anyway, as stated... the next version of my tab patch is ready, get it at http://www.geocities.com/ikbenfrank Read my last message for more info... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Aug. 5, 2003

Question about frames (have them working, but...)

by Frank de Lange

Hi'all, The next version (7) of my tab patch is ready (see bottom of this message for download instructions). Most notable change is that it now also contains an experimental, not-really-ready-but-quite-entertaining implementation of frame/iframe support. The not-quite-ready part has to do with the sizing of frames (more on this later). Frame support, like tab support, is optional. It is enabled by default, but you can disable it using (frames) --disable-frames and (tabs) --disable-tabs during configure. Other new features: - title of window/tab set to url if file has no title (this can be disabled with the preference 'document_title_use_url=NO', default enabled) - navigation buttons (back, forward, stop, reload) in popup menu (can be disabled with preference 'show_popup_navigation=NO', default enabled) - duplicate page (open current page in new window, keyboard ALT-N) and, if tab support is enabled, duplicate tab (open current page in new tab, keyboard ALT-T) options in popup menu. Of course, the patch also fixes some bugs (and possibly introduces new ones). I had to back out my stopgap fix for the Gdk-CRITICAL warnings, which caused more problems than it solved. Instead, I patched dw_widget. The warnings were generated from within Dw_widget_mouse_event(dw_widget:729) when it tried to set a cursor on a non-existing window. I added a NULL-check, and made the widget generate a debug message (set DEBUG_LEVEL to 10 to see the warning). More on frame/iframe support ============================ What works: - loading (nested) framesets, displaying frames at their appropriate location (but not at their appropriate size... yet...) - loading (nested) iframes, displaying iframes at their appropriate location and with (mostly) appropriate size and alignment. - all frame-related menu options (in the popup menu). Frame menus can be accessed using the 'This Frame...' button in the popup menu, nested framesets have their own 'This Frameset...' menu. This way, Dillo allows you to limit actions to a subset of a framed document, eg. you can search for text in just one frame/iframe/frameset. Top-level menu options usually refer to the whole document (the frameset). An exception to this is the 'Jump To' option, which refers to the frame in which the menu was opened (question: should this contain the anchors for all frames?). Use the 'Show only this Frame' option in the Frame Options menu to get a full-page view of a frame (which is what you'd get with an unpatched version of Dillo). What does not work yet: - obeying frameset proportions. Currently all frames are allocated a default size. I have the appropriate sizes for the frames at hand, but GTK does not provide a means to size multiple widgets in a container relative to the size of that container. The 'gtk_widget_set_usize()' (or GTK2's gtk_widget_set_size_request() replacement function) are not suitable for this purpose, although they can be used to set a minimum or absolute size for rows/columns which have been specified that way (frameset rows=100,100,* is easy, frameset rows=100,20%,3*,* is not...). - the full_screen_off_button is not shown in frame documents. Use double-click instead to toggle the full screen setting... These problems can be solved by creating a new widget for the frameset, but that might be overkill. DwTable provides some of the needed features, but is is overcomplicated for the task at hand (no colspan or rowspan in framesets, etc) and lacks direct control over the height of table cells. If anyone has any bright ideas on how to assign widgets sizes which are relative to their container, speak up... Or, if anyone has already created (or at least thought about creating) a 'frameset' widget, please let me know. No need to re-invent the wheel... If I get no response, I will probably create a new widget based on GtkTable, with some built-in sizing magic. I chose GtkTable over DwTable because the former seems to be more suitable for the purpose than the latter. I might be wrong, please tell me... Tabs, frames and browser bloat ============================== For those who wonder if all this will add much to the size of Dillo, rest assured that it does not. I did some size comparisons between CVS Dillo (unpatched) and several configurations with the patch applied. The main results are (compiled with gcc 3.2.2, binutils 2.13.90.0.18 for x86, optimisation -Os, stripped binary) CVS unpatched: 285024 bytes Patched, no tabs, no frames: 289884 bytes Patched, no tabs, with frames: 294076 bytes Patched, with tabs, no frames: 297596 bytes Patched, with tabs and frames: 301692 bytes So, some 15 Kb for tabs and frames together, bearing in mind the patch has not been optimised for size yet (premature optimisation is... well, a bad idea). Not too bad, I think. Download instructions ===================== The patch is made against 20030804 CVS. It can be downloaded from the usual (ad-happy, but...) Geocities site: http://www.geocities.com/ikbenfrank/ More specifically, it can be found here: http://www.geocities.com/ikbenfrank/dillo-20030804-tabs.patch.gz size: 53262 bytes (gzipped, as downloaded) 220519 bytes (uncompressed) md5sum: 5c218077382d6c6e7300f1dd7d41e024 (gzipped, as downloaded) f6242c4f01f0eed60645db91a8882b2c (uncompressed) As always, check the site for the most recent version: That's all for now, Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Aug. 5, 2003

Re: [Dillo-dev] dillo-0.7.3-rc2

by Sebastian Geerken

On Sat, Aug 02, Jorge Arellano Cid wrote: > Today I was decided to upload 0.8.0-pre but found some problems > with one plugin. At the same time Sebastian sent me a fix for the > bug that delays 0.7.3 (very simple), so most probably our current > CVS holds the final 0.7.3! Sorry, this patch was incomplete. I tried to extract the actual code changes, without some new debugging messages, but ommitted some things. The current CVS (which has now also the new debugging messages) contains now the complete changes. > Please give it a hard test. If everything goes fine, it'll be > released by Tuesday or Wednesday. > > With regard to 0.8.0-pre, please expect it to be in CVS at > announce time. I know I have delayed it a lot, but it comes with > much more than what was anticipated (and I believe you'd prefer > it to be working right! :). Jorge, I've not yet tagged the code, please do so when uploading the 0.8.0 code. Sebastian

Aug. 3, 2003

dillo-0.7.3-rc2

by Jorge Arellano Cid

Hi there! Today I was decided to upload 0.8.0-pre but found some problems with one plugin. At the same time Sebastian sent me a fix for the bug that delays 0.7.3 (very simple), so most probably our current CVS holds the final 0.7.3! Please give it a hard test. If everything goes fine, it'll be released by Tuesday or Wednesday. With regard to 0.8.0-pre, please expect it to be in CVS at announce time. I know I have delayed it a lot, but it comes with much more than what was anticipated (and I believe you'd prefer it to be working right! :). Cheers Jorge.- PS: Phil, Kelson: Please be prepared to upgrade your packages before 0.7.3 is announced. That is, if testing don't say otherwise! I'll let you know one or two days before the announcement.

Aug. 3, 2003

Re: [Dillo-dev] [PATCH] version 6 of Dillo tab patch now available

by Jorge Arellano Cid

On Fri, 25 Jul 2003, Kelson Vibber wrote: > On Friday 25 July 2003 10:30 am, Mattias Östergren wrote: > > When visiting a page without a title or an image dillo displays the URL in > > the windows titlebar, but the tab is empty. Feature or bug? > > That reminds me, I had a patch to add a title to the Bookmarks page - > something I noticed because of this. (attached) Done! And also tagged current CVS as "release-0_7_3-rc1". Cheers Jorge.-

July 31, 2003