- Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] [PATCH] Version 10 of tab/frame patch is ready...

by Victor Sahlstedt

On Sat, 27 Sep 2003 12:56:59 +0200 Frank de Lange <frank(a)unternet.org> wrote: > Which patch are you actually using, and which CVS version? Patch 10 (the one I > just released) is against 09/26 CVS (not 08/21 like you state in your message), > and the patch file is dillo-20030926-tabs.patch.gz (not > dillo-20030821-tabs.patch.gz). My wrong. I fetched the patch from http://www.geocities.com/ikbenfrank/ but didn't reflect over the fact that it was dated 08/21, not 09/26. No wonder it didn't apply to 9/26-CVS. The 9/26-patch worked fine with 9/26-CVS, keep up the good work. - Victor

Sept. 27, 2003

Re: [Dillo-dev] [PATCH] Version 10 of tab/frame patch is ready...

by Frank de Lange

On Sat, Sep 27, 2003 at 02:47:22AM +0200, Victor Sahlstedt wrote: > On Fri, 26 Sep 2003 19:48:04 +0200 > Frank de Lange <frank(a)unternet.org> wrote: > > > The next version (10) of my tab patch is ready > > salan@smedjan:~/incoming/cvs/dillo> gmake -s > Making all in doc > Making all in src > Making all in IO > http.c: In function `Http_use_socket': > http.c:228: structure has no member named `bw' > http.c:232: structure has no member named `bw' > http.c: In function `Http_connect_socket': > http.c:320: structure has no member named `bw' > http.c: In function `Http_send_query': > http.c:339: structure has no member named `bw' > http.c: In function `Http_get': > http.c:406: structure has no member named `bw' > http.c: In function `a_Http_ccc': > http.c:437: structure has no member named `bw' > http.c:466: structure has no member named `bw' > http.c:477: structure has no member named `bw' > http.c:502: structure has no member named `bw' > gmake[3]: *** [http.o] Error 1 > gmake[2]: *** [all-recursive] Error 1 > gmake[1]: *** [all-recursive] Error 1 > gmake: *** [all] Error 2 > > dillo-20030821-tabs.patch.gz patched against 08/21 CVS. > It's related to the patch as Dillo compiles fine without it. > > OpenBSD 3.3 / GCC 2.95.3 > > - Victor Hm, sounds like BW_MSG is not patched correctly in your case, did the patch not apply cleanly? Which patch are you actually using, and which CVS version? Patch 10 (the one I just released) is against 09/26 CVS (not 08/21 like you state in your message), and the patch file is dillo-20030926-tabs.patch.gz (not dillo-20030821-tabs.patch.gz). Try again with the correct versions, and if it does not work, by all means let me know... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / \ \ `--| _/ <Hacker for Hire> \ `---' \ +46-734352015 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Sept. 27, 2003

Re: [Dillo-dev] [PATCH] Version 10 of tab/frame patch is ready...

by Kelson Vibber

On Friday 26 September 2003 10:48 am, Frank de Lange wrote: > The next version (10) of my tab patch is ready (see bottom of this > message for download instructions). In case anyone's interested, I've posted RPMs for most of my usual set of distributions, based on 0.7.3 and the new tab patch at http://www.hyperborea.org/software/dillo/modified.html This covers Red Hat 6,7,8, and 9, Mandrake 8.1 and 8.2, Mandrake 9.1 PPC, and the source RPM, plus a CVS-based RPM or SuSE 8.1 contributed by Patrick Shanahan. I'll get the last two (SuSE 8.2 and Mandrake 9.1 x86) posted tomorrow. -- Kelson Vibber kelson(a)pobox.com http://www.hyperborea.org/ Creative Writing - Photography - The Flash

Sept. 27, 2003

Re: [Dillo-dev] Mac OS X Aqua port and new project HEML

by Kelson Vibber

Sorry to extend this thread again... I just wanted to apologize for anything inflammatory I said earlier. Andreas has the right idea: let the past stay in the past and move on. -- Kelson Vibber www.hyperborea.org

Sept. 27, 2003

Re: [Dillo-dev] [PATCH] Version 10 of tab/frame patch is ready...

by Victor Sahlstedt

On Fri, 26 Sep 2003 19:48:04 +0200 Frank de Lange <frank(a)unternet.org> wrote: > The next version (10) of my tab patch is ready salan@smedjan:~/incoming/cvs/dillo> gmake -s Making all in doc Making all in src Making all in IO http.c: In function `Http_use_socket': http.c:228: structure has no member named `bw' http.c:232: structure has no member named `bw' http.c: In function `Http_connect_socket': http.c:320: structure has no member named `bw' http.c: In function `Http_send_query': http.c:339: structure has no member named `bw' http.c: In function `Http_get': http.c:406: structure has no member named `bw' http.c: In function `a_Http_ccc': http.c:437: structure has no member named `bw' http.c:466: structure has no member named `bw' http.c:477: structure has no member named `bw' http.c:502: structure has no member named `bw' gmake[3]: *** [http.o] Error 1 gmake[2]: *** [all-recursive] Error 1 gmake[1]: *** [all-recursive] Error 1 gmake: *** [all] Error 2 dillo-20030821-tabs.patch.gz patched against 08/21 CVS. It's related to the patch as Dillo compiles fine without it. OpenBSD 3.3 / GCC 2.95.3 - Victor

Sept. 27, 2003

[PATCH] Version 10 of tab/frame patch is ready...

by Frank de Lange

Hi'all, The next version (10) of my tab patch is ready (see bottom of this message for download instructions). Control over margins in (i)frames has been improved (no more extraneous margin space in iframe). Dillo (when configured for frameset support) now always renders frameset - even when body content is placed outside the frameset. Frame resize support has been improved a bit. Worked around a bug in GtkContainer which messed up the 'tab' order (focus got stuck in GtkToolbar widgets). Improved/corrected focus handling in dw_gtk_scrolled_frame. New features: - interactive search ('find as you type') on "/" key - new preference: popup_dialogs=([YES]/NO) when set to NO the status bar and location bar are used for search and open URL. Open file and save file still use popup dialogs, though. Changed preferences from previous versions of patch: - frame_blank_in_tab and tab_on_middle_click are now merged into a new preference: tab_instead_of_window=(YES/[NO]) - document_title_use_url is gone, this functionality is now default - (for those who downloaded the interim-patch with find_as_you_type) find_as_you_type is gone, this functionality is bound by default to the "/" key. Use Ctrl-F for normal (non-interactive) search Some behavioural changes with regard to stock (CVS) Dillo: - Shift-Ctrl-L (instead of Ctrl-L) for "open URL" dialog - Ctrl-L for "focus location bar" - Ctrl-S for "Save page As..." - Ctrl-U for "view source" while in a document, "clear entry" everywhere else (in stock Dillo this key is bound to "focus location bar" while in a document) - Ctrl-B for "Bookmark this page" - Alt-H for "Home" - "/" starts incremental search instead of normal search. For normal (non-incremental) search use Ctrl-F The popup menu over images and hand cursor over input image features wihch used to be part of this patch have meanwhile been committed to CVS. The same goes for the bug fixes to dw_image and dw_widget. Support for the 0.7.3 branch will be dropped for the next version of this patch. Some of the new features (interactive search, popup dialog=NO, tab order bug fix) are not availabe in the 0.7.3 version of the patch. if you want the new features you'll have to switch to 0.8.0-pre. Sorry, folks, but that is the price you pay for progress... Currently, both tab and frame support can be turned off completely, producing a smaller binary. I might (on request of other Dillo developers) remove the conditional compilation, thereby making tab and frame support a permanent feature of Dillo. If you want to keep the conditional compilation feature, speak out on the mailing list! Frameset (and iframe) support is enabled by default, it can be disabled using the configure option --enable-xhtml-dtd=strict. You can also use --enable-xhtml-dtd=transitional, which will give you iframe but no frameset support. The default option, --enable-xhtml-dtd=frameset, gives both iframe and frameset support. As usual, tab support can be disabled using --disable-tabs. What does not work yet: - the full_screen_off_button is not shown in frame documents. Use double-click instead to toggle the full screen setting... - the frameborder attribute works, but dw_gtk_scrolled_frame always draws a (focus) shadow around itself - even with the border size is set to 0. This can be solved in several ways - adding a 'borderless' attribute to dw_gtk_scrolled_frame, using a special borderless GTK theme for the widget, etc. In GTK2 this is all much easier (just set the widget's style's xthickness/ythickness to 0), but we're not there yet... - borderless frames can not be resized, even though Dillo always shows a thin border (see above). Who cares about resizing borderless frames? Mozilla does it, but I don't think this is an issue. Agree? - iframes always have a border (see above) Tabs, Frames and browser bloat ============================== version: 0.8.0-pre patch: dillo-20030926-tabs.patch.gz unpatched: 292372 bytes patched, no tabs, no frames: 298624 bytes patched, with tabs, no frames: 306176 bytes patched, no tabs, with frames: 315200 bytes patched, with tabs, with frames: 322784 bytes version: 0.7.3 patch: dillo-0.7.3-20030926-tabs.patch.gz unpatched: 285248 bytes patched, no tabs, no frames: 291852 bytes patched, with tabs, no frames: 298700 bytes patched, no tabs, with frames: 308268 bytes patched, with tabs, with frames: 316556 bytes (gcc 3.2.2, binutils 2.13.90.0.18, CFLAGS "-Os") Download instructions ===================== There are two versions of the patch, one for Dillo 0.7.3 (release) and one for Dillo 0.8.0-pre (CVS). Make sure to download the correct version for the Dillo source you want to patch! If you patch the CVS source, do not forget to run ./autogen.sh after applying the patch. The CVS patch is made against 20030926 CVS, while the 0.7.3 patch is made against Dillo-0.7.3.tar.bz2 (the source tarball on the main Dillo website). Both versions of the patch can be downloaded from the usual (ad-happy, but...) Geocities site: http://www.geocities.com/ikbenfrank/ More specifically for both versions: Dillo 0.8.0-pre (CVS) ===================== http://www.geocities.com/ikbenfrank/dillo-20030926-tabs.patch.gz size: 73796 bytes (gzipped, as downloaded) 315210 bytes (uncompressed) md5sum: e8e1bf9d20ff26991c9d3b7cc1202ee2 (gzipped, as downloaded) 127d224ff29ce263d685718c7ca511f1 (uncompressed) Dillo 0.7.3 (release) ===================== http://www.geocities.com/ikbenfrank/dillo-0.7.3-20030926-tabs.patch.gz size: 88264 bytes (gzipped, as downloaded) 369994 bytes (uncompressed) md5sum: 51df11b26723283124ada4368a9958ea (gzipped, as downloaded) 64769d5f996cec2ac248578a234b32a7 (uncompressed) As always, check the site for the most recent version Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Sept. 26, 2003

Re: [Dillo-dev] Dillo authorization question...

by Kelson Vibber

At 11:30 AM 9/25/2003, Ronald W. Henderson wrote: >Does dillo authorization via a popup login authorization dialog? >... >Is there a patch for this? There's at least one: http://www.zone.ee/myzz/dillo/0.7.3/dillo-0.7.3-mzz.html Kelson Vibber www.hyperborea.org

Sept. 26, 2003

Re: [Dillo-dev] Yes or No: optional compilation of 'extra' features

by Andreas Kemnade

On Thu, 25 Sep 2003 14:51:45 +0200 Frank de Lange <frank(a)unternet.org> wrote: > Hi'all, > > Those of you who have tried my tab/frames patch will know that I usually make > all 'extra' features optional. This allows those who {do not {need|like}|can > not afford} those features to leave them out of the resulting binary. However, > it also makes the code somewhat more complex, as the optional features are > enabled/disabled through conditional compilation (#ifdef/#ifndef....#endif). > The space saved by leaving out tabs and frames is currently about 25 kilobytes > (Kib, kB, KB, choose your acronym...). > > I have gotten some comments on this, suggesting the removal of these > conditional statements. This way, Dillo would ALWAYS have the extra features > (tabs and frames). > > Before I say 'yes' or 'no' to these suggestions, I'd like to know what your > thoughts are on this. > 25 KB can be important on PDAs. I guess having real frame support is not always a good idea on PDAs because of the low resoltion. On many pages you can easily find the navbar and then go to the content pages from there. So the simple frame support now in cvs is enough in some situations. Greetings Andreas Kemnade

Sept. 26, 2003

Re: [Dillo-dev] Yes or No: optional compilation of 'extra' features

by Patrick Shanahan

* Frank de Lange <frank(a)unternet.org> [09-25-03 16:14]: > On Thu, Sep 25, 2003 at 09:17:12PM +0200, Andreas Schweitzer wrote: > > > I'm guessing almost everybody wants to have frames, so maybe removing > > > the conditional compilation of frames is worthwhile for the sake of > > > simplifying code. > > > > Not only everybody *wants* it. Afterall, frames are part of > > the HTML standard. So it makes sense to have them. > > > > But then again, as far as I understood some of the last e-mails > > from Jorge : isn't he reviewing this patch now or pretty > > soon ? > > It was in reaction to comments from Sebastian that I posed this question to the > list. He suggested removing the conditional compile, but I want to know what > the list has to say on this. As a quick look at the list archives will show, > not everyone likes these new additions to Dillo. The _tabbed_ browsing is wonderful and, afaiac, necessary, along with the tab_on_middle_click. > - exchange tab_load_in_background with a UI element/choice (I think this > should be delayed until Dillo has a preference UI/plugin to avoid > unnecessary complexity and one-off solutions) acceptable > I will release a new version today or tomorrow Looking forward. Will provide a SuSE 8.1 rpm if I am able to compile. -- Patrick Shanahan Registered Linux User #207535 http://wahoo.no-ip.org @ http://counter.li.org

Sept. 25, 2003

Re: [Dillo-dev] Yes or No: optional compilation of 'extra' features

by Frank de Lange

On Thu, Sep 25, 2003 at 09:17:12PM +0200, Andreas Schweitzer wrote: > > I'm guessing almost everybody wants to have frames, so maybe removing > > the conditional compilation of frames is worthwhile for the sake of > > simplifying code. > > Not only everybody *wants* it. Afterall, frames are part of > the HTML standard. So it makes sense to have them. > > But then again, as far as I understood some of the last e-mails > from Jorge : isn't he reviewing this patch now or pretty > soon ? It was in reaction to comments from Sebastian that I posed this question to the list. He suggested removing the conditional compile, but I want to know what the list has to say on this. As a quick look at the list archives will show, not everyone likes these new additions to Dillo. I have already removed some preferences which could be combined (frame_blank_in_tab and tab_on_middle_click -> tab_instead_of_window) or which should be defaulted to the new functionality (document_title_use_url). Other suggestions Sebastian made are: - Remove tab title compression/shortening (I might create a new label widget which compresses/shortens text to a given size for this functionality) - exchange tab_load_in_background with a UI element/choice (I think this should be delayed until Dillo has a preference UI/plugin to avoid unnecessary complexity and one-off solutions) - rename "DilloDoc" to something else (I do not agree, DilloDoc is descriptive and short) The current state of the patch is: - still have conditional compile - have removed unnecessary preferences - have removed some recent changes to CVS nav.c which conflict with document/interface separation (have mailed Jorge about this) - have added incremental search and status-bar search widget (instead of popup) I will release a new version today or tomorrow Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Sept. 25, 2003