- Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] HTTPS Patch

by Indan Zupancic

> Declaring variables in mid-code (ie, anywhere in the block) is valid > only for compilers complying with the C99 standard (such as GCC3). The code is declared at the start of the block, and is also the last code declared, it's just also initialized, but if you look at the code all declarations are before the statements. Please send the emails only to the list, otherwise I receive two emails, thanks.

Oct. 28, 2003

Re: [Dillo-dev] HTTPS Patch

by David McKee

Indan, This is extremely cool. I am pleased and excited. It rates as high with me as frame support, and leaves me waiting only for printing to be content. On Mon, 27 Oct 2003, Indan Zupancic wrote: > > First, the build doesn't know where to find my openssl headers > > and libraries [snippage] > I don't know much about autoconfigure/make/build, so it's no wonder. In > the final version it should be autodetected. Fair enough. Neither do I. > Seems like you have an old openssl version, on my computer all headers > are in openssl/, you probably need to change the includes at the top > of IO.c. If they are just in a non-default directory then run > "CFLAGS=-I/path/to/ssl ./configure". Also don't forget to run autogen > after applying the patch. New openssl in a weird place because I compiled from source. I fixed this by installing some carefully chosen links in the file system, so it should work for other builds as well... But thanks for the advice: I hadn't realized that ./configure could take paths from environment variables. > I'll change that St thing, but I'm pretty sure it's allowed to do it that > way, my compiler (gcc 3.2.2) didn't give any warnings either. Will change > it anyway, if old gcc has problems with it (not home now, so will change > it later). It is (as has already been noted) a c99 thing, not allowed in the old ANSI standard. Thanks for your work. It looks great. -- -- David McKee -- dmckee(a)jlab.org -- (757) 269-7492 (Office)

Oct. 27, 2003

Re: [Dillo-dev] HTTPS Patch

by Livio Baldini Soares

Indan Zupancic writes: [...] > I'll change that St thing, but I'm pretty sure it's allowed to do it that > way, my compiler (gcc 3.2.2) didn't give any warnings either. Will change > it anyway, if old gcc has problems with it (not home now, so will change > it later). Declaring variables in mid-code (ie, anywhere in the block) is valid only for compilers complying with the C99 standard (such as GCC3). IMHO this type of construct should still be avoided, as it breaks compatibility with other ANSI-C-only compilers (including GCC 2.95). best regards, -- Livio B. Soares

Oct. 27, 2003

Re: [Dillo-dev] HTTPS Patch

by Indan Zupancic

> First, the build doesn't know where to find my openssl headers > and libraries, and there does not seem to be a ./configure option > for this. (BTW: My goodies are in /usr/local/ssl/...) I can fix > this locally, but a config option might be in order. I don't know much about autoconfigure/make/build, so it's no wonder. In the final version it should be autodetected. Seems like you have an old openssl version, on my computer all headers are in openssl/, you probably need to change the includes at the top of IO.c. If they are just in a non-default directory then run "CFLAGS=-I/path/to/ssl ./configure". Also don't forget to run autogen after applying the patch. I'll change that St thing, but I'm pretty sure it's allowed to do it that way, my compiler (gcc 3.2.2) didn't give any warnings either. Will change it anyway, if old gcc has problems with it (not home now, so will change it later). greetings, Indan

Oct. 27, 2003

Re: [Dillo-dev] HTTPS Patch

by Mike Eriksen

My Red Hat 7.3 didn't have problems finding the ssl-headers, but I couldn't compile before I made the two changes to St mentioned below. Yahoo! Now I have webmail with Dillo. Even with Yahoo! ;-) Mike On Mon, 27 Oct 2003, David McKee wrote: > Folks, > > When I apply and attempt to compile (on a Redhat 6.2 machine, gcc > 2.95), I have two problems. > > First, the build doesn't know where to find my openssl headers > and libraries, and there does not seem to be a ./configure option > for this. (BTW: My goodies are in /usr/local/ssl/...) I can fix > this locally, but a config option might be in order. > > > > Secondly, I get two compilation errors in IO.c. Both are related to the > code: > > errno = 0; > ssize_t St = SSL_read(io->ssl, io->Buf, io->BufSize); > > which I believe should (strictly) be > > ssize_t St; > errno = 0; > St = SSL_read(io->ssl, io->Buf, io->BufSize); > > because declaration should come before statements. In anycase, > making this change in both places (around lines 822 and 852) > fixes the problem for me. > > Now to try it out... > > Thanks, > > -- Thinstation FAQ maintainer http://thinstation.sourceforge.net - a light, full featured linux based thin client OS

Oct. 27, 2003

Re: [Dillo-dev] HTTPS Patch

by David McKee

Folks, When I apply and attempt to compile (on a Redhat 6.2 machine, gcc 2.95), I have two problems. First, the build doesn't know where to find my openssl headers and libraries, and there does not seem to be a ./configure option for this. (BTW: My goodies are in /usr/local/ssl/...) I can fix this locally, but a config option might be in order. Secondly, I get two compilation errors in IO.c. Both are related to the code: errno = 0; ssize_t St = SSL_read(io->ssl, io->Buf, io->BufSize); which I believe should (strictly) be ssize_t St; errno = 0; St = SSL_read(io->ssl, io->Buf, io->BufSize); because declaration should come before statements. In anycase, making this change in both places (around lines 822 and 852) fixes the problem for me. Now to try it out... Thanks, -- -- David McKee -- dmckee(a)jlab.org -- (757) 269-7492 (Office)

Oct. 27, 2003

Re: [Dillo-dev] HTTPS patch

by Mike Eriksen

Sorry - apparently I can't read :-( I'll go for the cvs version. Thanks Mike On Mon, 27 Oct 2003, Indan Zupancic wrote: > > Which version does the patch require? I tried against 0.7.3 and got some > > errors - one in each of IO.c, Url.c and capi.c. > > Quote: "It was made against the current cvs" > > I guess that's pre 0.8. > > it shouldn't be much work to get it working with 0.7.3, if you want that > then just say, I'll make another patch then. The current cvs version seems > very stable, and Frank's patches are also cvs only, so it seems more than > logical to me that if you want experimental new features, you use the cvs > version. > > Two things I forgot to mention: > > If you want a lean and mean Dillo, then comment out or, remove "#define > DEBUG_MSG 5" at the top of IO.c, the extra overhead of the spam isn't > negligible on my 233 mhz computer (it also makes the https code much > bigger). > > The openssl licence is a "GPL-Incompatible, Free Software Licenses", so > it's needed to add an exception that says that DIllo may be linked to the > openssl library, see for more info: > http://www.gnu.org/philosophy/license-list.html#TOCGPLIncompatibleLicenses > > > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)lists.auriga.wearlab.de > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev > -- Thinstation FAQ maintainer http://thinstation.sourceforge.net - a light, full featured linux based thin client OS

Oct. 27, 2003

Re: [Dillo-dev] fltk c binding

by Indan Zupancic

You still have to compile the program with a C++ compiler, also it won't be supported in the future, not sure if it is now. Xforms seem to make things only more complex without any real benefits. Take a look at FLTK's code, from what I saw it's just c with classes. If all you use is classes from c++, and no STL or other stuff, then you can compile a program that doesn't link to standard c++ libraries and isn't bloated by c++.

Oct. 27, 2003

Re: [Dillo-dev] HTTPS patch

by Indan Zupancic

> Which version does the patch require? I tried against 0.7.3 and got some > errors - one in each of IO.c, Url.c and capi.c. Quote: "It was made against the current cvs" I guess that's pre 0.8. it shouldn't be much work to get it working with 0.7.3, if you want that then just say, I'll make another patch then. The current cvs version seems very stable, and Frank's patches are also cvs only, so it seems more than logical to me that if you want experimental new features, you use the cvs version. Two things I forgot to mention: If you want a lean and mean Dillo, then comment out or, remove "#define DEBUG_MSG 5" at the top of IO.c, the extra overhead of the spam isn't negligible on my 233 mhz computer (it also makes the https code much bigger). The openssl licence is a "GPL-Incompatible, Free Software Licenses", so it's needed to add an exception that says that DIllo may be linked to the openssl library, see for more info: http://www.gnu.org/philosophy/license-list.html#TOCGPLIncompatibleLicenses

Oct. 27, 2003

Re: [Dillo-dev] HTTPS patch

by Mike Eriksen

Which version does the patch require? I tried against 0.7.3 and got some errors - one in each of IO.c, Url.c and capi.c. Mike On Mon, 27 Oct 2003, Indan Zupancic wrote: > Get it here: http://www.xs4all.nl/~dorinek/dillo/dillo-ssl.diff.gz > > It's not as nice and simple as I wanted it to be, thanks to three things: > > 1) SSL can always read and write, meaning that SSL_write may want to read. > 2) Dillo uses two IOData structures per file descriptor. > 3) There is no efficient way of (un)registering file descriptor events in > GTK. (FLTK has a perfect interface). > > This three facts contribute a lot to the complexity of the code. > > There is one known bug, you may try to find it. ;) > Dillo will not crash, I made it exit with a message. > > This patch adds also generic ssl/tls support to Dillo, most work was done > in IO.c, http.c has hardly changed. The current way to tell the IO engine > that it should use ssl is by giving a negative fd to a_IO_new. This avoids > extra interface, is simple, and doesn't clash with anything else. > > Dillo is about 2K bigger after the patch. It was made against the current > cvs, apply it with 'patch -p1 < dillo-ssl.diff' while you're in the dillo > dir. Run configure with --disable-ssl if you don't want https... > > Have fun. > > p.s. > I hate glib ;), it's totally worthless, the most complex piece Dillo uses > is a hash table, and glib implements it as a linked list, look in the code > yourself if you don't believe me. Since when is ansi c not good enough? > Please switch to FLTK. :) > > p.s.s > This mail was sent from webmail with a patched Dillo. :) > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)lists.auriga.wearlab.de > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev > -- Thinstation FAQ maintainer http://thinstation.sourceforge.net - a light, full featured linux based thin client OS

Oct. 27, 2003