- Dillo-dev - lists.mailman3.com

[patch]: more doxygen fixes

by onepoint＠starurchin.org

Doxygen is missing some methods because it's not smart enough about namespaces and sometimes thinks that the signatures of the declaration and the definition are different when they are not. You can see the warnings in its output (hint: redirect stdout to /dev/null to extract the warnings from the noise). Patch attached that adds some explicit namespace qualifiers. This removes doxygen's confusion, fixes the docs and silences the warnings. Regards, Jeremy Henty

May 31, 2009

[patch]: spelling: instanciate

by corvid＠lavabit.com

Jeremy wrote: > The act of creating an instance is not "instanciation" but > "instantiation". Patch attached. Committed.

May 30, 2009

patch: segfault in win_cb in uicmd.cc

by corvid＠lavabit.com

I was closing dillo. So far as I can recall, I just hit ^Q a couple times (my usual method), but I don't think that would explain the win_cb(). (gdb) bt #0 0x08055a00 in UI::tabs (this=0x0) at ui.hh:105 #1 0x080555ef in win_cb (w=0x813fe48, cb_data=0x8190618) at uicmd.cc:351 #2 0x080df426 in fltk::handle () at ../fltk/Widget.h:127 #3 0x080e0995 in do_queued_events () at x11/run.cxx:399 #4 0x080e0c16 in fltk::wait (time_to_wait=1.00000002e+20) at x11/run.cxx:459 #5 0x080e0db0 in fltk::run () at run.cxx:399 #6 0x0804f737 in main (argc=1, argv=0xbffffb34) at dillo.cc:353 (gdb) p num_bws $13 = 2 (gdb) p bws[0] $14 = (BrowserWindow *) 0x81da720 (gdb) p bws[1] $15 = (BrowserWindow *) 0x81e4a10 (gdb) p bws[2] $16 = (BrowserWindow *) 0x81da720 Perhaps I had just closed the old bw[0], with a_List_remove moving the old bw[2] there. Here's a patch, since it's a good idea in any case to check what we've been given in a callback, but there is a bit of symptom-vs-disease in that I'm not positive how I got here in this situation.

May 30, 2009

[patch]: spelling: instanciate

by onepoint＠starurchin.org

Replying to myself, > You have been reading "Great stupidities of English spelling", > number 361 of a *very* long series. Hasty clarification: I meant that English spelling itself is stupid (since "instanciate" is more logical than "instantiate"). I wasn't insulting the authors of the code (and didn't intend to write anything that could be construed as though I was). Regards, Jeremy Henty

May 30, 2009

[patch]: spelling: instanciate

by onepoint＠starurchin.org

The act of creating an instance is not "instanciation" but "instantiation". Patch attached. You have been reading "Great stupidities of English spelling", number 361 of a *very* long series. Regards, Jeremy Henty

May 30, 2009

--xid option

by corvid＠lavabit.com

Johannes wrote: > On Fri, May 29, 2009 at 04:25:18PM -0400, Jorge Arellano Cid wrote: > > On Fri, May 29, 2009 at 07:28:39PM +0000, corvid wrote: > > > Jorge wrote: > > > > On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote: > > > > > Of course naturally I think, "I hope my MSG macros count as polishing... > > > > > I hope my UTF-8 file.c code counts as polishing..." > > > > > > > > Send them to me when they're ready. > > > > > > It looks like I sent the UTF-8 one on the 17th, and > > > the MSG macros on the 16th, with another mail on the > > > 18th discovering that, whatever the gnu info text might say, > > > "" is safer than an empty argument. > > > > Both committed (thanks for the bump). > > > > @all: please compile test. > > Is this non_ascci instead of non_ascii in misc.c a typo? I've always left it alone when working in that bit of the code (either in misc or in file) under the assumption that it dated back to prehistory and therefore had become 'venerable' somehow, but the cvs log shows it only being introduced in 2006.

May 29, 2009

--xid option

by Johannes.Hofmann＠gmx.de

On Fri, May 29, 2009 at 04:25:18PM -0400, Jorge Arellano Cid wrote: > On Fri, May 29, 2009 at 07:28:39PM +0000, corvid wrote: > > Jorge wrote: > > > On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote: > > > > Of course naturally I think, "I hope my MSG macros count as polishing... > > > > I hope my UTF-8 file.c code counts as polishing..." > > > > > > Send them to me when they're ready. > > > > It looks like I sent the UTF-8 one on the 17th, and > > the MSG macros on the 16th, with another mail on the > > 18th discovering that, whatever the gnu info text might say, > > "" is safer than an empty argument. > > Both committed (thanks for the bump). > > @all: please compile test. Is this non_ascci instead of non_ascii in misc.c a typo? Cheers, Johannes PS: Compiles fine here.

May 29, 2009

--xid option

by jcid＠dillo.org

On Fri, May 29, 2009 at 07:28:39PM +0000, corvid wrote: > Jorge wrote: > > On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote: > > > Of course naturally I think, "I hope my MSG macros count as polishing... > > > I hope my UTF-8 file.c code counts as polishing..." > > > > Send them to me when they're ready. > > It looks like I sent the UTF-8 one on the 17th, and > the MSG macros on the 16th, with another mail on the > 18th discovering that, whatever the gnu info text might say, > "" is safer than an empty argument. Both committed (thanks for the bump). @all: please compile test. -- Cheers Jorge.-

May 29, 2009

patch: a binding for stop

by corvid＠lavabit.com

Jorge wrote: > On Fri, May 29, 2009 at 02:39:04AM +0000, corvid wrote: > > > I don't like much Esc for stop, but if that's FFs default, > > > it may be better than another (as the Ctrl-x clash you spot). > > > Afterall this is what configurable keybindings is suppossed to > > > solve so Esc is OK for me as default. > > > > I'll have to rip out the mysterious HIDE_PANELS in order to > > take back Escape which it is using. > > AFAIS, in the sense of: > > > What is the purpose of KEYS_HIDE_PANELS when we have KEYS_FULLSCREEN? > > The idea is to handle the case of a "search text" request on > hidden panels. In which case the search panel is temporarily > shown, until Esc is pressed. > > If it can be done with less variables, no problem. So it was added on purpose. All right. > Now, Esc is used to: > > - Close dialog windows > - Hide the search panel > > Please don't rip that functionality. The idea is Esc to stop > when there's no search bar. I don't want to use escape for stop if the search bar conflicts with it.

May 29, 2009

--xid option

by corvid＠lavabit.com

Jorge wrote: > On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote: > > Of course naturally I think, "I hope my MSG macros count as polishing... > > I hope my UTF-8 file.c code counts as polishing..." > > Send them to me when they're ready. It looks like I sent the UTF-8 one on the 17th, and the MSG macros on the 16th, with another mail on the 18th discovering that, whatever the gnu info text might say, "" is safer than an empty argument.

May 29, 2009