- Dillo-dev - lists.mailman3.com

Re: patch: cache Data allocation

by corvid＠lavabit.com

Jorge wrote: > On Thu, May 29, 2008 at 05:51:02PM +0000, corvid wrote: > > This is to make my unref()s cleaner. > > As it was in the prototype code, I would always unref at IOClose time. > > This made the reference count negative for file not found, which I didn't > > like. I could've tested for GotHeader, but it seemed more natural to > > test for data before unref()ing data. > > I'd prefer GotHeader because that's what Cache_process_queue() > tests for, and thus Data doesn't become an implicit flag. All right. > > I think it's all right for me to put that Cache_process_queue(entry) inside > > an entry->Data test -- at least I couldn't find anything bad happening. > > BTW, funny as it may seem, I don't yet know what data unref > you're talking about! :-) The reference counting in my charset-translating-in-cache code. (For any others in the audience: I keep track of how many things are reading the UTF8-ized version of the cache entry data.)

May 29, 2008

Hooked a decoder for text/plain with charset.

by corvid＠lavabit.com

Jorge wrote: > On Thu, May 29, 2008 at 08:49:22PM +0000, corvid wrote: > > Jorge wrote: > > > Just committed this patch. It makes things like: > > > > > > http://separat-lib.narod.ru/master.txt > > > > > > work. > > > > Why now? I don't understand the motivation for this. > > > > My next patch is just going to rip it out again because it > > will become unnecessary. > > Yeah, I noticed it could happen after making the patch, > but a segfault on that page made me fix and commit it. Why did it make plain segfault?

May 29, 2008

Re: patch: cache Data allocation

by jcid＠dillo.org

On Thu, May 29, 2008 at 05:51:02PM +0000, corvid wrote: > This is to make my unref()s cleaner. > As it was in the prototype code, I would always unref at IOClose time. > This made the reference count negative for file not found, which I didn't > like. I could've tested for GotHeader, but it seemed more natural to > test for data before unref()ing data. I'd prefer GotHeader because that's what Cache_process_queue() tests for, and thus Data doesn't become an implicit flag. > I think it's all right for me to put that Cache_process_queue(entry) inside > an entry->Data test -- at least I couldn't find anything bad happening. BTW, funny as it may seem, I don't yet know what data unref you're talking about! :-) -- Cheers Jorge.-

May 29, 2008

Hooked a decoder for text/plain with charset.

by jcid＠dillo.org

On Thu, May 29, 2008 at 08:49:22PM +0000, corvid wrote: > Jorge wrote: > > Just committed this patch. It makes things like: > > > > http://separat-lib.narod.ru/master.txt > > > > work. > > Why now? I don't understand the motivation for this. > > My next patch is just going to rip it out again because it > will become unnecessary. Yeah, I noticed it could happen after making the patch, but a segfault on that page made me fix and commit it. -- Cheers Jorge.-

May 29, 2008

Hooked a decoder for text/plain with charset.

by corvid＠lavabit.com

Jorge wrote: > Just committed this patch. It makes things like: > > http://separat-lib.narod.ru/master.txt > > work. Why now? I don't understand the motivation for this. My next patch is just going to rip it out again because it will become unnecessary.

May 29, 2008

[patch]: simplify a_Html_form_event_handler(): part II

by jcid＠dillo.org

On Thu, May 29, 2008 at 07:38:26PM +0100, Jeremy Henty wrote: > > More simplification of form handling. Several functions that used an > index to an input in the form's input list have been changed to use a > pointer to the input, which removed some useless indirection. This > enabled refactoring the code in a_Html_form_event_handler() that found > the input from the resource into a new method "DilloHtmlInput > *DilloHtmlForm::getInput (void *v_resource)". Committed. -- Cheers Jorge.-

May 29, 2008

[patch]: simplify a_Html_form_event_handler()

by jcid＠dillo.org

On Thu, May 29, 2008 at 05:54:57PM +0100, Jeremy Henty wrote: > > The a_Html_form_event_handler() function displays an amusing > anti-pattern (which I wish I knew the name of) where it's not given > enough data and has to go searching for the missing information. > Specifically, it gets a pointer to the DilloHtml of the page, but not > not the DilloHtmlForm that submitted it, so it has to search the form > list of the DilloHtml to find the form. > > This patch passes the DilloHtmlForm to the handler and adds a pointer > from the DilloHtmlForm to the DilloHtml , so the handler can now > directly access the form and the html without messing around. Committed. -- Cheers Jorge.-

May 29, 2008

Hooked a decoder for text/plain with charset.

by jcid＠dillo.org

Hi, Just committed this patch. It makes things like: http://separat-lib.narod.ru/master.txt work. -- Cheers Jorge.-

May 29, 2008

[patch]: convert Html_submit_form2() to DilloHtmlForm::buildQueryUrl()

by jcid＠dillo.org

On Thu, May 29, 2008 at 03:40:02PM +0100, Jeremy Henty wrote: > > The function Html_submit_form2() does two jobs rolled into one: most > of its code creates a url from a DilloHtmlForm and a few lines push > the url to a DilloHtml . This patch takes advantage of the fact that > Html_submit_form2() is only called from a_Html_form_event_handler() ; > it moves the url push out into the caller and the rest of the code > into a new method "DilloUrl *DilloHtmlForm::buildQueryUrl()". This > separates concerns nicely: the DilloHtmlForm creates the url and > a_Html_form_event_handler() pushes it to the DilloHtml . Committed. > We're getting close to having a proper API for DilloHtmlForm , > unfortunately some of the remaining code is very messy. I'll do the > rest of the easy stuff and then summarise what's left. OK. -- Cheers Jorge.-

May 29, 2008

Previous patches a la camelCase

by jcid＠dillo.org

On Wed, May 28, 2008 at 05:29:35PM +0100, Jeremy Henty wrote: > > In case Jorge prefers them, here are revised versions of today's > patches with camelCased method names. Patch set Committed! -- Cheers Jorge.-

May 29, 2008