- Dillo-dev - lists.mailman3.com

Check for unterminated quoted strings

by Andreas Kemnade

I found this tag on pages at www.reichelt.de: <A HREF="Info.html?P1mqhKwQAQsAAHVmTEY+Suche+0+50+LM%20324%20D%20SMD+lm324" onmouseover="return overlib('<TABLE><TR><TD><font face=\'Verdana, Arial, Helvetica, sans-serif\' size=1 color=\'#FFFFFF\'></font></TD></TR></TABLE>',CAPTION,'LM 324 D SMD');" onMouseout="return nd();"> It looks like correct html to me or am I wrong? But dillo does not render it correctly. It is rendered like this: <A HREF=... onmouseover="...TABLE"><TR><TD>... So the check for unterminated quoted strings confuses the table handling. With a small change to html.c, it will be rendered correctly: /* Skip over quoted string */ buf_index++; buf_index += strcspn(buf + buf_index, - (ch == '"') ? "\">" : "'>"); + (ch == '"') ? "\"" : "'"); if ( buf[buf_index] == '>' ) { /* Unterminated string value? Let's look ahead and test: * (<: unterminated, closing-quote: terminated) */ I don't know why that check is there. Does HTML allow quoted strings to be not terminated? I guess there is a better solution than mine. Greetings Andreas Kemnade

Sept. 6, 2003

Re: [Dillo-dev] Re: [Patch] Search feature and more

by Jorge Arellano Cid

Hi Johan! It took a long time to analyze the three patches, but finally here we are: [I'm not quoting the previous email bacause it got too big and can be easily found at the web archives] The patches were: 1.- Made main document window grab focus on startup and after open url. Commited! In the meanwhile, Owen taylor answered my post to GTK-list and it become clear that the "Nirvana"-widget issue is solved in GTK2. Thanks a lot for your comments on this. You may find interesting to read the answer: http://mail.gnome.org/archives/gtk-list/2003-June/msg00307.html 2.- Accelerator keys. Huh! These are to be picked very carefully! It took me a lot of work to figure simple mnemonic shortcuts that integrate well with the UI model. The chosen ones are: Shortcut Mnemonic ------------------------------------------------------------ Ctrl-U "Ctrl-URL" (to edit the URL) Ctrl-H "Ctrl-Hide" (Hide/show controls) Ctrl-S "Ctrl-Search" (search the web) Ctrl-R "Ctrl-Reload" (reload current page) ------------------------------------------------------------ (integrating with the existent) Ctrl-L "Ctrl-Location" (enters a new URL) Ctrl-F "Ctrl-Find" (find text) Ctrl-Q "ctrl-Quit" (quit window) (Note: Ctrl-S is not implemented yet) These should provide good defaults as Havoc suggests. Please give them a test drive to get the feel. Ah, while thinking of it, I thought it'd be good to add the ESC key as a way to switch from the location box into the main window, it can be easily done with the key handler you wrote. 3.- Search feature Uncommited yet, the functionality is perfect. Just some minor details in the UI: A small icon to the right of the location box (hideable as the othe icons), with Ctrl-S as shortcut, that pops up a dialog (just as find text and open url). The icon's tooltip can be "Search the Internet", "Search the Web", or something better :-) The final touches: * While working on the location bar shortcuts, I thought it'd be good to add the ESC key as a way to switch from the location box into the main window, it can be easily done with the key handler you wrote. * It'd be also good to add middle-click over the clear-url button, as a way to "paste-push" an URLs. Instead of the the current three step sequence: - Press clear-url - Paste URL - Press enter I carefully considered your previous email and this model should take good care of the several points we talked about. Half of the work is on CVS now, and the above mentioned details are pending. Please send me a new patch with the modifications to fast-track-commit-it-in! Best Jorge.-

Sept. 5, 2003

Re: [Dillo-dev] Something to think about: free vs. proprietary OSes

by Andreas Schweitzer

Hi, On Thu, Sep 04, 2003 at 01:59:51PM +0000, Phil Pennock wrote: > On 2003-09-04 at 00:11 -0700, Kelson Vibber wrote: > > Where do we draw the line... and why? Compatibility? Ideology? And to throw in even more flamebait (which I will not defend :-) ... ) The BSD's are not really free software in the meaning of FSF's definition ;-) ... To me, it doesn't matter, though. > Suggestion: the point where conditional code compilation is being > scattered throughout the code. On the other hand, it is truely beneficial for producing clean code (i.e. not lots of ifdefs) when trying to compile on largely different platforms. I speak from experience when I say that trying to compile with a different compiler (or on a different platform) usually reveals bugs. So far, dillo is mainly compiled with gcc - I'm not sure about the various solaris efforts, though. I personally once tried IBM's xlc compiler on AIX. It mostly worked and resulted in a few minor code cleanups, that went into dillo. Hmmm, I really should try Intel's IFC or tendra at some point .... Anyways, that alone would make a native Windows port at least interesting. Not that I have any experience with Micorsofts C-compiler, nor that I know about Windows Posix compliance (didn't some Windows version receive some sort of Unix specification ?). Still, I'm sure things will show up that may be real bugs. And these are just the purely technical and objective issues that came up when reading the recent mails on this list :-) > Jorge: I've been at a conference and now am on a different desktop, so > am not easily able to test the alternate fix for FreeBSD and the IO > errors -- since Andreas reports that things work fine for him now, I'll > take it on faith that the problem has been resolved -- thanks for the > prompt response! It doesn't lock up any more. Sometimes, I'm not sure if there are still issues or not. It simply may be the local network like DNS servers etc. As I said, I'll report problems once I'll find them :-) Cheers, Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

Sept. 5, 2003

Re: [Dillo-dev] Something to think about: free vs. proprietary OSes

by Andreas Kemnade

On Thu, 4 Sep 2003 13:59:51 +0000 Phil Pennock <phil.pennock(a)globnix.org> wrote: > (I got forced onto a new box and made a policy decision to go GTK2 only; > I had a brief look at porting to GTK2 and got more stuff compiling, but > part way through realised that I'd messed up badly so dumped that. I > won't have time to look at this again for a while -- sorry) > -- familar linux 0.7 has a gtk2 dillo. gtk1.2 is not installed by default. So there should be patches for a gtk2 dillo somewhere. Perhaps that can be used as a starting point. Greetings Andreas Kemnade

Sept. 5, 2003

Re: [Dillo-dev] could not find font

by Jorge Arellano Cid

Hi, > > Hi, I am using dillo for a project here at the univ. In the course of it I > have had to make some modifications to the dillo source so as to be able > to talk with some `tuple space` server. They don't affect the working of > dillo and are abstracted out. Also I need to get the modified dillo on my > ipaq H3670 for use in the project demo. I did the source changes and > everything seems just great. I compiled it for arm using handhelds.org > public clusters and also managed to get it onto my IPAQ. So far so good. > > However the dillo executable doesnt run and bails out saying: > ---- > ** WARNING **: Can't load any ISO8859-1 font!?! :( > ** ERROR **: Could not find any font. aborting... Aborted > ---- This means all the attempts in Dw_style_font_realize() failed. > The dw_style.c seems to look for a font and I would think it fails if it > doesnt find any. That's it. > But what I dont understand is the vanilla gpe > distribution given by the familiar folks also includes dillo and that > works fine on the SAME ipaq. So somehow that dillo executable knows how to > find the fonts? No. It may be that they don't try with the same fontnames! Make sure both provide the exactly the same Dw_style_font_realize() font. If it's the same, check you're using the same dillorc for both. If the problem still persists, using both on the same machine under the same username, using the same dillorc, I'm puzzled! > I am guessing I need to pass a font dir or something > related to x/xfs here? It also works great if I compile it on a desktop > linux box. I am wondering why it cannot find the fonts on the ipaq only. > > Does anyone have any suggestions on how to get this working? Thanks, As above. Cheers Jorge.-

Sept. 4, 2003

Re: [Dillo-dev] Something to think about: free vs. proprietary OSes

by Phil Pennock

On 2003-09-04 at 00:11 -0700, Kelson Vibber wrote: > Where do we draw the line... and why? Compatibility? Ideology? Suggestion: the point where conditional code compilation is being scattered throughout the code. That way lies a maintenance nightmare. The OpenSSH people have to do this, because every OS is a bit different in how the login process is managed, and even there the main development is done in a "clean" branch, for OpenSSH, and the Portable stuff is maintained separately. For a more historical example, look at wu-ftpd. If differences can be cleanly abstracted, so that people don't need to worry about the differences, then it's probably fine. But if someone's devoting their own personal time to a project, finding one OS which forces #ifdefs everywhere, in every file, just to compile suggests that it's not clean and not sufficiently in line. A grep for "ifdef" in the Dillo .c files shows remarkably little in that regard (most of the ones I see are the frames+tab patch's careful segregation. The most common ifdef is for VERBOSE and after that EXTENDED_COLOR, and those tend to be confined to small spaces. For an example of abstraction of OS differences done right, I like Exim (the Mail Transport Agent). Jorge: I've been at a conference and now am on a different desktop, so am not easily able to test the alternate fix for FreeBSD and the IO errors -- since Andreas reports that things work fine for him now, I'll take it on faith that the problem has been resolved -- thanks for the prompt response! (I got forced onto a new box and made a policy decision to go GTK2 only; I had a brief look at porting to GTK2 and got more stuff compiling, but part way through realised that I'd messed up badly so dumped that. I won't have time to look at this again for a while -- sorry) -- 2001: Blogging invented. Promises to change the way people bore strangers with banal anecdotes about their pets. <http://www.thelemon.net/issues/timeline.php>

Sept. 4, 2003

Something to think about: free vs. proprietary OSes

by Kelson Vibber

<flamebait> So if Dillo is about 100% free software, including the OS it runs on, does that mean we should reject any patches that help Dillo run on Solaris, IRIX, AIX, HP-UX, Mac OS X and so on? If something breaks compatibility with Cygwin, should we let it slide because Cygwin only runs on Windows? What's next, dropping support for SuSE because it's less free than Debian? Red Hat because they call it "Linux" instead of "GNU/Linux?" </flamebait> Where do we draw the line... and why? Compatibility? Ideology? If someone came up with a way to get a working prototype on Mac OS classic, without any effort on your part, would you reject their contribution because the OS is proprietary? If yes, what makes Solaris different? If no, what makes Windows different? A consensus on this issue would be useful, especially the next time someone expresses interest in using Dillo on a nonconventional platform. -- Kelson Vibber www.hyperborea.org

Sept. 4, 2003

could not find font

by Vikram

Hi, I am using dillo for a project here at the univ. In the course of it I have had to make some modifications to the dillo source so as to be able to talk with some `tuple space` server. They don't affect the working of dillo and are abstracted out. Also I need to get the modified dillo on my ipaq H3670 for use in the project demo. I did the source changes and everything seems just great. I compiled it for arm using handhelds.org public clusters and also managed to get it onto my IPAQ. So far so good. However the dillo executable doesnt run and bails out saying: ---- ** WARNING **: Can't load any ISO8859-1 font!?! :( ** ERROR **: Could not find any font. aborting... Aborted ---- The dw_style.c seems to look for a font and I would think it fails if it doesnt find any. But what I dont understand is the vanilla gpe distribution given by the familiar folks also includes dillo and that works fine on the SAME ipaq. So somehow that dillo executable knows how to find the fonts? I am guessing I need to pass a font dir or something related to x/xfs here? It also works great if I compile it on a desktop linux box. I am wondering why it cannot find the fonts on the ipaq only. Does anyone have any suggestions on how to get this working? Thanks, Vikram

Sept. 4, 2003

Re: [Dillo-dev] Dillo on Windows fork

by Eric GAUDET

-- En reponse de "Re: [Dillo-dev] Dillo on Windows fork" de Robin Rowe, le 04-Sep-2003 : > Jorge, > > That you have so many derogatory names for Windows doesn't make a Windows > developer feel welcome. > Many, many, many people came to this list, asking question, proposing patches, etc. All of them were welcome and answered nicely. But you're in a Free Software community: if you can't stand the heat, if you can't keep a low profile, scoot. Why do you feel so personal about windows anyway? > Either a native Windows port is welcome (that means no cygwin in case you > don't understand), you want any patches I create for building Dillo as a > Microsoft Visual C++ project, want to work together, and are happy to > answer what technical points you can regardless of operating system I > use -- or you don't. > I already explained why, personally, I did not want a windows port integrated in Dillo. A fork is ok, though. There's probably way too much changes between Posix and Windows for the two projects to live together anyway. > I am willing to admit that I have no idea what you are talking about in > general. Your previous email, the one from last week that did not attempt > to answer my technical questions about Dillo as it is implemented now, > told me that "if you want to make dillo run on M$ Windoze natively, > you're on your own", and pointed me for the reason to an article whose Dillo's web site has plenty of references about why Jorge (and Dillo's developers agree, I think) think Free Software is what he wnats to develop for. Not any open source project: Free Software. > only reference to Windows is a rant against "Micro$oft (windoze)", > could have led me to the wrong conclusion. All your talk today about > having no Windows users currently, cygwin, posix, articles, attacks, > FUD, false assertions, lies, the dark side (as you call running Dillo > on Windows) and so forth only confuses things further. > Now you're the one being offensive here. > What do you really want me to do? > If you have technical question, ask them, you'll be answered. Or not. Anyway: TAKE THIS DISCUSSION OFF THE LIST! This is a development list, not a fighting list between you and Jorge. This list has a long history of moderation and politeness, and I like it like that. It was never about Jorge, anyway. Didn't you get it? Jorge just happens to be the maintainer and lead developer of Dillo's current main tree. And he's pretty good at it too. But if he's not good enough and somebody feels like forking, developers will go with the most active and appealing project. You don't need Jorge or any of us to tell you what to do. But since you need clarification, here goes: - if you have any technical question, ask them in the list. Politely. - I don't think Jorge will ever consider merging your patches, or any patch about a Windows port. - nobody can or will ever want to prevent you to fork or use Dillo's code in any way you want, provided it's compatible with the GPL. Please, please, nobody answers this message (or this thread in the list). You can answer to me personally if you want to, but I think everything's clear now. Good luck with your project. Best, EG

Sept. 4, 2003

Re: [Dillo-dev] Dillo on Windows fork

by Robin Rowe

Jorge, That you have so many derogatory names for Windows doesn't make a Windows developer feel welcome. You went to a lot of trouble to mince point by point through my "attacks, FUD, and all the false assertions", but it was unnecessary. If it is what you feel, all you need say is that you welcome a native Windows port, that it was just a big misunderstanding. Either a native Windows port is welcome (that means no cygwin in case you don't understand), you want any patches I create for building Dillo as a Microsoft Visual C++ project, want to work together, and are happy to answer what technical points you can regardless of operating system I use -- or you don't. I am willing to admit that I have no idea what you are talking about in general. Your previous email, the one from last week that did not attempt to answer my technical questions about Dillo as it is implemented now, told me that "if you want to make dillo run on M$ Windoze natively, you're on your own", and pointed me for the reason to an article whose only reference to Windows is a rant against "Micro$oft (windoze)", could have led me to the wrong conclusion. All your talk today about having no Windows users currently, cygwin, posix, articles, attacks, FUD, false assertions, lies, the dark side (as you call running Dillo on Windows) and so forth only confuses things further. What do you really want me to do? Cheers, Robin --------------------------------------------------------------------------- Robin.Rowe(a)MovieEditor.com Hollywood, California www.CinePaint.org Free motion picture and still image editing software

Sept. 4, 2003