- Dillo-dev - lists.mailman3.com

CPU hog bug with https?

by jcid＠dillo.org

Hi, If I start current dillo with [1], an https dialog springs (untrusted certificate). Answering "continue" gets into a CPU hog, answering "cancel" allows reading the page with no problems. FWIW, I've done that lots of times with other sites, and this is the first CPU hog I get accross. [1] https://linux.slashdot.org/comments.pl?sid=5852295&cid=48188823 -- Cheers Jorge.-

May 1, 2016

Bug in meta tag refresh code [with cause]

by nick＠linicks.net

I have been looking at this for about 5 hours now, and it has fried my brain. Reading the code, and then reading the email thread about depreciated meta tag 'refresh', I agree with Dillo's actions. But what I found was that on some sites (mine included), if there was a tag: <meta http-equiv="refresh" content="15" /> Dillo reports and the warning message reports: The author wanted you to go _here_ after 10 seconds. What happens now is the link (_here_) gets appended with the refresh value, so for example: www.example.com/refesh.html becomes: www.example.com/10 (or 15 or whatever the refresh value is). I have found that if the meta tag is right: <meta http-equiv="refresh" content="5;URL='./index.html'" /> then the code creates the right URL (but it's not seen as no warning is given. html.cc from line 3218 if the meta tag refresh is correct HTML on the web page, mr_url returns the correct path to the refresh. If it isn't, then mr_url returns the value of the refresh - which fubars the warning messages link. I tested this running dillo from the commandline with this insertion and testing the correct and wrong meta tags: } /* Skip to anything after "URL=" or ";" if "URL=" is not found */ if ((p = dStriAsciiStr(content, "url="))) content = p + strlen("url="); else if ((p = strstr(content, ";"))) content = p + strlen(";"); /* Handle the case of a quoted URL */ if (*content == '"' || *content == '\'') { if ((p = strchr(content + 1, *content))) mr_url = dStrndup(content + 1, p - content - 1); else mr_url = dStrdup(content + 1); } else { mr_url = dStrdup(content); } //nick printf ("%s\n", mr_url); new_url = a_Html_url_new(html, mr_url, NULL, 0); // new_url = a_Html_url_new(html, ".", NULL, 0); Not being very good with C++, I can't work out what goes wrong here - but it looks like that if 'URL=' or';' isn't found, then the code still looks for quotes - which does something to the string? I have two pages you can test on - one with the proper meta tag, and one with out: http://irpi.linicks.net:8080/static_simple.html <- good http://fishpi.linicks.net:8081/static_simple.html <- bad - that shows the bug If possible view both with that printf I put in - you can see what mr_url returns. Phew* Nick -- Gosh that takes me back... or is it forward? That's the trouble with time travel, you never can tell." -- Doctor Who "Androids of Tara"

May 1, 2016

Minor bug in test/cookies.c

by jcid＠dillo.org

On Sun, May 01, 2016 at 11:05:27AM +0100, Nick Warne wrote: > Hi Jorge, > > I saw the two minor fixes you done today - here's another: > > :~/slackbuilds/dillo/hg/dillo$ grep -Rin "} if" * > test/cookies.c:426: } if ((ret = Dpi_blocking_read(sock_fd)) == NULL) { Right, committed, thks! -- Cheers Jorge.-

May 1, 2016

Minor bug in test/cookies.c

by nick＠linicks.net

Hi Jorge, I saw the two minor fixes you done today - here's another: :~/slackbuilds/dillo/hg/dillo$ grep -Rin "} if" * test/cookies.c:426: } if ((ret = Dpi_blocking_read(sock_fd)) == NULL) { Nick -- Gosh that takes me back... or is it forward? That's the trouble with time travel, you never can tell." -- Doctor Who "Androids of Tara"

May 1, 2016

"ok" for unnested body

by genoob＠yandex.com

Hello! I'm a noob, so I'm sorry if this is actually not an issue, but I've searched and haven't found anything on this. When creating a simple list using `ul` (I've replaced < > with `` in order to avoid html parsing by some readers) tags I accidentally placed it after `/body``/html` and to my surprise It wasn't marked as an html error and the data was correctly displayed, jus like it would be had the list been placed inside the `html``body` `/body``/html` tags. Unnesting `li` from `ul` however displayed nesting problem, but only referring to the `li` being out of `ul` or `ol` tags, not from it being unnested from `html` `body`. I realize my explanation might be a little confusing at this point, so this is what I mean: I put it on bpaste so this message wouldn't be flagged as spam: https://bpaste.net/show/ed1374304997 And this is a screenshot of the data being displayed and getting a thumbs-up from the browser in case its relevant: http://i.imgur.com/d1f9Pv9.png I'd like to report this in case it's a bug(invalid html being marked valid), however if it's a valid html you can disregard/exclude this message from the list with no hard feelings. I'm using dillo-3.0.5-r1 by the way. I'm sorry if this was confusing and wasted your time. In case you need more info on my system I'm happy to help however I can. And thanks for maintaining such a nice project (It really helped me a lot thus far). Cheers!

April 30, 2016

image overlaps text

by jcid＠dillo.org

On Sat, Apr 30, 2016 at 01:31:48PM +0200, Sebastian Geerken wrote: > On Fr, Apr 29, 2016, Jorge Arellano Cid wrote: > > On Fri, Apr 29, 2016 at 06:41:32PM +0200, Sebastian Geerken wrote: > > > On Fri, Apr 29, 2016, Nick Warne wrote: > > > > > > > > > > > > On 29/04/16 16:46, Alexander Voigt wrote: > > > > >I noticed, that in current Dillo (tip) there are cases where images > > > > >overlap surrounding text, making in unreadable. Here is an example page: > > > > > > > > > > https://netzpolitik.org/2016/massenbeschlagnahme-von-mobiltelefonen-in-leip… > > > > > > > > Strange, renders here OK (latest hg pull). > > > > > > As I wrote, this is hard to reproduce. > > > > Yes. > > > > (I can't reproduce it with your best URL :) > > > > Fortunately, today I managed to find&reduce a case that works all the time > > here. Attached it goes. Just resize horizontally to see the overlap. > > > > I hope it works there! > > Thanks, Jorge, for the perfect testcase. So far, I've tracked down the > problem, Great! :) :) > but I'm not yet sure how to fix it. Hopefully, the fix will > also solve the other issues with overlapping floats. Yes, I also hope in the same direction! FWIW, yesternight, without knowing whether the example would tackle it, I came with a different approach to testing (just in case). Do you remember our slow.cgi testing program? It can be made to serve adjustable chunks of data with adjustable delays, this way: slow.cgi?2048:1:/tmp/testcase.html for 2048 bytes in 1 second (for instance). This could help to reproduce the bug in the network dependent cases by finding the combination that triggers it. Just let me know if you need it as plan B. HTH. -- Cheers Jorge.-

April 30, 2016

image overlaps text

by sgeerken＠dillo.org

On Fr, Apr 29, 2016, Jorge Arellano Cid wrote: > On Fri, Apr 29, 2016 at 06:41:32PM +0200, Sebastian Geerken wrote: > > On Fri, Apr 29, 2016, Nick Warne wrote: > > > > > > > > > On 29/04/16 16:46, Alexander Voigt wrote: > > > >I noticed, that in current Dillo (tip) there are cases where images > > > >overlap surrounding text, making in unreadable. Here is an example page: > > > > > > > > https://netzpolitik.org/2016/massenbeschlagnahme-von-mobiltelefonen-in-leip… > > > > > > Strange, renders here OK (latest hg pull). > > > > As I wrote, this is hard to reproduce. > > Yes. > > (I can't reproduce it with your best URL :) > > Fortunately, today I managed to find&reduce a case that works all the time > here. Attached it goes. Just resize horizontally to see the overlap. > > I hope it works there! Thanks, Jorge, for the perfect testcase. So far, I've tracked down the problem, but I'm not yet sure how to fix it. Hopefully, the fix will also solve the other issues with overlapping floats. Sebastian

April 30, 2016

image overlaps text

by jcid＠dillo.org

On Fri, Apr 29, 2016 at 10:11:37PM +0100, higuita wrote: > On Fri, 29 Apr 2016 13:41:16 -0300, Jorge Arellano Cid <jcid at dillo.org> > wrote: > > Does going Back and Forward fix the problem? > > Yes, it solves the problem. Reload also solves this. > > For me, i can reproduce this ~70% of the attempts. > it seems just a race drawing the page and getting the resources > from the internet. That's my point. The rendering algorithm seems to make a decision on incomplete data (sometimes depending on available data) and, also sometimes, it can't recover when all data is got. Now, if you feed it the whole of the data, it seldom fails. I hope the reduced test case fails because it gets to that point in the algorithm and not because it always fails. -- Cheers Jorge.-

April 29, 2016

image overlaps text

by jcid＠dillo.org

On Fri, Apr 29, 2016 at 06:26:50PM -0300, Jorge Arellano Cid wrote: > [...] > > Fortunately, today I managed to find&reduce a case that works all the time > here. Attached it goes. Just resize horizontally to see the overlap. > > I hope it works there! Ooops, I forgot to attach the image. Here it goes. -- Cheers Jorge.-

April 29, 2016

image overlaps text

by jcid＠dillo.org

On Fri, Apr 29, 2016 at 06:41:32PM +0200, Sebastian Geerken wrote: > On Fri, Apr 29, 2016, Nick Warne wrote: > > > > > > On 29/04/16 16:46, Alexander Voigt wrote: > > >I noticed, that in current Dillo (tip) there are cases where images > > >overlap surrounding text, making in unreadable. Here is an example page: > > > > > > https://netzpolitik.org/2016/massenbeschlagnahme-von-mobiltelefonen-in-leip… > > > > Strange, renders here OK (latest hg pull). > > As I wrote, this is hard to reproduce. Yes. (I can't reproduce it with your best URL :) Fortunately, today I managed to find&reduce a case that works all the time here. Attached it goes. Just resize horizontally to see the overlap. I hope it works there! -- Cheers Jorge.- PD: subliminal message in the example. ;)

April 29, 2016