- Dillo-dev - lists.mailman3.com

rebased patch: print numeric addresses instead of pointer

by 4winter＠informatik.uni-hamburg.de

Skipped content of type multipart/mixed

Oct. 28, 2008

patch: print numeric addresses instead of pointer

by jcid＠dillo.org

On Tue, Oct 28, 2008 at 02:32:48PM +0100, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Justus Winter wrote: > > Jorge Arellano Cid wrote: > >> Not yet committed, mainly because the feature freeze for release. > >> (although the small fix went in). > > > >>> The attached patch fixes this and > >>> also adds the function > >>> > >>> void a_DilloHost_to_String(DilloHost *host, char *dst, size_t size) > >> If you finally get to a complete fix, please name exported functions > >> in dns.c with the "a_Dns_" prefix. > >> e.g. a_Dns_host_to_string > > Sure thing. Updated patch is attached. > *bump* > > > While tracking my ipv6 related problems through dillos source files I > > noticed *a lot* of ENABLE_IPV6 #ifdefs... Is this necessary for > > portability or do you want to be able to strip ipv6 support from certain > > builds? > > > > If portability at compile time is not the issue I would vote for the > > removal of those #ifdefs, if there's worry about the executables size, > > let's see: > > > > $ wc --bytes with{,out}/dillo2/src/dillo-fltk > > 3311349 with/dillo2/src/dillo-fltk > > 3309974 without/dillo2/src/dillo-fltk > > > > Well, IPv6 costs 1375 bytes on my system, I don't see any problem here, > > but I think this could be reduced. Many of those ipv6 related #ifdefs > > duplicate quite a lot of code. One tiny little cleanup patch is attached > > (please note that it depends on the a_Dns_DilloHost_to_String function). > Any thoughts on this one? Good you reminded me... IIRC the ENABLE_IPV6 stuff was because resolving was slower for IPV4 with the IPV6 code. I don't know whether this is still the case. Maybe portability is also an issue. Please send me two patches. One with a_Dns_dillohost_to_string() and another removing the ifdefs. If we get no comments on this thread, a commit experiment may take place. -- Cheers Jorge.-

Oct. 28, 2008

patch: print numeric addresses instead of pointer

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Justus Winter wrote: > Jorge Arellano Cid wrote: >> Not yet committed, mainly because the feature freeze for release. >> (although the small fix went in). > >>> The attached patch fixes this and >>> also adds the function >>> >>> void a_DilloHost_to_String(DilloHost *host, char *dst, size_t size) >> If you finally get to a complete fix, please name exported functions >> in dns.c with the "a_Dns_" prefix. >> e.g. a_Dns_host_to_string > Sure thing. Updated patch is attached. *bump* > While tracking my ipv6 related problems through dillos source files I > noticed *a lot* of ENABLE_IPV6 #ifdefs... Is this necessary for > portability or do you want to be able to strip ipv6 support from certain > builds? > > If portability at compile time is not the issue I would vote for the > removal of those #ifdefs, if there's worry about the executables size, > let's see: > > $ wc --bytes with{,out}/dillo2/src/dillo-fltk > 3311349 with/dillo2/src/dillo-fltk > 3309974 without/dillo2/src/dillo-fltk > > Well, IPv6 costs 1375 bytes on my system, I don't see any problem here, > but I think this could be reduced. Many of those ipv6 related #ifdefs > duplicate quite a lot of code. One tiny little cleanup patch is attached > (please note that it depends on the a_Dns_DilloHost_to_String function). Any thoughts on this one? Justus -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkkHFIAACgkQoPmwNWhsaZbaUQCfegvuOhWQgZw1Fgbv1WUklIRs j58AoKUT8xSrbIUR6gLLHfnGNQQ1km/0 =JjH6 -----END PGP SIGNATURE-----

Oct. 28, 2008

[patch]: small update to the dpidrc build

by jcid＠dillo.org

On Mon, Oct 27, 2008 at 04:30:08PM +0000, Jeremy Henty wrote: > > I just noticed that the automake example that I based my last patch on > was careful to include the makefile as a dependency in the custom > build rule, so here's a mini-patch to do that. Committed. -- Cheers Jorge.-

Oct. 28, 2008

[patch]: small update to the dpidrc build

by onepoint＠starurchin.org

I just noticed that the automake example that I based my last patch on was careful to include the makefile as a dependency in the custom build rule, so here's a mini-patch to do that. Jeremy Henty

Oct. 27, 2008

[patch]: improve the build of dpidrc

by jcid＠dillo.org

On Mon, Oct 27, 2008 at 02:16:50PM +0000, Jeremy Henty wrote: > > I've been studying the DPI code (hoping to work on SSL) and I noticed > that installing dpidrc is rather hacky. The info page > "(automake.info) Scripts" describes a standard way to do this using a > template. This is simpler because we only explicitly code the build > rule in Makefile.am and automake installs it as normal, so there's no > messing around with $(datadir), $(DESTDIR) etc. Also, changes such as > making the https dpi into a server rather than a filter will only > affect the template and won't require changing Makefile.am. > > The patch is attached. It creates a new source file dpid/dpidrc.in > which must be added to CVS. Good! Committed. -- Cheers Jorge.-

Oct. 27, 2008

[patch]: improve the build of dpidrc

by onepoint＠starurchin.org

I've been studying the DPI code (hoping to work on SSL) and I noticed that installing dpidrc is rather hacky. The info page "(automake.info) Scripts" describes a standard way to do this using a template. This is simpler because we only explicitly code the build rule in Makefile.am and automake installs it as normal, so there's no messing around with $(datadir), $(DESTDIR) etc. Also, changes such as making the https dpi into a server rather than a filter will only affect the template and won't require changing Makefile.am. The patch is attached. It creates a new source file dpid/dpidrc.in which must be added to CVS. Regards, Jeremy Henty

Oct. 27, 2008

pasting URL

by jcid＠dillo.org

On Fri, Oct 24, 2008 at 08:36:52PM +0200, Thomas Orgis wrote: > Am Fri, 24 Oct 2008 15:14:54 -0300 > schrieb Jorge Arellano Cid <jcid(a)dillo.org>: > > > Please add the commented option in dillorc in the > > "USER INTERFACE SECTION" and resubmit with "diff -pru". > > (you can cut lines with starting with '?' too). > > Ok, second one. Committed a modified version because it wasn't allowing middle click over links to work as usual. Also finally decided to use "middle_click_drags_page" as the option's name. Please test the CVS. -- Cheers Jorge.-

Oct. 26, 2008

dillo-2.0 compilation failure

by jcid＠dillo.org

On Wed, Oct 22, 2008 at 12:09:10AM +0200, Ben de Groot wrote: > Jorge Arellano Cid wrote: > > On Tue, Oct 21, 2008 at 07:39:51PM +0200, Ben de Groot wrote: > > >> % grep inbuf_t work/dillo-2.0/config.log > >> #define inbuf_t const char > > > > It looks like the test in configure.in detects iconv() in > > a strange way. > > Indeed, something seems to go wrong there. My glibc version is > 2.8_p20080602. > > > What's inconv's signature in your OS? > > extern size_t iconv (iconv_t __cd, char **__restrict __inbuf, > size_t *__restrict __inbytesleft, > char **__restrict __outbuf, > size_t *__restrict __outbytesleft); > > > Just for testing try setting [char] instead of [const char] in > > configure.in:348. There's a patch in CVS. Please let me know if it works. -- Cheers Jorge.-

Oct. 26, 2008

Tango like Icon theme for Dillo

by jcid＠dillo.org

Hi Colin, On Sun, Oct 26, 2008 at 11:48:41AM -0400, Colin Jones wrote: > Hello, > > I've been working on a Tango-like version of the default Dillo icon theme. > The pixmap.h file is attached. > I used the current Dillo icon theme as a base, so it's very close in terms > of size and design. I've tested it with Dillo 2, and it seems to work well. Thanks for the contribution! It was added in the Icons page. BTW, I'd suggest the inactive version of the Stop icon to have the internal "x" mark. -- Cheers Jorge.-

Oct. 26, 2008