- Dillo-dev - lists.mailman3.com

dillo CSS and charset

by furaisanjin＠gmail.com

Hi. 2009/1/23 Jorge Arellano Cid <jcid(a)dillo.org>: >> Have you added charset to the content-type given by the bookmarks dpi? >> or have you added a META or both? I did hg revert cache.c to cancel my local modification and then built dillo again. However I can't reproduce the problem anymore. I don't add content-type on dpi nor meta on bookmark because if encoding type is UTF-8, no conversion is required. I assume dillo native encoding is UTF-8 now. Sorry for confusion. Please ignore bookmark problem. Regards, furaisanjin

Jan. 22, 2009

Valgrind errors

by onepoint＠starurchin.org

I've been valgrinding Dillo to see what I find and this one keeps turning up. Some memory is accessed that was freed by a_Cache_set_content_type(). Regards, Jeremy Henty

Jan. 22, 2009

dillo CSS and charset

by Johannes.Hofmann＠gmx.de

On Thu, Jan 22, 2009 at 06:53:46PM +0000, corvid wrote: > Johannes wrote: > > On Thu, Jan 22, 2009 at 05:57:42PM +0000, corvid wrote: > > > Johannes wrote: > > > > BTW. now you can set vw_fontname in dillorc again. This font will > > > > then be used when CSS specifies "sans" as font, e.g: > > > > vw_fontname="VL Gothic" > > > > > > If I put a serif font in vw_fontname and then use > > > sans in style.css for some things, it'll use > > > the serif font. > > > > True. We need to make new config options > > > > sans-serif_fontname > > serif_fontname > > cursive_fontname > > fantasy_fontname > > monospace_fontname > > > > maybe even dropping the "_fontname" suffix. > > > > But of course that would no longer be compatible with older > > versions of dillorc. > > I would add the new options and remove the old options. > CSS is big and certainly worth some incompatibility. Ok, attached is a patch for discussion. Cheers, Johannes > > Related to this, I've been wondering whether we should have > a policy about the dillorc on the website -- whether it should > follow tip, or follow the most recent release, or always add > new options but never delete old options... > > > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Jan. 22, 2009

[patch]: fix DBG build of table.cc

by jcid＠dillo.org

On Sat, Jan 17, 2009 at 06:53:13PM +0000, Jeremy Henty wrote: > > If you uncomment the #define of DBG in table.cc it won't compile. It > looks as though most of the DBG code was fixed not to use the > non-existent "result" variable, but one instance was left unchanged. > Patch attached. Committed. -- Cheers Jorge.-

Jan. 22, 2009

Crashes in dw::core::Layout::createImgbuf()

by onepoint＠starurchin.org

On Tue, Jan 20, 2009 at 07:33:41PM +0100, Hofmann Johannes wrote: > Can you try to use "hg bisect" to find the changeset where the error > was introduced? I know it's difficult with sporadic errors... I was hoping to avoid that, as it would probably be awfully tedious. I'll give it a go if nothing else works. > Or maybe try valgrind? I've given it a few quick runs under valgrind but seen nothing helpful. Maybe I should just run it under valgrind continually. It's lucky Dillo is fast! Imagine trying to do that with Firefox. Regards, Jeremy Henty

Jan. 22, 2009

dillo CSS and charset

by jcid＠dillo.org

On Thu, Jan 22, 2009 at 12:24:41PM -0300, Jorge Arellano Cid wrote: > On Thu, Jan 22, 2009 at 11:06:01PM +0900, furaisanjin wrote: > > 2009/1/22 furaisanjin <furaisanjin(a)gmail.com>: > > > By the way I notice bookmark (ctrl-b) doesn't work. Does anybody has > > > this problem? > > > > bookmark problem is solved by this patch. > > > > --- a/src/cache.c Thu Jan 22 08:31:44 2009 -0300 > > +++ b/src/cache.c Thu Jan 22 23:03:33 2009 +0900 > > @@ -512,8 +512,10 @@ > > if (entry->CharsetDecoder) > > a_Decode_free(entry->CharsetDecoder); > > a_Misc_parse_content_type(ctype, NULL, NULL, &charset); > > - entry->CharsetDecoder = a_Decode_charset_init(charset); > > - dFree(charset); > > + if (charset) { > > + entry->CharsetDecoder = a_Decode_charset_init(charset); > > + dFree(charset); > > + } > > curr = Cache_current_content_type(entry); > > > > /* Invalidate UTF8Data */ > > Have you added charset to the content-type given by the bookmarks dpi? > or have you added a META or both? > > I would like to know the problem in detail, because it looks like > adding an extra parameter to a_Cache_set_content_type() would make > its API, and code cleaner. e.g. ({CA_Header|CA_Meta} as last parameter). > > If the problem can be solved with that API change, great, hence > the above question. Does something like the attached patch solve the problem? -- Cheers Jorge.-

Jan. 22, 2009

dillo CSS and charset

by corvid＠lavabit.com

Johannes wrote: > On Thu, Jan 22, 2009 at 05:57:42PM +0000, corvid wrote: > > Johannes wrote: > > > BTW. now you can set vw_fontname in dillorc again. This font will > > > then be used when CSS specifies "sans" as font, e.g: > > > vw_fontname="VL Gothic" > > > > If I put a serif font in vw_fontname and then use > > sans in style.css for some things, it'll use > > the serif font. > > True. We need to make new config options > > sans-serif_fontname > serif_fontname > cursive_fontname > fantasy_fontname > monospace_fontname > > maybe even dropping the "_fontname" suffix. > > But of course that would no longer be compatible with older > versions of dillorc. I would add the new options and remove the old options. CSS is big and certainly worth some incompatibility. Related to this, I've been wondering whether we should have a policy about the dillorc on the website -- whether it should follow tip, or follow the most recent release, or always add new options but never delete old options...

Jan. 22, 2009

dillo CSS and charset

by Johannes.Hofmann＠gmx.de

On Thu, Jan 22, 2009 at 05:57:42PM +0000, corvid wrote: > Johannes wrote: > > BTW. now you can set vw_fontname in dillorc again. This font will > > then be used when CSS specifies "sans" as font, e.g: > > vw_fontname="VL Gothic" > > If I put a serif font in vw_fontname and then use > sans in style.css for some things, it'll use > the serif font. True. We need to make new config options sans-serif_fontname serif_fontname cursive_fontname fantasy_fontname monospace_fontname maybe even dropping the "_fontname" suffix. But of course that would no longer be compatible with older versions of dillorc. Opinions? Cheers, Johannes

Jan. 22, 2009

dillo CSS and charset

by corvid＠lavabit.com

Johannes wrote: > BTW. now you can set vw_fontname in dillorc again. This font will > then be used when CSS specifies "sans" as font, e.g: > vw_fontname="VL Gothic" If I put a serif font in vw_fontname and then use sans in style.css for some things, it'll use the serif font.

Jan. 22, 2009

dillo CSS and charset

by jcid＠dillo.org

On Thu, Jan 22, 2009 at 11:06:01PM +0900, furaisanjin wrote: > 2009/1/22 furaisanjin <furaisanjin(a)gmail.com>: > > By the way I notice bookmark (ctrl-b) doesn't work. Does anybody has > > this problem? > > bookmark problem is solved by this patch. > > --- a/src/cache.c Thu Jan 22 08:31:44 2009 -0300 > +++ b/src/cache.c Thu Jan 22 23:03:33 2009 +0900 > @@ -512,8 +512,10 @@ > if (entry->CharsetDecoder) > a_Decode_free(entry->CharsetDecoder); > a_Misc_parse_content_type(ctype, NULL, NULL, &charset); > - entry->CharsetDecoder = a_Decode_charset_init(charset); > - dFree(charset); > + if (charset) { > + entry->CharsetDecoder = a_Decode_charset_init(charset); > + dFree(charset); > + } > curr = Cache_current_content_type(entry); > > /* Invalidate UTF8Data */ Have you added charset to the content-type given by the bookmarks dpi? or have you added a META or both? I would like to know the problem in detail, because it looks like adding an extra parameter to a_Cache_set_content_type() would make its API, and code cleaner. e.g. ({CA_Header|CA_Meta} as last parameter). If the problem can be solved with that API change, great, hence the above question. BTW AFAIS, with the above patch if CharsetDecoder was already set, and a_Misc_parse_content_type() fails, CharsetDecoder is left in an unknown state. -- Cheers Jorge.-

Jan. 22, 2009