- Dillo-dev - lists.mailman3.com

Character entity parsing regression.

by corvid＠lavabit.com

Jorge wrote: > There's a regression with the attached page. Squared boxes > appear where nothing should be. I haven't dug since when. Attached. Looks like it dates to changeset: 286:d16cec5095be user: jcid date: Fri Jun 20 19:10:04 2008 +0200 summary: - Adapted the code to the new Textblock::addText() API.

Jan. 26, 2009

Character entity parsing regression.

by jcid＠dillo.org

Hi, There's a regression with the attached page. Squared boxes appear where nothing should be. I haven't dug since when. Can somebody please give it a look while I work on the tools button? TIA. -- Cheers Jorge.-

Jan. 26, 2009

switch to DILLO_HTML_PARSE_MODE_PRE depending on style

by jcid＠dillo.org

On Thu, Jan 22, 2009 at 02:39:32PM +0100, Hofmann Johannes wrote: > Hi, > > I'm experimenting with attached patch to make switching to > DILLO_HTML_PARSE_MODE_PRE from CSS possible. > Some online source browsers like cgit (http://hjemli.net/git/cgit/) > use this to display sources or diffs. > > Please comment. Considering the current length of the Html_process_tag function, and that the proposed patch may have secondary effects if a tag with automatic close sets PRE, I'd suggest something along the lines of the attached patch. If it passes your tests, feel free to commit. -- Cheers Jorge.-

Jan. 26, 2009

CSS parser leak

by Johannes.Hofmann＠gmx.de

On Sat, Jan 24, 2009 at 09:01:07PM +0000, Jeremy Henty wrote: > On Sat, Jan 24, 2009 at 06:13:48PM +0100, Hofmann Johannes wrote: > > > ... the problem is that the destructor is not called > > atm. CssSimpleSelector is embedded in struct CombinatorAndSelector > > which in turn lives in a lout::misc::SimpleVector. So the memory is > > allocated with malloc and not properly handled with new/delete. > > This is nasty and has to be fixed somehow. > > ...especially as valgrind reports that this is one of Dillo's biggest > leaks. > > I'm attaching a quick and dirty fix that defines a finalize() method > on selectors. This still misses the case when the SimpleVector is > resize()-ed, but that appears to be much more rare. > > The proper fix would be to replace the SimpleVector with a typed > Vector with ownerOfObjects = true. Then finalize() could be turned > into a proper destructor. That would mean CombinatorAndSelector > inheriting Object. I decided to stick with SimpleVector, but allocate CssSimpleSelector properly with new/delete. Please check current tip. Cheers, Johannes

Jan. 25, 2009

dillo CSS and charset

by furaisanjin＠gmail.com

Please ignore this one. I found that my cache.c was corrupted. My local change still remained after updating and that caused this behaviour. 2009/1/25 furaisanjin <furaisanjin(a)gmail.com>: > After pulling from http://freehg.org/u/dillo/main and updating dillo, > the charset conversion problem appeared again. > > Goto http://headlines.yahoo.co.jp/hl (this page is OK) and click some > of article like > http://headlines.yahoo.co.jp/hl?a=20090125-00000013-yom-soci. Charset > conversion doesn't happen on this page. These pages don't contain meta > but HTTP server specifies charset. > > Regards, > furaisanjin >

Jan. 25, 2009

dillo CSS and charset

by furaisanjin＠gmail.com

After pulling from http://freehg.org/u/dillo/main and updating dillo, the charset conversion problem appeared again. Goto http://headlines.yahoo.co.jp/hl (this page is OK) and click some of article like http://headlines.yahoo.co.jp/hl?a=20090125-00000013-yom-soci. Charset conversion doesn't happen on this page. These pages don't contain meta but HTTP server specifies charset. Regards, furaisanjin

Jan. 25, 2009

CSS parser leak

by onepoint＠starurchin.org

On Sat, Jan 24, 2009 at 06:13:48PM +0100, Hofmann Johannes wrote: > ... the problem is that the destructor is not called > atm. CssSimpleSelector is embedded in struct CombinatorAndSelector > which in turn lives in a lout::misc::SimpleVector. So the memory is > allocated with malloc and not properly handled with new/delete. > This is nasty and has to be fixed somehow. ...especially as valgrind reports that this is one of Dillo's biggest leaks. I'm attaching a quick and dirty fix that defines a finalize() method on selectors. This still misses the case when the SimpleVector is resize()-ed, but that appears to be much more rare. The proper fix would be to replace the SimpleVector with a typed Vector with ownerOfObjects = true. Then finalize() could be turned into a proper destructor. That would mean CombinatorAndSelector inheriting Object. Regards, Jeremy Henty

Jan. 24, 2009

inheriting background color

by Johannes.Hofmann＠gmx.de

On Sat, Jan 24, 2009 at 05:43:52PM +0000, corvid wrote: > Is the idea that we should stick in inheritBackgroundColor > whenever we encounter cases like the following? > (I see the "get rid of this somehow" comment.) The inheritBackgroundColor thing is a workaround for elements (<a>, <small> in the below case) that do not create a new dw widget. Things like: <span style="border: 2px solid black">hello</span> don't work at all. I'd like to see a general solution for this but have no idea yet. It's also somehow related to the CSS property "display" (http://www.w3.org/TR/CSS21/visuren.html#display-prop) which is not yet supported at all. But yes, as long as we stick with inheritBackgroundColor, we will need to add it whenever no dw widget is created. Cheers, Johannes > > <head> > <title></title> > <style type="text/css"> > body {background: #000000; color: #00ff00} > </style> > </head> > <body> > <SPAN STYLE='background:#fff6aa;'>link background dark( > <SMALL><A HREF="/">link</A></SMALL> > )</SPAN> > <p> > <SPAN STYLE='background:#fff6aa;'>link background light( > <A HREF="/">link</A>) > </SPAN> > </body> > > > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Jan. 24, 2009

inheriting background color

by corvid＠lavabit.com

Is the idea that we should stick in inheritBackgroundColor whenever we encounter cases like the following? (I see the "get rid of this somehow" comment.) <head> <title></title> <style type="text/css"> body {background: #000000; color: #00ff00} </style> </head> <body> <SPAN STYLE='background:#fff6aa;'>link background dark( <SMALL><A HREF="/">link</A></SMALL> )</SPAN> <p> <SPAN STYLE='background:#fff6aa;'>link background light( <A HREF="/">link</A>) </SPAN> </body>

Jan. 24, 2009

CSS parser leak

by Johannes.Hofmann＠gmx.de

On Sat, Jan 24, 2009 at 05:00:02PM +0000, Jeremy Henty wrote: > > The CSS parser gurus will have to verify this for me, but it *seems* > to me that the leak is because the CssSimpleSelector class does not > clean up its id, klass and pseudo members. Furthermore the only > method that sets those members is Css_parse_simple_selector(), and it > always assigns them to new heap-allocated values. So I reckon the fix > is just to add a CssSimpleSelector destructor that dFree()s those > members. Have I missed anything? No, you are right, but the problem is that the destructor is not called atm. CssSimpleSelector is embedded in struct CombinatorAndSelector which in turn lives in a lout::misc::SimpleVector. So the memory is allocated with malloc and not properly handled with new/delete. This is nasty and has to be fixed somehow. Regards, Johannes

Jan. 24, 2009