- Dillo-dev - lists.mailman3.com

Holiday week

by jcid＠dillo.org

Hi there, I happen to be enjoying a much needed holiday week! :-) The plan is to come back around near wednesday 25. In the meanwhile, I leave you with the following issues lurking in my list to be considered. Maybe all of them can be left to the release after 2.1, but maybe not: [ ] https dialog bombing issue. BUG#868 When enabled, multiple https requests to the same site result in dialog bombing. The https dpi is disabled by default in Dillo. Anyway, in Debian, there's a security warning against dillo for not checking certificates (I don't know what version of dillo they use, nor why they enable https.) [ ] Jump to #anchor doesn't work correctly. The idle timeout doesn't work reliably (an old bug). [ ] Implement @import statement in STYLE element. [ ] What will we do with xhtml? FF doesn't validate. BUG#732 This would be interesting to define. (already suggested as discussion material in another thread). [ ] "-fno-rtti -fno-exceptions" gcc: 64KB less. Enabling this switches reduces the binary size. [ ] dpi for "view page source" (it re-uses search capability). Waiting since a long time... [-] BUG#892 prefs bg_color is not working Johannes was working on related things... [ ] META refresh: "instant client-side redirect". [ ] META refresh: URL='<URI>' case. I plan to implement both when I'm back (and to include them in dillo-2.1). BTW, I want to welcome Tim Nieradzik as a new developer and to tell Joao that the bug in the find-text iterator is not that much important. Just focus on something more urgent. -- Cheers Jorge.-

Feb. 21, 2009

[patch] Improving keyboard shortcuts for tab navigation

by corvid＠lavabit.com

I wonder whether you'd be interested in implementing configurable key bindings...

Feb. 21, 2009

[patch] Improving keyboard shortcuts for tab navigation

by tim.nieradzik＠gmx.de

This patch adds keyboard shortcuts for the tabs 0 - 9. You can reach them by pressing Ctrl concurrently with the number number of the tab you would like to see. Thus, for the first tab this is Ctrl-0. Alternatively, you can press Ctrl-Home. To get to the last tab, simply press Ctrl-End. In addition the modifier for moving left and right between tabs has been changed from Shift to Ctrl because it makes sense to have an unified modifier for all tab movement operations. --Tim

Feb. 21, 2009

[patch] Hiding panels by pressing "Escape"

by tim.nieradzik＠gmx.de

This small patch allows you to press the "Escape" key in order to hide the panels. It assumes that you are in the UI mode "UI_TEMPORARILY_SHOW_PANELS". --Tim

Feb. 20, 2009

[patch] Reloading page by pressing "Enter" in the location box (bug #890)

by tim.nieradzik＠gmx.de

To whom it may concern, I have signed up on the dillo-dev mailing list and would like to introduce myself. My name is Tim Nieradzik. I am new to this mailing list, and I would like to contribute some patches. In the included attachment you will find my first contribution to the Dillo project. It allows users to reload the current page by pressing "Enter" in the location box (bug #890). Sincerely, Tim

Feb. 20, 2009

Re: css parsing numbers

by Johannes.Hofmann＠gmx.de

On Thu, Feb 19, 2009 at 03:32:54PM +0000, corvid wrote: > Johannes wrote: > > On Thu, Feb 19, 2009 at 12:30:34AM +0000, corvid wrote: > > > Johannes wrote: > > > > On Wed, Feb 11, 2009 at 06:03:13PM +0000, corvid wrote: > > > > > I tried > > > > > font-size: .6in > > > > > (we still love archaic measurements here) > > > > > and it didn't work. > > > > > > > > > > The grammar says > > > > > num [0-9]+|[0-9]*"."[0-9]+ > > > > > > > > > > > > > Oh yes. That's Css_next_token() which is not recognizing ".6" as a > > > > float... > > > > > > Attached. > > > Looks good to me so far. The only thing I'm wooried about is the > > hack where Css_parse_simple_selector() checks for CSS_TK_FLOAT and > > interprets them as class selectors. > > After looking at the CSS syntax I think this is not necessary, as > > class names must not start with numbers. > > Can you please have look at the spec too, to confirm this? > > In that case we could just remove the hack in > > Css_parse_simple_selector(). > > I did happen to see: > In CSS1, a class name could start with a digit (".55ft"), unless > it was a dimension (".55in"). In CSS2, such classes are parsed as > unknown dimensions (to allow for future additions of new units). > To make ".55ft" a valid class, CSS2 requires the first digit to be > escaped (".\35 5ft") Ah ok. That explains the current implementation. For CSS 2.1 must not support class selectors like '.1'. http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/by-section.htm has some nice test cases on this subject. I also noticed, that we need to discard the whole ruleset in case of an invalid selector. Cheers, Johannes PS: I haven't looked at escaped chars at all yet. There seems to be some code for it in cssparser.cc.

Feb. 19, 2009

Re: css parsing numbers

by corvid＠lavabit.com

Johannes wrote: > On Thu, Feb 19, 2009 at 12:30:34AM +0000, corvid wrote: > > Johannes wrote: > > > On Wed, Feb 11, 2009 at 06:03:13PM +0000, corvid wrote: > > > > I tried > > > > font-size: .6in > > > > (we still love archaic measurements here) > > > > and it didn't work. > > > > > > > > The grammar says > > > > num [0-9]+|[0-9]*"."[0-9]+ > > > > > > > > > > Oh yes. That's Css_next_token() which is not recognizing ".6" as a > > > float... > > > > Attached. > Looks good to me so far. The only thing I'm wooried about is the > hack where Css_parse_simple_selector() checks for CSS_TK_FLOAT and > interprets them as class selectors. > After looking at the CSS syntax I think this is not necessary, as > class names must not start with numbers. > Can you please have look at the spec too, to confirm this? > In that case we could just remove the hack in > Css_parse_simple_selector(). I did happen to see: In CSS1, a class name could start with a digit (".55ft"), unless it was a dimension (".55in"). In CSS2, such classes are parsed as unknown dimensions (to allow for future additions of new units). To make ".55ft" a valid class, CSS2 requires the first digit to be escaped (".\35 5ft")

Feb. 19, 2009

Re: css parsing numbers

by Johannes.Hofmann＠gmx.de

On Thu, Feb 19, 2009 at 12:30:34AM +0000, corvid wrote: > Johannes wrote: > > On Wed, Feb 11, 2009 at 06:03:13PM +0000, corvid wrote: > > > I tried > > > font-size: .6in > > > (we still love archaic measurements here) > > > and it didn't work. > > > > > > The grammar says > > > num [0-9]+|[0-9]*"."[0-9]+ > > > > > > > Oh yes. That's Css_next_token() which is not recognizing ".6" as a > > float... > > Attached. > > I'm too much of a css newbie to promise great testing, but I did cobble together > the following and the right things seemed to happen: > > <html> > <head> > <style type="text/css"> > hr.aaaaa {width: 1.5in} > bbbbb {width: 2 in} > </style> > </head> > <body> > <hr style="width: 0.3in"> > <hr style="width: .6in"> > <hr style="width: 1 in"> > <hr class="aaaaa"> > <hr class="bbbbb"> > </body > </html> Looks good to me so far. The only thing I'm wooried about is the hack where Css_parse_simple_selector() checks for CSS_TK_FLOAT and interprets them as class selectors. After looking at the CSS syntax I think this is not necessary, as class names must not start with numbers. Can you please have look at the spec too, to confirm this? In that case we could just remove the hack in Css_parse_simple_selector(). Cheers, Johannes

Feb. 19, 2009

Re: css parsing numbers

by corvid＠lavabit.com

Johannes wrote: > On Wed, Feb 11, 2009 at 06:03:13PM +0000, corvid wrote: > > I tried > > font-size: .6in > > (we still love archaic measurements here) > > and it didn't work. > > > > The grammar says > > num [0-9]+|[0-9]*"."[0-9]+ > > > > Oh yes. That's Css_next_token() which is not recognizing ".6" as a > float... Attached. I'm too much of a css newbie to promise great testing, but I did cobble together the following and the right things seemed to happen: <html> <head> <style type="text/css"> hr.aaaaa {width: 1.5in} bbbbb {width: 2 in} </style> </head> <body> <hr style="width: 0.3in"> <hr style="width: .6in"> <hr style="width: 1 in"> <hr class="aaaaa"> <hr class="bbbbb"> </body </html>

Feb. 19, 2009

Leaking image structures

by onepoint＠starurchin.org

On Wed, Feb 18, 2009 at 05:06:16PM +0100, Hofmann Johannes wrote: > Yes. Updated patch attached. OK, I'm running with this patch. Since I don't have reproducible test cases I can't say right away whether it works. Keep an eye on my valgrind log page (it updates every night). http://starurchin.org/dillo/valgrind.html BTW, it seems that the CSS leaks stopped about three days ago. Yay! Regards, Jeremy Henty

Feb. 18, 2009