- Dillo-dev - lists.mailman3.com

dillo mouse cursor

by pastebin＠gmx.com

Hi anyone have any interesting mouse cursor pointers? i'm using a left arrow pointer - then over a link becomes left pointing hand xsetroot -cursor_name left_ptr

July 6, 2024

Re: Feature idea: zoom buttons

by a1ex＠dismail.de

On Sat, 6 Jul 2024 14:30:01 +0200 Rodrigo Arias <rodarima(a)gmail.com> wrote: > Hi Alex, > > >Here is a patch which allows zooming in and out using the Refresh > >button. Right clicking on it zooms the page in. Middle clicking zooms > >out. It's not especially intuitive, but it's simple and it works. > > I agree is not very intuitive, maybe using the scroll wheel may be > more clear. But still, tying it to the refresh button is weird to me. > > On the other hand, I like that you can see the whole page while > changing the zoom level using the mouse (which doesn't happen in > other browsers). I'm thinking if it could make sense to add another > "appearance" bar (usually hidden) like the "find text" where we can > put some knobs to change the page appearance, like the zoom buttons > or sliders but also maybe some of the CSS options too. > > I think this would also make more sense if we can select multiple > "user" styles to implement some king of reader mode, as you will want > to see the effect without covering the canvas. Your idea of an "appearance" bar sounds interesting. I was originally thinking it would be neat to have the zoom buttons on the bottom next to the bugmeter, similar to what you are suggesting. Since that sounds more like a long-term goal, I have come up with a patch to create a dedicated zoom button on the toolbar. Left-click zooms in, right-click zooms out. Its just a proof of concept, but if you like the idea, maybe I could polish it up and make an optional setting for it, etc. Here you go: diff -u ./pixmaps.h mod/pixmaps.h --- ./pixmaps.h Sat Jul 6 18:03:43 2024 +++ mod/pixmaps.h Sat Jul 6 18:23:27 2024 @@ -1410,6 +1410,28 @@ }; /* XPM */ +static const char *const zoom_xpm[] = { +"16 16 2 1", +" c None", +"@ c gray70", +" ", +" @@ ", +" @@ ", +" @@ ", +" @@ ", +" @@ ", +" @@ ", +" @@@@@@@@@@@@@ ", +" @@@@@@@@@@@@@ ", +" @@ ", +" @@ ", +" @@ ", +" @@ ", +" @@ ", +" @@ ", +" "}; + +/* XPM */ static const char *const new_s_xpm[] = { "11 11 35 1", " c None", diff -u ./ui.cc mod/ui.cc --- ./ui.cc Sat Jul 6 18:26:52 2024 +++ mod/ui.cc Sat Jul 6 18:03:57 2024 @@ -38,7 +38,7 @@ struct iconset { Fl_Image *ImgMeterOK, *ImgMeterBug, - *ImgHome, *ImgReload, *ImgSave, *ImgBook, *ImgTools, + *ImgHome, *ImgReload, *ImgSave, *ImgBook, *ImgTools, *ImgZoom, *ImgClear,*ImgSearch, *ImgHelp, *ImgLeft, *ImgLeftIn, *ImgRight, *ImgRightIn, *ImgStop, *ImgStopIn; }; @@ -51,6 +51,7 @@ new Fl_Pixmap(save_xpm), new Fl_Pixmap(bm_xpm), new Fl_Pixmap(tools_xpm), + new Fl_Pixmap(zoom_xpm), new Fl_Pixmap(new_s_xpm), new Fl_Pixmap(search_xpm), new Fl_Pixmap(help_xpm), @@ -70,6 +71,7 @@ new Fl_Pixmap(save_s_xpm), new Fl_Pixmap(bm_s_xpm), new Fl_Pixmap(tools_s_xpm), + new Fl_Pixmap(zoom_xpm), new Fl_Pixmap(new_s_xpm), standard_icons.ImgSearch, standard_icons.ImgHelp, @@ -356,6 +358,13 @@ wid->y() + wid->h()); } break; + case UI_ZOOM: + if (b == FL_LEFT_MOUSE) { + a_UIcmd_zoom_in(a_UIcmd_get_bw_by_widget(wid)); + } else if (b == FL_RIGHT_MOUSE) { + a_UIcmd_zoom_out(a_UIcmd_get_bw_by_widget(wid)); + } + break; default: break; } @@ -433,6 +442,7 @@ Stop = make_button("Stop", icons->ImgStop, icons->ImgStopIn, UI_STOP); Bookmarks = make_button("Book", icons->ImgBook, NULL, UI_BOOK); Tools = make_button("Tools", icons->ImgTools, NULL, UI_TOOLS); + Zoom = make_button("Zoom", icons->ImgZoom, NULL, UI_ZOOM); Back->set_tooltip("Previous page"); Forw->set_tooltip("Next page"); @@ -442,6 +452,7 @@ Stop->set_tooltip("Stop loading"); Bookmarks->set_tooltip("View bookmarks"); Tools->set_tooltip("Settings"); + Tools->set_tooltip("Zoom"); } /** diff -u ./ui.hh mod/ui.hh --- ./ui.hh Sat Jul 6 18:03:43 2024 +++ mod/ui.hh Sat Jul 6 18:03:57 2024 @@ -23,6 +23,7 @@ UI_STOP, UI_BOOK, UI_TOOLS, + UI_ZOOM, UI_CLEAR, UI_SEARCH } UIButton; @@ -125,7 +126,7 @@ CustGroupVertical *TopGroup; CustButton *Back, *Forw, *Home, *Reload, *Save, *Stop, *Bookmarks, - *Tools, *Clear, *Search, *Help, *BugMeter, *FileButton; + *Tools, *Zoom, *Clear, *Search, *Help, *BugMeter, *FileButton; CustGroupHorizontal *LocBar, *NavBar, *StatusBar; Fl_Input *Location; CustProgressBox *PProg, *IProg; Regards, Alex

July 6, 2024

Re: extra /tmp on file name line when save html

by pastebin＠gmx.com

Hi, Thanks Rodrigo for working with Albrecht-S i think this issue is now resolved for me when saving an html 1. if i like the highlightd name given in the Filename: box i just click 'ok' 2. if i want to add more text or suffix to the highlighted name given in the Filename: box i just hit 'end' key (easier then using mouse click in filename box) and enter what i want 3, if i want to enter a completely new name to save in save_dir (problem being dillo enters /tmp now) i don't know if changing rc = chdir("/tmp"); to rc = chdir("/html"); in src/paths.cc is what you meant by your suggestion : > One option to work around it is to chdir() to the save_dir, so at least > it would make a bit more sense. but by doing so now it now puts /html/'firstkeypressed' an i can put the name i want there (i didn't know how to put the save_dir variable there instead of my hardcoded "/html" which would be better) (i get make error ->? save_dir not defined in this scope) so all seems fixed - for me anyway thank Albrecht-S for his work and interesting posts in the https://github.com/fltk/fltk/issues/1004#issuecomment-2210810570 i think the only issue left here is Albrecht-S saying that hitting '/' leaves a '/' there my hitting the '/' key just erases highlight and leaves nothing in the filename box :) On Sat, 6 Jul 2024 14:10:22 +0200 Rodrigo Arias <rodarima(a)gmail.com> wrote: > Hi, > > >the problem is 2 parts > >in dillo - switching from the savedir to /tmp dir when first 'd' > >pressed and then repeating /tmp/d/tmp/d when another 'd' is pressed > > > >the fix only fixes the repeat to /tmp/d/tmp/d when a second d is > >pressed but the changing from savedir to /tmp/d still happens when > >first d is pressed > > > >your program only shows the second part of the problem (and that part > >is fixed) since it does the chdir("/tmp") itself and not what happens > >with dillo when the first 'd' is pressed > > > >the fix only fixes the repeat not the initial change to /tmp dir from > >the savedir > > This is a "design" decision by FLTK[1], as when a non-/ character is > added it is considered as a relative path *to the current directory* > which is always set to /tmp in Dillo (regardless of the save_dir) and it > gets prefixed. > > [1]: https://github.com/fltk/fltk/issues/1004#issuecomment-2210810570 > > One option to work around it is to chdir() to the save_dir, so at least > it would make a bit more sense. yes i edited src/paths.cc rc = chdir("/html"); // rc = chdir("/tmp"); > Another good idea is to switch to the native file chooser which also > comes with other niceties (but this problem will continue there if the > native file chooser is not available). what source is the 'native file chooser' in? > Rodrigo. > _______________________________________________ > Dillo-dev mailing list -- dillo-dev(a)mailman3.com > To unsubscribe send an email to dillo-dev-leave(a)mailman3.com

July 6, 2024

Re: Feature idea: zoom buttons

by Rodrigo Arias

Hi Alex, >Here is a patch which allows zooming in and out using the Refresh >button. Right clicking on it zooms the page in. Middle clicking zooms >out. It's not especially intuitive, but it's simple and it works. I agree is not very intuitive, maybe using the scroll wheel may be more clear. But still, tying it to the refresh button is weird to me. On the other hand, I like that you can see the whole page while changing the zoom level using the mouse (which doesn't happen in other browsers). I'm thinking if it could make sense to add another "appearance" bar (usually hidden) like the "find text" where we can put some knobs to change the page appearance, like the zoom buttons or sliders but also maybe some of the CSS options too. I think this would also make more sense if we can select multiple "user" styles to implement some king of reader mode, as you will want to see the effect without covering the canvas. Rodrigo.

July 6, 2024

Re: Nice work

by Rodrigo Arias

Hi, On Sat, Jul 06, 2024 at 06:45:51AM -0400, Kate Draven wrote: >Just started playing with Dillo. Nice work. Can't wait to see where >it's going. > >Keep up the good work. I have a feeling I and soon, many people will >be using it to get away from the bloat rubbish that most browsers have >become. > >Again, nice work. Thanks Kate, it is good to see more people interested in Dillo :-) Rodrigo.

July 6, 2024

Re: extra /tmp on file name line when save html

by Rodrigo Arias

Hi, >the problem is 2 parts >in dillo - switching from the savedir to /tmp dir when first 'd' >pressed and then repeating /tmp/d/tmp/d when another 'd' is pressed > >the fix only fixes the repeat to /tmp/d/tmp/d when a second d is >pressed but the changing from savedir to /tmp/d still happens when >first d is pressed > >your program only shows the second part of the problem (and that part >is fixed) since it does the chdir("/tmp") itself and not what happens >with dillo when the first 'd' is pressed > >the fix only fixes the repeat not the initial change to /tmp dir from >the savedir This is a "design" decision by FLTK[1], as when a non-/ character is added it is considered as a relative path *to the current directory* which is always set to /tmp in Dillo (regardless of the save_dir) and it gets prefixed. [1]: https://github.com/fltk/fltk/issues/1004#issuecomment-2210810570 One option to work around it is to chdir() to the save_dir, so at least it would make a bit more sense. Another good idea is to switch to the native file chooser which also comes with other niceties (but this problem will continue there if the native file chooser is not available). Rodrigo.

July 6, 2024

Nice work

by Kate Draven

Just started playing with Dillo. Nice work. Can't wait to see where it's going. Keep up the good work. I have a feeling I and soon, many people will be using it to get away from the bloat rubbish that most browsers have become. Again, nice work. Cheers, Kate Draven

July 6, 2024

Re: extra /tmp on file name line when save html

by pastebin＠gmx.com

Hi it is the highlight that is the problem when removed by clicking in the filename location all is good when any 'key' but '/' is done it puts /tmp/'key' there with '/' it just clears the box and nothing is put there fltk knows about the save_dir because it puts it there in the first place but loses site of it when highlight is cleared and (i guess) default dir '/tmp' is used just not using the hightlight would probably solve the problem cosmetically but not algorithmically wise whoever is putting '/tmp/key' there should put the 'save_dir/key' there instead On Thu, 4 Jul 2024 19:57:59 +0200 Rodrigo Arias <rodarima(a)gmail.com> wrote: > > A fix was provided by FLTK developer Albrecht Schlosser: > > https://github.com/fltk/fltk/issues/1004#issuecomment-2209144366 > > You can take the "branch-1.3" branch which also contains the fix (f34719). > > $ git clone https://github.com/fltk/fltk > $ cd fltk > $ git checkout branch-1.3 > ... > > Can you check it solves your issue? They are waiting for confirmation to > close the issue on their side. > > Best, > Rodrigo. > _______________________________________________ > Dillo-dev mailing list -- dillo-dev(a)mailman3.com > To unsubscribe send an email to dillo-dev-leave(a)mailman3.com

July 5, 2024

Re: Feature idea: zoom buttons

by a1ex＠dismail.de

On Wed, 26 Jun 2024 21:16:47 +0200 Rodrigo Arias <rodarima(a)gmail.com> wrote: > >One thing which I would suggest is also having optional toolbar > >buttons to control this. > > Yeah, I thought about adding three new menu items in the main menu or > under a sub-menu, but I like the idea of Firefox and Chromium where > they placed both the [-] [+] buttons inside a main menu item. > > Not sure how hard it would be to do with FLTK. I briefly looked at adding this to the Page menu, it certainly looks possible, but it's a little beyond me at the moment. Same with toolbar buttons. So, right now I just tried to find the least complicated way to zoom with the mouse. Here is a patch which allows zooming in and out using the Refresh button. Right clicking on it zooms the page in. Middle clicking zooms out. It's not especially intuitive, but it's simple and it works. $ diff -u ui.cc.orig ui.cc.mod --- ui.cc.orig Fri Jul 5 15:04:00 2024 +++ ui.cc.mod Fri Jul 5 16:07:48 2024 @@ -333,6 +333,10 @@ case UI_RELOAD: if (b == FL_LEFT_MOUSE) { a_UIcmd_reload(a_UIcmd_get_bw_by_widget(wid)); + } else if (b == FL_RIGHT_MOUSE) { + a_UIcmd_zoom_in(a_UIcmd_get_bw_by_widget(wid)); + } else if (b == FL_MIDDLE_MOUSE) { + a_UIcmd_zoom_out(a_UIcmd_get_bw_by_widget(wid)); } break; case UI_SAVE: Regards, Alex

July 5, 2024

Re: use remote css unchecked

by pastebin＠gmx.com

Hi thanks - that works perfectly On Thu, 4 Jul 2024 20:08:49 +0200 Rodrigo Arias <rodarima(a)gmail.com> wrote: > Hi, > > On Thu, Jul 04, 2024 at 10:11:12AM -0600, pastebin(a)gmx.com wrote: > >Hi, > > > >shouldn't the lines wrap with > >https://packetstormsecurity.com/files/179337/Red-Hat-Security-Advisory-2024… > >with 'tools/use remote css' unchecked? > > > >with 'tools/use remote css' checked the lines wrap but their css looks horrible (to me) > > This is the default behavior when no other CSS rules are applied. If you > want to break the lines by default, you can add this rule to break long > lines at word boundary: > > $ echo 'pre { white-space: pre-wrap; }' >> ~/.dillo/style.css > > Then reload the page. See also: > > https://developer.mozilla.org/en-US/docs/Web/CSS/white-space#content > > Note that it will affect any page that has a pre tag an no other rules > override that value. > > Rodrigo. > _______________________________________________ > Dillo-dev mailing list -- dillo-dev(a)mailman3.com > To unsubscribe send an email to dillo-dev-leave(a)mailman3.com

July 4, 2024