- Dillo-dev - lists.mailman3.com

PATCH: don't force selection of first element in multi-select input.

by dtikhonov＠yahoo.com

Hi all, Great job on dillo! Below is a patch that prevents the browser from selecting the first element of a multi-select input. Thanks, - Dmitri. --- a/src/form.cc Mon Nov 02 13:41:37 2009 -0300 +++ b/src/form.cc Tue Nov 03 12:57:02 2009 -0500 @@ -767,8 +767,8 @@ void Html_tag_close_select(DilloHtml *ht DilloHtmlInput *input = Html_get_current_input(html); DilloHtmlSelect *select = input->select; - // BUG(?): should not do this for MULTI selections - select->ensureSelection (); + if (DILLO_HTML_INPUT_SEL_LIST != input->type) + select->ensureSelection (); SelectionResource *res = (SelectionResource*)input->embed->getResource(); select->addOptionsTo (res);

Nov. 3, 2009

Big changes in DPI framework and API

by corvid＠lavabit.com

dillo-dev wrote: > Jorge wrote: > > On Mon, Nov 02, 2009 at 08:14:40PM +0000, corvid wrote: > > > Jorge wrote: > > > > On Mon, Nov 02, 2009 at 07:26:49PM +0000, corvid wrote: > > > > > Jorge wrote: > > > > > > On Mon, Nov 02, 2009 at 03:07:29PM -0300, Jorge Arellano Cid wrote: > > > > > > > On Mon, Nov 02, 2009 at 04:16:53PM +0000, corvid wrote: > > > > > > > > [...] > > > > > > > > I tried putting the pieces under ~/.dillo/, similar to how I'd > > > > > > > > had them before, and got error msgs instead of working dpis. > > > > > > > > Would it make more sense for me to dig in now to understand what > > > > > > > > is happening, or are the docs and patches coming very soon? > > > > > > > > > > > > > > I should write Docs soon (before Friday). There were no changes > > > > > > > regarding dpis in ~/.dillo/. I haven't tested them though. Let me > > > > > > > check here... > > > > > > > > > > > > After changing the table colors in file.dpi, more or less it > > > > > > worked with: > > > > > > > > > > > > make > > > > > > dpidc stop > > > > > > mkdir -p ~/.dillo/dpi/file > > > > > > cp file.dpi ~/.dillo/dpi/file > > > > > > dillo . > > > > > > > > > > > > It may be that you already have dpis there, and those will not > > > > > > work with the new code. They need convertion to the new dsh API. > > > > > > If this is the case, you can wait a bit for the docs, or give a > > > > > > look to the respective "convert to dsh API" patch in the repo. > > > > > > > > > > When dillo tries to talk to dpid: > > > > > After connect(), lsof -i shows me ESTABLISHED for both sides > > > > > After write(), the dpid side is gone and dillo says CLOSE_WAIT > > > > > After shutdown(), both sides are gone. > > > > > Then Dpi_get_server_port: can't read server port from dpid. > > > > > and ** ERROR **: dpi.c: can't start dpi daemon > > > > > > > > There may be an old dpid binary around. Try this in two > > > > terminal windows: > > > > > > > > 1.- 2.- > > > > cd src/dpid cd src/dpid > > > > ./dpid ./dpidc stop > > > > > > > > > > > > If dpid stops, it's OK. Most probably an old dpid is started. > > > > > > > > > > > > Is anybody else seeing this problem? > > > > > > But that dpid had been listening on the port advertised in > > > dpid_comm_keys, which an old dpid wouldn't have been doing. > > > > OK. The error looks like a problem in the authentication phase, > > but I'm not sure. Does the above test work for you? Are you > > testing on GNU/Linux or other OS? Is there a chance of another > > app trying to talk to the same port (DPID_BASE_PORT)? > > The test starts and stops dpid. > GNU/Linux. > lsof -i doesn't show anything else doing anything. > > > Are you trying to run all from ~/.dillo, or a global install? > > All from ~/.dillo I removed the dpidrc and was looking at things, wasn't enlightened, wrote a new one, and now it's working. Evidently there was something wrong in the first one. Hurray! I did notice that dpid was making 8 dpi service entries from local, and then 8 more because it's regarding (perhaps rightly) my dpi_dir line as pointing to system dpis even though it's just pointing to the local ones. The 16 entries didn't seem to be harming anything, though.

Nov. 3, 2009

Big changes in DPI framework and API

by corvid＠lavabit.com

Jorge wrote: > On Mon, Nov 02, 2009 at 08:14:40PM +0000, corvid wrote: > > Jorge wrote: > > > On Mon, Nov 02, 2009 at 07:26:49PM +0000, corvid wrote: > > > > Jorge wrote: > > > > > On Mon, Nov 02, 2009 at 03:07:29PM -0300, Jorge Arellano Cid wrote: > > > > > > On Mon, Nov 02, 2009 at 04:16:53PM +0000, corvid wrote: > > > > > > > [...] > > > > > > > I tried putting the pieces under ~/.dillo/, similar to how I'd > > > > > > > had them before, and got error msgs instead of working dpis. > > > > > > > Would it make more sense for me to dig in now to understand what > > > > > > > is happening, or are the docs and patches coming very soon? > > > > > > > > > > > > I should write Docs soon (before Friday). There were no changes > > > > > > regarding dpis in ~/.dillo/. I haven't tested them though. Let me > > > > > > check here... > > > > > > > > > > After changing the table colors in file.dpi, more or less it > > > > > worked with: > > > > > > > > > > make > > > > > dpidc stop > > > > > mkdir -p ~/.dillo/dpi/file > > > > > cp file.dpi ~/.dillo/dpi/file > > > > > dillo . > > > > > > > > > > It may be that you already have dpis there, and those will not > > > > > work with the new code. They need convertion to the new dsh API. > > > > > If this is the case, you can wait a bit for the docs, or give a > > > > > look to the respective "convert to dsh API" patch in the repo. > > > > > > > > When dillo tries to talk to dpid: > > > > After connect(), lsof -i shows me ESTABLISHED for both sides > > > > After write(), the dpid side is gone and dillo says CLOSE_WAIT > > > > After shutdown(), both sides are gone. > > > > Then Dpi_get_server_port: can't read server port from dpid. > > > > and ** ERROR **: dpi.c: can't start dpi daemon > > > > > > There may be an old dpid binary around. Try this in two > > > terminal windows: > > > > > > 1.- 2.- > > > cd src/dpid cd src/dpid > > > ./dpid ./dpidc stop > > > > > > > > > If dpid stops, it's OK. Most probably an old dpid is started. > > > > > > > > > Is anybody else seeing this problem? > > > > But that dpid had been listening on the port advertised in > > dpid_comm_keys, which an old dpid wouldn't have been doing. > > OK. The error looks like a problem in the authentication phase, > but I'm not sure. Does the above test work for you? Are you > testing on GNU/Linux or other OS? Is there a chance of another > app trying to talk to the same port (DPID_BASE_PORT)? The test starts and stops dpid. GNU/Linux. lsof -i doesn't show anything else doing anything. > Are you trying to run all from ~/.dillo, or a global install? All from ~/.dillo

Nov. 3, 2009

Crashes at bizmakoto.jp

by corvid＠lavabit.com

Jorge wrote: > On Tue, Nov 03, 2009 at 09:19:50AM +0900, furaisanjin wrote: > > Hi. > > > > I don't try all pages but at least there are several pages where dillo > > keeps crashing. One example is > > http://bizmakoto.jp/bizid/articles/0911/02/news082.html. gdb backtrace > > shows something like this. > > It doesn't crash here... :P > > The were a couple of patches for cleanup_at_close, please > try from the repository without them (upto 1404:d4a8309dc63c), > and let us know how it goes. I don't see where the tag variable is set to anything at all in tip. I don't get a crash, but I get gibberish in the page bugs.

Nov. 3, 2009

Crashes at bizmakoto.jp

by furaisanjin＠gmail.com

2009/11/3 Jorge Arellano Cid <jcid(a)dillo.org>: > ?The were a couple of patches for cleanup_at_close, please > try from the repository without them (upto 1404:d4a8309dc63c), > and let us know how it goes. I did hg update -C 1404, this looks OK. Regards, furaisanjin

Nov. 3, 2009

Crashes at bizmakoto.jp

by jcid＠dillo.org

On Tue, Nov 03, 2009 at 09:19:50AM +0900, furaisanjin wrote: > Hi. > > I don't try all pages but at least there are several pages where dillo > keeps crashing. One example is > http://bizmakoto.jp/bizid/articles/0911/02/news082.html. gdb backtrace > shows something like this. It doesn't crash here... :P The were a couple of patches for cleanup_at_close, please try from the repository without them (upto 1404:d4a8309dc63c), and let us know how it goes. -- Cheers Jorge.-

Nov. 3, 2009

Big changes in DPI framework and API

by jcid＠dillo.org

On Mon, Nov 02, 2009 at 08:14:40PM +0000, corvid wrote: > Jorge wrote: > > On Mon, Nov 02, 2009 at 07:26:49PM +0000, corvid wrote: > > > Jorge wrote: > > > > On Mon, Nov 02, 2009 at 03:07:29PM -0300, Jorge Arellano Cid wrote: > > > > > On Mon, Nov 02, 2009 at 04:16:53PM +0000, corvid wrote: > > > > > > [...] > > > > > > I tried putting the pieces under ~/.dillo/, similar to how I'd > > > > > > had them before, and got error msgs instead of working dpis. > > > > > > Would it make more sense for me to dig in now to understand what > > > > > > is happening, or are the docs and patches coming very soon? > > > > > > > > > > I should write Docs soon (before Friday). There were no changes > > > > > regarding dpis in ~/.dillo/. I haven't tested them though. Let me > > > > > check here... > > > > > > > > After changing the table colors in file.dpi, more or less it > > > > worked with: > > > > > > > > make > > > > dpidc stop > > > > mkdir -p ~/.dillo/dpi/file > > > > cp file.dpi ~/.dillo/dpi/file > > > > dillo . > > > > > > > > It may be that you already have dpis there, and those will not > > > > work with the new code. They need convertion to the new dsh API. > > > > If this is the case, you can wait a bit for the docs, or give a > > > > look to the respective "convert to dsh API" patch in the repo. > > > > > > When dillo tries to talk to dpid: > > > After connect(), lsof -i shows me ESTABLISHED for both sides > > > After write(), the dpid side is gone and dillo says CLOSE_WAIT > > > After shutdown(), both sides are gone. > > > Then Dpi_get_server_port: can't read server port from dpid. > > > and ** ERROR **: dpi.c: can't start dpi daemon > > > > There may be an old dpid binary around. Try this in two > > terminal windows: > > > > 1.- 2.- > > cd src/dpid cd src/dpid > > ./dpid ./dpidc stop > > > > > > If dpid stops, it's OK. Most probably an old dpid is started. > > > > > > Is anybody else seeing this problem? > > But that dpid had been listening on the port advertised in > dpid_comm_keys, which an old dpid wouldn't have been doing. OK. The error looks like a problem in the authentication phase, but I'm not sure. Does the above test work for you? Are you testing on GNU/Linux or other OS? Is there a chance of another app trying to talk to the same port (DPID_BASE_PORT)? Are you trying to run all from ~/.dillo, or a global install? -- Cheers Jorge.-

Nov. 3, 2009

Crashes at bizmakoto.jp

by furaisanjin＠gmail.com

Hi. I don't try all pages but at least there are several pages where dillo keeps crashing. One example is http://bizmakoto.jp/bizid/articles/0911/02/news082.html. gdb backtrace shows something like this. #0 0x28554687 in __vfprintf () from /lib/libc.so.6 #1 0x284e1fe0 in vsnprintf () from /lib/libc.so.6 #2 0x0807a16f in dStr_vsprintfa (ds=0x83cad40, format=0x80fd314 "unexpected closing tag: </%s> -- expected </%s>.\n", argp=0xbfbfe318 "$B!&(B216\017\b") at dlib.c:362 #3 0x08065f94 in DilloHtml::bugMessage (this=0x847f400, format=0x80fd314 "unexpected closing tag: </%s> -- expected </%s>.\n") at html.cc:144 #4 0x0806bed5 in Html_tag_cleanup_at_close (html=0x847f400, new_idx=8) at html.cc:1338 #5 0x0806ce4f in Html_write_raw (html=0x847f400, buf=0x861e000 "\n\n<!DOCTYPE html PUBLIC \"-//W3C//DTD HTML 4.01 Transitional//EN\" \"http://www.w3.org/TR/html4/loose.dtd\">\n<html id=\"/bizid/articles/0911/02/news082.html\">\n<head>\n<meta http-equiv=\"Content-Type\" content"..., bufsize=59935, Eof=0) at html.cc:3514 #6 0x0806dca5 in DilloHtml::write (this=0x847f400, Buf=0x0, BufSize=59935, Eof=0) at html.cc:556 #7 0x0806ddbe in Html_callback (Op=0, Client=0x8502380) at html.cc:3673 #8 0x0805b862 in Cache_process_queue (entry=0x8562980) at cache.c:1173 #9 0x0805c41f in Cache_delayed_process_queue_callback () at cache.c:1237 #10 0x080cc874 in fltk::wait () #11 0x080cca19 in fltk::run () #12 0x0804f158 in main (argc=1, argv=0xbfbfe798) at dillo.cc:353 I set YES/NO on w3c_plus_heuristics in dillorc but it didn't help. It seems that new_tag contains something valid but tag looks corrupted or not-initialized. (gdb) p new_tag $1 = {name = 0x80f8ef7 "body", Flags = 30 '\036', EndTag = 79 'O', TagLevel = 1 '\001', open = 0x8069e9c <Html_tag_open_body>, close = 0x8067db0 <Html_tag_close_body>} (gdb) p tag $2 = {name = 0x79000000 <Error reading address 0x79000000: Bad address>, Flags = 16 '\020', EndTag = 0 '\0', TagLevel = 0 '\0', open = 0, close = 0x2f} Regards, furaisanjin

Nov. 3, 2009

Big changes in DPI framework and API

by furaisanjin＠gmail.com

2009/11/3 Jorge Arellano Cid <jcid(a)dillo.org>: > ?Please try the latest repo and send feedback! > Thank you for updating and now I can compile. However I encounter the problematic pages. I will report this in another thread. Regards, furaisanjin

Nov. 3, 2009

Big changes in DPI framework and API

by corvid＠lavabit.com

Jorge wrote: > On Mon, Nov 02, 2009 at 07:26:49PM +0000, corvid wrote: > > Jorge wrote: > > > On Mon, Nov 02, 2009 at 03:07:29PM -0300, Jorge Arellano Cid wrote: > > > > On Mon, Nov 02, 2009 at 04:16:53PM +0000, corvid wrote: > > > > > [...] > > > > > I tried putting the pieces under ~/.dillo/, similar to how I'd > > > > > had them before, and got error msgs instead of working dpis. > > > > > Would it make more sense for me to dig in now to understand what > > > > > is happening, or are the docs and patches coming very soon? > > > > > > > > I should write Docs soon (before Friday). There were no changes > > > > regarding dpis in ~/.dillo/. I haven't tested them though. Let me > > > > check here... > > > > > > After changing the table colors in file.dpi, more or less it > > > worked with: > > > > > > make > > > dpidc stop > > > mkdir -p ~/.dillo/dpi/file > > > cp file.dpi ~/.dillo/dpi/file > > > dillo . > > > > > > It may be that you already have dpis there, and those will not > > > work with the new code. They need convertion to the new dsh API. > > > If this is the case, you can wait a bit for the docs, or give a > > > look to the respective "convert to dsh API" patch in the repo. > > > > When dillo tries to talk to dpid: > > After connect(), lsof -i shows me ESTABLISHED for both sides > > After write(), the dpid side is gone and dillo says CLOSE_WAIT > > After shutdown(), both sides are gone. > > Then Dpi_get_server_port: can't read server port from dpid. > > and ** ERROR **: dpi.c: can't start dpi daemon > > There may be an old dpid binary around. Try this in two > terminal windows: > > 1.- 2.- > cd src/dpid cd src/dpid > ./dpid ./dpidc stop > > > If dpid stops, it's OK. Most probably an old dpid is started. > > > Is anybody else seeing this problem? But that dpid had been listening on the port advertised in dpid_comm_keys, which an old dpid wouldn't have been doing.

Nov. 2, 2009