- Dillo-dev - lists.mailman3.com

hyphenation in dillo

by Johannes.Hofmann＠gmx.de

Hi Jorge, On Wed, Sep 05, 2012 at 02:30:32PM -0300, Jorge Arellano Cid wrote: > On Tue, Sep 04, 2012 at 08:55:19PM +0200, Johannes Hofmann wrote: > > On Tue, Sep 04, 2012 at 06:46:30PM +0200, Sebastian Geerken wrote: > > > On Tue, Sep 04, Johannes Hofmann wrote: > > > > On Tue, Sep 04, 2012 at 02:36:29PM +0200, Sebastian Geerken wrote: > > > > > > I'm mostly finished with cleaning up the calculation of extremes (used > > > > > > for tables). This should already work now, please test it again. > > > > > > > > > > Just pushed some more changes; should be complete now. Please test > > > > > thoroughly. > > Several sites I visit don't trigger hyphenation because they lack > the "lang" attribute. I'm experimenting with a very simple language > guess routine, to get an idea of how it could help in this regard. > > @Johannes, This function samples text from the parser, and it may > fall anywhere on the CSS tree. How can I set it for the HTML element so > it is inherited from there? Fancy! Unfortunately you probabely only know the language of an element, after you've seen text from it. That's too late. You would need to do the setNonCssHint() before the first call to getStyle() on that element. So basically you would need to somehow remember the language for each element and then reload and set the appropriate language for the element - but I agree that that's not really elegant. > > I've tried: > > html->styleEngine->setNonCssHint( > PROPERTY_X_LANG, CSS_TYPE_STRING, html->lang); > > which seems to set it for the current element only. > > and > > html->styleEngine->restyle (); > > with no good result. Yeah, I fear restyle() does not what you need here. For now we could simply expose x-lang to the css parser, so you can at least set a reasonable default (e.g. body { x-lang:"en" } )in your ~/.dillo/style.css (see attached patch against dillo_hyphenation). Cheers, Johannes

Sept. 5, 2012

hyphenation in dillo

by jcid＠dillo.org

On Tue, Sep 04, 2012 at 08:55:19PM +0200, Johannes Hofmann wrote: > On Tue, Sep 04, 2012 at 06:46:30PM +0200, Sebastian Geerken wrote: > > On Tue, Sep 04, Johannes Hofmann wrote: > > > On Tue, Sep 04, 2012 at 02:36:29PM +0200, Sebastian Geerken wrote: > > > > > I'm mostly finished with cleaning up the calculation of extremes (used > > > > > for tables). This should already work now, please test it again. > > > > > > > > Just pushed some more changes; should be complete now. Please test > > > > thoroughly. Several sites I visit don't trigger hyphenation because they lack the "lang" attribute. I'm experimenting with a very simple language guess routine, to get an idea of how it could help in this regard. @Johannes, This function samples text from the parser, and it may fall anywhere on the CSS tree. How can I set it for the HTML element so it is inherited from there? I've tried: html->styleEngine->setNonCssHint( PROPERTY_X_LANG, CSS_TYPE_STRING, html->lang); which seems to set it for the current element only. and html->styleEngine->restyle (); with no good result. TIA. -- Cheers Jorge.-

Sept. 5, 2012

hyphenation in dillo

by Johannes.Hofmann＠gmx.de

On Tue, Sep 04, 2012 at 06:46:30PM +0200, Sebastian Geerken wrote: > On Tue, Sep 04, Johannes Hofmann wrote: > > On Tue, Sep 04, 2012 at 02:36:29PM +0200, Sebastian Geerken wrote: > > > > I'm mostly finished with cleaning up the calculation of extremes (used > > > > for tables). This should already work now, please test it again. > > > > > > Just pushed some more changes; should be complete now. Please test > > > thoroughly. > > > > Nice! lwn.net and wikipedia look good for me now, but the text on the > > splash screen seems a bit squeezed. > > Now I see what you mean: the too narrow text blocks. Fixed now. Cool, works for me as well now! Johannes

Sept. 4, 2012

hyphenation in dillo

by corvid＠lavabit.com

Sebastian wrote: > On Tue, Sep 04, corvid wrote: > > Sebastian wrote: > > > > I'm mostly finished with cleaning up the calculation of extremes (used > > > > for tables). This should already work now, please test it again. > > > > > > Just pushed some more changes; should be complete now. Please test > > > thoroughly. > > > > I'm noticing occasional overlapping of text with alt text > > (example from linuxquestions.org: http://www.dillo.org/test/alt_text.jpg ), > > and, when I load those images, I see that there's some clipping > > ( http://www.dillo.org/test/img_clipped.jpg ). > > Can you reproduce this with the latest version? It may have been fixed > with the last change. I can still reproduce it.

Sept. 4, 2012

hyphenation in dillo

by sgeerken＠dillo.org

On Tue, Sep 04, corvid wrote: > Sebastian wrote: > > > I'm mostly finished with cleaning up the calculation of extremes (used > > > for tables). This should already work now, please test it again. > > > > Just pushed some more changes; should be complete now. Please test > > thoroughly. > > I'm noticing occasional overlapping of text with alt text > (example from linuxquestions.org: http://www.dillo.org/test/alt_text.jpg ), > and, when I load those images, I see that there's some clipping > ( http://www.dillo.org/test/img_clipped.jpg ). Can you reproduce this with the latest version? It may have been fixed with the last change. Sebastian

Sept. 4, 2012

hyphenation in dillo

by sgeerken＠dillo.org

On Tue, Sep 04, Johannes Hofmann wrote: > On Tue, Sep 04, 2012 at 02:36:29PM +0200, Sebastian Geerken wrote: > > > I'm mostly finished with cleaning up the calculation of extremes (used > > > for tables). This should already work now, please test it again. > > > > Just pushed some more changes; should be complete now. Please test > > thoroughly. > > Nice! lwn.net and wikipedia look good for me now, but the text on the > splash screen seems a bit squeezed. Now I see what you mean: the too narrow text blocks. Fixed now. Sebastian

Sept. 4, 2012

hyphenation in dillo

by corvid＠lavabit.com

Sebastian wrote: > > I'm mostly finished with cleaning up the calculation of extremes (used > > for tables). This should already work now, please test it again. > > Just pushed some more changes; should be complete now. Please test > thoroughly. I'm noticing occasional overlapping of text with alt text (example from linuxquestions.org: http://www.dillo.org/test/alt_text.jpg ), and, when I load those images, I see that there's some clipping ( http://www.dillo.org/test/img_clipped.jpg ).

Sept. 4, 2012

hyphenation in dillo

by sgeerken＠dillo.org

On Tue, Sep 04, corvid wrote: > On http://www.dillo.org/stats/ , it breaks between the month and year. Fixed. Look at the change: it's simple. Unlike before, breaks are also prohibited for "white-space: pre-wrap"; this is how I interpret the CSS spec. Sebastian

Sept. 4, 2012

hyphenation in dillo

by corvid＠lavabit.com

Sebastian wrote: > Just pushed some more changes; should be complete now. Please test > thoroughly. On http://www.dillo.org/stats/ , it breaks between the month and year.

Sept. 4, 2012

hyphenation in dillo

by sgeerken＠dillo.org

> > Just pushed some more changes; should be complete now. Please test > > thoroughly. > > Nice! lwn.net and wikipedia look good for me now, but the text on the > splash screen seems a bit squeezed. I see no difference to the current main repository. I investigated this already some days ago, and found out that paragraphs are handled differenty. Defining a margin for paragraphs works, OTOH. So this is no reason to delay merging. :-) Sebastian

Sept. 4, 2012