- Dillo-dev - lists.mailman3.com

Tooltip bugs revisited

by jcid＠dillo.org

On Tue, Dec 11, 2012 at 04:30:59AM +0000, corvid wrote: > Jorge wrote: > > So far (and despite the warning inside FLTK), I've experimented > > with a custom tooltip handling class, and a couple custom UI > > widgets, that seem to work well together (i.e. solve the problem > > without the workaround :) ). > > I see that this code is derived from the code at > http://seriss.com/people/erco/fltk/#SliderTooltip > I think we should mention that at the tops of the tipwin files and > in AUTHORS. Yes, I wrote to Greg and got his answer stating that all the code there is public domain, and that he'll soon add some lines declaring it so in his "Cheat Page". -- Cheers Jorge.-

Dec. 17, 2012

Dpi_connect_socket retry

by jcid＠dillo.org

Hi, Finally I had the time to review this issue in more detail... On Sun, Dec 09, 2012 at 02:58:43PM +0400, p37sitdu at lavabit.com wrote: > Dpi_connect_socket function from src/IO/dpi.c (also duplicated in > test/cookies.c) has retry argument. It is set to TRUE on first call, > and Dpi_connect_socket calls itself recursively with retry == FALSE in > case of error. > > This retry function is not working. If connection fails, at line 645 > sock_fd is set, but ret is still set to -1. Even if the second attempt > to connect is successful, -1 is returned and conected sock_fd is lost. > > It is possible to fix it by adding "ret = sock_fd", but I think it is > better to just remove retries completely. It is unlikely that > connecting using loopback interface will fail on first try and succeed > on retry. Yes, this code is obsolete now. It was meant for Unix domain sockets (when dpis/dpid used them). Sometimes the filename lingered in the filesystem after a dpi or server crash. With unlink&retry it was possible to recover then. Details in patchset: 7faa2c7a544f (Nov, 2009 ;) Removed in the repo (see below). > Also, comment says "the server closes sock_fd on error". However, > sock_fd should still be closed by client to free allocated file > descriptor. OS don't know if Dillo is going to read from it (in which > case error such as ECONNRESET should happen) so file descriptor can't > be reused. > > File descriptor should be closed in case of error in a_Dpip_build_cmd > too. The file descriptor is properly closed by its CCC afterwards (Visible by defining VERBOSE in chain.c). The CCC manages the error propagation/handling, in both the requesting and answer branches. > Patch to fix this function and its calls in src/IO/dpi.c and > test/cookies.c is attached. No need to fix, it works properly. -- Cheers Jorge.-

Dec. 16, 2012

Extensions for hyphenation

by corvid＠lavabit.com

Sebastian wrote: > On Sat, Dec 08, corvid wrote: > > Sebastian wrote: > > > On Fri, Dec 07, corvid wrote: > > > > For instance, > > > > > > > > dillo -geometry 850x700 http://fltk.org > > > > > > > > makes the names of the snapshots very narrow, and if I try > > > > > > > > penalty_hyphen=inf > > > > > > > > part of the fltk-2 snapshot link is obscured by the image. > > > > I still see this, or at least the penalty_hyphen=inf case. I didn't try > > the default penalty_hyphen case. > > I was finally able to reproduce this, by using "trickle". > > It is fixed now, at least for me; please test it again. It's working :)

Dec. 16, 2012

Extensions for hyphenation

by sgeerken＠dillo.org

On Sat, Dec 08, corvid wrote: > Sebastian wrote: > > On Fri, Dec 07, corvid wrote: > > > For instance, > > > > > > dillo -geometry 850x700 http://fltk.org > > > > > > makes the names of the snapshots very narrow, and if I try > > > > > > penalty_hyphen=inf > > > > > > part of the fltk-2 snapshot link is obscured by the image. > > I still see this, or at least the penalty_hyphen=inf case. I didn't try > the default penalty_hyphen case. I was finally able to reproduce this, by using "trickle". It is fixed now, at least for me; please test it again. As far as I see, this is the last bug related to hypenation, at least the last one relevant for the next release. Sebastian

Dec. 16, 2012

[patch] Gopher DPI

by jcid＠dillo.org

On Sun, Dec 16, 2012 at 12:31:19AM +0400, p37sitdu at lavabit.com wrote: > Now search works properly. URL looks like > gopher://gopher.floodgap.com:70/7/v2/vs?query=dillo, but ?query is > replaced with %09 internally. I have not found the way to make > redirect. The patch is ready to be commited and should not break > anything as it is a separate DPI that is only called for gopher URLs. > > I will try to implement search without forms by adding input dialogs > as a separate patch in my patch queue on top of it. User experience > will be similar to lynx: you open the page and then browser asks you > for search query. Are you sure a dialog is better than a simple form (as with bookmarks)? I'll review the patch as soon as I find the necessary time. So far from what I've read in the list, it looks OK. Just some friendly advice: don't rush; you'll find plenty of options along the way, and independent as a dpi is, it looks much like it will make it into the next release. > Also patch for src/IO/dpi.c is attached to make Dpi_parse_token more > robust as I accedently made it segfault during development of gopher > DPI. Yes, there're subtle interactions and assumptions in dpip. That's why I'd like to take the necessary time to review the FD leak patch and then the gopher dpi. -- Cheers Jorge.-

Dec. 15, 2012

[patch] Gopher DPI

by p37sitdu＠lavabit.com

On Sat, Dec 15, 2012 at 09:27:14PM +0100, Johannes Hofmann wrote: I have added setbuf(fp, NULL) instead. Fixed patch is attaced. > Took me quite a while to figure this out ... > Anyway, with these tiny modifications it works nice for me and I'd > like to commit it. Let me know when you think it's ready. I think attached patch is ready to be commited, I will develop code that changes dillo internals (DPI api) as a separate patch.

Dec. 15, 2012

[patch] Gopher DPI

by p37sitdu＠lavabit.com

Now search works properly. URL looks like gopher://gopher.floodgap.com:70/7/v2/vs?query=dillo, but ?query is replaced with %09 internally. I have not found the way to make redirect. The patch is ready to be commited and should not break anything as it is a separate DPI that is only called for gopher URLs. I will try to implement search without forms by adding input dialogs as a separate patch in my patch queue on top of it. User experience will be similar to lynx: you open the page and then browser asks you for search query. Also patch for src/IO/dpi.c is attached to make Dpi_parse_token more robust as I accedently made it segfault during development of gopher DPI.

Dec. 15, 2012

[patch] Gopher DPI

by Johannes.Hofmann＠gmx.de

very cool! To get it working on DragonFlyBSD I had to add a fflush() after the fprintf() on the socket. Also the fdopen() flags had to be changed to w+ (from man page: ``w+'' Open for reading and writing.). Otherwise the fflush() doesn't work. There is the following comment in the fflush code: /* * There is disagreement about the correct behaviour of * fflush() * when passed a file which is not open for reading. * According to * the ISO C standard, the behaviour is undefined. * Under linux, such an fflush returns success and has no * effect; * under Windows, such an fflush is documented as behaving * instead * as fpurge(). * Given that applications may be written with the * expectation of * either of these two behaviours, the only safe * (non-astonishing) * option is to return EBADF and ask that applications be * fixed. */ Took me quite a while to figure this out ... Anyway, with these tiny modifications it works nice for me and I'd like to commit it. Let me know when you think it's ready. Cheers, Johannes

Dec. 15, 2012

[patch] Gopher DPI

by p37sitdu＠lavabit.com

I am trying to make search work. Now (latest version of patch is included) I process type '7' (FullText search) is the same as '1'. So link "Search Veronica-2" on [1]/ is just a link that leads to [2]. Search terms can be added manually, like [3]. It works and it is what gopher URI Scheme RFC4266 says. DPI dialogs don't support text input, though it should not be hard to add. Another option is HTML forms and redirections. [1] gopher://gopherproject.org:70/1/ [2] gopher://gopher.floodgap.com:70/7/v2/vs [3] gopher://gopher.floodgap.com:70/7/v2/vs%09dillo

Dec. 15, 2012

[patch] Gopher DPI

by p37sitdu＠lavabit.com

Updated patch a little to support URLs without path (like gopher://gopher.quux.org) Made functions static, added newlines to messages etc.

Dec. 15, 2012