- Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] [PATCH] new version of tab patch, fixes segfault on bookmark

by Victor Sahlstedt

On Tue, 1 Jul 2003 16:19:13 +0200 Frank de Lange <frank(a)localhost.localdomain> wrote: > Sigh... I put the wrong version of the patch on the site... the version on the > site has the definition in the old place. > > So, next version is now on the site: > > http://www.geocities.com/ikbenfrank/dillo-20030701-tabs.patch.gz > 40887 bytes > 20dffde9c0e5f2134492e138ee707cdd (as is) > 09b454800f1b53bd83428a2b62d3e618 (uncompressed) This one worked out-of-the-box. I was just about to suggest a few things but I noticed that you'd pretty much covered it all; > Functionality > ------------- > - focus tab contents on tab switch (so key navigation works correctly > without having to first click in the tab pane) > - focus location bar on switch to empty tab/new tab > - new empty tab should show/focus, even when 'tab load in background' > is set > - after tab delete, switch to NEXT tab instead of PREVIOUS (like > mozilla) - Victor

July 2, 2003

Re: [Dillo-dev] Hangin with high CPU load

by Jorge Arellano Cid

Hi there! On Thu, 19 Jun 2003, David McKee wrote: > Folks, > I've been using dillo for a number of months now, and it has become my > first choice browser--I switch to mozilla or opera only when I have to > java, javascript, http/1.1 authentication, ssl and the like. I like that part! :) Well, this thread has had a lot of post, and bugfixes! The problem is that we don't yet find a way to reproduce the original problem, that is: > Of late dillo has started getting into a state where all progress stop in > all open windows, and it sits on the CPU---keeping my load average at 1.0 > [...] > > N.B. I seems to happen most when I have opened several links in new > windows in rapid succession. (I also hinted howto try to reproduce it in this thread). Now a "blind fix" is in the CVS. That is, new code that fixes all the lose ends in IO.c and file.c, I was able to find, about EINTR. If some of the file descriptor, for instance, happened to be interrupted inside the 'close' call (returning EINTR), and remained open, could be the cause of the CPU HOG (by not being eliminated from the FDset inside GTK+ code). What does it mean? If someone finds a way to reproduce the HOG (with older code) and it doesn't happen with the CVS, then it's fixed! If someone reproduces the bug with the newest CVS code, then the bug is hiding elsewhere... Cheers Jorge.-

July 2, 2003

Re: [Dillo-dev] chinese patch and dillo's bug

by Sebastian Geerken

On Tue, Jul 01, ronnie wrote: > 2)when you clicking mouse and the draging it to copy something will > cause the dillo crash.why? Because you came upon a bug ;-) Please do the the following when reporting bugs: 1. Try to reproduce them in in the CVS version. Selection has actually changed quite much since 0.7.2, so it is likely that this particular bug has vanished. 2. Try to describe the bug as precise as possible. If possible, provide an exact description, which makes it possible for me to reproduce, and so fix, the bug. Sebastian

July 1, 2003

Re: [Dillo-dev] selection bug

by Sebastian Geerken

On Tue, Jul 01, Joe Crayne wrote: > click on the image in this page: > > > <html> > <body> > <a href="http://www.google.com"> > <img src="http://www.google.com/images/logo.gif"></a> > </body> > </html> > > > Dillo will segfault. > > Apparently, this is because there is no selectable > content in the page. a_Dw_ext_iterator_new() is > returning NULL at selection.c:152 > > selection->link = a_Dw_ext_iterator_new (it); > selection->link_char = > Selection_correct_char_pos (selection->link, char_pos); > selection->link_number = link; > ret = TRUE; > > So I tried a naive quick fix: > > selection->link = a_Dw_ext_iterator_new (it); > if( selection->link ) > { > selection->link_char = > Selection_correct_char_pos (selection->link, char_pos); > selection->link_number = link; > ret = TRUE; > } > else > ret = FALSE; > > This just moved the bug elsewhere because dillo then > segfaulted when I clicked the image and held the button > down and moved off of it. Selection_switch_link_to_selection() > expects a non NULL iterator. I've just committed a fix, which also changes Selection_switch_link_to_selection(). The best may be to let a_Dw_ext_iterator_new() never return NULL, but instead a special, "empty" DwExtIterator, so that all calling code can expect a valid iterator. This would simplify the code using DwExtIterator, and make it more robust. BTW, the page is invalid HTML, <img> must have a value for the ALT attribute, which whould then prevent the crash ;-) Sebastian

July 1, 2003

java and dillo

by Trevor Warren

Hey guys, Good-day. Have been looking high and low for a browser thats light weight and supports Java. The dillo homepage ain't saying anything about JVM integration, but Freshmeat does mention about JVM on the project page. Can someone please clarify since a project spec demands we need to be looking at a light weight jvm capable browser. Trevor -- ( >- LINUX, It's all about CHOICE -< ) /~\ __ twarren(a)redhat.com __ /~\ | \) / Pre Sales Consultant - Red Hat \ (/ | |_|_ \ 9820349221(M) | 22881326(O) / _|_| \___________________________________/

July 1, 2003

Re: [Dillo-dev] [PATCH] new version of tab patch, fixes segfault on bookmark

by Andreas Schweitzer

> So, next version is now on the site: > > http://www.geocities.com/ikbenfrank/dillo-20030701-tabs.patch.gz > 40887 bytes > 20dffde9c0e5f2134492e138ee707cdd (as is) > 09b454800f1b53bd83428a2b62d3e618 (uncompressed) And again on http://www.hs.uni-hamburg.de/~stcd102/dillo-20030701-tabs.patch.gz Cheers Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

July 1, 2003

Re: [Dillo-dev] [PATCH] new version of tab patch, fixes segfault on bookmark

by Frank de Lange

On Tue, Jul 01, 2003 at 04:07:21PM -0700, Victor Sahlstedt wrote: > I commented out the stuff in the function preceeding gboolean hide_tabs and it compiled. > > Great work by the way, I find non-tabbed browsers hardly usable for every-day-usage and as > my window manager of choice is the tabless evilwm it's been a pain uptil now. > > Tack! > > - Victor Sigh... I put the wrong version of the patch on the site... the version on the site has the definition in the old place. So, next version is now on the site: http://www.geocities.com/ikbenfrank/dillo-20030701-tabs.patch.gz 40887 bytes 20dffde9c0e5f2134492e138ee707cdd (as is) 09b454800f1b53bd83428a2b62d3e618 (uncompressed) If the previous version worked for you, there is no need to upgrade as the changes are only 'code-cosmetical'... As always, keep an eye on the site for the latest version. This patch was made against yesterday's CVS (20030701). Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

July 1, 2003

Re: [Dillo-dev] [PATCH] new version of tab patch, fixes segfault on bookmark

by Frank de Lange

On Tue, Jul 01, 2003 at 02:36:25PM -0700, Victor Sahlstedt wrote: > Hi Frank, > I get the following error while compiling the patched Dillo (GCC 2.95.3); > > tab.c: In function `a_Tab_visibility_update': > tab.c:317: syntax error before `hide_tabs' > tab.c:328: `hide_tabs' undeclared (first use in this function) > tab.c:328: (Each undeclared identifier is reported only once > tab.c:328: for each function it appears in.) > gmake[3]: *** [tab.o] Error 1 > gmake[2]: *** [all-recursive] Error 1 > gmake[1]: *** [all-recursive] Error 1 > gmake: *** [all] Error 2 This is with the latest version of the patch (the one mentioned in my last message)? Check if the function begins with: (src/tab.c:301-307) /* * set visibility of tab bar */ void a_Tab_visibility_update(BrowserWindow *bw) { gboolean hide_tabs; See, that is where hide_tabs is declared. Your line numbers are off by 10. Makesme wonder if you have the right version... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

July 1, 2003

Re: [Dillo-dev] [PATCH] new version of tab patch, fixes segfault on bookmark

by Andreas Schweitzer

> I uploaded a new version of the patch to the geocities page (block those > popup/under/down/everywhere ads to your heart's content...): > > http://www.geocities.com/ikbenfrank/dillo-20030630-tabs.patch.gz Mirror on http://www.hs.uni-hamburg.de/~stcd102/dillo-20030630-tabs.patch.gz Cheers Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

July 1, 2003

[PATCH] new version of tab patch, fixes segfault on bookmark

by Frank de Lange

Hey'all, Had a minute to spare and a wireless connection in a (very smoky... a filty habit it is indeed...) coffee shop in Cambridge/UK, so I fixed the buglet which made the tabbed version of Dillo segfault on bookmark add. I also cleaned up the code a little, moved some things around to satisfy C99, removed generated files from the patch, etc. No big functional changes (unless you call 'not crashing anymore on bookmark add' a functional change...) I uploaded a new version of the patch to the geocities page (block those popup/under/down/everywhere ads to your heart's content...): http://www.geocities.com/ikbenfrank/dillo-20030630-tabs.patch.gz 41210 bytes 4e96e122819d9d61a61a07a2cb8557e4 (as is) 27b9923f410a28224957fa40474c901a (uncompressed) I removed the old patch file, and replaced it with a note telling people to download the latest version instead. In general, I keep the patch file on the geocities site up to date, so look there (http://www.geocities.com/ikbenfrank/) for the last version before submitting bug reports to me/to the list. Also, I removed the generated files (configure, makefile.in) from the patch. So, DO NOT FORGET TO RUN ./autogen.sh after patching! The patch is against the 20030630 CVS version of Dillo. As long as there are no big changes to CVS which touch the tab patch, I will try to follow CVS releases. If this should change before the tab patch is committed, I'll keep to the last CVS release which works with the patch. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

July 1, 2003