- Dillo-dev - lists.mailman3.com

Patch to allow setting of initial position

by Jan Dittmer

Hi, for a TV Terminal I needed dillo to come up at a different position than 0,0. As there is no window manager running I wrote a small patch which allows to set the initial position of the upper left corner. Essentially it just clones the geometry code and adds a config option position=<xpos>x<ypos>. If it is not set or 0x0 specified it just takes it's default position. Perhaps this is of some use to anyone else. (Patch is against 0.7.3) Thanks, Jan diff -u org/src/dillo.c jan/src/dillo.c --- org/src/dillo.c Tue Jul 22 22:51:22 2003 +++ jan/src/dillo.c Fri Nov 28 14:34:35 2003 @@ -268,6 +268,8 @@ /* a_Nav_init() has been moved into this call because it needs to be * initialized with the new browser_window structure */ bw = a_Interface_browser_window_new(prefs.width, prefs.height, xid); + if ((prefs.xpos + prefs.ypos) > 0) + gtk_widget_set_uposition(bw->main_window, prefs.xpos, prefs.ypos); a_Bookmarks_init(); diff -u org/src/prefs.c jan/src/prefs.c --- org/src/prefs.c Mon Jul 7 17:40:15 2003 +++ jan/src/prefs.c Fri Nov 28 14:39:21 2003 @@ -35,6 +35,7 @@ guint token; } symbols[] = { { "geometry", DRC_TOKEN_GEOMETRY }, + { "position", DRC_TOKEN_POSITION }, { "http_proxy", DRC_TOKEN_PROXY }, { "no_proxy", DRC_TOKEN_NOPROXY }, { "link_color", DRC_TOKEN_LINK_COLOR }, @@ -114,6 +115,18 @@ } } break; + case DRC_TOKEN_POSITION: { + gchar *ptr, *str = scanner->value.v_string; + gint xpos, ypos; + + if ( (ptr = strchr(str, 'x')) && (xpos = strtol(str,NULL,10)) && + (ypos = strtol(++ptr,NULL,10)) ){ + prefs.xpos = xpos; + prefs.ypos = ypos; + } + } + break; + case DRC_TOKEN_PROXY: a_Url_free(prefs.http_proxy); prefs.http_proxy = a_Url_new(scanner->value.v_string, NULL, 0, 0); @@ -329,6 +342,8 @@ prefs.width = D_GEOMETRY_DEFAULT_WIDTH; prefs.height = D_GEOMETRY_DEFAULT_HEIGHT; + prefs.xpos = D_GEOMETRY_DEFAULT_XPOS; + prefs.ypos = D_GEOMETRY_DEFAULT_YPOS; prefs.http_proxy = NULL; prefs.no_proxy = NULL; prefs.no_proxy_vec = NULL; diff -u org/src/prefs.h jan/src/prefs.h --- org/src/prefs.h Thu Jul 10 00:00:34 2003 +++ jan/src/prefs.h Fri Nov 28 14:37:17 2003 @@ -10,6 +10,8 @@ #define DILLO_HOME "http://www.dillo.org/" #define D_GEOMETRY_DEFAULT_WIDTH 640 #define D_GEOMETRY_DEFAULT_HEIGHT 550 +#define D_GEOMETRY_DEFAULT_XPOS 0 +#define D_GEOMETRY_DEFAULT_YPOS 0 #define DW_COLOR_DEFAULT_GREY 0xd6d6d6 #define DW_COLOR_DEFAULT_BLACK 0x000000 @@ -27,6 +29,7 @@ typedef enum { DRC_TOKEN_FIRST = G_TOKEN_LAST, DRC_TOKEN_GEOMETRY, + DRC_TOKEN_POSITION, DRC_TOKEN_PROXY, DRC_TOKEN_NOPROXY, DRC_TOKEN_LINK_COLOR, @@ -70,6 +73,8 @@ struct _DilloPrefs { gint width; gint height; + gint xpos; + gint ypos; DilloUrl *http_proxy; gchar *no_proxy; gchar **no_proxy_vec;

Nov. 28, 2003

Re: about feedback

by Indan Zupancic

Hi, To clear up some things to avoid misunderstandings: I will continue keeping the https patch up to date, no matter what else I'll do. As there seems to be enough demand, I will update the installer once a while too. > Sometimes, it took quite some time before Jorge looked at the patches and > fixed or accepted (or rejected) them. I had zero feedback the last 3 weeks, not very motivating. Merely a short email to say that it will be looked at or that it has no priority would be appreciated, I mean, _any_ feedback is. Now it's just a black hole where you pour patches into. Don't forget that it's their program you spend time writing a patch for, but currently it feels like it's a privilege to have your patch integreted in Dillo, even expecting some feedback is asked too much for. May I come to the conclusion that I should spend my time on something else instead of wasting it on Dillo? If they aren't willing to spend 10 minutes writing a short email, why should I spend hours or even days writing and testing some Dillo patch? I don't expect the Dillo developers to just integrate my https patch or so, I wouldn't either without a lot testing and making sure it's stable, but I would expect that they give some feedback about it, I mean, it's their program, they wrote it, so I would expect that they know the code better, so could give good advice about pitfals etc. Or just simply say "no, we don't like your approach, let us keep using wget for https". But for the IO.c patch it's a different case, all it is is a cleanup of their code, naive as I am, I would expected them to want cleaner code, even if it's a small step like I made with the patch. > Anyways, that's how it works here. I got used to it. Working with one feedback per month is impossible if you want to do major IO cleanups as I want. > However, the core developers probably need to read all mails and keep track > with a whole lot more patches - therefore, even they may miss one or two > patches/suggestions. Whole lot more patches? Looking at the CVS activity then I'm not too sure. Also there is a reasonable amount of old patches for Dillo already: multiple https implementations (I only found the last one when I started on mine), UTF8 support, server/client mode, and other I can't remember/didn't found. And looking at the mailing list, they didn't get much feedback either. All those people hooked off as far as I can tell, except Frank. > So, please stay with the project ... hmmm ... some semi-serious > suggestion ;-) : do some christmas shopping, enjoy the holidays > and wait for the feedback from the developers ...:-) Christmas shopping? Need money for that I suppose. Enjoy the holidays? Have no job, so it's always holiday for me ;-). And don't know where you live, but christmas is just a commercial paradise here. > However, overall, I like the dpi idea. There are certain advantages: As with many things, the idea is good, the implementating isn't, IMHO. > - For me, it makes it rather easy to contribute, since I need to only > write a program and not to dig through dillo's code (if only I did > write more than my simplistic finger plugin ;-) ...) True, but if I look at the default plugins they're not as easy to make as it should be. > - The concept of extra processes instead of extra code has advantages : > - with the download plugin being a seperate process you can even log > out of X while the download continues (e.g. over night on dial-up). That is true. I don't know if you noticed, but if you want to use the current download plugin, you need to start up 3 processes... First, the dpid, then the download dpi, which in turn starts wget. I'm so naive to think it could be only wget, with a simple "handle this protocol with this program with this parameters in this way" system. This way you could also startup your favourite email program when encountering mailto:, to give just one example. Don't forget that there is specific code in Dillo to handle certain plugins like the bookmark and download plugins. The plugins aren't really standalone. Sure, it's not finished yet, but the current dpi system can't solve that problem. What I would do is make a clear library plugin api, then you can implement the download and bookmark GUI in a library, and let the library start up wget. You can even implement a library plugin that handels the dpi plugins, instead of adding the code to Dillo's core as now happened (I mean moving the dpi code into a library plugin). This way you can have relative simple and small library plugins that don't do much, which let external programs like wget do the real work. Or add the features directly in the library plugin, whatever you want. > - the bookmark plugin allows for a real bookark server ! This is something > I am contemplating about : wouldn't it be cool if you could access the > same bookamrks from different machines via a sophisticated bookmark server > ? No, it doesn't. Not with the current dpi system anyway. As I said in an earlier email, the bookmark plugin should probably be a real, standalone daemon, so that it can also be used with other browser, from different pc's. It can even be hosted by some site, so that wherever you go, you can get your bookmarks :). Of course Dillo could have special support for it, so that it's easier to add bookmarks, and that it's started when it isn't running yet, but the main point is that the bookmark server won't be a dpi plugin, or can't be because you can't use unix sockets as the current dpi system uses now (which is fine for a plugin system, but not when you want to connect to non-local pc's). Greetings, Indan

Nov. 28, 2003

about feedback was: Re: [Dillo-dev] [patch] Cleanup of IO.c

by Andreas Schweitzer

Hi, I post this to the list, so that some other possible future contributor that might get frustrated can find it in the archive :-) > I feel sad and frustrated because of the lack of feedback from the Dillo > developers. I tried to improve Dillo, to add some extra features. Dillo is a > nice browser and I thought that spending my time on it would be appreciated, > but it seems I was wrong. I give up, I'm not going to waste my time on > improving Dillo while all efforts are just ignored or told to be useless > because of the "that mess is fine as it is now" attitude. If the neutral and > obviously (somehow I start doubting that now) improving IO cleanup patch is > ignored, then what chance do I have with cleaning up the CCC horror... I can totally understand you. I, too, sent in patches at times. Not as big as yours, some were useful, some were not. Sometimes, it took quite some time before Jorge looked at the patches and fixed or accepted (or rejected) them. The first time, I was very excited once I submitted the patch. But as time went by and I did not hear anything, I got disappointed, until I finally got feedback - life was good again ;-) ... Anyways, that's how it works here. I got used to it. Also, since Frank and you started contributing great patches, traffic went up quite a bit. I think it's ok, since I skip some threads that I'm not interested in. :-) However, the core developers probably need to read all mails and keep track with a whole lot more patches - therefore, even they may miss one or two patches/suggestions. So, please stay with the project ... hmmm ... some semi-serious suggestion ;-) : do some christmas shopping, enjoy the holidays and wait for the feedback from the developers ...:-) > To give you an idea how bad it is: Unfortunatly I am rather a happy user than a real developer. So, I just read and say "aha" ... Hence, I also could not comment on your cleanup of IO.c > Worst is, making a dpi isn't as simple as making a CGI, as it should be. And > of course the whole dpid construction makes no sense. not really anyway: you > can find all the dpi's the same way as you find the dpid... Sure, dpid has > some minor advantages, but everyhting has _some_ advantages. Currently, I'm just watching the changes to the dpi infrastructure. Sometimes, I too think "hopefully this is not getting too bloated, with two many interfaces". However, overall, I like the dpi idea. There are certain advantages: - For me, it makes it rather easy to contribute, since I need to only write a program and not to dig through dillo's code (if only I did write more than my simplistic finger plugin ;-) ...) - The concept of extra processes instead of extra code has advantages : - with the download plugin being a seperate process you can even log out of X while the download continues (e.g. over night on dial-up). - the bookmark plugin allows for a real bookark server ! This is something I am contemplating about : wouldn't it be cool if you could access the same bookamrks from different machines via a sophisticated bookmark server ? Cheers, Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

Nov. 28, 2003

Re: [Dillo-dev] [patch] Cleanup of IO.c

by Indan Zupancic

Hi, > I do not understand your disapointing very well and maybe because that i sound rude, excuseme then. Go read Dillo's website, go read the new developer info, go read the files in Dillo's doc dir. Then spend a reasonable amount of time coding for Dillo and cleaning up _their_ mess in IO.c. Then send a patch to the mailing list and wait one week. Let's see if you're disappointed or not. Keep in mind that CVS didn't change the last 6 days, and the last few changes were small, and also don't forget that Jorge claims that he's busy with Dillo full time. Dillo claims to have nice, modular, clean code, and then you encounter some ugly code and try to fix it... I'm afraid I sound rude sometimes too, but we're just telling what we think, right? :) Greetings, Indan

Nov. 27, 2003

Re: [Dillo-dev] [patch] Cleanup of IO.c

by Diego Sáenz

In few words: more code and less words. Come on to code it to have something to compare. I will help you if you want and i think that more people in the list will help too. About feedback from developers they are always like that. I think they are busy. I do not understand your disapointing very well and maybe because that i sound rude, excuseme then. Diego. "Indan Zupancic" <indan(a)nul.nu> escribio: > Hello, > > The patch was downloaded 14 times, and zero feedback... Great. I > wanted to cleanup http.c in a similar way, but never mind. > > I feel sad and frustrated because of the lack of feedback from the > Dillo developers. I tried to improve Dillo, to add some extra > features. Dillo is a nice browser and I thought that spending my time > on it would be appreciated, but it seems I was wrong. I give up, I'm > not going to waste my time on improving Dillo while all efforts are > just ignored or told to be useless because of the "that mess is fine > as it is now" attitude. If the neutral and obviously (somehow I start > doubting that now) improving IO cleanup patch is ignored, then what > chance do I have with cleaning up the CCC horror... > > To give you an idea how bad it is: > > There are at least 24 ways of calling a ccc function. That is a > conservative estimation, because I only counted the possible parameter > combinations(values, types), you still need to know which variant of > the many you need to use with a certain module. Also I counted only > the ccc functions of the IO, cache, file, http and dns module, I > didn't count the dpi and capi modules(just didn't come that far). > > This mess means that modules can't communicate transparantly with > eachother, because they need to know exactly which data to give, > implicating that they need to know with which module they're talking. > That makes the whole CCC construction worthless, because one of it > goals, or so I guess, was to have a chain like communication where > linked elements could do their's stuff and notify the next element > without knowing anything specific about eachother. With the current > situation the CCC structure only adds unnecessary complexity to the > overall code, obfuscating it. > > If that's what you want, fine, but then say so, instead of saying that > it's hard to replace. Yes, duh, you made a spaghetti mountain, of > course it's hard to clear that up. I truly hope that the rest of Dillo > is cleaner, and from what I saw of it, the GUI part doesn't look that > bad. > > Next grief: DPI's. > > What was meant like a simple plugin system turned out to become the > sauce over the spaghetti, to stay with the previous metaphor. It seems > like the cache api code handles dpi's differently, at least there is > plenty dpi specific code in the capi.c file, so it seems like it's in > the wrong place. I mean, if it's not part of the cache api, then what > is it doing in that file? capi.c has even it's own CCC function only > for dpi's, so an extra module in a wrapper?? > > Worst is, making a dpi isn't as simple as making a CGI, as it should > be. And of course the whole dpid construction makes no sense. not > really anyway: you can find all the dpi's the same way as you find the > dpid... Sure, dpid has some minor advantages, but everyhting has > _some_ advantages. > > All the dpi code (not including bookmarks.c) is 14K big, just imagine > what you could implement with so much code (native ftp support comes > into mind). Not even talking about how much resources the dpi's use, > because they have such an awkward interface and need to do things that > Dillo already could do, duplicating code and features. > > I'm aware that certain people already wasted too much time on the > current dpi code, so it has zero chance of being changed, I'm not so > naive to think it would. I just give my oppinion on it. I had put my > hope on the IO/CCC mess. > > Sigh, if only Dillo went the GTK2 way, then I could say goodbye > without trouble, but now it seems like Dillo will use FLTK it's even > more depressing. > > --- > > Oh well, enough rambling, if someone wants an updated version of the > installer, then say so. I won't do much with the https patch, because > as it is now it can't be improved much without cleaning up IO, CCC > or/and http, or at least without merging the IOData structures, so > more than synching with CVS and tiny changes won't happen. > > Good luck and take care, > > Indan > > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)lists.auriga.wearlab.de > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Nov. 27, 2003

Re: [Dillo-dev] [patch] Cleanup of IO.c

by Mike Eriksen

On Thu, 27 Nov 2003, Patrick Shanahan wrote: > * Indan Zupancic <indan(a)nul.nu> [11-27-03 13:42]: > > I'm not qualified to comment about the part snipped... The same goes for me too. > > ------ > > > > Oh well, enough rambling, if someone wants an updated version of the > > installer, then say so. I won't do much with the https patch, because > > as it is now it can't be improved much without cleaning up IO, CCC > > or/and http, or at least without merging the IOData structures, so more > > than synching with CVS and tiny changes won't happen. > > I would appreciate an updated version of the installer. > > Thankyou for your contributions. Please reconsider. I too would very much like an updated installer. And I would be really grateful if you would consider to maintain you HTTPS patch as well. I can understand you are disapointed with the lack of feed back from the official developers, but Dillo *is* a very conservative project. Look at Franks frame/tab patch - it has been around for ages and is still "just" an unofficial patch. I would be sad if you leave Dillo all together. I not only need Dillo+frames+HTTPS for myself, but as you can see from my signature, I'm involved in a linux based thin client project and a light web-mail capable web browser is a killer-app to us! And would make quite an impact on the Dillo user base too. Please reconsider. Mike -- Thinstation FAQ maintainer http://thinstation.sourceforge.net - a light, full featured linux based thin client OS

Nov. 27, 2003

Re: [Dillo-dev] [patch] Cleanup of IO.c

by Patrick Shanahan

* Indan Zupancic <indan(a)nul.nu> [11-27-03 13:42]: I'm not qualified to comment about the part snipped... > ------ > > Oh well, enough rambling, if someone wants an updated version of the > installer, then say so. I won't do much with the https patch, because > as it is now it can't be improved much without cleaning up IO, CCC > or/and http, or at least without merging the IOData structures, so more > than synching with CVS and tiny changes won't happen. I would appreciate an updated version of the installer. Thankyou for your contributions. Please reconsider. -- Patrick Shanahan Registered Linux User #207535 http://wahoo.no-ip.org @ http://counter.li.org

Nov. 27, 2003

Re: [Dillo-dev] [patch] Cleanup of IO.c

by Indan Zupancic

Hello, The patch was downloaded 14 times, and zero feedback... Great. I wanted to cleanup http.c in a similar way, but never mind. I feel sad and frustrated because of the lack of feedback from the Dillo developers. I tried to improve Dillo, to add some extra features. Dillo is a nice browser and I thought that spending my time on it would be appreciated, but it seems I was wrong. I give up, I'm not going to waste my time on improving Dillo while all efforts are just ignored or told to be useless because of the "that mess is fine as it is now" attitude. If the neutral and obviously (somehow I start doubting that now) improving IO cleanup patch is ignored, then what chance do I have with cleaning up the CCC horror... To give you an idea how bad it is: There are at least 24 ways of calling a ccc function. That is a conservative estimation, because I only counted the possible parameter combinations (values, types), you still need to know which variant of the many you need to use with a certain module. Also I counted only the ccc functions of the IO, cache, file, http and dns module, I didn't count the dpi and capi modules (just didn't come that far). This mess means that modules can't communicate transparantly with eachother, because they need to know exactly which data to give, implicating that they need to know with which module they're talking. That makes the whole CCC construction worthless, because one of it goals, or so I guess, was to have a chain like communication where linked elements could do their's stuff and notify the next element without knowing anything specific about eachother. With the current situation the CCC structure only adds unnecessary complexity to the overall code, obfuscating it. If that's what you want, fine, but then say so, instead of saying that it's hard to replace. Yes, duh, you made a spaghetti mountain, of course it's hard to clear that up. I truly hope that the rest of Dillo is cleaner, and from what I saw of it, the GUI part doesn't look that bad. Next grief: DPI's. What was meant like a simple plugin system turned out to become the sauce over the spaghetti, to stay with the previous metaphor. It seems like the cache api code handles dpi's differently, at least there is plenty dpi specific code in the capi.c file, so it seems like it's in the wrong place. I mean, if it's not part of the cache api, then what is it doing in that file? capi.c has even it's own CCC function only for dpi's, so an extra module in a wrapper?? Worst is, making a dpi isn't as simple as making a CGI, as it should be. And of course the whole dpid construction makes no sense. not really anyway: you can find all the dpi's the same way as you find the dpid... Sure, dpid has some minor advantages, but everyhting has _some_ advantages. All the dpi code (not including bookmarks.c) is 14K big, just imagine what you could implement with so much code (native ftp support comes into mind). Not even talking about how much resources the dpi's use, because they have such an awkward interface and need to do things that Dillo already could do, duplicating code and features. I'm aware that certain people already wasted too much time on the current dpi code, so it has zero chance of being changed, I'm not so naive to think it would. I just give my oppinion on it. I had put my hope on the IO/CCC mess. Sigh, if only Dillo went the GTK2 way, then I could say goodbye without trouble, but now it seems like Dillo will use FLTK it's even more depressing. --- Oh well, enough rambling, if someone wants an updated version of the installer, then say so. I won't do much with the https patch, because as it is now it can't be improved much without cleaning up IO, CCC or/and http, or at least without merging the IOData structures, so more than synching with CVS and tiny changes won't happen. Good luck and take care, Indan

Nov. 27, 2003

Re: [Dillo-dev] patch: toggle force_my_colors

by Paul Pelzl

On Wed, Nov 26, 2003 at 02:06:20PM +0100, Frank de Lange wrote: > >I have attached a pair of Dillo patches. They add a toggle-able menu > >item to the right-button context menu, which enables/disables the > >force_my_colors preference on the fly. I find this useful for some > >occasional websites that Dillo renders rather poorly, as well as sites > >that simply choose a horrid color scheme. > > > >The first patch applies on top of Frank's monster patch v15; the second > >applies against Dillo CVS of 20031119. I hope others find it useful. > > > >Paul > > > > > I can add this to the tab/frame patch if you want, so you don't have to > produce two different versions. I would modify it slightly, so the > option works for all frames (not just the one in which the menu was > popped up). I would also add a DILLO_COMMAND, and I move the menu option > (the content menu is getting to big I think). OK Frank, I'll leave it in your capable hands. :-) Paul

Nov. 26, 2003

Re: [Dillo-dev] patch: toggle force_my_colors

by Frank de Lange

Paul Pelzl wrote: >Hi folks, > >I have attached a pair of Dillo patches. They add a toggle-able menu >item to the right-button context menu, which enables/disables the >force_my_colors preference on the fly. I find this useful for some >occasional websites that Dillo renders rather poorly, as well as sites >that simply choose a horrid color scheme. > >The first patch applies on top of Frank's monster patch v15; the second >applies against Dillo CVS of 20031119. I hope others find it useful. > >Paul > > I can add this to the tab/frame patch if you want, so you don't have to produce two different versions. I would modify it slightly, so the option works for all frames (not just the one in which the menu was popped up). I would also add a DILLO_COMMAND, and I move the menu option (the content menu is getting to big I think). Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 26, 2003