- Dillo-dev - lists.mailman3.com

[patch] fix warning in html.cc

by corvid＠lavabit.com

Johannes wrote: > html.cc: In function 'void a_Html_form_event_handler(void*, form::Form*, void*)': > html.cc:4331: warning: 'input' may be used uninitialized in this function Oops. I thought it was strange that I hadn't gotten this warning, and now I learn that one does not get -Wuninitialized if -O is turned off. I've been compiling without -O to make debugging easy.

April 14, 2008

[patch] fix warning in html.cc

by Johannes.Hofmann＠gmx.de

Hi, html.cc: In function 'void a_Html_form_event_handler(void*, form::Form*, void*)': html.cc:4331: warning: 'input' may be used uninitialized in this function can be fixed with attached patch. Please review. Cheers, Johannes

April 14, 2008

patch: image inputs

by corvid＠lavabit.com

It works on the sites I tried, and the data sent looks right for other cases, but: - To get click position, I used event_x() and event_y() in fltkui.cc because they happened to have the right values in them and I didn't know the proper place to look for this information. - If the image could not be loaded and you click on the alt text, the click position is sent, even though it's not meaningful. - I don't prevent the image from being loaded even when automatic image loading is disabled (but I'm the only person who would notice anyway). (I would have to be able to get button 3 to bring up the image menu.)

April 14, 2008

[patch] make ComplexButton work

by jcid＠dillo.org

On Sun, Apr 13, 2008 at 09:24:35PM +0200, Johannes Hofmann wrote: > Hi, > > this patch fixes ComplexButton - at least it works here now :-) > The patch includes the ComplexButton destructor proposed by place > and enables the ComplexButton code in dw-ui-test. > It requires my last FltkViewBase::draw() patch. OK. Committed both. -- Cheers Jorge.-

April 14, 2008

[patch] cleanup FltkViewBase::draw

by jcid＠dillo.org

On Sun, Apr 13, 2008 at 09:05:35PM +0200, Johannes Hofmann wrote: > Hi, > > here comes a cleanup of FltkViewBase::draw(). It had grown too > complicated... > This patch also fixes two issues with nested views as they will > exist with ComplexButtons. Committed. -- Cheers Jorge.-

April 13, 2008

[patch] make ComplexButton work

by corvid＠lavabit.com

Johannes wrote: > this patch fixes ComplexButton - at least it works here now :-) It's working for me, too! :)

April 13, 2008

[patch] make ComplexButton work

by Johannes.Hofmann＠gmx.de

Hi, this patch fixes ComplexButton - at least it works here now :-) The patch includes the ComplexButton destructor proposed by place and enables the ComplexButton code in dw-ui-test. It requires my last FltkViewBase::draw() patch. Cheers, Johannes

April 13, 2008

[patch] cleanup FltkViewBase::draw

by Johannes.Hofmann＠gmx.de

Hi, here comes a cleanup of FltkViewBase::draw(). It had grown too complicated... This patch also fixes two issues with nested views as they will exist with ComplexButtons. Cheers, Johannes

April 13, 2008

Re: patch: reset input

by jcid＠dillo.org

Hi, Committed -- Cheers Jorge.-

April 13, 2008

Re: patch: ISINDEX

by jcid＠dillo.org

On Sun, Apr 13, 2008 at 02:33:00AM +0000, corvid wrote: > Yeah, so very important... > > An isindex page: http://www.math.ncu.edu.tw/~shann/bcc16/7/html/isindex.cgi > Committed! Mmmm, ISINDEX, an old method that brings me back good memories. -- Cheers Jorge.-

April 13, 2008