- Dillo-dev - lists.mailman3.com

Re: the last patch that I sent you BREAKS isindex.

by jcid＠dillo.org

On Thu, Apr 17, 2008 at 06:17:04AM +0000, corvid wrote: > I shouldn't have moved isindex's connectActivate to close_form. > If you wish, I can make a new version. Yes, please. > > By the way, I found that the top of open_input needs > if (html->InFlags & IN_SELECT) { > MSG_HTML("INPUT inside SELECT\n"); > return; > } > Otherwise, if another input sneaks in there, close_select will crash. Please include it in the patch. -- Cheers Jorge.-

April 26, 2008

[patch] introduce lout namespace (was: namespace problem)

by jcid＠dillo.org

On Thu, Apr 24, 2008 at 09:18:30PM +0200, Johannes Hofmann wrote: > Hi, > > while trying to implement a fix to the namespace problem I came to > the conclusion that the easiest and least intrusive way is to keep > the existing namespaces in the lout directory and just wrap them in > another namespace "lout". > This fixes the name collision with signal. Committed. BTW, now the documentation should mention this "lout" namespace. ;-) -- Cheers Jorge.-

April 26, 2008

patch: /* todo: don't create things if button type is unknown */

by corvid＠lavabit.com

April 26, 2008

patch: Re: [Dillo-dev] start on image maps (dw-part)

by corvid＠lavabit.com

Jorge wrote: > On Tue, Apr 22, 2008 at 04:50:32AM +0000, corvid wrote: > > dw: I added motionNotifyImpl() and currLink > > > > dillo: > > - I imagine the setUseMap() in open_img() is probably supposed to be > > routed through DilloImage. > > - Html_read_coords() was borrowed from 0.8.6 and modified a fair amount. > > For one thing, the old code couldn't handle whitespace preceding a comma. > > - I didn't really like that dReturn_if_fail so far down in open_area() > > since coords is dynamically allocated now, but I left it there. > > Committed this patch and also scroll_motionNotify.dw2. > > Shape image-mapped links work so far. Coordinates are not > yet being sent. If I missed something, please repost the patch. > (I assume this is a work in progress). What's not working exactly? We didn't do ISMAP yet, if that's what you're saying...

April 26, 2008

I figured out why charset handling has been all broken lately.

by jcid＠dillo.org

On Thu, Apr 24, 2008 at 01:57:41AM +0000, corvid wrote: > The top of Nav_open_url has > > bool_t ForceReload = (URL_FLAGS(url) & > (URL_E2EReload + URL_ReloadFromCache)); > > When repushing URLs, URL_FLAGS contains URL_ReloadFromCache, > which is 0x100. And remember how Jorge changed bool_t from > int to unsigned char? I'd forgotten about it, too, which meant > I wasted some time looking in the wrong places for this bug. Ooops, sorry. I thought the parenthesis wrapping was returning a boolean value. Patch committed. diff -pru dillo2/src/nav.c dillo2-cur/src/nav.c --- dillo2/src/nav.c 2008-04-08 17:50:25.000000000 -0400 +++ dillo2-cur/src/nav.c 2008-04-26 13:19:27.000000000 -0400 @@ -204,14 +204,14 @@ static void Nav_stack_clean(BrowserWindo static void Nav_open_url(BrowserWindow *bw, const DilloUrl *url, int offset) { DilloUrl *old_url; - bool_t MustLoad; + bool_t MustLoad, ForceReload; int x, y, idx, ClientKey; DilloWeb *Web; - bool_t ForceReload = (URL_FLAGS(url) & - (URL_E2EReload + URL_ReloadFromCache)); MSG("Nav_open_url: new url='%s'\n", URL_STR_(url)); + ForceReload = (URL_FLAGS(url) & (URL_E2EReload + URL_ReloadFromCache)) != 0; + /* Get the url of the current page */ idx = a_Nav_stack_ptr(bw); old_url = a_History_get_url(NAV_UIDX(bw, idx)); -- Cheers Jorge.-

April 26, 2008

[patch] phrase search

by jcid＠dillo.org

Hi, Committed. On Tue, Apr 22, 2008 at 06:12:55PM +0200, Johannes Hofmann wrote: > Hi, > > attached is a patch that make phrase search work. I'm not 100% sure > about the CharIterator::prev() change. CharIterator::next() returned > \0 between words, prev() didn't. So something was wrong. > I decided to go with current next() behaviour and made prev() return > \0 as word separator too. It looks reasonable. BTW, while working on fixing the parsing of " " (a not yet committed work), I found that it's not clear how non-breaking whitespace is handled/represented. Currently we have a parser/dw mix that tries to render it "right" for HTML. The idea is to decide how to render inside the HTML parser and to use dw for that. Now there's some HTML logic built in dw, which would be good not to have (an idea we talked with Sebastian long ago). For instance dillo1 handles NBSP better in some cases and worse in others than dillo2. I think it'll have to wait until I find some time to dig into it... > Also the current implementation only works if one enters exactly one > blank between words in the search dialog. Should we collapse multiple > blanks into one automatically? As a workaround, I don't see why not. BTW, the phrase search doesn't work with text wrapped by the PRE element. This probably is related to a whole sentence/line stored as a single dw word. -- Cheers Jorge.-

April 26, 2008

Re: patch: Accept-Charset: utf-8,*;q=0.8

by corvid＠lavabit.com

Jorge wrote: > Committed, assuming: > > "Accept-Charset: utf-8,*;q=0.8\r\n" > > means dillo2 leaves the door open to also receive iso-8859-1. Yes. Here's what the RFC says: The special value "*", if present in the Accept-Charset field, matches every character set (including ISO-8859-1) which is not mentioned elsewhere in the Accept-Charset field. If no "*" is present in an Accept-Charset field, then all character sets not explicitly mentioned get a quality value of 0, except for ISO-8859-1, which gets a quality value of 1 if not explicitly mentioned.

April 26, 2008

patch: Re: [Dillo-dev] start on image maps (dw-part)

by jcid＠dillo.org

On Tue, Apr 22, 2008 at 04:50:32AM +0000, corvid wrote: > dw: I added motionNotifyImpl() and currLink > > dillo: > - I imagine the setUseMap() in open_img() is probably supposed to be > routed through DilloImage. > - Html_read_coords() was borrowed from 0.8.6 and modified a fair amount. > For one thing, the old code couldn't handle whitespace preceding a comma. > - I didn't really like that dReturn_if_fail so far down in open_area() > since coords is dynamically allocated now, but I left it there. Committed this patch and also scroll_motionNotify.dw2. Shape image-mapped links work so far. Coordinates are not yet being sent. If I missed something, please repost the patch. (I assume this is a work in progress). -- Cheers Jorge.-

April 26, 2008

Re: patch: Accept-Charset: utf-8,*;q=0.8

by jcid＠dillo.org

On Thu, Apr 17, 2008 at 04:57:48PM +0000, corvid wrote: > It is good for dillo to state its preference for UTF-8 > over ISO-8859-1. > > Also, the RFC says that not mentioning '*' puts dillo > in theoretical danger of receiving 406 Not Acceptable. > Committed, assuming: "Accept-Charset: utf-8,*;q=0.8\r\n" means dillo2 leaves the door open to also receive iso-8859-1. -- Cheers Jorge.- > --- dillo2/src/IO/http.c 2008-04-11 19:48:51.000000000 +0000 > +++ dillo2-cur/src/IO/http.c 2008-04-17 16:17:17.000000000 +0000 > @@ -236,7 +236,7 @@ Dstr *a_Http_make_query_str(const DilloU > query, > "POST %s HTTP/1.1\r\n" > "Connection: close\r\n" > - "Accept-Charset: utf-8, iso-8859-1\r\n" > + "Accept-Charset: utf-8,*;q=0.8\r\n" > "Accept-Encoding: gzip\r\n" > "Host: %s%s\r\n" > "%s" > @@ -258,7 +258,7 @@ Dstr *a_Http_make_query_str(const DilloU > "GET %s HTTP/1.1\r\n" > "%s" > "Connection: close\r\n" > - "Accept-Charset: utf-8, iso-8859-1\r\n" > + "Accept-Charset: utf-8,*;q=0.8\r\n" > "Accept-Encoding: gzip\r\n" > "Host: %s%s\r\n" > "%s"

April 26, 2008

patch: image loading on demand for complex button

by jcid＠dillo.org

Hi, Committed. I also changed Html_add_new_linkimage() to take a DilloUrl** parameter, to show it keeps the url. -- Cheers Jorge.-

April 26, 2008