- Dillo-dev - lists.mailman3.com

[patch]: remove redundant #include in fltkflatview.cc

by jcid＠dillo.org

On Tue, Apr 29, 2008 at 07:29:21PM +0100, Jeremy Henty wrote: > > A small cleanup: the "#include <fltk/damage.h>" in fltkflatview.cc is > unnecessary. Committed. -- Cheers Jorge.-

April 30, 2008

[patch] fix table destructor

by jcid＠dillo.org

On Tue, Apr 29, 2008 at 04:09:08PM +0200, Johannes Hofmann wrote: > Hi, > > with memleaks in the news lately.... Here comes another one. Committed. -- Cheers Jorge.-

April 30, 2008

patch: motionNotify and LEAVE

by corvid＠lavabit.com

Jorge wrote: > On Mon, Apr 28, 2008 at 09:21:16PM +0000, corvid wrote: > > Since findtext has been in the news lately, I might as well > > at least provide this bit so that my code behaves better with dialogs. > > > > What is this patch for? If searching with the findtext dialog caused scrolling, the code had been showing the url of the link that happened to be under the cursor underneath the dialog.

April 29, 2008

patch: fltkimgbuf memleak

by jcid＠dillo.org

On Tue, Apr 29, 2008 at 01:24:49AM +0000, corvid wrote: > You should see a significant decrease in memory used. Committed. What a gross leak! -- Cheers Jorge.-

April 29, 2008

patch: usemap <area shape=default>

by corvid＠lavabit.com

shape=default is the background in a client-side image map.

April 29, 2008

patch: motionNotify and LEAVE

by jcid＠dillo.org

On Mon, Apr 28, 2008 at 09:21:16PM +0000, corvid wrote: > Since findtext has been in the news lately, I might as well > at least provide this bit so that my code behaves better with dialogs. > What is this patch for? > diff -pur dw2/dw/fltkviewport.cc dw2-cur/dw/fltkviewport.cc > --- dw2/dw/fltkviewport.cc 2008-04-26 18:21:55.000000000 +0000 > +++ dw2-cur/dw/fltkviewport.cc 2008-04-28 20:40:43.000000000 +0000 > @@ -273,6 +273,10 @@ int FltkViewport::handle (int event) > positionChanged(); > break; > > + case ::fltk::LEAVE: > + mouse_x = mouse_y = -1; > + break; > + > case ::fltk::SHORTCUT: > switch (::fltk::event_key()) { > case PageUpKey: > @@ -324,14 +328,15 @@ void FltkViewport::setCanvasSize (int wi > } > > /* > - * This is needed when a position change is not the result of mouse motion. > + * This is used to simulate mouse motion (e.g., when scrolling). > */ > void FltkViewport::positionChanged () > { > - (void)theLayout->motionNotify (this, > - translateViewXToCanvasX (mouse_x), > - translateViewYToCanvasY (mouse_y), > - (core::ButtonState)0); > + if (mouse_x != -1) > + (void)theLayout->motionNotify (this, > + translateViewXToCanvasX (mouse_x), > + translateViewYToCanvasY (mouse_y), > + (core::ButtonState)0); > } > > /* > diff -pur dw2/dw/textblock.cc dw2-cur/dw/textblock.cc > --- dw2/dw/textblock.cc 2008-04-17 13:30:05.000000000 +0000 > +++ dw2-cur/dw/textblock.cc 2008-04-28 20:52:39.000000000 +0000 > @@ -549,12 +549,12 @@ bool Textblock::motionNotifyImpl (core:: > > void Textblock::enterNotifyImpl (core::EventCrossing *event) > { > - hoverLink = -1; > } > > void Textblock::leaveNotifyImpl (core::EventCrossing *event) > { > - (void) emitLinkEnter (-1, -1, -1, -1); > + hoverLink = -1; > + (void) emitLinkEnter (hoverLink, -1, -1, -1); > } > > /** > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev -- Cheers Jorge.-

April 29, 2008

Cheering some recent improvements in table layout

by jcid＠dillo.org

Hi Jeremy, On Sun, Apr 27, 2008 at 07:22:05AM +0100, Jeremy Henty wrote: > > Just to say that I'm seeing much better table rendering now. I have a > page with a large two-column table. For a while recently this > rendered very strangely in Dillo: it appeared with the two columns at > opposite sides of the page, then the second column would move over to > the left, one item at a time, to sit next to the first. But now the > table immediately appears with both columns in the right place. I > don't know what caused the strange realignment behaviour but I'm glad > it's gone. Great! There were several minor typo-bug fixes and who knows which one of them made it for you. Please send me a compressed version of the test page you use. -- Cheers Jorge.-

April 29, 2008

[patch] phrase search - take 2

by jcid＠dillo.org

On Mon, Apr 28, 2008 at 10:10:21PM +0200, Johannes Hofmann wrote: > Hi, > > here comes my second attempt on phrase search. As already described, > I changed CharIterator back to not return \0s. Instead blanks are > inserted when the space flag is set. > This way CharIterator always returns a smooth stream of chars > whether for normal html- or pre-text. > Then there was a bug in DeepIterator::prev() that took me some > time to find. > I also adjusted charsEqual() to treat all space-chars equally. > Finally I had to add a check in CharIterator::highlight() to avoid a > crash when searching for the last word in pre-text with a blank > appended. Great. Committed. With this miscelany of bug fixes within patches, it seems some bugs are starting to vanish as "side effects" of patches (as with what Jeremy reports happened with tables!). -- Cheers Jorge.-

April 29, 2008

patch: Re: patch: Re: [Dillo-dev] start on image maps (dw-part)

by jcid＠dillo.org

On Sun, Apr 27, 2008 at 06:36:31PM +0000, corvid wrote: > > /* BUG: if several ISMAP images follow each other without > > * being separated with a word, only the first one is ISMAPed > > */ > > PS I left this old comment in, but if I make a file containing a bunch of > ismap images in a row, they certainly _seem_ ismapped. I click on them and > dillo tries to go to http://[wherever]?x,y. Yes, comment was deleted. -- Cheers Jorge.-

April 29, 2008

patch: Re: patch: Re: [Dillo-dev] start on image maps (dw-part)

by jcid＠dillo.org

On Sun, Apr 27, 2008 at 06:22:48PM +0000, corvid wrote: > Jorge wrote: > > Yes, ISMAP. > > All right, here you go. It turned out to be a lot of work :) Committed. It'd be good to hook emitMotionNotify() to have URL feedback for ISMAP in the status box. -- Cheers Jorge.-

April 29, 2008