- Dillo-dev - lists.mailman3.com

[BUG]: Redirect to previous page + Reload crashes

by onepoint＠starurchin.org

Dillo crashes as follows: * Point Dillo at http://starurchin.org:8080/dillo/here * Click the "There" link. Dillo is redirected back to the "Here" page. * Click the "Reload" button. * Dillo crashes inside a_Nav_reload() (nav.c) at the line "if (URL_FLAGS(url) & URL_Post) {" because url is NULL. I noticed this a few weeks ago but only just found a simple way to trigger it. Any ideas why this is happening? Regards, Jeremy Henty

May 24, 2008

memory statistics

by jcid＠dillo.org

On Fri, May 23, 2008 at 06:42:14PM +0200, Johannes Hofmann wrote: > On Fri, May 23, 2008 at 12:25:46PM -0400, Jorge Arellano Cid wrote: > > On Fri, May 23, 2008 at 03:22:15PM +0000, corvid wrote: > > > Johannes wrote: > > > > Another thing is the way new incoming html is handled in > > > > DilloHtml::write(). It' get's decoded in a new string and is then > > > > copied to the end of Local_Buf. Maybe we could avoid the copy by > > > > letting the decoder write it to the right place? > > > > > > If possible, I'd prefer to move decoding from html.cc to cache.c. > > > I have working prototype code, but it's not good enough to put into > > > dillo. If anyone would like to receive a 35K patch and provide > > > suggestions on how to improve it... :) > > > > Ouch! > > > > I know I have this pending. Well, if I dissappear some time > > from dillo-dev you'll know what I am at. > > > > On to another topic, I'd really like to see gprof working again. > > What exactly is not working for you? When using "./configure --enable-gprof" both in dw2 and dillo2, the resulting dillo-fltk binary doesn't produce gmon.out. The dw2 test programs inside test/ work out of the box. i.e. There's no need to disable XFT nor to link manually. Just "./configure --enable-gprof". > Do you want to automate the static linking? I'd like dillo-fltk to work out of the box with "./configure --enable-gprof" just as the test programs in dw. -- Cheers Jorge.-

May 23, 2008

memory statistics

by jcid＠dillo.org

On Fri, May 23, 2008 at 05:15:53PM +0000, corvid wrote: > Jorge wrote: > > > If possible, I'd prefer to move decoding from html.cc to cache.c. > > > I have working prototype code, but it's not good enough to put into > > > dillo. If anyone would like to receive a 35K patch and provide > > > suggestions on how to improve it... :) > > > > Ouch! > > > > I know I have this pending. Well, if I dissappear some time > > from dillo-dev you'll know what I am at. > > Don't read that the wrong way. > I know perfectly well that it isn't good enough to go into dillo as it is, > and I spoke of it in case anybody on the list might wish to take a look. > > I know it's ultimately my code and my responsibility, but I haven't had > any insights occur to me. No problem. I just meant it has high priority now, and that other thing will have to wait. -- Cheers Jorge.-

May 23, 2008

memory statistics

by corvid＠lavabit.com

Jorge wrote: > > If possible, I'd prefer to move decoding from html.cc to cache.c. > > I have working prototype code, but it's not good enough to put into > > dillo. If anyone would like to receive a 35K patch and provide > > suggestions on how to improve it... :) > > Ouch! > > I know I have this pending. Well, if I dissappear some time > from dillo-dev you'll know what I am at. Don't read that the wrong way. I know perfectly well that it isn't good enough to go into dillo as it is, and I spoke of it in case anybody on the list might wish to take a look. I know it's ultimately my code and my responsibility, but I haven't had any insights occur to me.

May 23, 2008

Uncluttering dillo, part II: the findbar

by Johannes.Hofmann＠gmx.de

On Thu, May 22, 2008 at 12:32:07PM -0400, Jorge Arellano Cid wrote: > On Wed, May 21, 2008 at 05:43:05PM +0200, Johannes Hofmann wrote: > > Hi Justus, > > > > On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote: > > > -----BEGIN PGP SIGNED MESSAGE----- > > > Hash: SHA1 > > > > > > Hey everyone :) > > > > > > attached is a patch that transforms dillos find in page dialog box into > > > a firefox style toolbar. There are some issues that I cannot put my > > > finger on... see the comments in the event handler. Maybe there's some > > > magic about fltks event model that I did not fully understand... then > > > again it might be fltks fault. Anyway, I'd be happy for some hints. > > > > This is really nice! For text search the popup menus are even more > > annoying than for entering an url. > > > > One minor thing. You can make the CheckButton and Input members of > > Findbar private if you use static methods for the callbacks instead > > of functions. > > Yes, I agree. Patch attached. Cheers, Johannes

May 23, 2008

memory statistics

by Johannes.Hofmann＠gmx.de

On Fri, May 23, 2008 at 12:25:46PM -0400, Jorge Arellano Cid wrote: > On Fri, May 23, 2008 at 03:22:15PM +0000, corvid wrote: > > Johannes wrote: > > > Another thing is the way new incoming html is handled in > > > DilloHtml::write(). It' get's decoded in a new string and is then > > > copied to the end of Local_Buf. Maybe we could avoid the copy by > > > letting the decoder write it to the right place? > > > > If possible, I'd prefer to move decoding from html.cc to cache.c. > > I have working prototype code, but it's not good enough to put into > > dillo. If anyone would like to receive a 35K patch and provide > > suggestions on how to improve it... :) > > Ouch! > > I know I have this pending. Well, if I dissappear some time > from dillo-dev you'll know what I am at. > > On to another topic, I'd really like to see gprof working again. What exactly is not working for you? Do you want to automate the static linking? Cheers, Johannes

May 23, 2008

memory statistics

by jcid＠dillo.org

On Fri, May 23, 2008 at 03:22:15PM +0000, corvid wrote: > Johannes wrote: > > Another thing is the way new incoming html is handled in > > DilloHtml::write(). It' get's decoded in a new string and is then > > copied to the end of Local_Buf. Maybe we could avoid the copy by > > letting the decoder write it to the right place? > > If possible, I'd prefer to move decoding from html.cc to cache.c. > I have working prototype code, but it's not good enough to put into > dillo. If anyone would like to receive a 35K patch and provide > suggestions on how to improve it... :) Ouch! I know I have this pending. Well, if I dissappear some time from dillo-dev you'll know what I am at. On to another topic, I'd really like to see gprof working again. -- Cheers Jorge.-

May 23, 2008

patch: trim Local_Buf

by Johannes.Hofmann＠gmx.de

Hey that's cool! I thought about doing something like this, but didn't find a good way. I thought it would grow much more complicated. On Fri, May 23, 2008 at 03:12:13PM +0000, corvid wrote: > --- dillo2/src/html.cc 2008-05-23 14:02:05.000000000 +0000 > +++ dillo2-cur/src/html.cc 2008-05-23 14:45:11.000000000 +0000 > @@ -1004,11 +1004,16 @@ void DilloHtml::write(char *Buf, int Buf > Buf_Consumed = BufSize; > Local_Ofs += token_start; > > + /* updates line number and tag offset */ > + (void)Html_get_line_number(this); > + > + /* don't need anything further back */ > + dStr_erase(Local_Buf, 0, CurrTagOfs); > + Local_Ofs -= CurrTagOfs; > + OldTagOfs = CurrTagOfs = 0; > + > if (bw) > a_UIcmd_set_page_prog(bw, BufSize, 1); > - > - if (Eof) > - a_Decode_free(decoder); > } > > /* > @@ -1021,6 +1026,8 @@ void DilloHtml::freeParseData() > > dStr_free(Stash, TRUE); > dStr_free(attr_data, TRUE); > + > + a_Decode_free(decoder); > dStr_free(Local_Buf, TRUE); > dFree(charset); > } > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

May 23, 2008

memory statistics

by corvid＠lavabit.com

Johannes wrote: > Another thing is the way new incoming html is handled in > DilloHtml::write(). It' get's decoded in a new string and is then > copied to the end of Local_Buf. Maybe we could avoid the copy by > letting the decoder write it to the right place? If possible, I'd prefer to move decoding from html.cc to cache.c. I have working prototype code, but it's not good enough to put into dillo. If anyone would like to receive a 35K patch and provide suggestions on how to improve it... :)

May 23, 2008

patch: trim Local_Buf

by corvid＠lavabit.com

May 23, 2008