- Dillo-dev - lists.mailman3.com

[patch] fix findtext for single char searches

by Johannes.Hofmann＠gmx.de

Hi, attached patch fixes a segfault when searching for single characters. Cheers, Johannes

July 2, 2008

iterator related bugs

by Johannes.Hofmann＠gmx.de

Hi, while looking for the reason of the rare selection related crashes I found something that seems like a severe bunch of bugs in the iterator code. It might be related to the crash, but I'm not 100% sure yet. There is this innocent comment in front of the DeepIterator constructor in iterator.cc: If you want to continue using \em it, pass it->cloneIterator(). This means, that the DeepIterator constructor eats up the Iterator it get's passed a pointer to! The evil thing is that every method that passes one of it's arguments to the DeepIterator constructor inherits this property, e.g: DeepIterator::createVariant() and as a consequence also: SelectionState::switchLinkToSelection() and SelectionState::adjustSelection() In Iterator::scrollTo() Iterators that are used after being passed to the DeepIterator constructor. In SelectionState::buttonRelease() an iterator that has been passed to switchLinkToSelection() might be used afterwards as argument to adjustSelection(). I would propose to change the behaviour of the DeepIterator constructor and always clone its input Iterator. Better be safe than sorry and the fact that there is already several bugs related to this shows, that the current behaviour - even if it's documented - is really dangerous. What do you think? Cheers, Johannes

July 2, 2008

patch: (any Solarians in the audience?) rm nanosleep solaris workaround

by corvid＠lavabit.com

It seems that there was a nanosleep() in src/IO/dpi.c long ago, but I can't find any nanosleep()s anywhere anymore, so...

July 2, 2008

what's next

by jcid＠dillo.org

On Mon, Jun 30, 2008 at 05:44:40PM +0200, Johannes Hofmann wrote: > Hi, > > for me dillo-fltk is pretty stable, fast, and generally a joy to use. > I still see the following issues: > > * In rare cases the screen contents is not properly redrawn due to > the redraw optimization. I'm looking for a way to reproduce it. > Anyone else seeing this? Not me. I'll pay more attention... > * The cursor is not always updated properly when over a link. This > happens while page is rendered and also when drag-scrolling with > the middle mouse button. > > * The bus error I had posted about is still there and I have seen it > once as a segafault with similar stack trace on a Linux box. I > still don't have a way to reproduce it though. Yeah, It'd be good to know what it is. > Any other problems or missing features? > > Jorge, what do you think about officially releasing what we have in > the near future? > Or do you prefer to wait for the big stuff (like CSS)? I'd like to release before CSS. I'll check the TABs stuff and see if it can be coded/included. Releasing by Aug looks OK to me. -- Cheers Jorge.-

June 30, 2008

Should --enable-ansi be removed?

by jcid＠dillo.org

On Sat, Jun 28, 2008 at 02:18:05AM +0000, corvid wrote: > I tried enabling it out of curiosity, and I see > that the code doesn't come close to compiling with it. > > Since it complains a lot about the various > MSG(...) macros > (warning: anonymous variadic macros were introduced in C99), > I'm guessing that the answer will be yes. Now that dillo needs a C++ compiler to build, I don't know whether this option is useful anymore. Does anybody know better? -- Cheers Jorge.-

June 30, 2008

what's next

by Johannes.Hofmann＠gmx.de

Hi, for me dillo-fltk is pretty stable, fast, and generally a joy to use. I still see the following issues: * In rare cases the screen contents is not properly redrawn due to the redraw optimization. I'm looking for a way to reproduce it. Anyone else seeing this? * The cursor is not always updated properly when over a link. This happens while page is rendered and also when drag-scrolling with the middle mouse button. * The bus error I had posted about is still there and I have seen it once as a segafault with similar stack trace on a Linux box. I still don't have a way to reproduce it though. Any other problems or missing features? Jorge, what do you think about officially releasing what we have in the near future? Or do you prefer to wait for the big stuff (like CSS)? Cheers, Johannes

June 30, 2008

Should --enable-ansi be removed?

by onepoint＠starurchin.org

On Sat, Jun 28, 2008 at 02:18:05AM +0000, corvid wrote: > Since it complains a lot about the various MSG(...) macros (warning: > anonymous variadic macros were introduced in C99), I tried to get -pedantic to work and I could silence those warnings in the C source by specifying -std=gnu99 but I could find no gcc 3.4.x option to do the same for C++ source. Maybe gcc 4.x has one? Regards, Jeremy Henty

June 28, 2008

Should --enable-ansi be removed?

by corvid＠lavabit.com

> I tried enabling it out of curiosity, and I see > that the code doesn't come close to compiling with it. > > Since it complains a lot about the various > MSG(...) macros > (warning: anonymous variadic macros were introduced in C99), > I'm guessing that the answer will be yes. To save any time spent discussing whether warnings with a rarely-used option can be ignored, I should mention that it also gave errors for, e.g., bitvec, apparently because a struct is returned. I can't imagine that we'd want to start changing around such things for the sake of this.

June 28, 2008

Should --enable-ansi be removed?

by corvid＠lavabit.com

I tried enabling it out of curiosity, and I see that the code doesn't come close to compiling with it. Since it complains a lot about the various MSG(...) macros (warning: anonymous variadic macros were introduced in C99), I'm guessing that the answer will be yes.

June 28, 2008

[patch] use prefs.vw_fontname

by jcid＠dillo.org

On Thu, Jun 26, 2008 at 09:54:07PM +0200, Johannes Hofmann wrote: > Hi, > > attached patch uses prefs.vw_fontname instead of hardcoded > "Bitstream Charter" in web.cc. Thereby it avoids opening "Bitstream > Charter" if it is not selected in dillorc. > This saves about 500k in initial startup size with --disable-xft > It hardly saves anything in the xft case. I don't know why. I would > have expected it the other way round.... Committed. -- Cheers Jorge.-

June 27, 2008