- Dillo-dev - lists.mailman3.com

[patch]: @media support

by onepoint＠starurchin.org

corvid wrote: > Jeremy wrote: > > + dStrcasecmp(tval, "media") == 0) > > Should that be "screen"? <headdesk/> :-) . Good call! Updated patch attached. Regards, Jeremy Henty

Nov. 22, 2010

[patch]: @media support

by corvid＠lavabit.com

Jeremy wrote: > + dStrcasecmp(tval, "media") == 0) Should that be "screen"?

Nov. 22, 2010

[patch]: @media support

by Johannes.Hofmann＠gmx.de

On Mon, Nov 22, 2010 at 08:29:03PM +0000, Jeremy Henty wrote: > > Does what it says on the tin. Please review and comment. I'm going > to road-test this at home for a few days before pushing it. Naturally > I won't push it if people have objections or corrections. But it does > fix this site[1]! Heh, nice! After your last patch I was already tempted to ask whether you wanted to look into this :-) Feel free to commit when you think it's ready. Cheers, Johannes

Nov. 22, 2010

[patch]: @media support

by onepoint＠starurchin.org

Does what it says on the tin. Please review and comment. I'm going to road-test this at home for a few days before pushing it. Naturally I won't push it if people have objections or corrections. But it does fix this site[1]! Regards, Jeremy Henty [1]: http://www.psychologicalscience.org/onlyhuman/2009/01/paradox-of-temptation…

Nov. 22, 2010

[patch]: ignore unknown @-rules in CSS

by onepoint＠starurchin.org

On Sun, Nov 21, 2010 at 08:52:58PM +0100, Johannes Hofmann wrote: > On Sat, Nov 20, 2010 at 12:31:55PM +0000, Jeremy Henty wrote: > > > > So, here are two patches that make Dillo ignore @-rules that it > > does not recognise. > > Looks good to me. Please commit! Done! Regards, Jeremy Henty

Nov. 21, 2010

[patch]: ignore unknown @-rules in CSS

by Johannes.Hofmann＠gmx.de

Hi Jeremy, On Sat, Nov 20, 2010 at 12:31:55PM +0000, Jeremy Henty wrote: > > Currently Dillo tries to parse every @-rule in the same way (with > CssParser::parseImport()). This causes problems, particularly with > @media. Here[1] part of the style is missing so that the line size is > smaller than the text. I have also attached a small test case where a > @media rule causes the red style to go missing. > > So, here are two patches that make Dillo ignore @-rules that it does > not recognise. The first patch just moves the test for the import > keyword from CssParser::parseImport() into the main parser loop. > Because it changes indentation it looks much more radical than it is. > The second patch reworks the main parser loop so that > CssParser::parseImport() is only called for @import and other @-rules > are skipped. > > Please review and comment. I will push the patches if you think they > are good. Looks good to me. Please commit! Thanks, Johannes

Nov. 21, 2010

[patch]: ignore unknown @-rules in CSS

by onepoint＠starurchin.org

Currently Dillo tries to parse every @-rule in the same way (with CssParser::parseImport()). This causes problems, particularly with @media. Here[1] part of the style is missing so that the line size is smaller than the text. I have also attached a small test case where a @media rule causes the red style to go missing. So, here are two patches that make Dillo ignore @-rules that it does not recognise. The first patch just moves the test for the import keyword from CssParser::parseImport() into the main parser loop. Because it changes indentation it looks much more radical than it is. The second patch reworks the main parser loop so that CssParser::parseImport() is only called for @import and other @-rules are skipped. Please review and comment. I will push the patches if you think they are good. Regards, Jeremy Henty [1]http://johannhari.com//2010/11/19/we-should-not-tolerate-religious-excuse…

Nov. 20, 2010

patch: text-indent

by Johannes.Hofmann＠gmx.de

On Fri, Nov 19, 2010 at 06:15:45PM +0000, corvid wrote: > I wrote: > > However, with > > <div style="text-indent: 1em; border: 1px solid"> > > <table border=1> > > <tr><td>I'm<td>a<td>table > > </table> > > text > > </div> > > firefox doesn't indent the text in the cells, and I don't know why > > not. The property inherits. Guess I have some deeper spec reading > > in my immediate future. > > Ah, http://davidwalsh.name/firefox-internal-rendering-css > shows > table { > .. > text-indent: 0; > } Yeah tables seem to reset some CSS values traditionally. There is already a related comment in css.cc with the following link: http://developer.mozilla.org/En/Fixing_Table_Inheritance_in_Quirks_Mode Cheers, Johannes

Nov. 19, 2010

patch: text-indent

by corvid＠lavabit.com

I wrote: > However, with > <div style="text-indent: 1em; border: 1px solid"> > <table border=1> > <tr><td>I'm<td>a<td>table > </table> > text > </div> > firefox doesn't indent the text in the cells, and I don't know why > not. The property inherits. Guess I have some deeper spec reading > in my immediate future. Ah, http://davidwalsh.name/firefox-internal-rendering-css shows table { .. text-indent: 0; }

Nov. 19, 2010

patch: text-indent

by corvid＠lavabit.com

Committed a change. I see that tables still don't work properly with it. <table border=1 style="text-indent: 1em"> <tr><td>I'm<td>a<td>table </table> doesn't make the cells big enough, but that's simply because I haven't looked into it yet. However, with <div style="text-indent: 1em; border: 1px solid"> <table border=1> <tr><td>I'm<td>a<td>table </table> text </div> firefox doesn't indent the text in the cells, and I don't know why not. The property inherits. Guess I have some deeper spec reading in my immediate future.

Nov. 19, 2010