January 2026 - Dillo-dev - lists.mailman3.com

Re: Avoid ctype(3) abuses

by Leonardo Taccari

Leonardo Taccari writes: > [...] > Good idea! > > I will then add possible missing d*() helper ctype(3) functions and > adapt all direct ctype(3) users to switch to such d*() helper > functions. > > I hope to be able to share possible patches for that in 48 hours or so! > [...] Updated patches modified as required attached in this email. Now ctype(3) usage is only via d*() helper ctype(3) functions. Thanks!

Jan. 15, 2026

Re: Segfault on form submit / CSS display:none

by Rodrigo Arias

Hi, On Wed, Jan 14, 2026 at 11:40:34AM +0100, Thomas Rudolph wrote: > Hi, > > the following html code causes Dillo to segfault in the latest git > versions when clicking the button. I stripped the html down to the > problem: > > <form> > > <span style="display:none;"> > <input type="checkbox" name="x"> > </span> > > <input type=submit name="submit" value="Crash"> > > </form> > > This is reproducible on my Raspberry Pi OS (Debian 13) machine as well > as on my laptop (Debian 13). > > Removing either "display:none;", or the name attribute of the input, > or disabling embedded CSS results in Dillo not crashing. > Input type text crashes as well as checkbox. > Older versions of Dillo such as the 3.2.0 release do not crash on this > code, too. Thanks for the report. Yes, is a known problem: https://bug.dillo-browser.org/506/ The fix is in progress. As a workaround you can disable CSS for that page to submit the form or use 3.2.0. > Thanks for resurrecting this awesome browser. It has become my default > browser for 60-70 percent of the web. Glad to read that :) Best, Rodrigo.

Jan. 15, 2026

Segfault on form submit / CSS display:none

by Thomas Rudolph

Hi, the following html code causes Dillo to segfault in the latest git versions when clicking the button. I stripped the html down to the problem: <form> <span style="display:none;"> <input type="checkbox" name="x"> </span> <input type=submit name="submit" value="Crash"> </form> This is reproducible on my Raspberry Pi OS (Debian 13) machine as well as on my laptop (Debian 13). Removing either "display:none;", or the name attribute of the input, or disabling embedded CSS results in Dillo not crashing. Input type text crashes as well as checkbox. Older versions of Dillo such as the 3.2.0 release do not crash on this code, too. Thanks for resurrecting this awesome browser. It has become my default browser for 60-70 percent of the web. All the best, Thomas

Jan. 14, 2026

Re: Avoid ctype(3) abuses

by Leonardo Taccari

Hello Rodrigo, Rodrigo Arias writes: > Hi, > > On Mon, Jan 12, 2026 at 11:05:17AM +0100, Leonardo Taccari wrote: > >Hello! > > > >Most ctype(3) functions usage abuses an undefined behavior of passing > >values outside integers outside EOF or the range representable as > >unsigned char. > > > >On NetBSD 11 and newer such incorrect behaviors crashes applications > >violating that and due that Dillo easily crash by just visiting, e.g. > ><https://www.NetBSD.org/>. > > > >For possible further information please give a look to > ><https://man.NetBSD.org/ctype.3#CAVEATS>. > > Interesting! > > >I have grep-ed all such uses and added the relevant cast to uchar_t > >similar to other ctype(3) calls already present and in that way I can > >also confirm that Dillo no longer crashes. > > Thanks for the patch and tests. > > We have wrappers that do just that for isspace() and isalnum() in > dlib/dlib.h: > > https://git.dillo-browser.org/dillo/tree/dlib/dlib.h?id=7c6ccebe61077902160… > > I would be inclined to add the extra wrappers there and use the > dIsspace, dIsalnum... macros instead of doing the explicit casting. > > Additionally, I think it would be safer to also switch all these ctype > macros to static inline functions so we cover accidental castings from > unexpected types with an error instead of a warning: > > static inline int dIsalnum(unsigned char c) { return isalnum(c); } > > Example: > > % cat foo.c > #include <ctype.h> > static inline int dIsalnum(unsigned char c) { return isalnum(c); } > #define dIsalnum_unsafe(c) isalnum((unsigned char) (c)) > > int main(void) > { > char *a = "a"; > dIsalnum(a); > dIsalnum_unsafe(a); > > return 0; > } > > % gcc foo.c -o foo > foo.c: In function ‘main’: > foo.c:8:18: error: passing argument 1 of ‘dIsalnum’ makes integer from pointer without a cast [-Wint-conversion] > 8 | dIsalnum(a); > | ^ > | | > | char * > foo.c:2:42: note: expected ‘unsigned char’ but argument is of type ‘char *’ > 2 | static inline int dIsalnum(unsigned char c) { return isalnum(c); } > | ~~~~~~~~~~~~~~^ > In file included from foo.c:1: > foo.c:3:36: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > 3 | #define dIsalnum_unsafe(c) isalnum((unsigned char) (c)) > | ^ > foo.c:9:9: note: in expansion of macro ‘dIsalnum_unsafe’ > 9 | dIsalnum_unsafe(a); > | ^~~~~~~~~~~~~~~ > [...] Good idea! I will then add possible missing d*() helper ctype(3) functions and adapt all direct ctype(3) users to switch to such d*() helper functions. I hope to be able to share possible patches for that in 48 hours or so! Thank you!

Jan. 12, 2026

Re: Include missing <stdlib.h> for calloc(3) and exit(3)

by Leonardo Taccari

Hello Rodrigo, Rodrigo Arias writes: > Hi, > > On Mon, Jan 12, 2026 at 11:04:07AM +0100, Leonardo Taccari wrote: > >Hello! > > > >When trying to build current HEAD of dillo in NetBSD the build fails > >with: > > > > [...] > > g++ ... -o dialog.o dialog.cc > > [...] > > dialog.cc:38:1: note: 'calloc' is defined in header '<cstdlib>'; this is probably fixable by adding '#include <cstdlib>' > > 37 | #include "dlib/dlib.h" > > +++ |+#include <cstdlib> > > 38 | > > dialog.cc:192:11: error: 'exit' was not declared in this scope > > 192 | exit(1); > > | ^~~~ > > dialog.cc:192:11: note: 'exit' is defined in header '<cstdlib>'; this is probably fixable by adding '#include <cstdlib>' > > *** [dialog.o] Error code 1 > > [...] > > > >Including <stdlib.h> fixes that and the attached patch does that. > > Thanks!, merged in: > > https://git.dillo-browser.org/dillo/commit/?id=7c6ccebe61077902160798e5af46… > [...] Thank you very much for quickly applying it!

Jan. 12, 2026

Re: Avoid ctype(3) abuses

by Rodrigo Arias

Hi, On Mon, Jan 12, 2026 at 11:05:17AM +0100, Leonardo Taccari wrote: >Hello! > >Most ctype(3) functions usage abuses an undefined behavior of passing >values outside integers outside EOF or the range representable as >unsigned char. > >On NetBSD 11 and newer such incorrect behaviors crashes applications >violating that and due that Dillo easily crash by just visiting, e.g. ><https://www.NetBSD.org/>. > >For possible further information please give a look to ><https://man.NetBSD.org/ctype.3#CAVEATS>. Interesting! >I have grep-ed all such uses and added the relevant cast to uchar_t >similar to other ctype(3) calls already present and in that way I can >also confirm that Dillo no longer crashes. Thanks for the patch and tests. We have wrappers that do just that for isspace() and isalnum() in dlib/dlib.h: https://git.dillo-browser.org/dillo/tree/dlib/dlib.h?id=7c6ccebe61077902160… I would be inclined to add the extra wrappers there and use the dIsspace, dIsalnum... macros instead of doing the explicit casting. Additionally, I think it would be safer to also switch all these ctype macros to static inline functions so we cover accidental castings from unexpected types with an error instead of a warning: static inline int dIsalnum(unsigned char c) { return isalnum(c); } Example: % cat foo.c #include <ctype.h> static inline int dIsalnum(unsigned char c) { return isalnum(c); } #define dIsalnum_unsafe(c) isalnum((unsigned char) (c)) int main(void) { char *a = "a"; dIsalnum(a); dIsalnum_unsafe(a); return 0; } % gcc foo.c -o foo foo.c: In function ‘main’: foo.c:8:18: error: passing argument 1 of ‘dIsalnum’ makes integer from pointer without a cast [-Wint-conversion] 8 | dIsalnum(a); | ^ | | | char * foo.c:2:42: note: expected ‘unsigned char’ but argument is of type ‘char *’ 2 | static inline int dIsalnum(unsigned char c) { return isalnum(c); } | ~~~~~~~~~~~~~~^ In file included from foo.c:1: foo.c:3:36: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 3 | #define dIsalnum_unsafe(c) isalnum((unsigned char) (c)) | ^ foo.c:9:9: note: in expansion of macro ‘dIsalnum_unsafe’ 9 | dIsalnum_unsafe(a); | ^~~~~~~~~~~~~~~ Best, Rodrigo.

Jan. 12, 2026

Re: Include missing <stdlib.h> for calloc(3) and exit(3)

by Rodrigo Arias

Hi, On Mon, Jan 12, 2026 at 11:04:07AM +0100, Leonardo Taccari wrote: >Hello! > >When trying to build current HEAD of dillo in NetBSD the build fails >with: > > [...] > g++ ... -o dialog.o dialog.cc > [...] > dialog.cc:38:1: note: 'calloc' is defined in header '<cstdlib>'; this is probably fixable by adding '#include <cstdlib>' > 37 | #include "dlib/dlib.h" > +++ |+#include <cstdlib> > 38 | > dialog.cc:192:11: error: 'exit' was not declared in this scope > 192 | exit(1); > | ^~~~ > dialog.cc:192:11: note: 'exit' is defined in header '<cstdlib>'; this is probably fixable by adding '#include <cstdlib>' > *** [dialog.o] Error code 1 > [...] > >Including <stdlib.h> fixes that and the attached patch does that. Thanks!, merged in: https://git.dillo-browser.org/dillo/commit/?id=7c6ccebe61077902160798e5af46… Best, Rodrigo

Jan. 12, 2026

Avoid ctype(3) abuses

by Leonardo Taccari

Hello! Most ctype(3) functions usage abuses an undefined behavior of passing values outside integers outside EOF or the range representable as unsigned char. On NetBSD 11 and newer such incorrect behaviors crashes applications violating that and due that Dillo easily crash by just visiting, e.g. <https://www.NetBSD.org/>. For possible further information please give a look to <https://man.NetBSD.org/ctype.3#CAVEATS>. I have grep-ed all such uses and added the relevant cast to uchar_t similar to other ctype(3) calls already present and in that way I can also confirm that Dillo no longer crashes. Attached in this email you can find a patch to address that. Thank you!

Jan. 12, 2026

Include missing <stdlib.h> for calloc(3) and exit(3)

by Leonardo Taccari

Hello! When trying to build current HEAD of dillo in NetBSD the build fails with: [...] g++ ... -o dialog.o dialog.cc [...] dialog.cc:38:1: note: 'calloc' is defined in header '<cstdlib>'; this is probably fixable by adding '#include <cstdlib>' 37 | #include "dlib/dlib.h" +++ |+#include <cstdlib> 38 | dialog.cc:192:11: error: 'exit' was not declared in this scope 192 | exit(1); | ^~~~ dialog.cc:192:11: note: 'exit' is defined in header '<cstdlib>'; this is probably fixable by adding '#include <cstdlib>' *** [dialog.o] Error code 1 [...] Including <stdlib.h> fixes that and the attached patch does that. Thank you!

Jan. 12, 2026