May 2025 - Dillo-dev - lists.mailman3.com

[PATCH] Use contrasting color for widget selections

by a1ex＠dismail.de

Hi, Here is a cleaned up version of my previous patch. I have been testing it quite a bit and for me it is working OK with both dark and light backgrounds. Just to recap the issue: Dillo currently hard-codes the color black to be used as the widget selection color (checkmarks, radio buttons, etc). When using a dark background, these selections appear to be invisible. With this patch, we ensure that the selction is visible by contrasing the selection color against the background. Any feedback welcome. Regards, Alex --- a/dw/fltkui.cc Sun Apr 27 18:56:44 2025 +++ b/dw/fltkui.cc Thu May 22 15:02:20 2025 @@ -1171,8 +1171,11 @@ void FltkToggleButtonResource<I>::setWidgetStyle (Fl_W core::style::Style *style) { FltkResource::setWidgetStyle(widget, style); - - widget->selection_color(FL_BLACK); + FltkColor *bg = (FltkColor*)style->backgroundColor; + int normal_bg = bg->colors[FltkColor::SHADING_NORMAL]; + int style_fg = ((FltkColor*)style->color)->colors[FltkColor::SHADING_NORMAL]; + Fl_Color fg = fl_contrast(style_fg, normal_bg); + widget->selection_color(fg); }

May 22, 2025

Re: Question regarding styling input checkbox element

by a1ex＠dismail.de

<a1ex(a)dismail.de> wrote: > Here is a working patch which I believe fixes it so that it uses the > foreground color: Sorry, I hit send too fast! It doesn't actually use the CSS foreground color, but creates a contrasting color based on the background. Maybe not ideal, but probably better than the current behavior.

May 21, 2025

Re: Question regarding styling input checkbox element

by a1ex＠dismail.de

Hi Rodrigo, Rodrigo Arias <rodarima(a)gmail.com> wrote: > For some reason is always hardcoded to be black. Here is making it > always red: Thanks, looks great now! > See commit fa967f233fe6da82a98aaf3e2149d7aa5e1516cc for context, but > not sure why is not just inheriting the CSS foreground color. Here is a working patch which I believe fixes it so that it uses the foreground color: diff -upr a/dw/fltkui.cc b/dw/fltkui.cc --- a/dw/fltkui.cc Sun Apr 27 18:56:44 2025 +++ b/dw/fltkui.cc Wed May 21 14:01:08 2025 @@ -1171,8 +1171,12 @@ void FltkToggleButtonResource<I>::setWidgetStyle (Fl_W core::style::Style *style) { FltkResource::setWidgetStyle(widget, style); - - widget->selection_color(FL_BLACK); + FltkColor *bg = (FltkColor*)style->backgroundColor; + int normal_bg = bg->colors[FltkColor::SHADING_NORMAL]; + int style_fg = ((FltkColor*)style->color)->colors + [FltkColor::SHADING_NORMAL]; + Fl_Color fg = fl_contrast(style_fg, normal_bg); + widget->selection_color(fg); } Regards, Alex

May 21, 2025

Re: Question regarding styling input checkbox element

by Kevin Koster

a1ex-J7K0XVabL0iELgA04lAiVw(a)public.gmane.org wrote: > When using a dark css theme (I like to use a black background), putting > a checkmark in a checkbox is invisible (black). I tried messing around > with style.css with various configurations for input, but it seems > impossible to make the checkmark anything other than black. > > It's not a huge issue, but when editing bookmarks it becomes a little > annoying. I've got visible checkboxes on a black background with this style.css in Dillo 3.2.0: * {color: #00f400} html {background-color: gray !important} body, div, span, nav, p, a, form, h1, h2, h3, h4, h5, h6, ul, ol, li, table, tr, td {background-color: black} img, map {background-color: gray !important} :link {text-decoration: none !important; color: #00f5e8 !important} :visited {text-decoration: none !important; color: #a020f0 !important} That style does make the bookmarks page look pretty odd with its CSS enabled, but it's intended to avoid dark-on-black content on some websites.

May 20, 2025

Re: Question regarding styling input checkbox element

by Rodrigo Arias

Hi, On Tue, May 20, 2025 at 01:33:43PM +0000, a1ex(a)dismail.de wrote: >Hi, > >When using a dark css theme (I like to use a black background), putting >a checkmark in a checkbox is invisible (black). I tried messing around >with style.css with various configurations for input, but it seems >impossible to make the checkmark anything other than black. > >It's not a huge issue, but when editing bookmarks it becomes a little >annoying. > >Any suggestions, or is this just a limitation of the css implementation? For some reason is always hardcoded to be black. Here is making it always red: diff --git a/dw/fltkui.cc b/dw/fltkui.cc index db7c94e2..2d3882d2 100644 --- a/dw/fltkui.cc +++ b/dw/fltkui.cc @@ -1172,7 +1172,7 @@ void FltkToggleButtonResource<I>::setWidgetStyle (Fl_Widget *widget, { FltkResource::setWidgetStyle(widget, style); - widget->selection_color(FL_BLACK); + widget->selection_color(FL_RED); } See commit fa967f233fe6da82a98aaf3e2149d7aa5e1516cc for context, but not sure why is not just inheriting the CSS foreground color. Best, Rodrigo.

May 20, 2025

Question regarding styling input checkbox element

by a1ex＠dismail.de

Hi, When using a dark css theme (I like to use a black background), putting a checkmark in a checkbox is invisible (black). I tried messing around with style.css with various configurations for input, but it seems impossible to make the checkmark anything other than black. It's not a huge issue, but when editing bookmarks it becomes a little annoying. Any suggestions, or is this just a limitation of the css implementation? Thanks, Alex

May 20, 2025

Re: [PATCH] Revert "Use right button to close tabs by default"

by Plasma (David Paul)

On Wed, 30 Apr 2025 22:52:57 +0200 Rodrigo Arias <rodarima(a)gmail.com> wrote: > On Wed, Apr 30, 2025 at 03:31:21PM -0500, Plasma (David Paul) wrote: > >This reverts commit 6392699316bbdfd027862fa28050cd54253f25d4. > >--- > > > >Notes: > > This change addresses two issues: > > > > 1. This restores the ability to close a tab by middle-clicking on > > it. This matches long-supported behaviour of other browsers. > > Since when do we follow what other browsers do? Ok, maybe that wasn't the best way to phrase that. It's not just browsers that support closing a tab by middle-clicking; it is also the standard behaviour in both my IRC client and my graphical text editor (in addition to my other browsers). Dillo having a different default is disorienting in a similar manner (though, admittedly, not to the same severity) as driving a vehicle and discovering that the functions of the pedals are flipped. > > 2. Right-clicking a tab is now no longer a destructive action. > > It is common user expectation that right-clicking may produce a > > contextual menu. This expectation should not result in a lost tab. > > Not interested in this patch, not all systems have 3 mouse button, > specially old netbooks. If you prefer to use the middle button change > the option in dillorc. Alas. -- Plasma

May 1, 2025