June 2016 - Dillo-dev - lists.mailman3.com

Strange performance behaviour related to <span>

by jcid＠dillo.org

On Sun, Jun 05, 2016 at 11:34:13PM +0200, Sebastian Geerken wrote: > Hi! > > I've stripped down one testcase to a sequence of simple HTML snippets. > Try > > (for i in $(seq 1 20); do echo '<div style="float:left"><div></div><div style="display:table"><span></div></div>'; done) > tmp.html; dillo tmp.html > > and the development version of dillo hangs for a while. You may vary > the number (second argument of seq). > > If you look at the file tmp.html, you'll notice that it is incorrect > HTML. Interrestinly, leaving the <span> away still results in > incorrect and deeply nested HTML, but dillo is much faster: > > (for i in $(seq 1 20); do echo '<div style="float:left"><div></div><div style="display:table"></div></div>'; done) > tmp.html; dillo tmp.html > > Dillo 3.0.5 is fast in both cases. > > Does anyone have an idea what effect the <span> has? > > I've already run gprof, but the result does not look very meaningful > at a first glance. OK, after some experiments I see what happens. If you close the SPAN element, it's fast again. The problem lies in how the parser handles bad HTML, and how the rendering deals with it afterwards. In this case the span is left open, and so we end with an anomalous tree where an inline container has 20 levels of block containers inside inline containers. You can surely imagine the mess textblock and OOFM get trapped-in when trying to make sense of it all! :) Good news, I already have a working patch. It needs some testing because it constitutes a big change in how we deal with bad-formed HTML, but so far it makes more sense than what we have now. If you need the patch quick just drop me a note. HTH. -- Cheers Jorge.-

June 6, 2016

Strange performance behaviour related to <span>

by sgeerken＠dillo.org

Hi! I've stripped down one testcase to a sequence of simple HTML snippets. Try (for i in $(seq 1 20); do echo '<div style="float:left"><div></div><div style="display:table"><span></div></div>'; done) > tmp.html; dillo tmp.html and the development version of dillo hangs for a while. You may vary the number (second argument of seq). If you look at the file tmp.html, you'll notice that it is incorrect HTML. Interrestinly, leaving the <span> away still results in incorrect and deeply nested HTML, but dillo is much faster: (for i in $(seq 1 20); do echo '<div style="float:left"><div></div><div style="display:table"></div></div>'; done) > tmp.html; dillo tmp.html Dillo 3.0.5 is fast in both cases. Does anyone have an idea what effect the <span> has? I've already run gprof, but the result does not look very meaningful at a first glance. Sebastian

June 5, 2016

Patch: Zero detected HTML errors

by nick＠linicks.net

Hi Devs, The sentence (Dillo message): Zero detected HTML errors! Is a bit contrived in English - this small patch (attached) changes it to more legal/legible English usage. Regards, Nick -- Gosh that takes me back... or is it forward? That's the trouble with time travel, you never can tell." -- Doctor Who "Androids of Tara"

June 5, 2016

Missing anchor - strange results

by nick＠linicks.net

On Sat, 4 Jun 2016 20:48:28 -0400 Jorge Arellano Cid <jcid at dillo.org> wrote: > > > Strange one to find - Dillo is great at finding stuff like this - > > > other browsers hide it all. > > > > Good catch, good news, > > > > I'm testing a patch for this one (part 2 of patch 4557). > > Committed. Works perfectly - thanks! Nick -- Gosh that takes me back... or is it forward? That's the trouble with time travel, you never can tell." -- Doctor Who "Androids of Tara"

June 5, 2016

Missing anchor - strange results

by jcid＠dillo.org

On Sat, Jun 04, 2016 at 05:54:09PM -0400, Jorge Arellano Cid wrote: > On Sat, Jun 04, 2016 at 09:45:31PM +0100, Nick Warne wrote: > > On Sat, 4 Jun 2016 16:51:09 +0000 > > eocene <eocene at gmx.com> wrote: > > > > > On Sat, Jun 04, 2016 at 04:21:24PM +0100, Nick Warne wrote: > > > > Hi All, > > > > > > > > I don't know what to make of this one: > > > > > > > > http://apod.nasa.gov/apod/ap160604.html > > > > > > > > It appears line 49 in the source is missing a </a> which seems make > > > > the whole paragraph a URL, but the other URLs in there are still > > > > shown/valid if you hover over the text. > > > > > > > > Viewing the source, no errors are reported by Dillo either. > > > > > > > > So do we get a URL embedding all the other URLs on the plain text > > > > in between? > > > > > > Hmm, it does say in HTML5 for the A element: > > > > > > "Content model: > > > > > > Transparent, but there must be no interactive content or a element > > > descendants." > > > > > > ...so perhaps one should be closed with a warning when another is > > > seen. > > > > Yes, also surely there is no case to do embedded <a href=... <a > > href=...</a> </a> is there (even though this was a typo)? > > > > Strange one to find - Dillo is great at finding stuff like this - other > > browsers hide it all. > > Good catch, good news, > > I'm testing a patch for this one (part 2 of patch 4557). Committed. -- Cheers Jorge.-

June 5, 2016

Missing anchor - strange results

by jcid＠dillo.org

On Sat, Jun 04, 2016 at 09:45:31PM +0100, Nick Warne wrote: > On Sat, 4 Jun 2016 16:51:09 +0000 > eocene <eocene at gmx.com> wrote: > > > On Sat, Jun 04, 2016 at 04:21:24PM +0100, Nick Warne wrote: > > > Hi All, > > > > > > I don't know what to make of this one: > > > > > > http://apod.nasa.gov/apod/ap160604.html > > > > > > It appears line 49 in the source is missing a </a> which seems make > > > the whole paragraph a URL, but the other URLs in there are still > > > shown/valid if you hover over the text. > > > > > > Viewing the source, no errors are reported by Dillo either. > > > > > > So do we get a URL embedding all the other URLs on the plain text > > > in between? > > > > Hmm, it does say in HTML5 for the A element: > > > > "Content model: > > > > Transparent, but there must be no interactive content or a element > > descendants." > > > > ...so perhaps one should be closed with a warning when another is > > seen. > > Yes, also surely there is no case to do embedded <a href=... <a > href=...</a> </a> is there (even though this was a typo)? > > Strange one to find - Dillo is great at finding stuff like this - other > browsers hide it all. Good catch, good news, I'm testing a patch for this one (part 2 of patch 4557). -- Cheers Jorge.-

June 4, 2016

Missing anchor - strange results

by nick＠linicks.net

On Sat, 4 Jun 2016 16:51:09 +0000 eocene <eocene at gmx.com> wrote: > On Sat, Jun 04, 2016 at 04:21:24PM +0100, Nick Warne wrote: > > Hi All, > > > > I don't know what to make of this one: > > > > http://apod.nasa.gov/apod/ap160604.html > > > > It appears line 49 in the source is missing a </a> which seems make > > the whole paragraph a URL, but the other URLs in there are still > > shown/valid if you hover over the text. > > > > Viewing the source, no errors are reported by Dillo either. > > > > So do we get a URL embedding all the other URLs on the plain text > > in between? > > Hmm, it does say in HTML5 for the A element: > > "Content model: > > Transparent, but there must be no interactive content or a element > descendants." > > ...so perhaps one should be closed with a warning when another is > seen. Yes, also surely there is no case to do embedded <a href=... <a href=...</a> </a> is there (even though this was a typo)? Strange one to find - Dillo is great at finding stuff like this - other browsers hide it all. Nick -- Gosh that takes me back... or is it forward? That's the trouble with time travel, you never can tell." -- Doctor Who "Androids of Tara"

June 4, 2016

Missing anchor - strange results

by eocene＠gmx.com

On Sat, Jun 04, 2016 at 04:21:24PM +0100, Nick Warne wrote: > Hi All, > > I don't know what to make of this one: > > http://apod.nasa.gov/apod/ap160604.html > > It appears line 49 in the source is missing a </a> which seems make the > whole paragraph a URL, but the other URLs in there are still > shown/valid if you hover over the text. > > Viewing the source, no errors are reported by Dillo either. > > So do we get a URL embedding all the other URLs on the plain text > in between? Hmm, it does say in HTML5 for the A element: "Content model: Transparent, but there must be no interactive content or a element descendants." ...so perhaps one should be closed with a warning when another is seen.

June 4, 2016

Missing anchor - strange results

by nick＠linicks.net

Hi All, I don't know what to make of this one: http://apod.nasa.gov/apod/ap160604.html It appears line 49 in the source is missing a </a> which seems make the whole paragraph a URL, but the other URLs in there are still shown/valid if you hover over the text. Viewing the source, no errors are reported by Dillo either. So do we get a URL embedding all the other URLs on the plain text in between? Nick -- Gosh that takes me back... or is it forward? That's the trouble with time travel, you never can tell." -- Doctor Who "Androids of Tara"

June 4, 2016