May 2016 - Dillo-dev - lists.mailman3.com

Bug in meta tag refresh code [with cause]

by nick＠linicks.net

I have been looking at this for about 5 hours now, and it has fried my brain. Reading the code, and then reading the email thread about depreciated meta tag 'refresh', I agree with Dillo's actions. But what I found was that on some sites (mine included), if there was a tag: <meta http-equiv="refresh" content="15" /> Dillo reports and the warning message reports: The author wanted you to go _here_ after 10 seconds. What happens now is the link (_here_) gets appended with the refresh value, so for example: www.example.com/refesh.html becomes: www.example.com/10 (or 15 or whatever the refresh value is). I have found that if the meta tag is right: <meta http-equiv="refresh" content="5;URL='./index.html'" /> then the code creates the right URL (but it's not seen as no warning is given. html.cc from line 3218 if the meta tag refresh is correct HTML on the web page, mr_url returns the correct path to the refresh. If it isn't, then mr_url returns the value of the refresh - which fubars the warning messages link. I tested this running dillo from the commandline with this insertion and testing the correct and wrong meta tags: } /* Skip to anything after "URL=" or ";" if "URL=" is not found */ if ((p = dStriAsciiStr(content, "url="))) content = p + strlen("url="); else if ((p = strstr(content, ";"))) content = p + strlen(";"); /* Handle the case of a quoted URL */ if (*content == '"' || *content == '\'') { if ((p = strchr(content + 1, *content))) mr_url = dStrndup(content + 1, p - content - 1); else mr_url = dStrdup(content + 1); } else { mr_url = dStrdup(content); } //nick printf ("%s\n", mr_url); new_url = a_Html_url_new(html, mr_url, NULL, 0); // new_url = a_Html_url_new(html, ".", NULL, 0); Not being very good with C++, I can't work out what goes wrong here - but it looks like that if 'URL=' or';' isn't found, then the code still looks for quotes - which does something to the string? I have two pages you can test on - one with the proper meta tag, and one with out: http://irpi.linicks.net:8080/static_simple.html <- good http://fishpi.linicks.net:8081/static_simple.html <- bad - that shows the bug If possible view both with that printf I put in - you can see what mr_url returns. Phew* Nick -- Gosh that takes me back... or is it forward? That's the trouble with time travel, you never can tell." -- Doctor Who "Androids of Tara"

May 1, 2016

Minor bug in test/cookies.c

by jcid＠dillo.org

On Sun, May 01, 2016 at 11:05:27AM +0100, Nick Warne wrote: > Hi Jorge, > > I saw the two minor fixes you done today - here's another: > > :~/slackbuilds/dillo/hg/dillo$ grep -Rin "} if" * > test/cookies.c:426: } if ((ret = Dpi_blocking_read(sock_fd)) == NULL) { Right, committed, thks! -- Cheers Jorge.-

May 1, 2016

Minor bug in test/cookies.c

by nick＠linicks.net

Hi Jorge, I saw the two minor fixes you done today - here's another: :~/slackbuilds/dillo/hg/dillo$ grep -Rin "} if" * test/cookies.c:426: } if ((ret = Dpi_blocking_read(sock_fd)) == NULL) { Nick -- Gosh that takes me back... or is it forward? That's the trouble with time travel, you never can tell." -- Doctor Who "Androids of Tara"

May 1, 2016