January 2013 - Dillo-dev - lists.mailman3.com

ui colors again

by corvid＠lavabit.com

Jorge wrote: > Of course it should also be able to manage saving the custom > defined theme. Do you mean saving things to dillorc?

Jan. 6, 2013

[patch] consistent file save UI behaviour for overwriting files

by corvid＠lavabit.com

Jeremy wrote: > These two patches move the UI logic from the downloads DPI into Dillo. > This puts all the UI logic in the same place and ensures consistent > behaviour for "Save link as file" whether or not the URL is cached. Seems good to have the logic in dillo. I imagine a later step would be to teach UIcmd_save_file_check() about file permissions, errno possibilities, etc.

Jan. 6, 2013

[patch] modified a_Dialog_choice5 to accept any number alternatives

by corvid＠lavabit.com

p37sitdu wrote: > -5 LOC, nothing is changed visually I haven't looked at it carefully or anything, but I like the idea of not being hardcoded to five anymore... PS I made a choice5 once to fit the long error msgs from https, but it was vetoed (can't remember exactly why).

Jan. 6, 2013

[patch] consistent file save UI behaviour for overwriting files

by onepoint＠starurchin.org

The UI for downloading files is split between Dillo (which prompts for a file to save to) and the downloads DPI (which prompts for another file if the first file already exists). This leads to inconsistent behaviour for "Save link as file" depending on whether the URL is cached or not - if it is cached then any existing file is silently overwritten but if it is not cached we go to the downloads DPI which prompts before overwriting anything. These two patches move the UI logic from the downloads DPI into Dillo. This puts all the UI logic in the same place and ensures consistent behaviour for "Save link as file" whether or not the URL is cached. http://starurchin.org/dillo/patch/downloads-dpi_file_test_remove.html http://starurchin.org/dillo/patch/uicmd-cc_file_test_add.html Comments? Shall I push this? Regards, Jeremy Henty

Jan. 6, 2013

[patch] modified a_Dialog_choice5 to accept any number alternatives

by p37sitdu＠lavabit.com

-5 LOC, nothing is changed visually

Jan. 5, 2013

autotools

by p37sitdu＠lavabit.com

There is autogen.sh in source tree. It can be replaced with "autoreconf -i" or simply removed. According to ChangeLog of autoconf, autoreconf has been there for at least 10 years. I also looked at configure.ac. In attached patch I added dillo URL, used AS_HELP_STRING to format help lines, replaced AC_ERROR with AC_MSG_ERROR (it was renamed) and replaced -D flags with AC_DEFINE. If no config.h is used, flags should be added to DEFS variable, but with config.h they should be defined in config.h using AC_DEFINE. The problem is that not all files include config.h. I added #includes where necessary, but to avoid problems when some files see defines and some files don't, config.h should be included by every .c and .cc file before all other includes.

Jan. 5, 2013

[patch] remove redundant check in cache.c

by jcid＠dillo.org

On Sat, Jan 05, 2013 at 05:55:03PM +0400, p37sitdu at lavabit.com wrote: > > # HG changeset patch > # Parent 9195a2df5ca310cc907f3d5df3593acaed988820 > > diff -r 9195a2df5ca3 src/cache.c > --- a/src/cache.c > +++ b/src/cache.c > @@ -233,7 +233,7 @@ > break; > } > /* Test for a working redirection */ > - if (entry && entry->Flags & CA_Redirect && entry->Location) { > + if (entry->Flags & CA_Redirect && entry->Location) { > Url = entry->Location; > } else > break; Committed. -- Cheers Jorge.-

Jan. 5, 2013

[patch] remove redundant check in cache.c

by p37sitdu＠lavabit.com

Jan. 5, 2013

Patch for xembed updated

by podarcis＠lavabit.com

Hi, I have updated my patch (no removal of existing code, added comments, trimmed the source,..). Let me perhaps explain from the beginning: My starting point was, that when embedding dillo from an external program using the --xid parameter, dillo's window didn't show up in the embedder. I have now found, there's a one-line fix for that problem: -> dillo_xembed_patch_1.txt After that was working again (by the way: it worked in dillo2 already) I tried to make resizing of the embedder window work too: -> dillo_xembed_patch_2.txt A test program for all this: -> dembed.cxx Looking forward for your comments. Cheers, Podarcis P.S.: I am aware now, that *real* embedding (to make tab-switching and focus-handling work together with the embedder) will require the usage of the xembed-protocol from the embedder side. I didn't touch the existing part of this implementation. But I guess embedding dillo without caring for this issues may be useful too, for example to just display help pages (no focus handling or tabbing required).

Jan. 5, 2013

ui colors again

by jcid＠dillo.org

On Thu, Jan 03, 2013 at 06:42:19AM +0000, corvid wrote: > > I added some more to the color choosing stuff: > > http://www.dillo.org/test/choose_colors2.diff Good. Just this minor fix to compile. diff -r cc706f9310db src/menu.cc --- a/src/menu.cc Fri Jan 04 12:13:39 2013 -0300 +++ b/src/menu.cc Fri Jan 04 16:53:20 2013 -0300 @@ -675,7 +675,7 @@ static Fl_Color get_label_color(int32_t static void Menu_base_color_change_cb(Fl_Widget*, void *user_data) { - Fl_Color colornum = (Fl_Color)user_data; + Fl_Color colornum = VOIDP2INT(user_data); int old_rgb = Fl::get_color(colornum); uchar r = old_rgb >> 24, g = (old_rgb >> 16) & 0xff, > > It's not terribly nice, careful code at this point. > It knows about the more recent prefs, and I spent some time making > the menu fancy for some reason. It helps a lot with making themes. BTW, a greenish one: ui_fg_color=#100404 ui_main_bg_color=#c8d394 ui_text_bg_color=#bdd8b6 ui_selection_color=#7c5f42 ui_button_highlight_color=#bdbd80 ui_tab_active_bg_color=#b5b679 ui_tab_active_fg_color=#b60907 ui_tab_bg_color=#cac682 -- Cheers Jorge.-

Jan. 4, 2013