June 2012 - Dillo-dev - lists.mailman3.com

[patch] dlib cleanup

by jcid＠dillo.org

On Sun, Jun 03, 2012 at 05:52:43PM +0400, 123 wrote: > On Sat, Jun 02, 2012 at 05:23:52PM -0400, Jorge Arellano Cid wrote: > > Hi, > > > > On Sun, Jun 03, 2012 at 12:13:41AM +0400, 123 wrote: > > > malloc.diff: added perror calls for malloc and realloc errors > > > > > > dstr.diff: dStr* functions cleanup > > > > > > dlist.diff: replaced recursive QuickSort with qsort from stdlib.h. > > > Tested with file.dpi where it is used for sorting directory listing. > > > > There're different criteria to write code. In dlib, a few lines > > are preferred to a single contracted one to make it simpler to > > understand. In the same spirit, scattered return statements are avoided > > to make code path following simpler. > > What about perror in malloc? It is still better than silent exit(1). Yes, it looks better. Some C libs leave errno unset, and others always set it to ENOMEM. Please excuse my ignorance, but what other error conditions may malloc return? > > For quick sort I remember having to implement it in dlib because > > stdlib's qsort varies among platforms. > > I can only find reports about problems in Solaris qsort related to > performance. There should be no known problems in platforms listed on > http://www.dillo.org/Compatibility.html and qsort is a part of > POSIX/SUS. > > qsort is also used in lout/container.cc so broken qsort will break > dillo anyway. AFAIR, there were some qsort receiving different types of arguments or behaving a bit different with some special border cases. I'll try to find what was it in the archives... Non uniform treatment in dlib/dillo is a bug. Unless we know that in container.cc we don't ever fall in one of the special cases. -- Cheers Jorge.-

June 4, 2012

[patch] HTML parser bugfix

by jcid＠dillo.org

On Sun, Jun 03, 2012 at 09:00:55PM +0100, Jeremy Henty wrote: > > 123 wrote: > > > Attached patch removes logic that tries to detect unterminated > > quoted attributes and fixes this bug. > > I would be wary of applying this patch without further thought. I run > Dillo with a very similar patch and it breaks *many* more pages than > it fixes. It is unfortunately necessary to detect and recover from > quoting errors in attributes. For instance, the web is *full* of > pages with tags containing this: > > foo="bar"" > > If you don't detect and ignore that extra double quote you will break > many pages that every other browser renders perfectly well. > > It's not even that uncommon to see monstrosities like this: > > foo=""bar""" > > It is also common to see short attributes (often CSS lengths) > delimited with a mixture of single and double quotes, eg: > > size="12pt' > > For these reasons, sadly, it is IMHO not realistic to just drop the > misquote-detection logic. Ditto. (FWIW, maybe this is the fourth time this patch is received; In the past the submitter has always desisted after some more testing). -- Cheers Jorge.-

June 4, 2012

[patch] HTML parser bugfix

by p37sitdu＠lavabit.com

According to WHATWG [1] fragment <div title=""abc""">def</div> should be parsed without errors until 'a' character. abc""" should be parsed as attribute name with parse errors because of lack of space character and quotes inside attribute name. [1] http://www.whatwg.org/specs/web-apps/current-work/multipage/tokenization.ht…

June 4, 2012

[patch] HTML parser bugfix

by p37sitdu＠lavabit.com

On Sun, Jun 03, 2012 at 09:00:55PM +0100, Jeremy Henty wrote: > I would be wary of applying this patch without further thought. I run > Dillo with a very similar patch and it breaks *many* more pages than > it fixes. It is unfortunately necessary to detect and recover from > quoting errors in attributes. For instance, the web is *full* of > pages with tags containing this: > > foo="bar"" > > If you don't detect and ignore that extra double quote you will break > many pages that every other browser renders perfectly well. Then there should be some logic for detecting double quotes. Searching for < inside quotes is not the right way as it breaks valid pages like reddit main page. Can you give examples of real web pages with double quotes? > It's not even that uncommon to see monstrosities like this: > > foo=""bar""" <div title=""abc""">def</div> does not show tip "abc" for def in Firefox. It silently displays nothing in Dillo after patch, however. I will try to fix it. > It is also common to see short attributes (often CSS lengths) > delimited with a mixture of single and double quotes, eg: > > size="12pt' <div title="abc'>def</div> displays nothing in Firefox. What browser can render it?

June 3, 2012

[patch] HTML parser bugfix

by onepoint＠starurchin.org

123 wrote: > Attached patch removes logic that tries to detect unterminated > quoted attributes and fixes this bug. I would be wary of applying this patch without further thought. I run Dillo with a very similar patch and it breaks *many* more pages than it fixes. It is unfortunately necessary to detect and recover from quoting errors in attributes. For instance, the web is *full* of pages with tags containing this: foo="bar"" If you don't detect and ignore that extra double quote you will break many pages that every other browser renders perfectly well. It's not even that uncommon to see monstrosities like this: foo=""bar""" It is also common to see short attributes (often CSS lengths) delimited with a mixture of single and double quotes, eg: size="12pt' For these reasons, sadly, it is IMHO not realistic to just drop the misquote-detection logic. Regards, Jeremy Henty

June 3, 2012

[patch] HTML parser bugfix

by p37sitdu＠lavabit.com

The following HTML fragment is shown as BUG<">abc by Dillo. It is valid (checked with validator.w3.org) HTML. In Firefox it is shown as abc with '>BUG<' tooltip. <div title=">BUG<">abc</div> What happens is that Dillo see < character inside quotes, shows bug "attribute lacks closing quote" and breaks out of tag parsing loop. In fact it is not possible to say if there is a bug in HTML at that point. In WWW you can see this bug on http://reddit.com. Each entry on this page contains votehash', null, event)" > and bug meter shows bugs for them. Attached patch removes logic that tries to detect unterminated quoted attributes and fixes this bug.

June 3, 2012

[patch] dlib cleanup

by p37sitdu＠lavabit.com

On Sat, Jun 02, 2012 at 05:23:52PM -0400, Jorge Arellano Cid wrote: > Hi, > > On Sun, Jun 03, 2012 at 12:13:41AM +0400, 123 wrote: > > malloc.diff: added perror calls for malloc and realloc errors > > > > dstr.diff: dStr* functions cleanup > > > > dlist.diff: replaced recursive QuickSort with qsort from stdlib.h. > > Tested with file.dpi where it is used for sorting directory listing. > > There're different criteria to write code. In dlib, a few lines > are preferred to a single contracted one to make it simpler to > understand. In the same spirit, scattered return statements are avoided > to make code path following simpler. What about perror in malloc? It is still better than silent exit(1). > For quick sort I remember having to implement it in dlib because > stdlib's qsort varies among platforms. I can only find reports about problems in Solaris qsort related to performance. There should be no known problems in platforms listed on http://www.dillo.org/Compatibility.html and qsort is a part of POSIX/SUS. qsort is also used in lout/container.cc so broken qsort will break dillo anyway.

June 3, 2012

[patch] typedefs and identifiers with leading underscores

by p37sitdu＠lavabit.com

Updated patch to fix warning in jpeg.c.

June 3, 2012

[patch] downloads dpi progress bar

by p37sitdu＠lavabit.com

Now progress bar is implemented as custom widget on top of Fl_Widget class. But FLTK already has Fl_Progress class for the same thing. Progress bar looks the same with two exceptions: 1. No tooltip: it is not displayed for Fl_Progress even when set. Normally progress bars, labels and other widgets for status information don't have tooltips so I think it is ok. 2. When downloading file without Content-Length, progress bar is always empty. With current implementation it changes for one percent on every update and remains somewhere in the middle when download is finished. For me keeping it at zero looks better. Patch and python HTTP server for testing downloads without Content-Length attached.

June 3, 2012

[patch] dlib cleanup

by jcid＠dillo.org

Hi, On Sun, Jun 03, 2012 at 12:13:41AM +0400, 123 wrote: > malloc.diff: added perror calls for malloc and realloc errors > > dstr.diff: dStr* functions cleanup > > dlist.diff: replaced recursive QuickSort with qsort from stdlib.h. > Tested with file.dpi where it is used for sorting directory listing. There're different criteria to write code. In dlib, a few lines are preferred to a single contracted one to make it simpler to understand. In the same spirit, scattered return statements are avoided to make code path following simpler. For quick sort I remember having to implement it in dlib because stdlib's qsort varies among platforms. -- Cheers Jorge.-

June 2, 2012