May 2012 - Dillo-dev - lists.mailman3.com

dpid patches

by joerg.sonnenberger＠web.de

On Sat, May 26, 2012 at 11:05:28PM +0400, 123 wrote: > One patch for using random instead of rand. [1] Guessing the intention here, I would recomment to use arc4random on systems that have it. time(0) should likely be spelled as time(NULL). > Reordered headers and removed old comments (what is ckt_write?). umask > is actually in sys/stat.h and not in unistd.h umask in sys/stat.h is correct. Joerg

May 26, 2012

dpid patches

by jcid＠dillo.org

On Sat, May 26, 2012 at 11:05:28PM +0400, 123 wrote: > One patch for using random instead of rand. [1] Ack. > Reordered headers and removed old comments (what is ckt_write?). umask > is actually in sys/stat.h and not in unistd.h Dillo compiles in several OSes/platforms, which sometimes have declarations in different files. This is the to-be-tested point. > (what is ckt_write?). ckd_write() an EINTR-protected write() (see dpid/dpid_common.c). > Also removed expired TODO item about dpi_service.[c|h]. Ack. -- Cheers Jorge.-

May 26, 2012

dillorc and src/keysrc

by p37sitdu＠lavabit.com

dillorc is in the root of repo and keysrc is in src/keysrc. Not a serious issue, but I think keysrc should be located in root too.

May 26, 2012

dpid patches

by p37sitdu＠lavabit.com

One patch for using random instead of rand. [1] Reordered headers and removed old comments (what is ckt_write?). umask is actually in sys/stat.h and not in unistd.h Also removed expired TODO item about dpi_service.[c|h]. [1] https://www.securecoding.cert.org/confluence/display/seccode/MSC30-C.+Do+no…

May 26, 2012

cleanup patches

by Johannes.Hofmann＠gmx.de

On Sat, May 26, 2012 at 03:59:12PM +0200, Alexander Voigt wrote: > Hi 123, > > why not introducing a macro like > > #define LENGTH(X) (sizeof (X) / sizeof (X)[0]) > > which could be used in all these for loops? I think this would make > the code simpler and less error prone. I'm not a fan of hiding this in macros. Something like struct foo * f = malloc(sizeof(struct foo) * 10); for(int i = 0; i < LENGTH(f); i++) { looks even more unsuspicious than with the sizeof stuff visible. Cheers, Johannes

May 26, 2012

cleanup patches

by Hole.destructor＠gmx.de

Hi 123, why not introducing a macro like #define LENGTH(X) (sizeof (X) / sizeof (X)[0]) which could be used in all these for loops? I think this would make the code simpler and less error prone. Best, Alexander

May 26, 2012

cleanup patches

by Johannes.Hofmann＠gmx.de

On Sat, May 26, 2012 at 09:26:39AM -0400, Jorge Arellano Cid wrote: > On Sat, May 26, 2012 at 02:02:17PM +0200, Johannes Hofmann wrote: > > On Sat, May 26, 2012 at 03:02:24PM +0400, 123 wrote: > > > One patch for README, one for dFree (no need to check for NULL) and > > > one for sizeof usage. > > > > thanks, committed. > > BTW, why is it better to have sizeof this way? > > - (sizeof(Css_shorthand_info) / sizeof(CssShorthandInfo)) > + (sizeof(Css_shorthand_info) / sizeof(Css_shorthand_info[0])) This way it stays correct even if someone changes the type of Css_shorthand_info to say CssShorthandInfo2. Not a big improvement, but I like it being consistently done like that. Cheers, Johannes

May 26, 2012

src/colors.c cleanup

by p37sitdu＠lavabit.com

- Fixed indentation. - Added LEN macro. - Reimplemented binary search using bsearch(3). - Changed NOTE: colors can be in any case, they are compared with dStrAsciiCasecmp.

May 26, 2012

cleanup patches

by jcid＠dillo.org

On Sat, May 26, 2012 at 02:02:17PM +0200, Johannes Hofmann wrote: > On Sat, May 26, 2012 at 03:02:24PM +0400, 123 wrote: > > One patch for README, one for dFree (no need to check for NULL) and > > one for sizeof usage. > > thanks, committed. BTW, why is it better to have sizeof this way? - (sizeof(Css_shorthand_info) / sizeof(CssShorthandInfo)) + (sizeof(Css_shorthand_info) / sizeof(Css_shorthand_info[0])) -- Cheers Jorge.-

May 26, 2012

cleanup patches

by Johannes.Hofmann＠gmx.de

On Sat, May 26, 2012 at 03:02:24PM +0400, 123 wrote: > One patch for README, one for dFree (no need to check for NULL) and > one for sizeof usage. thanks, committed. Cheers, Johannes

May 26, 2012