December 2012 - Dillo-dev - lists.mailman3.com

[patch] dpid/dpid.c unused variable

by p37sitdu＠lavabit.com

Patch removes unused variable usr_srv_num.

Dec. 7, 2012

Extensions for hyphenation

by sgeerken＠dillo.org

On Fri, Dec 07, Jorge Arellano Cid wrote: > On Thu, Dec 06, 2012 at 09:38:28PM +0100, Sebastian Geerken wrote: > > 2. How to deal with tables? > > > > a) I've pushed my changes regarding extremes calculation to > > <http://flpsed.org/hgweb/dillo_hyphen>, but I'd like to push it into > > the main repository as soon as possible. The current state has some > > bugs, but I hope it should be stable soon. > > > > This is, BTW, generally some cleanup and so useful independent of this > > special purpose. (Might be even somewhat faster than the old > > implementation.) > > Probably this is the way to go. Just push it into the main repo > as soon as you find it stable enough. Just pushed to http://hg.dillo.org/dillo. I've found no problems so far, but please take another look. Something which came to my mind: should this new rule, to exclude hyphenation breaks from minimal width calculation, also be applied to soft hyphens? Currently it is applied to both, but letting minimal width calculation consider soft hyphens as possible breaks may be feasable, since soft hyphens are set by the author himself (who, OTOH, is surprised by the fact that there is a browser also hyphenating automatically ;-) ). This would be rather simple: diff -r 6a525e279c5d dw/textblock.cc --- a/dw/textblock.cc Fri Dec 07 19:32:40 2012 +0100 +++ b/dw/textblock.cc Fri Dec 07 19:45:52 2012 +0100 @@ -41,7 +41,7 @@ Textblock::DivChar Textblock::divChars[NUM_DIV_CHARS] = { // soft hyphen (U+00AD) - { "\xc2\xad", true, false, true, PENALTY_HYPHEN, -1 }, + { "\xc2\xad", true, false, false, PENALTY_HYPHEN, -1 }, // simple hyphen-minus: same penalties like automatic or soft // hyphens { "-", false, true, true, -1, PENALTY_HYPHEN }, // (unconditional) hyphen (U+2010): handled exactly like // minus-hyphen. See test/table-h1.html for the effect. Sebastian

Dec. 7, 2012

Extensions for hyphenation

by jcid＠dillo.org

On Fri, Dec 07, 2012 at 10:51:03AM +0100, Sebastian Geerken wrote: > Just one comment: > > On Thu, Dec 06, Jorge Arellano Cid wrote: > > In that case, AFAIU, a dillorc option can be formulated as: > > > > Breaking a single word in a line is not possible unless it is > > wider than XX chars (e.g. single_word_max_length). > > > > (I assume knowing whether a word is alone in a line is possible > > by comparing the start and end indexes of the array, but haven't > > checked it...) > > Yet again, the problem is to calculate the correct extremes, to avoid > too narrow columns. However, at this point, we do not have lines: > these are calculated as soon as a given column width is calculated > (which depends on the correct extremes). Ahhh!, now I see what you mean. > After the release, other approaches could be discussed. If that's the case, then we only have a set of words to work with; It may be possible to devise a different heuristic. -- Cheers Jorge.-

Dec. 7, 2012

Extensions for hyphenation

by jcid＠dillo.org

On Thu, Dec 06, 2012 at 09:38:28PM +0100, Sebastian Geerken wrote: > Hi! > > Sorry for cutting this a bit off, but I'd like to suggest the > following steps: > > 1. Concentrate on the next release, with hyphenation support. Which > issues are open? I recall these: (a) How to deal with the pattern > files, and (b) tables. Did I forget something? Are there some pages > not rendering which were rendering before? Not that I'm aware of (besides the table issue). > For dealing with tables, see below, step 2 (after step 3). > > 3. Floats: will not be part of the next release, but I'd like to > finish this rather soon; this has been delayed already long enugh. > (There has been some progress, BTW, see > <http://flpsed.org/hgweb/dillo_floats_geerken>.) Great. > 2. How to deal with tables? > > a) I've pushed my changes regarding extremes calculation to > <http://flpsed.org/hgweb/dillo_hyphen>, but I'd like to push it into > the main repository as soon as possible. The current state has some > bugs, but I hope it should be stable soon. > > This is, BTW, generally some cleanup and so useful independent of this > special purpose. (Might be even somewhat faster than the old > implementation.) Probably this is the way to go. Just push it into the main repo as soon as you find it stable enough. > b) I'd like to use it for my approach: not using hyphenation for > calculation the extremes, but of course, using hyphenation when > breaking lines (also in table cells). This gives us: > > (i) full advantages of hyphenation; > > (ii) no risk regarding table rendering: table columns will be the same > as before, and similar to other browsers (without hyphenation), so the > problems Jorge mentioned will not occure; > > (iii) finally, this would make one bug obsolete: > > | **Incorrect calculation of extremes:** The minimal width of a text > | block (as part of the width extremes, which are mainly used for > | tables) is defined by everything between two possible breaks. A > | possible break may also be a hyphenation point; however, hyphenation > | points are calculated in a lazy way, when the lines are broken, and > | not when extremes are calculated. So, it is a matter of chance whether > | the calculation of the minimal width will take the two parts "dil-" > | and "lo" into account (when "dillo" has already been hyphenated), or > | only one part, "dillo" (when "dillo" has not yet been hyphenated), > | resulting possibly in a different value for the minimal width. > > (See "dw-line-breaking.doc" for more. This would leave only "low > priority" issues.) > > After the release, other approaches could be discussed. This looks like the simplest approach. -- Cheers Jorge.-

Dec. 7, 2012

Extensions for hyphenation

by sgeerken＠dillo.org

Just one comment: On Thu, Dec 06, Jorge Arellano Cid wrote: > In that case, AFAIU, a dillorc option can be formulated as: > > Breaking a single word in a line is not possible unless it is > wider than XX chars (e.g. single_word_max_length). > > (I assume knowing whether a word is alone in a line is possible > by comparing the start and end indexes of the array, but haven't > checked it...) Yet again, the problem is to calculate the correct extremes, to avoid too narrow columns. However, at this point, we do not have lines: these are calculated as soon as a given column width is calculated (which depends on the correct extremes). Sebastian

Dec. 7, 2012

ideographic, zero-width space

by sgeerken＠dillo.org

On Tue, Nov 27, corvid wrote: > Would it make the most sense for the handling of ideographic characters > and zero-width space to go somewhere in textblock these days instead of > html.cc? I'd tend to this shift, especally since now everything is represented as CSS (and so dw style attributes). In the past, it was the HTML parser who now about HTML tags like <pre> etc. Thinking this further to an extreme, there would not be a method for adding words, but a method adding characters; breaking into words is then done by the textblock widget. (Not sure about the this, OTOH.) Sebastian

Dec. 6, 2012

Extensions for hyphenation

by sgeerken＠dillo.org

Hi! Sorry for cutting this a bit off, but I'd like to suggest the following steps: 1. Concentrate on the next release, with hyphenation support. Which issues are open? I recall these: (a) How to deal with the pattern files, and (b) tables. Did I forget something? Are there some pages not rendering which were rendering before? For dealing with tables, see below, step 2 (after step 3). 3. Floats: will not be part of the next release, but I'd like to finish this rather soon; this has been delayed already long enugh. (There has been some progress, BTW, see <http://flpsed.org/hgweb/dillo_floats_geerken>.) 2. How to deal with tables? a) I've pushed my changes regarding extremes calculation to <http://flpsed.org/hgweb/dillo_hyphen>, but I'd like to push it into the main repository as soon as possible. The current state has some bugs, but I hope it should be stable soon. This is, BTW, generally some cleanup and so useful independent of this special purpose. (Might be even somewhat faster than the old implementation.) b) I'd like to use it for my approach: not using hyphenation for calculation the extremes, but of course, using hyphenation when breaking lines (also in table cells). This gives us: (i) full advantages of hyphenation; (ii) no risk regarding table rendering: table columns will be the same as before, and similar to other browsers (without hyphenation), so the problems Jorge mentioned will not occure; (iii) finally, this would make one bug obsolete: | **Incorrect calculation of extremes:** The minimal width of a text | block (as part of the width extremes, which are mainly used for | tables) is defined by everything between two possible breaks. A | possible break may also be a hyphenation point; however, hyphenation | points are calculated in a lazy way, when the lines are broken, and | not when extremes are calculated. So, it is a matter of chance whether | the calculation of the minimal width will take the two parts "dil-" | and "lo" into account (when "dillo" has already been hyphenated), or | only one part, "dillo" (when "dillo" has not yet been hyphenated), | resulting possibly in a different value for the minimal width. (See "dw-line-breaking.doc" for more. This would leave only "low priority" issues.) After the release, other approaches could be discussed. Comments and thoughts? Regards Sebastian

Dec. 6, 2012

Extensions for hyphenation

by jcid＠dillo.org

On Wed, Dec 05, 2012 at 11:59:01AM +0100, Sebastian Geerken wrote: > On Sat, Nov 24, Jorge Arellano Cid wrote: > > > Calculating width extremes, and so table rendering, > > > is independent of the actual penalty values (except for the value > > > "inf"i; see below). > > > > I beg to differ. > > > > > [...] > > > Penaltie values cannot actually influence table rendering: > > > > > > 1. Column widths depend on column min/max widths and available width > > > (window width at the top). > > > > Agreed. > > > > > 2. Column min/max widths depend on cell min/max widths (maximum of the > > > respective values). > > > > Agreed. > > > > > 3. Cell widths (calculated in dw::Textblock::getExtremesImpl) do not > > > take the penalty values into account, only three cases are > > > distinguished: inf (no break allowed), -inf (break forced), and > > > other values (break possible.) > > > > Agreed. > > > > > So changing penalties (say, to 5 instead of 1), won't make a > > > difference. > > > > Here I differ. Please let me know what I'm missing. > > > > If a penalty can increase the badness of breaking certain word, > > to the point of it not being broken (ar at least be broken less times), > > > > e.g. > > becomes or > > hy- hyphenation hyphen- > > phen- ation > > ation > > > > and that word is the only word in a cell, and that cell is the > > widest in its column (as in the URL example [1]), then cell max > > is affected (as you explain in point 2), an so table rendering. > > Penalties are useful for decisions regarding actual line breaking, but > calculating the minimal width must regard all possible breaks; so > there is only a decision whether a break is possible at all, or *not* > possible at all. Both breaks, with penalties of 1 or 5, respectively, > are possible breaks. Ack! > So, as long as table calculation is kept this simple way (and not > replaced by something more complex), the only possibility is to regard > some breaks as not possible at all, when the minimal width is > calculated. In that case, AFAIU, a dillorc option can be formulated as: Breaking a single word in a line is not possible unless it is wider than XX chars (e.g. single_word_max_length). (I assume knowing whether a word is alone in a line is possible by comparing the start and end indexes of the array, but haven't checked it...) > > > > [...] > > > > or even simpler, in characters: > > > > > > > > penalty_one_word_line=18 > > > > /* Don't try to break words shorter than 18 chars, when > > > > alone in a single line */ > > > > > > > > > > > > The advantage I see to a penalty that handles this case is that > > > > it can help a lot with web rendering and also with more precise > > > > book rendering with a simple dillorc option. > > > > > > Could be, but it sounds a bit hackish, and with an uncertain result. > > > Could be worth a test, however. > > > > It sounds a bit strange, but also the problem is: if we have to > > format text into a narrow column, breaking a long word to make it > > fit in, is clearly the way to go. Now, if breaking that word also > > makes the column narrower for the whole text (as narrow as the > > broken word's widest split part), then we have to choose which of > > both cases is better. > > Generally, yes. But notice the order: 1. min/max width of the cell, > and so min/max width of the column, 2. *actual* width of the column, > 3. line breaking, based on the actual width. Any change must be made > in #1, otherwise it is too late. > > So, the decision has to be simplified: regarding a given point as > possible break or not. The actual column width (as you describe it) > cannot be regarded. I understand the point. But can it be decided beforehand (i.e. without knowing the actual width of the column), as stated above? (e.g. declaring via dillorc option that columns narrower than 18 characters are "bad" when a single word in a line needs hyphenation.). > > [...] > > I'd like to have the best choice rendered! ;-) > > Independant of the approach actually implemented (perhaps both should > be tested), the calculation of extremes has to be re-implemented, to > decouple it from the line breaking. This is some more work, and rather > risky (now half finished, but unstable). Is this something for the > next release, or should we ignore it, on the short term? I don't know the complexity of this task, it certainly sounds daunting to me. I'd *like* to have full hyphenation in our next release, but also priorize floating objects over it. Certainly you're in a better position to evaluate the effort, side effects of it, and also decide. > I can push my changes in another repository, if you want to take a > look at it. If we were working in the same physical place, perhaps I could be of more help. My feeling is I would be more of a burden to explain the whole problem to by email than of help. If you feel otherwise, we may try. -- Cheers Jorge.-

Dec. 6, 2012

Patch set: improve window titles

by jcid＠dillo.org

On Wed, Dec 05, 2012 at 06:54:43PM +0000, corvid wrote: > Jeremy wrote: > > Please comment. There is nothing complicated or disruptive here - > > just some minor polishing of the GUI and the code base. No > > functionality is changed. > > These are a good improvement... Looks good and clean, +1 -- Cheers Jorge.-

Dec. 6, 2012

Patch set: improve window titles

by corvid＠lavabit.com

Jeremy wrote: > Please comment. There is nothing complicated or disruptive here - > just some minor polishing of the GUI and the code base. No > functionality is changed. These are a good improvement...

Dec. 5, 2012