November 2012 - Dillo-dev - lists.mailman3.com

Handling preferences

by jcid＠dillo.org

Hi Sebastian, On Thu, Nov 15, 2012 at 01:42:29PM +0100, Sebastian Geerken wrote: > Hi! > > I'm just working on making some values related to hyphenation > configurable via dillorc. A long time ago (before the Fltk port), Dw > directy accessed the prefs module for the value limit_text_width. When > Dw was ported to Fltk (which was largely a rewrite), it was seperated, > so it does not depend on prefs anymore. However, this made it > necessary to pass the value of prefs.limit_text_width to dw::Textblock > in the constructor. > > Now, I do not want to extend dw::Textblock::Textblock() by a couple of > new parameters. Instead, I though of storing the values directly in Dw > (initialized by feasable standard values), and the prefs parser must > store them there. This way, Dw is still independent. This could be > adapted in other modules. > > Currenty, my code is this: > > 1. The new values are still stored in DilloPrefs. > > 2. There is a static method dw::Textblock::init, which called in main, > after the prefs parser: > > @@ -50,6 +50,7 @@ > #include "auth.h" > > #include "dw/fltkcore.hh" > +#include "dw/textblock.hh" > > /* > * Command line options structure > @@ -359,6 +360,8 @@ > a_Cookies_init(); > a_Auth_init(); > > + dw::Textblock::init (prefs.penalty_hyphen, prefs.penalty_hyphen_2); > + > /* command line options override preferences */ > if (options_got & DILLO_CLI_FULLWINDOW) > prefs.fullwindow_start = TRUE; > > Any thoughts/comments? Incidentally, today I was looking into the scrolling step (both for keyboard and mousewheel/scrollpad), and there's this method: void FltkViewport::setScrollStep(int step); also CustomButton has: void CustomButton::hl_color(Fl_Color col); etc. AFAICS an init(p1, p2, ...) function is very good for setting the whole prefs pack at once, but it doesn't seem as convenient for changing just one of those vars at run time; which may be necessary for instance if we ever implement a preferences dpi or enable a custom UI (as with change panel size). I'm a bit more inclined towards the separate functions for each var approach. BTW, your example also implicitly touches this point: dillorc may set a certain value, and a CLI parameter override it. In this case the separate functions approach seems cleaner. -- Cheers Jorge.-

Nov. 15, 2012

Handling preferences

by sgeerken＠dillo.org

Hi! I'm just working on making some values related to hyphenation configurable via dillorc. A long time ago (before the Fltk port), Dw directy accessed the prefs module for the value limit_text_width. When Dw was ported to Fltk (which was largely a rewrite), it was seperated, so it does not depend on prefs anymore. However, this made it necessary to pass the value of prefs.limit_text_width to dw::Textblock in the constructor. Now, I do not want to extend dw::Textblock::Textblock() by a couple of new parameters. Instead, I though of storing the values directly in Dw (initialized by feasable standard values), and the prefs parser must store them there. This way, Dw is still independent. This could be adapted in other modules. Currenty, my code is this: 1. The new values are still stored in DilloPrefs. 2. There is a static method dw::Textblock::init, which called in main, after the prefs parser: @@ -50,6 +50,7 @@ #include "auth.h" #include "dw/fltkcore.hh" +#include "dw/textblock.hh" /* * Command line options structure @@ -359,6 +360,8 @@ a_Cookies_init(); a_Auth_init(); + dw::Textblock::init (prefs.penalty_hyphen, prefs.penalty_hyphen_2); + /* command line options override preferences */ if (options_got & DILLO_CLI_FULLWINDOW) prefs.fullwindow_start = TRUE; Any thoughts/comments? Sebastian

Nov. 15, 2012

fill in that little square that the scrollbars form

by sgeerken＠dillo.org

On Wed, Nov 14, corvid wrote: > I don't know this drawing/damage code well enough to know whether this > is the best way to go about it, but it appears to work. Looks correct to me. Feel free to commit. Sebastian

Nov. 14, 2012

Tooltip bugs revisited

by jcid＠dillo.org

Hi, After some more testing I decided to commit the custom tooltip handler patchset for you to try. I has worked very well here so far. Please see details with: $hg log -v :-) -- Cheers Jorge.-

Nov. 14, 2012

fill in that little square that the scrollbars form

by corvid＠lavabit.com

I don't know this drawing/damage code well enough to know whether this is the best way to go about it, but it appears to work.

Nov. 14, 2012

Tooltip bugs revisited

by corvid＠lavabit.com

Jorge wrote: > On Sun, Nov 11, 2012 at 09:18:08PM +0000, corvid wrote: > > Jorge wrote: > > > Testing revealed the workaround concealed another problem, > > > which I don't remember whether it was detected before, and this > > > is that viewport mouse events get "through" the panel UI!. > > > > > > How?, placing the mouse pointer over the panel (e.g. to the > > > right of the Tools button, or even inside the Location), and > > > scrolling a page full of links under it, will make the mouse > > > pointer change to a hand, and the destination link appear in the > > > status bar area. > > > > > > This bug is revealed by disabling the workaround: just apply > > > the small attached patch. > > > > > > Clearly there's a viewport offset problem somewhere. Correcting > > > it may save us lots of headaches in the future. > > > > > > Does anybody know or has a clue of where this may be happening? > > > > > > TIA. > > > > Does this work for you? > > > diff -r 8b4259cdc6da dw/fltkviewport.cc > > --- a/dw/fltkviewport.cc Sat Nov 10 17:55:34 2012 +0000 > > +++ b/dw/fltkviewport.cc Sun Nov 11 21:14:40 2012 +0000 > > @@ -318,6 +318,10 @@ > > mouse_y = Fl::event_y(); > > positionChanged(); > > break; > > + > > + case FL_LEAVE: > > + mouse_x = mouse_y = -1; > > + break; > > } > > > > return FltkWidgetView::handle (event); > > Yes! It works. > > Please elaborate a bit. > > Some history: FLTK2 had widget coordinates relative to the > parent. When we ported dillo to FLTK-1.3 which has absolute > coords, a bunch of offset problems sprung here and there. I > remember hunting/fixing most of them. > > I thought this bug could be related to widget offsets, although > that's just one possibility, not a certainty. I had removed that code in the recent text selection / scrolling changes because I no longer thought I had any need for it, but: FltkViewport::scrollTo() calls positionChanged(), and it still remembered old mouse_x,mouse_y values from when the pointer was in the viewport.

Nov. 12, 2012

Tooltip bugs revisited

by jcid＠dillo.org

On Sun, Nov 11, 2012 at 09:18:08PM +0000, corvid wrote: > Jorge wrote: > > Testing revealed the workaround concealed another problem, > > which I don't remember whether it was detected before, and this > > is that viewport mouse events get "through" the panel UI!. > > > > How?, placing the mouse pointer over the panel (e.g. to the > > right of the Tools button, or even inside the Location), and > > scrolling a page full of links under it, will make the mouse > > pointer change to a hand, and the destination link appear in the > > status bar area. > > > > This bug is revealed by disabling the workaround: just apply > > the small attached patch. > > > > Clearly there's a viewport offset problem somewhere. Correcting > > it may save us lots of headaches in the future. > > > > Does anybody know or has a clue of where this may be happening? > > > > TIA. > > Does this work for you? > diff -r 8b4259cdc6da dw/fltkviewport.cc > --- a/dw/fltkviewport.cc Sat Nov 10 17:55:34 2012 +0000 > +++ b/dw/fltkviewport.cc Sun Nov 11 21:14:40 2012 +0000 > @@ -318,6 +318,10 @@ > mouse_y = Fl::event_y(); > positionChanged(); > break; > + > + case FL_LEAVE: > + mouse_x = mouse_y = -1; > + break; > } > > return FltkWidgetView::handle (event); Yes! It works. Please elaborate a bit. Some history: FLTK2 had widget coordinates relative to the parent. When we ported dillo to FLTK-1.3 which has absolute coords, a bunch of offset problems sprung here and there. I remember hunting/fixing most of them. I thought this bug could be related to widget offsets, although that's just one possibility, not a certainty. -- Cheers Jorge.-

Nov. 12, 2012

tab state

by corvid＠lavabit.com

How much trouble would it be to make tabs show whether they are - waiting for reply - receiving data - done It'd be quite useful...

Nov. 11, 2012

Tooltip bugs revisited

by corvid＠lavabit.com

Jorge wrote: > Testing revealed the workaround concealed another problem, > which I don't remember whether it was detected before, and this > is that viewport mouse events get "through" the panel UI!. > > How?, placing the mouse pointer over the panel (e.g. to the > right of the Tools button, or even inside the Location), and > scrolling a page full of links under it, will make the mouse > pointer change to a hand, and the destination link appear in the > status bar area. > > This bug is revealed by disabling the workaround: just apply > the small attached patch. > > Clearly there's a viewport offset problem somewhere. Correcting > it may save us lots of headaches in the future. > > Does anybody know or has a clue of where this may be happening? > > TIA. Does this work for you?

Nov. 11, 2012

Tooltip bugs revisited

by jcid＠dillo.org

Hi there, These days I've devoted some more effort to the tooltips bug [1] and its workaround patch [2]. The motivation is that the current workaround involves a full UI and viewport expose (i.e. a full erase/redraw) that produces annoying flickering when the mouse is in the UI but outside the viewport (e.g. over the panel). Over time I've learnt to move the mouse pointer outside the panel and into the viewport to scroll without flickering (but probably I'm among the few that know this trick). So far (and despite the warning inside FLTK), I've experimented with a custom tooltip handling class, and a couple custom UI widgets, that seem to work well together (i.e. solve the problem without the workaround :) ). Testing revealed the workaround concealed another problem, which I don't remember whether it was detected before, and this is that viewport mouse events get "through" the panel UI!. How?, placing the mouse pointer over the panel (e.g. to the right of the Tools button, or even inside the Location), and scrolling a page full of links under it, will make the mouse pointer change to a hand, and the destination link appear in the status bar area. This bug is revealed by disabling the workaround: just apply the small attached patch. Clearly there's a viewport offset problem somewhere. Correcting it may save us lots of headaches in the future. Does anybody know or has a clue of where this may be happening? TIA. [1] http://lists.auriga.wearlab.de/pipermail/dillo-dev/2011-July/008494.html [2] http://lists.auriga.wearlab.de/pipermail/dillo-dev/2011-July/008515.html -- Cheers Jorge.-

Nov. 11, 2012