May 2011 - Dillo-dev - lists.mailman3.com

configure.in -Wno-unused-parameter

by corvid＠lavabit.com

Jorge wrote: > On Mon, May 16, 2011 at 01:17:45AM +0000, corvid wrote: > > Jorge wrote: > > > On Sun, May 15, 2011 at 10:34:00PM +0000, corvid wrote: > > > > > > > > if eval "test x$GCC = xyes"; then > > > > .. > > > > if test "`echo $CFLAGS | grep '\-W[^a]' 2> /dev/null`" = ""; then > > > > if test "`$CC -v 2>&1 | grep 'version 3'`" != ""; then > > > > CFLAGS="$CFLAGS -W -Wno-unused-parameter" > > > > fi > > > > fi > > > > .. > > > > fi > > > > > > > > It checks for 3.x specifically. > > > > 3.0 came out on June 18, 2001. > > > > > > > > And of course 4.x has been out since...let's see...April 20, 2005. > > > > > > > > 2.95 was still apparently around back in > > > > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2003-December/001565.html , > > > > which prompted this code at the time. > > > > > > > > Can I rip out the version-checking and make it into an ordinary > > > > case of adding the argument if it isn't already in CFLAGS? > > > > Right after committing it, I thought, "Wait, this is -Wno-unused-parameter, > > not -Wunused-parameter. Why do we want this?" > > Some callbacks don't make use of default parameters and > this option avoids a lot of noise (making it simpler to spot > other warnings). I know we had that one in a_Http_ccc() that is suppressed with a (void)Data2; but I never see any other warnings around.

May 16, 2011

What's currently broken in... (Re: [Dillo-dev] 1.3 port)

by jcid＠dillo.org

On Sun, May 15, 2011 at 06:15:35PM +0000, corvid wrote: > > - drawing with nested layouts Any example besides dw-ui-test? -- Cheers Jorge.-

May 16, 2011

configure.in -Wno-unused-parameter

by jcid＠dillo.org

On Mon, May 16, 2011 at 01:17:45AM +0000, corvid wrote: > Jorge wrote: > > On Sun, May 15, 2011 at 10:34:00PM +0000, corvid wrote: > > > > > > if eval "test x$GCC = xyes"; then > > > .. > > > if test "`echo $CFLAGS | grep '\-W[^a]' 2> /dev/null`" = ""; then > > > if test "`$CC -v 2>&1 | grep 'version 3'`" != ""; then > > > CFLAGS="$CFLAGS -W -Wno-unused-parameter" > > > fi > > > fi > > > .. > > > fi > > > > > > It checks for 3.x specifically. > > > 3.0 came out on June 18, 2001. > > > > > > And of course 4.x has been out since...let's see...April 20, 2005. > > > > > > 2.95 was still apparently around back in > > > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2003-December/001565.html , > > > which prompted this code at the time. > > > > > > Can I rip out the version-checking and make it into an ordinary > > > case of adding the argument if it isn't already in CFLAGS? > > Right after committing it, I thought, "Wait, this is -Wno-unused-parameter, > not -Wunused-parameter. Why do we want this?" Some callbacks don't make use of default parameters and this option avoids a lot of noise (making it simpler to spot other warnings). > So, new proposal: How about I remove it completely? Currently I use gcc-4.4.3, and somehow the option gets into the compiler parameters, so I guess it makes its job. (I haven't checked without it to be sure). -- Cheers Jorge.-

May 16, 2011

configure.in -Wno-unused-parameter

by mr_semantics＠hotmail.com

> From: corvid(a)lavabit.com > Apparently -Wextra came along in 3.4, which is from 2004. > I personally lean toward leaving it alone unless they give the > impression that they are actually going to remove -W at some point. Yeah - probably best to leave well enough alone, seeing as somewhere someone could ?be trying to build with an older version of gcc. ?If and when the gcc devs break it, then it can be changed accordingly.

May 16, 2011

configure.in -Wno-unused-parameter

by corvid＠lavabit.com

Rob wrote: > As an aside, why not change -W to -Wextra? ?While they are both supported, the gcc manual encourages the use of -Wextra. ?My guess is that -W will eventually be deprecated. ?On the other hand, how far back does gcc support -Wextra? ?I cannot remember when that change was made. Apparently -Wextra came along in 3.4, which is from 2004. I personally lean toward leaving it alone unless they give the impression that they are actually going to remove -W at some point.

May 16, 2011

configure.in -Wno-unused-parameter

by corvid＠lavabit.com

Jorge wrote: > On Sun, May 15, 2011 at 10:34:00PM +0000, corvid wrote: > > > > if eval "test x$GCC = xyes"; then > > .. > > if test "`echo $CFLAGS | grep '\-W[^a]' 2> /dev/null`" = ""; then > > if test "`$CC -v 2>&1 | grep 'version 3'`" != ""; then > > CFLAGS="$CFLAGS -W -Wno-unused-parameter" > > fi > > fi > > .. > > fi > > > > It checks for 3.x specifically. > > 3.0 came out on June 18, 2001. > > > > And of course 4.x has been out since...let's see...April 20, 2005. > > > > 2.95 was still apparently around back in > > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2003-December/001565.html , > > which prompted this code at the time. > > > > Can I rip out the version-checking and make it into an ordinary > > case of adding the argument if it isn't already in CFLAGS? Right after committing it, I thought, "Wait, this is -Wno-unused-parameter, not -Wunused-parameter. Why do we want this?" So, new proposal: How about I remove it completely?

May 16, 2011

What's currently broken in... (Re: [Dillo-dev] 1.3 port)

by mr_semantics＠hotmail.com

When using a captcha system, I am unable to select text in order to copy. ?For example, go here: http://dragcave.net/login Then click on the IFRAME link. ?Type the words of the challenge into the text field. ?Assuming you have managed to pass as a human, you will be given (on a new page) a key to copy and paste to a field seen on the intial login screen. ?The trouble is that the text cannot be selected. Rob

May 16, 2011

configure.in -Wno-unused-parameter

by mr_semantics＠hotmail.com

---------------------------------------- > From: corvid(a)lavabit.com > Date: Sun, 15 May 2011 22:34:00 +0000 > To: dillo-dev(a)dillo.org > Subject: [Dillo-dev] configure.in -Wno-unused-parameter > > > if eval "test x$GCC = xyes"; then > .. > if test "`echo $CFLAGS | grep '\-W[^a]' 2> /dev/null`" = ""; then > if test "`$CC -v 2>&1 | grep 'version 3'`" != ""; then > CFLAGS="$CFLAGS -W -Wno-unused-parameter" > fi > fi > .. > fi > > It checks for 3.x specifically. > 3.0 came out on June 18, 2001. > > And of course 4.x has been out since...let's see...April 20, 2005. > > 2.95 was still apparently around back in > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2003-December/001565.html , > which prompted this code at the time. > > Can I rip out the version-checking and make it into an ordinary > case of adding the argument if it isn't already in CFLAGS? As an aside, why not change -W to -Wextra? ?While they are both supported, the gcc manual encourages the use of -Wextra. ?My guess is that -W will eventually be deprecated. ?On the other hand, how far back does gcc support -Wextra? ?I cannot remember when that change was made.

May 16, 2011

configure.in -Wno-unused-parameter

by jcid＠dillo.org

On Sun, May 15, 2011 at 10:34:00PM +0000, corvid wrote: > > if eval "test x$GCC = xyes"; then > .. > if test "`echo $CFLAGS | grep '\-W[^a]' 2> /dev/null`" = ""; then > if test "`$CC -v 2>&1 | grep 'version 3'`" != ""; then > CFLAGS="$CFLAGS -W -Wno-unused-parameter" > fi > fi > .. > fi > > It checks for 3.x specifically. > 3.0 came out on June 18, 2001. > > And of course 4.x has been out since...let's see...April 20, 2005. > > 2.95 was still apparently around back in > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2003-December/001565.html , > which prompted this code at the time. > > Can I rip out the version-checking and make it into an ordinary > case of adding the argument if it isn't already in CFLAGS? Sure. -- Cheers Jorge.-

May 16, 2011

What's currently broken in... (Re: [Dillo-dev] 1.3 port)

by jcid＠dillo.org

On Sun, May 15, 2011 at 09:04:43PM +0200, Johannes Hofmann wrote: > On Sun, May 15, 2011 at 06:15:35PM +0000, corvid wrote: > > > > - the preferred font code in dillo.cc. Necessary. > > - drawing with nested layouts Just managed to make the complex button draw right. I'm testing now. > > - page/tab titles Simple. > > - When scrolling with the keyboard, with buffered_drawing 0 or 1, > > tooltips leave grey boxes. Also in dillo2. > > - OSX. I believe Johannes tried it once, and there was something going > > wrong with iowatch. > > Yes, somehow the add_fd() and add_idle() stuff doesn't seem to work > on OSX. Either it's an fltk bug or we use it ways that are not > expected. FWIW, sometime ago I compiled and run dillo-2 in OSX with no such problem. > Here are my current issues with the fltk-1.3 port: > > - The toolbar in the initial tab is too high (with dwm in tiling > mode). Further tabs have correctly sized toolbars. This puzzles me. > - Ctrl-Tab doesn't cycle through tabs. I really miss that. Simple enough to fix. ;) > - There is a tab title even if there is only one tab. Yeah, this could take a few days. > - The keyboard shortcuts for text input fields have changed (I use > Ctrl-A (jump to beginning) Ctrl-K (kill until end of line) and > Ctrl-E (jump to end of line). > This seems to be intentional from fltk side. > Any opinions whether we should change this back to the fltk2 > behaviour? I miss them badly and several times have considered re-adding those keybindings. :-) Maybe next week. > - There are still a bit more redraws than with fltk2 dillo. Yes. BTW, have the last patches made a difference for you? -- Cheers Jorge.-

May 16, 2011