November 2011 - Dillo-dev - lists.mailman3.com

text alignment and list item markers

by jcid＠dillo.org

On Sun, Nov 13, 2011 at 01:21:10AM +0000, corvid wrote: > > Any objection to removing the special case for putting list item markers > at the far left even when the text is centered or whatever? > I've never liked this weird special case, and I see that Firefox doesn't > do it, anyway. +1 -- Cheers Jorge.-

Nov. 13, 2011

text alignment and list item markers

by onepoint＠starurchin.org

corvid wrote: > Any objection to removing the special case for putting list item > markers at the far left even when the text is centered or whatever? > I've never liked this weird special case, and I see that Firefox > doesn't do it, anyway. +1. It looks much nicer the Firefox way. Regards, Jeremy Henty

Nov. 13, 2011

text alignment and list item markers

by Johannes.Hofmann＠gmx.de

On Sun, Nov 13, 2011 at 01:21:10AM +0000, corvid wrote: > > Any objection to removing the special case for putting list item markers > at the far left even when the text is centered or whatever? > I've never liked this weird special case, and I see that Firefox doesn't > do it, anyway. > diff -r 284f9065236f dw/textblock.cc > --- a/dw/textblock.cc Sat Nov 12 20:35:34 2011 +0000 > +++ b/dw/textblock.cc Sun Nov 13 01:16:11 2011 +0000 > @@ -1079,15 +1079,7 @@ > if (leftOffset < 0) > leftOffset = 0; > > - if (hasListitemValue && lastLine == lines->getRef (0)) { > - /* List item markers are always on the left. */ > - lastLine->leftOffset = 0; > - words->getRef(0)->effSpace = words->getRef(0)->origSpace + leftOffset; > - //DBG_OBJ_ARRSET_NUM (this, "words.%d.effSpace", 0, > - // words->getRef(0)->effSpace); > - } else { > - lastLine->leftOffset = leftOffset; > - } > + lastLine->leftOffset = leftOffset; > } > mustQueueResize = true; > +1 Cheers, Johannes

Nov. 13, 2011

text alignment and list item markers

by corvid＠lavabit.com

Any objection to removing the special case for putting list item markers at the far left even when the text is centered or whatever? I've never liked this weird special case, and I see that Firefox doesn't do it, anyway.

Nov. 13, 2011

tests that should not be case-sensitive

by corvid＠lavabit.com

I wrote: > - a bunch of cases where we test url strings with the scheme > included. This seems to work all right for me, anyway. As for whether it really makes sense to test for dpi scheme in some of the DPIs, or whether I should care about URL_AUTHORITY anywhere, I'm not certain...

Nov. 11, 2011

is* character classification

by Johannes.Hofmann＠gmx.de

On Wed, Nov 09, 2011 at 05:14:23AM +0000, corvid wrote: > > I was just looking at how the is* functions treat characters with the > high bit set. If I set LC_CTYPE to en_US, 0xC0 is alpha, but it > understandably isn't in en_US.UTF-8. > > So I found my way to > /usr/share/i18n/locales/ en_US -> en_GB -> i18n > > And found that: > upper 41-5A, C0-D6, D8-DE > lower 61-7A, B5, DF-F6, F8-FF > alpha 41-5A, 61-7A, AA, B5, BA, C0-D6, D8-F6, F8-FF > digit 30-39 > space 09-0D, 20 > cntrl 00-1F, 7F-9F > punct 21-2F, 3A-40, 5B-60, 7B-7E, A0-A9, AB-B4, B6-B9, BB-BF, D7, F7 > graph 21-7E, A0-FF > print 20-7E, A0-FF > xdigit 30-39, 41-46, 61-66 > blank 9, 20 > > In dillo: > isupper not used > islower not used > isalpha cssparser, html > isdigit doesn't matter > isalnum cssparser, html, datauri, downloads, dlib.h > dIsalnum url > isspace cssparser, html, keys, dlib.h, findtext.hh > dIsspace colors, src/cookies, misc, dpi/cookies, file, ftp, dlib > iscntrl keys, auth, misc > ispunct textblock > isgraph not used > isprint dlib > isxdigit doesn't matter > isblank not used > isascii not used > > I'm not sure that any real harm is done in these cases, but it might not > be a bad idea to check that it's ascii when we only want ascii. Sure. I could imagine you already regret that you started looking into this stuff :)

Nov. 10, 2011

ascii string comparison [Re: use C locale for LC_CTYPE]

by Johannes.Hofmann＠gmx.de

On Tue, Nov 08, 2011 at 11:18:12PM +0000, corvid wrote: > Johannes wrote: > > So all uppercase macros then or just not trying to inline and use a > > normal function. > > Here's what I have now: > http://www.dillo.org/test/ascii_strcasecmp3.diff Looks good to me. Cheers, Johannes

Nov. 10, 2011

tests that should not be case-sensitive

by Johannes.Hofmann＠gmx.de

On Wed, Nov 09, 2011 at 02:46:00AM +0000, corvid wrote: > > I don't want to do anything about this until we get the big patch > committed, but I just looked through the str(n)cmp calls in dillo, > and I found: > > - a bunch of cases where we test url strings with the scheme > included. > > - hostname tests in dns.c. I don't know that code at all, though. > Is there any reason why it has to treat the hostnames that way? > > - generic font-family names in styleengine.cc. CSS 2.1 says: > "All CSS syntax is case-insensitive within the ASCII range (i.e., > [a-z] and [A-Z] are equivalent), except for parts that are not > under the control of CSS. For example, the case-sensitivity of > values of the HTML attributes "id" and "class", of font names, > and of URIs lies outside the scope of this specification. Note > in particular that element names are case-insensitive in HTML, > but case-sensitive in XML." > ...although I know "@charset" has to be lowercase, so this > might not be the ultimate answer, but I didn't see anything > suggesting otherwise. Right. Firefox also seems to accept font-family:MONOSPACE Cheers, Johannes

Nov. 10, 2011

tests that should not be case-sensitive

by johannes.hofmann＠gmx.de

On Wed, Nov 09, 2011 at 08:01:55AM -0300, Jorge Arellano Cid wrote: > Hi, > > On Wed, Nov 09, 2011 at 02:46:00AM +0000, corvid wrote: > > > > I don't want to do anything about this until we get the big patch > > committed, but I just looked through the str(n)cmp calls in dillo, > > and I found: > > > > [...] > > - hostname tests in dns.c. I don't know that code at all, though. > > Is there any reason why it has to treat the hostnames that way? > > If you mean treating them as case sensitive, no, I don't remember > a special reason (although there's a 10% chance or so of it being > for a purpose that I forgot). Same here. > > We can try the other way and check if anything breaks. Ack. Cheers, Johannes

Nov. 9, 2011

tests that should not be case-sensitive

by jcid＠dillo.org

Hi, On Wed, Nov 09, 2011 at 02:46:00AM +0000, corvid wrote: > > I don't want to do anything about this until we get the big patch > committed, but I just looked through the str(n)cmp calls in dillo, > and I found: > > [...] > - hostname tests in dns.c. I don't know that code at all, though. > Is there any reason why it has to treat the hostnames that way? If you mean treating them as case sensitive, no, I don't remember a special reason (although there's a 10% chance or so of it being for a purpose that I forgot). We can try the other way and check if anything breaks. -- Cheers Jorge.-

Nov. 9, 2011