September 2010 - Dillo-dev - lists.mailman3.com

Segmentation fault on startup

by jameslovejoy＠tiscali.co.uk

Hi, I'm creating a new distro that is supposed to be fast and light. I thought about Firefox but it all stacks up after you install gtk as well. So your slogan "fast and light" seemed sound the ticket. I compiled it on my ubuntu 10.04 system and it works on there. Copied it to the new distro and here is the output when I type "dillo" at the prompt: dillo: /lib/libjpeg.so.8: no version information available (required by dillo) paths: Cannot open file '/root/.dillo/dillorc' paths: Using /usr/local/etc/dillo/dillorc paths: Cannot open file '/root/.dillo/keysrc' paths: Using /usr/local/etc/dillo/keysrc dillo_dns_init: Here we go! (threaded) Disabling cookies. ** WARNING **: preferred sans-serif font "DejaVu Sans" not found. ** WARNING **: preferred serif font "DejaVu Serif" not found. ** WARNING **: preferred monospace font "DejaVu mono" not found. ** WARNING **: preferred cursive font "DejaVu Sans" not found. ** WARNING **: preferred fantasy font "DejaVu Sans" not found. Segmentation fault I can't get a backtrace from GDB because it's supposed to be a mega minimal system. It works fine on the development system. Regards, James

Sept. 11, 2010

Commit bit: WAS Re: [Dillo-dev] [patch]: html.cc: re-indent Html_tag_open_q() for consistency

by onepoint＠starurchin.org

Johannes Hofmann wrote: > BTW, don't you have a commit bit (or how is it called with DVCS's)? Not at the moment. I have considered asking but it's been a long while since I have felt comfortable making a serious long-term commitment to working on dillo. I'm very happy to contribute as and when I can but I wouldn't want anyone expecting me to be active, say, in six month's time. Also, I don't feel I know what the long-term plan for dillo is, in terms of priorities and directions. My impression (perhaps wrongly) is that the discussion happens elsewhere (although it does surface on this list every now and then). So I wouldn't feel comfortable doing non-trivial stuff without the other dev's review. But maybe that's over-cautious. If everyone's time would be more effectively used if I had a commit bit then I'm happy to have one. I feel a bit one-of-a-kind in the Dillo world. Is there anyone else in the class of "not a core dev but a long-time contributor"? Regards, Jeremy Henty

Sept. 7, 2010

[patch]: html.cc: re-indent Html_tag_open_q() for consistency

by Johannes.Hofmann＠gmx.de

On Mon, Sep 06, 2010 at 09:31:22PM +0100, Jeremy Henty wrote: > > The wise say you shouldn't sweat the small stuff, but when one > function in a file is indented by 4 spaces and all the rest are > indented by 3, well... Committed! BTW, don't you have a commit bit (or how is it called with DVCS's)? Cheers, Johannes

Sept. 6, 2010

[patch]: html.cc: re-indent Html_tag_open_q() for consistency

by onepoint＠starurchin.org

The wise say you shouldn't sweat the small stuff, but when one function in a file is indented by 4 spaces and all the rest are indented by 3, well... Regards, Jeremy Henty

Sept. 6, 2010

[bug]: <pre> element respects color but not background-color

by Johannes.Hofmann＠gmx.de

On Mon, Sep 06, 2010 at 07:18:52AM +0100, Jeremy Henty wrote: > > Johannes Hofmann wrote: > > > Correct. All Html_tag_open_*() functions that don't add a widget > > (e.g. a textblock or an image) must call > > html->styleEngine->inheritBackgroundColor() to make background-color > > work. Unfortunately this is just a hack that doesn't solve all > > problems. E.g. <pre style="border: 1px solid black">foo</pre> will > > still not work. For now, I would just add inheritBackgroundColor() > > where necessary. > > OK, patch attached. Please review carefully - I am not familiar with > the Dillo CSS implementation so this is really a request for comments. > (Although it does fix the page that first highlighted the problem.) Thanks! I commited a slightly modified version. Cheers, Johannes

Sept. 6, 2010

[bug]: <pre> element respects color but not background-color

by onepoint＠starurchin.org

Johannes Hofmann wrote: > Correct. All Html_tag_open_*() functions that don't add a widget > (e.g. a textblock or an image) must call > html->styleEngine->inheritBackgroundColor() to make background-color > work. Unfortunately this is just a hack that doesn't solve all > problems. E.g. <pre style="border: 1px solid black">foo</pre> will > still not work. For now, I would just add inheritBackgroundColor() > where necessary. OK, patch attached. Please review carefully - I am not familiar with the Dillo CSS implementation so this is really a request for comments. (Although it does fix the page that first highlighted the problem.) And thanks for the explanation of the CSS workings! Regards, Jeremy Henty

Sept. 6, 2010

[patch]: consistent screaming quotes

by Johannes.Hofmann＠gmx.de

On Sun, Sep 05, 2010 at 09:53:05AM +0100, Jeremy Henty wrote: > > A small cleanup. I noticed the ugly unbalanced quotes in the '>>> > a_Nav_repush <<<<' message so I did a quick grep and fixed all similar > messages to have the same formatting. Committed! Cheers, Johannes

Sept. 5, 2010

[bug]: <pre> element respects color but not background-color

by Johannes.Hofmann＠gmx.de

Hi Jeremy, On Sun, Sep 05, 2010 at 12:52:02PM +0100, Jeremy Henty wrote: > > The problem is that Html_tag_open_pre() does not call > html->styleEngine->inheritBackgroundColor() before calling > HT2TB(html)->addParbreak(). But several other Html_tag_open_*() > functions have the same problem, eg. Html_tag_open_{dt,dl}(). Should > we fix them one by one or is there a better way? Correct. All Html_tag_open_*() functions that don't add a widget (e.g. a textblock or an image) must call html->styleEngine->inheritBackgroundColor() to make background-color work. Unfortunately this is just a hack that doesn't solve all problems. E.g. <pre style="border: 1px solid black">foo</pre> will still not work. For now, I would just add inheritBackgroundColor() where necessary. > > Also, I wonder if more of the Html_tag_open_*() functions should call > html->styleEngine->setNonCssHints(), but I don't understand the CSS > engine well enough to be sure. setNonCssHints() in contrast is not a hack :-) It is used to pass style information from (deprecated) non-CSS HTML attributes like bgColor, align and so on to StyleEngine. This style information from HTML attributes has to be handled specially as described in http://www.w3.org/TR/CSS2/cascade.html#preshint So for all HTML-attributes that we want to support and that change the style there should be a corresponding setNonCssHints() call. Regards, Johannes

Sept. 5, 2010

[bug]: <pre> element respects color but not background-color

by onepoint＠starurchin.org

The problem is that Html_tag_open_pre() does not call html->styleEngine->inheritBackgroundColor() before calling HT2TB(html)->addParbreak(). But several other Html_tag_open_*() functions have the same problem, eg. Html_tag_open_{dt,dl}(). Should we fix them one by one or is there a better way? Also, I wonder if more of the Html_tag_open_*() functions should call html->styleEngine->setNonCssHints(), but I don't understand the CSS engine well enough to be sure. Regards, Jeremy Henty

Sept. 5, 2010

[bug]: <pre> element respects color but not background-color

by onepoint＠starurchin.org

<html> <head> <style type="text/css"> pre { background-color:#222; color:#fff; } </style> </head> <body> <pre>Blah, blah, blah</pre> </body> </html> Dillo renders the above as white text on the default background, which is almost illegible. Firefox renders it white on black, as intended. If you apply the style to the body element instead of the pre element then Dillo renders it correctly. The pre element respects the color style parameter but not the background-color. This bug is visible at http://jeffkreeftmeijer.com/2010/the-mighty-reflog-and-the-amazing-bisect/ Regards, Jeremy Henty

Sept. 5, 2010