Dillo-dev

By thread

dillo-dev@mailman3.com

August 2010

9 participants
41 messages

[patch]: do not let '>' terminate a quoted attribute value

by onepoint＠starurchin.org

If you point dillo at http://www.reddit.com/ you will see many javascript fragments. These come from div elements with an onclick="$(this).vote('<$>votehash</$>', null, event)" attribute. Dillo thinks that the '>' looks suspiciously like an end tag character. It looks ahead, sees the '<' character and decides that its suspicions are correct, so it terminates the tag at the '>', warns of a missing attribute close quote and renders the rest as HTML. This algorithm may have been effective in the early days of the web but I think it clearly does not work well today. I can't think of a better way of doing the job so I suggest removing it and instead just finding the matching close quote in all cases. Patch attached. After applying this patch dillo reports 0 HTML errors from http://www.reddit.com/! Regards, Jeremy Henty

Aug. 1, 2010