September 2009 - Dillo-dev - lists.mailman3.com

Weird chars bug

by jcid＠dillo.org

Hi, Since dillo-2.1, enabled-CSS makes funny chars in this page: http://blogdrake.net/node/14916 Screenshot: http://www.dillo.org/test/weirdChars.jpg Disabling it from the tools button solves the problem. Does anybody know what's the problem here? -- Cheers Jorge.-

Sept. 25, 2009

[patch]: fix the meta-refresh warning code

by jcid＠dillo.org

On Thu, Sep 24, 2009 at 06:04:15AM +0100, Jeremy Henty wrote: > On Tue, Sep 22, 2009 at 02:25:47PM -0400, Jorge Arellano Cid wrote: > > On Tue, Sep 22, 2009 at 04:35:28PM +0000, corvid wrote: > > > > Would it be less trouble to have this widget as a child of the UI > > > instead of in the rendering area? (I sort of had the impression > > > that was the plan... > > > > That's exactly the plan. > > > > A simple fltk widget that hides/shows (as the findext bar) and > > that gives a text message. It should also support a fake HTML link > > (underlined word that reacts to left click). > > Ah, I think I misunderstood the reference to "custom widget" in the TO > DO note. I was fixated on the Dillo Widget system and didn't realise > it was talking about a new FLTK widget. Maybe my patch isn't the way > to go. Still, it would be nice for the custom widget to be properly > CSS-styled. Maybe it be could another FltkViewport? As this is part of the UI, I'd suggest to use Xdefaults as Johannes suggested for colors some time ago. -- Cheers Jorge.-

Sept. 25, 2009

[patch]: fix the meta-refresh warning code

by onepoint＠starurchin.org

On Tue, Sep 22, 2009 at 02:25:47PM -0400, Jorge Arellano Cid wrote: > On Tue, Sep 22, 2009 at 04:35:28PM +0000, corvid wrote: > > Would it be less trouble to have this widget as a child of the UI > > instead of in the rendering area? (I sort of had the impression > > that was the plan... > > That's exactly the plan. > > A simple fltk widget that hides/shows (as the findext bar) and > that gives a text message. It should also support a fake HTML link > (underlined word that reacts to left click). Ah, I think I misunderstood the reference to "custom widget" in the TO DO note. I was fixated on the Dillo Widget system and didn't realise it was talking about a new FLTK widget. Maybe my patch isn't the way to go. Still, it would be nice for the custom widget to be properly CSS-styled. Maybe it be could another FltkViewport? Regards, Jeremy Henty

Sept. 24, 2009

[patch]: fix the meta-refresh warning code

by jcid＠dillo.org

On Tue, Sep 22, 2009 at 04:35:28PM +0000, corvid wrote: > Johannes wrote: > > On Tue, Sep 22, 2009 at 07:47:09AM +0100, Jeremy Henty wrote: > > > On Mon, Sep 21, 2009 at 11:58:09PM -0400, Jorge Arellano Cid wrote: > > > > > > > > * The HTML parser in table.cc does not create table widgets if > > > > > USE_TABLES is not defined. Perhaps this code should do the > > > > > same? > > > > > > > > Not necessary. That was an old feature for narrow displays. > > > > > > In that case, shouldn't we remove USE_TABLES entirely? > > > > > > > > * It would be nice if the widgets and the redirect link were > > > > > styled from the User Agent style in css.cc . ... > > > > > > > > AFAIS, the warning widget needs its own scheme, like the rest of > > > > the panel. > > > > > > Perhaps we could extend the default style in css.cc with clauses like > > > "dillo meta-refresh-warning redirect { color: ... }", using "dillo" > > > as a reserved CSS class for internal use? Then all of the style > > > information would be in CSS and none of it would be hard-coded in the > > > parser, which is how it should be. > > > > Yes, this would be possible. Other browsers also have similar > > extensions. They seem to start with a '-' usually ("-webkit...", > > "-moz..."). > > But generally if we generate messages in the rendering area, we > > can't avoid that someone fakes them on his webpage. > > Would it be less trouble to have this widget as a child of the UI > instead of in the rendering area? (I sort of had the impression that > was the plan, but maybe that was the xhtml one, or maybe I'm just > mixed up.) That's exactly the plan. A simple fltk widget that hides/shows (as the findext bar) and that gives a text message. It should also support a fake HTML link (underlined word that reacts to left click). Sorry for not having the time yet to test the code... -- Cheers Jorge.-

Sept. 22, 2009

[patch]: fix the meta-refresh warning code

by corvid＠lavabit.com

Johannes wrote: > On Tue, Sep 22, 2009 at 07:47:09AM +0100, Jeremy Henty wrote: > > On Mon, Sep 21, 2009 at 11:58:09PM -0400, Jorge Arellano Cid wrote: > > > > > > * The HTML parser in table.cc does not create table widgets if > > > > USE_TABLES is not defined. Perhaps this code should do the > > > > same? > > > > > > Not necessary. That was an old feature for narrow displays. > > > > In that case, shouldn't we remove USE_TABLES entirely? > > > > > > * It would be nice if the widgets and the redirect link were > > > > styled from the User Agent style in css.cc . ... > > > > > > AFAIS, the warning widget needs its own scheme, like the rest of > > > the panel. > > > > Perhaps we could extend the default style in css.cc with clauses like > > "dillo meta-refresh-warning redirect { color: ... }", using "dillo" > > as a reserved CSS class for internal use? Then all of the style > > information would be in CSS and none of it would be hard-coded in the > > parser, which is how it should be. > > Yes, this would be possible. Other browsers also have similar > extensions. They seem to start with a '-' usually ("-webkit...", > "-moz..."). > But generally if we generate messages in the rendering area, we > can't avoid that someone fakes them on his webpage. Would it be less trouble to have this widget as a child of the UI instead of in the rendering area? (I sort of had the impression that was the plan, but maybe that was the xhtml one, or maybe I'm just mixed up.)

Sept. 22, 2009

[patch]: fix the meta-refresh warning code

by Johannes.Hofmann＠gmx.de

Hi Jeremy, On Tue, Sep 22, 2009 at 07:47:09AM +0100, Jeremy Henty wrote: > On Mon, Sep 21, 2009 at 11:58:09PM -0400, Jorge Arellano Cid wrote: > > > > * The HTML parser in table.cc does not create table widgets if > > > USE_TABLES is not defined. Perhaps this code should do the > > > same? > > > > Not necessary. That was an old feature for narrow displays. > > In that case, shouldn't we remove USE_TABLES entirely? > > > > * It would be nice if the widgets and the redirect link were > > > styled from the User Agent style in css.cc . ... > > > > AFAIS, the warning widget needs its own scheme, like the rest of > > the panel. > > Perhaps we could extend the default style in css.cc with clauses like > "dillo meta-refresh-warning redirect { color: ... }", using "dillo" > as a reserved CSS class for internal use? Then all of the style > information would be in CSS and none of it would be hard-coded in the > parser, which is how it should be. Yes, this would be possible. Other browsers also have similar extensions. They seem to start with a '-' usually ("-webkit...", "-moz..."). But generally if we generate messages in the rendering area, we can't avoid that someone fakes them on his webpage. > > I still haven't worked out how to apply the CSS stylesheets to the > widgets I create (the style engine mechanism isn't being applied > because I create the widgets directly instead of from HTML). I tried > adding calls to styleEngine->{startElement,endElement}() but nothing > happened. I'm clearly still missing something. I'll have another > look, but any tips will be welcome! That should work. You need those styleEngine->{startElement,endElement}() calls and then use styleEngine->style() for your widgets. See plain.cc for an example. And of course you need to specify corresponding css either in the user agent style in css.cc or for testing just in your ~/.dillo/style.css file. Regards, Johannes

Sept. 22, 2009

[patch]: fix the meta-refresh warning code

by onepoint＠starurchin.org

On Mon, Sep 21, 2009 at 11:58:09PM -0400, Jorge Arellano Cid wrote: > > * The HTML parser in table.cc does not create table widgets if > > USE_TABLES is not defined. Perhaps this code should do the > > same? > > Not necessary. That was an old feature for narrow displays. In that case, shouldn't we remove USE_TABLES entirely? > > * It would be nice if the widgets and the redirect link were > > styled from the User Agent style in css.cc . ... > > AFAIS, the warning widget needs its own scheme, like the rest of > the panel. Perhaps we could extend the default style in css.cc with clauses like "dillo meta-refresh-warning redirect { color: ... }", using "dillo" as a reserved CSS class for internal use? Then all of the style information would be in CSS and none of it would be hard-coded in the parser, which is how it should be. I still haven't worked out how to apply the CSS stylesheets to the widgets I create (the style engine mechanism isn't being applied because I create the widgets directly instead of from HTML). I tried adding calls to styleEngine->{startElement,endElement}() but nothing happened. I'm clearly still missing something. I'll have another look, but any tips will be welcome! Regards, Jeremy Henty

Sept. 22, 2009

[patch]: fix the meta-refresh warning code

by jcid＠dillo.org

Hi Jeremy, Good to see you around! On Sat, Sep 19, 2009 at 11:32:19PM +0100, Jeremy Henty wrote: > > Long time no post! Here's a fix for an outstanding TODO in html.cc. > It replaces the code that creates the HTML META REFRESH warning (which > sends HTML to Html_write_raw()) with a function that creates the > widgets directly. Hopefully I'll review it in the next days. > There are still a few issues: > > * The HTML parser in table.cc does not create table widgets if > USE_TABLES is not defined. Perhaps this code should do the same? Not necessary. That was an old feature for narrow displays. > > * The new widgets do not have 'width="100%"' set, so the horizontal > layout is slightly different. > > * The redirect link colour does not reflect whether the link URL has > been visited. > > * It would be nice if the widgets and the redirect link were styled > from the User Agent style in css.cc . I couldn't figure out how > to do that so I just copied a few things like the link colour and > text decoration. If someone tells me how to do this properly I'll > revise the code. AFAIS, the warning widget needs its own scheme, like the rest of the panel. > Please comment! More in the next days... -- Cheers Jorge.-

Sept. 22, 2009

[patch]: fix the meta-refresh warning code

by onepoint＠starurchin.org

Long time no post! Here's a fix for an outstanding TODO in html.cc. It replaces the code that creates the HTML META REFRESH warning (which sends HTML to Html_write_raw()) with a function that creates the widgets directly. There are still a few issues: * The HTML parser in table.cc does not create table widgets if USE_TABLES is not defined. Perhaps this code should do the same? * The new widgets do not have 'width="100%"' set, so the horizontal layout is slightly different. * The redirect link colour does not reflect whether the link URL has been visited. * It would be nice if the widgets and the redirect link were styled from the User Agent style in css.cc . I couldn't figure out how to do that so I just copied a few things like the link colour and text decoration. If someone tells me how to do this properly I'll revise the code. Please comment! Jeremy Henty

Sept. 20, 2009

Textblock::drawLine() split

by Johannes.Hofmann＠gmx.de

Hi corvid, this split was overdue! Thanks a lot for the cleanup. Cheers, Johannes

Sept. 19, 2009