June 2009 - Dillo-dev - lists.mailman3.com

patch: viewport keybindings

by jcid＠dillo.org

On Wed, Jun 24, 2009 at 05:13:51AM +0000, corvid wrote: > Here is an idea for viewport keybindings. > > It just builds a SimpleVector once and lets all of the viewports point to it, > which I think goes against the dillo/dw boundary rules, but we'll see how > the general idea goes over... > Well, that's one way to do it... I'm more inclined to have an scrolling keys enum in fltkviewport.hh, and to export another scrollTo() function that receives them as parameter. Then we can catch the shortcut in UI::handle(), and map between KEYS_* and the enum in a function like a_UIcmd_set_scroll_xy(). That avoids stepping over the dillo/dw boundaries. -- Cheers Jorge.-

June 24, 2009

[PATCH] warning: ignoring return value of ???int chdir(const char*)???

by jcid＠dillo.org

On Wed, Jun 24, 2009 at 11:03:26AM +0200, Michal Nowak wrote: > gcc-4.4.0-4.i586 > > HG tip: > > newman src $ make | grep -i warning > [...] > paths.cc: In static member function ???static void Paths::init()???: > paths.cc:38: warning: ignoring return value of ???int chdir(const char*)???, declared with attribute warn_unused_result > > With the patch dillo-guard-chdir.patch no warning. But this > patch alone won't have any effect, all MSG(...) from > Paths::init() won't write anything to output due to > prefs.show_msg not being set to TRUE at that moment. Patch > dillo-use-MSG-asap.patch moves a_Prefs_init() > before Paths::init() is called. Hope it's not breaking > anything. > > Tested > - setting non-existing directory instead of /tmp > - Dillo won't crash on start, basic browsing works Committed. There're also: cookies.c:90: warning: ignoring return value of 'write', cookies.c:249: warning: ignoring return value of 'fgets', dpid.c:754: warning: ignoring return value of 'write' bookmarks.c:696: warning: ignoring return value of 'system' bookmarks.c:698: warning: ignoring return value of 'system' cookies.c:188: warning: ignoring return value of 'write' cookies.c:276: warning: ignoring return value of 'fgets' cookies.c:341: warning: ignoring return value of 'fgets' cookies.c:428: warning: ignoring return value of 'ftruncate' cookies.c:1234: warning: ignoring return value of 'fgets' datauri.c:283: warning: ignoring return value of 'chdir' ftp.c:280: warning: ignoring return value of 'chdir' Can you please make a patch for those too? -- Cheers Jorge.-

June 24, 2009

patch: a binding for stop

by jcid＠dillo.org

On Wed, Jun 24, 2009 at 12:20:54AM +0000, corvid wrote: > How about if we just don't give it any default binding: Committed. -- Cheers Jorge.-

June 24, 2009

patch: save bookmark segfault when dpis not found

by jcid＠dillo.org

On Wed, Jun 24, 2009 at 02:50:17PM +0000, corvid wrote: > A new one seen in the bugtracker... > > a_Bookmarks_chat_add() sets URL to NULL, so it needs to be handled. > > Anyway, the reason this is interesting is that I had always figured > the URL_*() macros were protecting against a NULL URL, when really > they protect against NULL fields in URLs. Right. Please commit (with changelog entry) and update the bug track entry as "done". -- Cheers Jorge.-

June 24, 2009

patch: save bookmark segfault when dpis not found

by corvid＠lavabit.com

A new one seen in the bugtracker... a_Bookmarks_chat_add() sets URL to NULL, so it needs to be handled. Anyway, the reason this is interesting is that I had always figured the URL_*() macros were protecting against a NULL URL, when really they protect against NULL fields in URLs.

June 24, 2009

dillo 2.1

by sandshrew＠gmail.com

On Wed, 24 Jun 2009 14:24:41 +0200 Johannes Hofmann <Johannes.Hofmann(a)gmx.de> wrote: > hg tip now has support for color definitions of the form > rgb(255,255,255). > > Please give it a try. > Thanks. It seems to work ok. I have also tried the patch which makes text wrapping work in textareas ( http://lists.auriga.wearlab.de/pipermail/dillo-dev/2009-April/006267.html ). The text does wrap but it doesn't automatically scroll down. Maybe the patch could be committed with some adjustments? -- Brain: an apparatus with which we think we think. - A. Bierce

June 24, 2009

dillo 2.1

by Johannes.Hofmann＠gmx.de

On Mon, Jun 22, 2009 at 05:12:07PM +0300, Tomas R wrote: > Been testing dillo 2.1 for some time and would like to share my > experience. > > It's really great to see some basic css support (appearance of most if > not all websites has improved alot), properly resized images, > redirection and basic authentication working now :) > > Anyway, even dillo improved alot recently there still seems to be some > issues. Here are some I've noticed after testing this release for few > days: > Rendering > 1) ubuntu.lt > Not sure if it's dillo fault or website's malformed stylesheet, but > with default dillo settings some of the lithuanian characters are not > displayed. This can be fixed by just adding "* {font-family: > serif !important}" to the style.css. Here is a pic with some of the > places where letters are missing marked in red: > http://img4.imageshack.us/img4/2227/ubuntult.png > 2) gmail > It's nice that login works now, but with default dillo settings the > size of most of the text is 1px. This can be partially fixed by adding > font_min_size to dillorc, but it's obviously a dillo bug as this > doesn't happen with links-hacked. > 3) google > What's with the textarea in the top left corner of the page? And just > for information: signing out doesn't work because it requires basic > javascript support (works with links-hacked). > 4) Black on black, white on white... > http://www.nma-fallout.com/forum/viewtopic.php?t=42776&start=2660&sid=a5712… > For some reason black font color is used here and we get black text on > black background in some posts (doesn't happen with links-hacked). > http://www.acetoneteam.org/ > Background color is not set here and if we have "body > {background-color: white}" rule in our style.css file, we get white > text on white background. hg tip now has support for color definitions of the form rgb(255,255,255). Please give it a try. Cheers, Johannes

June 24, 2009

[PATCH] warning: ignoring return value of ‘int chdir(const char*)’

by newman.x＠gmail.com

gcc-4.4.0-4.i586 HG tip: newman src $ make | grep -i warning [...] paths.cc: In static member function ?static void Paths::init()?: paths.cc:38: warning: ignoring return value of ?int chdir(const char*)?, declared with attribute warn_unused_result With the patch dillo-guard-chdir.patch no warning. But this patch alone won't have any effect, all MSG(...) from Paths::init() won't write anything to output due to prefs.show_msg not being set to TRUE at that moment. Patch dillo-use-MSG-asap.patch moves a_Prefs_init() before Paths::init() is called. Hope it's not breaking anything. Tested - setting non-existing directory instead of /tmp - Dillo won't crash on start, basic browsing works -- Regards, Michal Nowak

June 24, 2009

patch: viewport keybindings

by corvid＠lavabit.com

Here is an idea for viewport keybindings. It just builds a SimpleVector once and lets all of the viewports point to it, which I think goes against the dillo/dw boundary rules, but we'll see how the general idea goes over...

June 24, 2009

patch: a binding for stop

by corvid＠lavabit.com

How about if we just don't give it any default binding:

June 24, 2009