May 2009 - Dillo-dev - lists.mailman3.com

Latest Dillo

by freya128＠yahoo.com

Well I just finally managed to compile dillo from the latest developer source and wow it's really amazing! Check out this page: http://www.indiewire.com That site doesn't work properly in my old OS9 mac running the latest netscape available for OS9 but here on my linux laptop running dillo it is working just fine! Totally usable! I also tried myspace for a giggle and found that was also very usable, at least for reading blogs and comments and stuff. Great! Lots of other sites are also working just fine too! By the way, the copy link location option doesn't seem to work but maybe you already know that. It would be great to get wikipedia rendering really well, as there are so many wikipedia pages and it is so useful that it would be good just to have a little browser even if it only worked on wikipedia pages! Theres so much content on there. I am having one problem tho and I'm wondering if it is a known thing or something that I have done bad here. The default font seems to render very badly, like the kerning is out or something. The k in book is half missing and it is hard to read what you type into the location bar, and the wikipedia pages are basically unreadable too as they all use this font. Wondering if it is because of the version of the font libraries I'm linking in when I compile or something else? Is this a known problem? Anyway I'm still in awe at how well the new code is working! :) Thankyou! love Freya

May 4, 2009

[patch]: more cleanups

by onepoint＠starurchin.org

Three more cleanup patches: 1: Inline Cache_client_make_key() into Cache_client_enqueue(). Why have a separate function just to increment a variable? It's just as clear (and less noisy) to increment a static variable inside Cache_client_enqueue(). 2: The width and height arguments of a_Image_new() do nothing. The function itself ignores them and its callers always set them to 0. Since neither the function or its callers seem to care what these arguments are, why not remove them? 3: a_Web_dispatch_by_type() has a strange convention for its return type, it returns -1 to indicate failure. It's less confusing to use the common convention of a boolean: 1 indicates success and 0 indicates failure. Regards, Jeremy Henty

May 4, 2009

Trying to compile the fltk 2 thing

by livio＠eecg.toronto.edu

Hi, Freya writes: > > It goes a bit funny sadly: > > === making src === > === making images/libjpeg === > === making images/zlib === > === making images/libpng === > === making images === > === making OpenGL === > === making fluid === > Linking fluid2... > /usr/bin/ld: cannot find -lXi > collect2: ld returned 1 exit status > make[1]: *** [fluid2] Error 1 > make: *** [all] Error 2 > > Any idea what I might be doing wrong? > It's a shame there are no packages available for the source as I'm running debian and I suspect things would be easier that way. apt-get install libxi-dev Should fix this particular error. Unfortunately, I have not found an "authoritative" list of dependencies for FLTK2. So, if other errors show up due to missing installed dependencies, you can always go to: http://www.debian.org/distrib/packages#search_contents and look for the missing library. For example, in the above case, if one searches for "libXi.so" they can see the missing 'libxi-dev' package. Good luck, Livio

May 4, 2009

patch: punctuation keys

by corvid＠lavabit.com

I'm thinking it might be more natural to be able to put, e.g., "*" instead of "<shift>8" (my keyboard, anyway). This patch is working for the cases I've happened to try, but I am not sure that event_text() will necessarily work for everything. (Last bit of the patch allows binding '<', which is a shifted key for me.) PS <shift>TabKey doesn't work for me, but it wasn't working for me before, either. PPS It would be nice if we could allow multibyte characters.

May 4, 2009

Trying to compile the fltk 2 thing

by freya128＠yahoo.com

It goes a bit funny sadly: === making src === === making images/libjpeg === === making images/zlib === === making images/libpng === === making images === === making OpenGL === === making fluid === Linking fluid2... /usr/bin/ld: cannot find -lXi collect2: ld returned 1 exit status make[1]: *** [fluid2] Error 1 make: *** [all] Error 2 Any idea what I might be doing wrong? It's a shame there are no packages available for the source as I'm running debian and I suspect things would be easier that way. Hope someone can help! :) love Freya

May 4, 2009

[Patch 3/4] Key bindings

by corvid＠lavabit.com

Jorge wrote: > The patch is not 100% complete. For instance there's > a need to provide a default keysrc file in a similar way > that cookiesrc or dillorc (with useful comments). Started looking into making a default keysrc. Some of the bindings in keys.cc are not the same as those in dillo2-help.html. Is that intentional? What is the purpose of KEYS_HIDE_PANELS when we have KEYS_FULLSCREEN?

May 4, 2009

[patch]: fix comment for a_Cache_open_url()

by jcid＠dillo.org

On Sun, May 03, 2009 at 12:12:41AM +0100, Jeremy Henty wrote: > > a_Cache_open_url() never returns 0, so its comment needs fixing. > (Bonus typo fix included too.) :) Committed. -- Cheers Jorge.-

May 3, 2009

[patch]: ensure Cache_client_make_key() returns > 0

by jcid＠dillo.org

On Sat, May 02, 2009 at 11:22:06PM +0100, Jeremy Henty wrote: > > Cache_client_make_key() carefully prevents integer overflow from > making it return a negative value, but it might return 0. This is a > problem because a_Capi_open_url() either calls a_Cache_open_url() and > returns the new client key or else returns 0 to signal that it did not > call a_Cache_open_url(). If Cache_client_make_key() returns 0 then > a_Capi_open_url() will return 0 too, and so its caller will think that > a_Cache_open_url() was not called even though it was. This will stop > the new cache client from being added to the browser window that > is responsible for creating it, which is wrong. Committed. Thanks for the detailed explanation. -- Cheers Jorge.-

May 3, 2009

Style question: cleaning up NULL

by jcid＠dillo.org

On Sun, May 03, 2009 at 05:16:31PM +0100, Jeremy Henty wrote: > > On Sun, May 03, 2009 at 09:35:34AM -0400, Jorge Arellano Cid wrote: > > On Sun, May 03, 2009 at 11:27:14AM +0100, Jeremy Henty wrote: > > > > > > ... a_Url_free() and a_Image_unref() both guard against being > > > passed a NULL argument, yet in several cases the code that calls > > > these functions also checks for a NULL, which is redundant. > > > > In general the API accepts NULL (e.g. dlib), so please remove the > > redundant checks outside it. > > OK, patches attached. Committed! -- Cheers Jorge.-

May 3, 2009

[Patch 3/4] Key bindings

by jcid＠dillo.org

On Sun, May 03, 2009 at 05:51:33PM +0000, corvid wrote: > Jorge wrote: > > A new, rewritten version of the patch was committed. > > Hurray! :) > PS Don't we need something like the following: Committed. -- Cheers Jorge.-

May 3, 2009