April 2009 - Dillo-dev - lists.mailman3.com

http.c:500: warning: unused parameter ???Data2???

by jcid＠dillo.org

On Thu, Apr 02, 2009 at 12:11:27AM +0200, Michal Nowak wrote: > gcc -DHAVE_CONFIG_H -I. -I../.. -I/usr/local/include -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -g -O2 -DD_DNS_THREADED -D_REENTRANT -D_THREAD_SAFE -Wall -W -Waggregate-return -MT http.o -MD -MP -MF .deps/http.Tpo -c -o http.o http.c > http.c: In function ???a_Http_ccc???: > http.c:500: warning: unused parameter ???Data2??? > > gcc-4.3.2-7.i386 > > Emerged in recent days. Yes, it's visible since the addition of the "-W" flag. Data2 is a generic parameter used with CCC that is not used by http.c. No real problem here. -- Cheers Jorge.-

April 2, 2009

[PATCH] startup window

by jcid＠dillo.org

On Wed, Apr 01, 2009 at 08:11:32PM +0200, Hofmann Johannes wrote: > On Wed, Apr 01, 2009 at 04:49:44PM +0000, corvid wrote: > > Thomas wrote: > > > Am Wed, 1 Apr 2009 09:47:11 +0200 > > > schrieb Hofmann Johannes <Johannes.Hofmann(a)gmx.de>: > > > > > > > Hi, > > > > attached patch adds a proper startup screen for dillo. > > > > > > Oh, is dillo slow enough now that it needs a splash screen distracting the user while waiting for startup? > > > I sort of like the "instant startup" behaviour. A splash startup screen reminds you of the startup _not_ being instant. > > > Especially opening an extra window wastes CPU cycles, even in X11, that could be used on doing the actual work... > > > Of course I'll have to check out a current dillo2 to see how eminent the issue really is. But when we reach the startup speed of e.g. the GIMP with it's endless loading of plugins etc., one can safely declare dillo "just another bloated browser". > > > I don't want to be offensive, just voice my concern... > > > > I agree with Thomas here. > > > > me too - check the date :) Good one! I should have suggested using Gecko... :-) -- Cheers Jorge.-

April 2, 2009

[PATCH] startup window

by jcid＠dillo.org

On Wed, Apr 01, 2009 at 04:49:44PM +0000, corvid wrote: > Thomas wrote: > > Am Wed, 1 Apr 2009 09:47:11 +0200 > > schrieb Hofmann Johannes <Johannes.Hofmann(a)gmx.de>: > > > > > Hi, > > > attached patch adds a proper startup screen for dillo. > > > > Oh, is dillo slow enough now that it needs a splash screen distracting the user while waiting for startup? > > I sort of like the "instant startup" behaviour. A splash startup screen reminds you of the startup _not_ being instant. > > Especially opening an extra window wastes CPU cycles, even in X11, that could be used on doing the actual work... > > Of course I'll have to check out a current dillo2 to see how eminent the issue really is. But when we reach the startup speed of e.g. the GIMP with it's endless loading of plugins etc., one can safely declare dillo "just another bloated browser". > > I don't want to be offensive, just voice my concern... > > I agree with Thomas here. Me too. -- Cheers Jorge.-

April 2, 2009

Segfault on sites requiring authentication

by corvid＠lavabit.com

Tim wrote: > It is curious that we > loop two times over ClientQueue though. Probably because the > function is called every x received bytes, right? a_Cache_process_dbuf calls Cache_process_queue once for each packet and once when it's done (IOClose). > Looking for http://puppyisos.org/miniicons/kfm_home.png... > Looking for http://puppyisos.org/miniicons/ark.png... > Found (id=1). > HTTP warning: unhandled MIME type: "text/html; charset=iso-8859-1" > Looping over ClientQueue... > Looking for http://puppyisos.org/miniicons/kfm_home.png... > Looking for http://puppyisos.org/miniicons/ark.png... > Found (id=1). > Removing client (id=1) > > We should add support for charsets within MIME types anytime. As far > as I know, Dillo only depends on meta-tags when deciding which > encoding to go with. This notation is officially approved, see: > http://www.w3.org/International/tutorials/tutorial-char-enc/#Slide0270 Charsets in MIME types are supported. It's probably complaining because it expected an image/png and got the text/html; charset=iso-8859-1 401 Auth page which can't be displayed as an image. > PS: Having applied the patch, the iterations of the ClientQueue loop > will now stop after the URL has matched. Previously, the iteration > for the same entry item was then repeated again (if AbortEntry is > true). Is there a reason for keeping it as-is? In case multiple clients were waiting for this data. Now I _am_ getting the crash. Maybe I accidentally typed in the main page instead. Don't think I did, but...whatever...anyway... in Cache_auth_callback(), a_Nav_reload(data->bw) does not sound at all like what we want for images on a page. We'd want something more along the lines of Cache_entry_remove() on the image and a_Nav_repush() on the page, but I think in either case that would remove clients for other images while we're trying to get their data, causing...what we're seeing. (Is dillo turning into a snarled knot?) If the last image comes in while there's no client, I wouldn't know what bw to repush.

April 2, 2009

Segfault on sites requiring authentication

by tim.nieradzik＠gmx.de

> It would be good to find out what it's doing exactly for you. > - I'd expect a client to be waiting for it in this case. The client does not exist anymore because it has been destroyed too early. That is why I removed the timer in the previous patch. Debugging asynchronous code is difficult. I compiled Dillo with debugging symbols and added some printf()'s to see what is going on in detail. Afterwards I ran the binary through gdb. When visiting http://puppyisos.org/isos, everything looks alright in the beginning. The dialog pops up as expected. It is curious that we loop two times over ClientQueue though. Probably because the function is called every x received bytes, right? [New Thread 0xf760bb90 (LWP 14474)] [Thread 0xf760bb90 (LWP 14474) exited] Looping over ClientQueue... Looking for http://puppyisos.org/isos... Found (id=0). Looping over ClientQueue... Looking for http://puppyisos.org/isos... Found (id=0). Removing client (id=0) It seems that after confirming the authentication dialog, the page is being reloaded but without the header that is necessary for the HTTP authentication... Reloading page with authentication credentials... Looping over ClientQueue... Looking for http://puppyisos.org/isos... Found (id=0). Looping over ClientQueue... Looking for http://puppyisos.org/isos... Found (id=0). Removing client (id=0) At least this would explain, why the client for http://puppyisos.org/isos was deleted. Now the page is reloaded again because suddenly there is a client for http://puppyisos.org/isos/ again (with id=0): Looping over ClientQueue... Looking for http://puppyisos.org/isos/... Found (id=0). Looping over ClientQueue... Looking for http://puppyisos.org/isos/... Found (id=0). Looping over ClientQueue... Looking for http://puppyisos.org/isos/... Found (id=0). Looping over ClientQueue... Looking for http://puppyisos.org/isos/... Found (id=0). Looping over ClientQueue... Looking for http://puppyisos.org/isos/... Found (id=0). Removing client (id=0) Looping over ClientQueue... Looking for http://puppyisos.org/miniicons/kfm_home.png... Looking for http://puppyisos.org/miniicons/ark.png... Found (id=1). HTTP warning: unhandled MIME type: "text/html; charset=iso-8859-1" Looping over ClientQueue... Looking for http://puppyisos.org/miniicons/kfm_home.png... Looking for http://puppyisos.org/miniicons/ark.png... Found (id=1). Removing client (id=1) We should add support for charsets within MIME types anytime. As far as I know, Dillo only depends on meta-tags when deciding which encoding to go with. This notation is officially approved, see: http://www.w3.org/International/tutorials/tutorial-char-enc/#Slide0270 Reloading page with authentication credentials... Looping over ClientQueue... Looking for http://puppyisos.org/isos/... Not found! Looping over ClientQueue... Looking for http://puppyisos.org/isos/... Not found! Looping over ClientQueue... Looking for http://puppyisos.org/isos/... Not found! Looping over ClientQueue... Looking for http://puppyisos.org/isos/... Not found! Looping over ClientQueue... Looking for http://puppyisos.org/isos/... Not found! Looping over ClientQueue... Looking for http://puppyisos.org/isos/... Not found! Reloading page with authentication credentials... Why was the site reloaded again? Interestingly, no new client has been created for /isos this time. I am a bit astonished how often Cache_auth_callback() is called even though the dialog only appears once. Everything looks a bit asynchronous. An evidence might be the following lines: Looking for http://puppyisos.org/miniicons/kfm_home.png... Looking for http://puppyisos.org/miniicons/ark.png... In general, there should be a "Found (id=...)." or at least a "Not found!'" but they just follow after each other. And now it crashes: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0xf79bf6d0 (LWP 14340)] 0x0805ba14 in a_Nav_cancel_expect (bw=0x0) at nav.c:250 250 if (bw->nav_expecting) { Here is the back trace: (gdb) bt #0 0x0805ba14 in a_Nav_cancel_expect (bw=0x0) at nav.c:250 #1 0x0805c098 in a_Nav_reload (bw=0x0) at nav.c:474 #2 0x0805dd4e in Cache_auth_callback (vdata=0x8252208) at cache.c:971 #3 0xf7f23e75 in fltk::wait () from /usr/lib/libfltk2.so #4 0xf7f23f88 in fltk::run () from /usr/lib/libfltk2.so #5 0x0804f686 in main (argc=1, argv=0xffdf7b74) at dillo.cc:333 > - I think a client shouldn't ever have a NULL bw. I agree. > - The case where there are no clients waiting for the URL > does sound like a bug, although I think I'd be tempted > just not to call Cache_auth_entry() if the bw was NULL. Unfortunately, that did not really help. Well, Dillo does not crash anymore but no images on this page are shown and it reloads several times before anything gets displayed. > Reloading doesn't crash it for me. > Yes, I'm using the latest code. In contrast to /isos, the main page (http://puppyisos.org/) is working alright here. No crashes, all images are displayed properly. There are some other directory listings on that site which are working, too even though there syntax is quite similar to /isos'. > You mentioned the other day that you get a lot of crashes in general, > and I was surprised because I've had a total of three random crashes > since 2.0 was released. The situation has improved since I am browsing with the latest trunk. Nevertheless, I still experience non-reproducible crashes sometimes: It happens frequently that dpid ``crashes'' (100% CPU consumption). This happens mostly when domain names cannot be resolved correctly. Trying to reload the page does not solve it. I have to kill the process manually. PS: Having applied the patch, the iterations of the ClientQueue loop will now stop after the URL has matched. Previously, the iteration for the same entry item was then repeated again (if AbortEntry is true). Is there a reason for keeping it as-is? --Tim

April 2, 2009

http.c:500: warning: unused parameter ‘Data2’

by newman.x＠gmail.com

gcc -DHAVE_CONFIG_H -I. -I../.. -I/usr/local/include -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -g -O2 -DD_DNS_THREADED -D_REENTRANT -D_THREAD_SAFE -Wall -W -Waggregate-return -MT http.o -MD -MP -MF .deps/http.Tpo -c -o http.o http.c http.c: In function ?a_Http_ccc?: http.c:500: warning: unused parameter ?Data2? gcc-4.3.2-7.i386 Emerged in recent days. -- Regards, Michal Nowak

April 2, 2009

Warnings in src/IO/dpi.c and lout/misc.hh

by newman.x＠gmail.com

On Wed, Apr 01, 2009 at 10:16:41PM +0200, Hofmann Johannes wrote: > On Fri, Mar 27, 2009 at 01:07:14PM +0100, Hofmann Johannes wrote: > > Hi, > > > > On Fri, Mar 27, 2009 at 12:00:46AM +0100, Michal Nowak wrote: > > > Found this three warnings when compiling with gcc-4.3.2-7.i386: > > > > > > gcc -DHAVE_CONFIG_H -I. -I../.. -I/usr/local/include -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -g -O2 -DD_DNS_THREADED -D_REENTRANT -D_THREAD_SAFE -Wall -W -Waggregate-return -MT dpi.o -MD -MP -MF .deps/dpi.Tpo -c -o dpi.o dpi.c > > > dpi.c: In function ?Dpi_get_dpid_uds_dir?: > > > dpi.c:382: warning: ignoring return value of ?fgets?, declared with attribute warn_unused_result > > > dpi.c: In function ?a_Dpi_bye_dpid?: > > > dpi.c:733: warning: ignoring return value of ?write?, declared with attribute warn_unused_result > > > > > > g++ -DHAVE_CONFIG_H -I. -I.. -DDILLORC_SYS='"/usr/local/etc/dillorc"' -I/usr/local/include -I.. -I/usr/include/libpng12 -I/usr/include/freetype2 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -Wno-non-virtual-dtor -g -O2 -Wall -W -Wno-unused-parameter -fno-rtti -fno-exceptions -MT styleengine.o -MD -MP -MF .deps/styleengine.Tpo -c -o styleengine.o styleengine.cc > > > ../lout/misc.hh: In member function ?void StyleEngine::apply(dw::core::style::StyleAttrs*, CssPropertyList*)?: > > > ../lout/misc.hh:181: warning: assuming signed overflow does not occur when assuming that (X - c) > X is always false > > > > Can you please check whether attached patches fix the warnings? > > Michal, do the patches fix the warnings for you? > > Cheers, > Johannes Yes, the mentioned warnings are fixed now, thanks Johannes! But one more emerged due to recent clean up, see follow-up email. Michal > > > > > @all: please have a look at the dpi.c fix. > > > > Cheers, > > Johannes > > > diff -r b06377790b00 src/IO/dpi.c > > --- a/src/IO/dpi.c Thu Mar 26 23:18:02 2009 +0000 > > +++ b/src/IO/dpi.c Fri Mar 27 13:05:11 2009 +0100 > > @@ -371,7 +371,7 @@ static char *Dpi_get_dpid_uds_dir(void) > > { > > FILE *in; > > char *saved_name_filename; /* :) */ > > - char dpid_uds_dir[256], *p = NULL; > > + char buf[256], *dpid_uds_dir, *p = NULL, *p1; > > > > saved_name_filename = > > dStrconcat(dGethomedir(), "/.dillo/dpi_socket_dir", NULL); > > @@ -379,14 +379,16 @@ static char *Dpi_get_dpid_uds_dir(void) > > dFree(saved_name_filename); > > > > if (in != NULL) { > > - fgets(dpid_uds_dir, 256, in); > > + dpid_uds_dir = fgets(buf, sizeof(buf), in); > > fclose(in); > > - if ((p = strchr(dpid_uds_dir, '\n'))) { > > - *p = 0; > > - } > > - if (access(dpid_uds_dir, F_OK) == 0) { > > - p = dStrdup(dpid_uds_dir); > > - _MSG("Dpi_get_dpid_uds_dir:: %s\n", p); > > + if (dpid_uds_dir) { > > + if ((p1 = strchr(dpid_uds_dir, '\n'))) { > > + *p1 = 0; > > + } > > + if (access(dpid_uds_dir, F_OK) == 0) { > > + p = dStrdup(dpid_uds_dir); > > + _MSG("Dpi_get_dpid_uds_dir:: %s\n", p); > > + } > > } > > } > > > > @@ -730,7 +732,9 @@ void a_Dpi_bye_dpid() > > MSG("%s\n", sa.sun_path); > > } > > DpiBye_cmd = a_Dpip_build_cmd("cmd=%s", "DpiBye"); > > - (void) write(new_socket, DpiBye_cmd, strlen(DpiBye_cmd)); > > + if (write(new_socket, DpiBye_cmd, strlen(DpiBye_cmd)) != > > + (ssize_t) strlen(DpiBye_cmd)) > > + MSG_WARN("Failed to send DpiBye\n"); > > dFree(DpiBye_cmd); > > Dpi_close_fd(new_socket); > > } > > > diff -r b06377790b00 lout/misc.hh > > --- a/lout/misc.hh Thu Mar 26 23:18:02 2009 +0000 > > +++ b/lout/misc.hh Fri Mar 27 12:52:36 2009 +0100 > > @@ -178,7 +178,7 @@ public: > > */ > > inline T get (int i) { > > if (BOUND_CHECKING) > > - assert (i >= 0 && i < this->num); > > + assert (i >= 0 && this->num - i > 0); > > return this->array[i]; > > } > > > > @@ -192,7 +192,7 @@ public: > > */ > > inline void set (int i, T t) { > > if (BOUND_CHECKING) > > - assert (i >= 0 && i < this->num); > > + assert (i >= 0 && this->num - i > 0); > > this->array[i] = t; > > } > > }; > > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev -- Regards, Michal Nowak

April 1, 2009

Warnings in src/IO/dpi.c and lout/misc.hh

by Johannes.Hofmann＠gmx.de

On Fri, Mar 27, 2009 at 01:07:14PM +0100, Hofmann Johannes wrote: > Hi, > > On Fri, Mar 27, 2009 at 12:00:46AM +0100, Michal Nowak wrote: > > Found this three warnings when compiling with gcc-4.3.2-7.i386: > > > > gcc -DHAVE_CONFIG_H -I. -I../.. -I/usr/local/include -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -g -O2 -DD_DNS_THREADED -D_REENTRANT -D_THREAD_SAFE -Wall -W -Waggregate-return -MT dpi.o -MD -MP -MF .deps/dpi.Tpo -c -o dpi.o dpi.c > > dpi.c: In function ?Dpi_get_dpid_uds_dir?: > > dpi.c:382: warning: ignoring return value of ?fgets?, declared with attribute warn_unused_result > > dpi.c: In function ?a_Dpi_bye_dpid?: > > dpi.c:733: warning: ignoring return value of ?write?, declared with attribute warn_unused_result > > > > g++ -DHAVE_CONFIG_H -I. -I.. -DDILLORC_SYS='"/usr/local/etc/dillorc"' -I/usr/local/include -I.. -I/usr/include/libpng12 -I/usr/include/freetype2 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -Wno-non-virtual-dtor -g -O2 -Wall -W -Wno-unused-parameter -fno-rtti -fno-exceptions -MT styleengine.o -MD -MP -MF .deps/styleengine.Tpo -c -o styleengine.o styleengine.cc > > ../lout/misc.hh: In member function ?void StyleEngine::apply(dw::core::style::StyleAttrs*, CssPropertyList*)?: > > ../lout/misc.hh:181: warning: assuming signed overflow does not occur when assuming that (X - c) > X is always false > > Can you please check whether attached patches fix the warnings? Michal, do the patches fix the warnings for you? Cheers, Johannes > > @all: please have a look at the dpi.c fix. > > Cheers, > Johannes > diff -r b06377790b00 src/IO/dpi.c > --- a/src/IO/dpi.c Thu Mar 26 23:18:02 2009 +0000 > +++ b/src/IO/dpi.c Fri Mar 27 13:05:11 2009 +0100 > @@ -371,7 +371,7 @@ static char *Dpi_get_dpid_uds_dir(void) > { > FILE *in; > char *saved_name_filename; /* :) */ > - char dpid_uds_dir[256], *p = NULL; > + char buf[256], *dpid_uds_dir, *p = NULL, *p1; > > saved_name_filename = > dStrconcat(dGethomedir(), "/.dillo/dpi_socket_dir", NULL); > @@ -379,14 +379,16 @@ static char *Dpi_get_dpid_uds_dir(void) > dFree(saved_name_filename); > > if (in != NULL) { > - fgets(dpid_uds_dir, 256, in); > + dpid_uds_dir = fgets(buf, sizeof(buf), in); > fclose(in); > - if ((p = strchr(dpid_uds_dir, '\n'))) { > - *p = 0; > - } > - if (access(dpid_uds_dir, F_OK) == 0) { > - p = dStrdup(dpid_uds_dir); > - _MSG("Dpi_get_dpid_uds_dir:: %s\n", p); > + if (dpid_uds_dir) { > + if ((p1 = strchr(dpid_uds_dir, '\n'))) { > + *p1 = 0; > + } > + if (access(dpid_uds_dir, F_OK) == 0) { > + p = dStrdup(dpid_uds_dir); > + _MSG("Dpi_get_dpid_uds_dir:: %s\n", p); > + } > } > } > > @@ -730,7 +732,9 @@ void a_Dpi_bye_dpid() > MSG("%s\n", sa.sun_path); > } > DpiBye_cmd = a_Dpip_build_cmd("cmd=%s", "DpiBye"); > - (void) write(new_socket, DpiBye_cmd, strlen(DpiBye_cmd)); > + if (write(new_socket, DpiBye_cmd, strlen(DpiBye_cmd)) != > + (ssize_t) strlen(DpiBye_cmd)) > + MSG_WARN("Failed to send DpiBye\n"); > dFree(DpiBye_cmd); > Dpi_close_fd(new_socket); > } > diff -r b06377790b00 lout/misc.hh > --- a/lout/misc.hh Thu Mar 26 23:18:02 2009 +0000 > +++ b/lout/misc.hh Fri Mar 27 12:52:36 2009 +0100 > @@ -178,7 +178,7 @@ public: > */ > inline T get (int i) { > if (BOUND_CHECKING) > - assert (i >= 0 && i < this->num); > + assert (i >= 0 && this->num - i > 0); > return this->array[i]; > } > > @@ -192,7 +192,7 @@ public: > */ > inline void set (int i, T t) { > if (BOUND_CHECKING) > - assert (i >= 0 && i < this->num); > + assert (i >= 0 && this->num - i > 0); > this->array[i] = t; > } > };

April 1, 2009

Segfault on sites requiring authentication

by corvid＠lavabit.com

Tim wrote: > > I'm not seeing this crash. Is it going through the for loop and > > getting set to NULL in Client_bw = ClientWeb->bw;, or is it > > NULL because there weren't any clients and it didn't execute that code? > > Yes, it is going through the loop. Probably comparing Client->Url > with entry->Url fails. As a result, ClientWeb and Client_bw do not > get set. It would be good to find out what it's doing exactly for you. - I'd expect a client to be waiting for it in this case. - I think a client shouldn't ever have a NULL bw. - The case where there are no clients waiting for the URL does sound like a bug, although I think I'd be tempted just not to call Cache_auth_entry() if the bw was NULL. > Have you also tried reloading the page? Sometimes it does not get > loaded properly here. Anyway, it is odd that Dillo does not crash > for you. Are you using the latest trunk? Reloading doesn't crash it for me. Yes, I'm using the latest code. You mentioned the other day that you get a lot of crashes in general, and I was surprised because I've had a total of three random crashes since 2.0 was released.

April 1, 2009

[PATCH] startup window

by tim.nieradzik＠gmx.de

Heh, that is what I had in mind all the time. However, nice idea for an April Fool's hoax. :) --Tim

April 1, 2009