March 2009 - Dillo-dev - lists.mailman3.com

Too busy...

by jcid＠dillo.org

Hi, Please excuse me for being silent these days. It's being full of activities for me. Besides the regular job, I'm moving to another place and have a trip out of the city the next weekend. Rolling a release needs more than a couple spare days so, it will have to wait. I'll surely have more time when April starts, if I have some time before that, I'll try to answer the pending emails. The current repo is almost rc1. After the "instant META redirection" patch goes in, it'll be rc1, and the release procedures will start. -- Cheers Jorge.-

March 15, 2009

[patch]: remove the BW_* flags

by onepoint＠starurchin.org

On Fri, Mar 13, 2009 at 08:40:45AM -0300, Jorge Arellano Cid wrote: > Anyway I reviewed the patch back then, and remembered that the > current interface was meant for flexibility to experiment. Yes, there is a case for keeping the flags for future development. I just wanted to point that they are currently redundant and we could remove them if we wanted. > I have to give it a second review. Anyway, if there're more cleanups > pending on this patch, it may be worth accepting them Just so you know, the cleanups I have pending refactor a lot of code that calls the dList_* API in convoluted and inefficient ways. (Most stuff that call dList_remove() are like this.) You get cleaner and more efficient code by defining new dList_remove_* and dList_free_* functions, because that lets you replace lots of convoluted code paths that call dList_remove(), dList_nth_data() etc. with single API calls. One function that gets refactored is a_Bw_stop_clients(), which is why submitting the cleanup patches is waiting on the decision about the BM_Flags patch. It won't be hard to fix the cleanup patches if the BM_Flags patch does not go in, but until the decision is made I don't know whether or not to do that. Regards, Jeremy Henty

March 13, 2009

[patch]: remove the BW_* flags

by jcid＠dillo.org

On Thu, Mar 12, 2009 at 08:38:21PM +0100, Hofmann Johannes wrote: > On Thu, Mar 12, 2009 at 10:36:08AM +0000, Jeremy Henty wrote: > > > > I wrote: > > > > > a_Bw_stop_clients() is always called with the BW_Root and BW_Img > > > flags set, so we can remove those flags. That leaves only the > > > BW_Force flag, so we can remove that too and change the flags > > > argument to a boolean that indicates whether to force. > > > > What's the verdict on this? I haven't seen any comments. I have some > > other cleanups and refactoring to propose and some of those patches > > depend on this one, so it would be good know whether or not it will go > > in so I can ready the rest for submission. > > Sorry, I can't comment on this one as I don't know the > relevant code enough. Let's wait for Jorge to comment. Sorry, I've had little time latelely... Anyway I reviewed the patch back then, and remembered that the current interface was meant for flexibility to experiment. The smantics for STOP were/are not well defined yet, and so the flags API lingered. I have to give it a second review. Anyway, if there're more cleanups pending on this patch, it may be worth accepting them and at worst to re-introduce the flags when STOP semantics get high priority (if ever). -- Cheers Jorge.-

March 13, 2009

[PATCH 0 of 3] tweaking the dillo ui for embedded devices

by jcid＠dillo.org

On Thu, Mar 12, 2009 at 11:07:58PM +0100, Andreas Kemnade wrote: > Hi, > > On Wed, 11 Mar 2009 08:41:20 -0300 > Jorge Arellano Cid <jcid(a)dillo.org> wrote: > > > On Tue, Mar 10, 2009 at 02:12:56AM +0100, Justus Winter wrote: > > > Hofmann Johannes wrote: > > >> Hi Justus, > > >> > > >> On Mon, Mar 09, 2009 at 05:59:31PM +0100, Justus Winter wrote: > > >>> Hey folks :) > > >>> > > >>> I've got a new toy (the Neo FreeRunner) and dillo2 runs quite nicely > > >>> on that little device, but there are some problems: > > >>> > > >>> * there is no way to create bookmarks > > >> > > >> What about the context menus in general? Is there no way to simulate > > >> a right mouse click? dillo uses context menus in many cases so we > > >> probabely need a general solution for this. > > > There is a module for gtk2 (libgtkstylus.so) that simulates a right > > > click when the user holds the left mouse button, that works quite nicely > > > in practice. > > > > Andreas suggestd the same, and it looks like a good solution. > > Even more if handheld users are accustomed to it. > > > > > That was actually what I wanted to implement at first. I looked through > > > the fltk2 event handling code (most thoroughly with respect to the > > > button widget) [...] > > > I have done a quick-hack for proof-of-concept purposes. > It is a really dirty patch. But maybe it is a starting point for experimenting. > If the button is released after pressing it more than two seconds, > the menu will popup on the page. > I have successfully added bookmarks without using the right mouse button. Good. Please continue working on this line into a clean patch. Also wrapping it with a pref switch looks right: e.g. emulate_right_click > > Maybe something like what's used for tooltip can be of help. > > This has to be asked in fltk general before discarding it. > > > > If there's no way, a right-click button may be of help. This is > > left-click on RCB and the next left-click will be processed as a > > right click. > > > A button like that does already exist. It is a matchbox-panel app > called xmonobut. > It toggles the button you hit when you touch the touchscreen. > I don't know why I don't get it work with the freerunner yet. > On my Ipaq I have no problems with it. Asking xmonobut developers may save some work. Anyway having the option in dillo doesn't hurt much. -- Cheers Jorge.-

March 13, 2009

[PATCH 0 of 3] tweaking the dillo ui for embedded devices

by akemnade＠tzi.de

Skipped content of type multipart/mixed

March 12, 2009

[patch]: remove the BW_* flags

by Johannes.Hofmann＠gmx.de

On Thu, Mar 12, 2009 at 10:36:08AM +0000, Jeremy Henty wrote: > > I wrote: > > > a_Bw_stop_clients() is always called with the BW_Root and BW_Img > > flags set, so we can remove those flags. That leaves only the > > BW_Force flag, so we can remove that too and change the flags > > argument to a boolean that indicates whether to force. > > What's the verdict on this? I haven't seen any comments. I have some > other cleanups and refactoring to propose and some of those patches > depend on this one, so it would be good know whether or not it will go > in so I can ready the rest for submission. Sorry, I can't comment on this one as I don't know the relevant code enough. Let's wait for Jorge to comment. Cheers, Johannes

March 12, 2009

[patch]: remove the BW_* flags

by onepoint＠starurchin.org

I wrote: > a_Bw_stop_clients() is always called with the BW_Root and BW_Img > flags set, so we can remove those flags. That leaves only the > BW_Force flag, so we can remove that too and change the flags > argument to a boolean that indicates whether to force. What's the verdict on this? I haven't seen any comments. I have some other cleanups and refactoring to propose and some of those patches depend on this one, so it would be good know whether or not it will go in so I can ready the rest for submission. Regards, Jeremy Henty

March 12, 2009

[PATCH 3 of 3] Easy panning with the left mouse button

by darirf＠yahoo.es

Hi! As this is my first post to the list: hello, I'm the one that ported (or broke, depending on your the point of view) dillo 0.8.6 for the iRex iLiad e-book reader; my alias in mobileread.com is Antartica. I've been reading the lists for some time now, but didn't thought I had anything to share yet. But... I agree with Justus in that panning is the easiest method to scroll in embedded devices; the scroll bar is very small and enlarging it wastes too much screen state. For the iliad port of dillo 0.8.6 I did exactly what Justus is proposing of left-button-does-panning (albeit in a hackish way, as I hardcoded that behaviour). For reference, the patch to old dillo 0.8.6 is in: http://projects.mobileread.com/iliad/users/antartica/dillo/dillo-patch-spli… I was actually doing the same for dillo2, but only have it partly-done (see attach). I would love to have Justus code merged in mainline, as it implements that functionality neatly and it would alleviate me from finishing my hack :). Right now I can't test Justus patch, but I had one error to fix in mine: it didn't pan when showing images. Its worth checking if Justus patch have that right. Anyway, you all are doing an excellent job in keeping dillo relevant. It is really a nice piece of work :). Congrats. Regards, Dario. --- El lun, 9/3/09, Justus Winter <4winter(a)informatik.uni-hamburg.de> escribi?: > De: Justus Winter <4winter(a)informatik.uni-hamburg.de> > Asunto: [Dillo-dev] [PATCH 3 of 3] Easy panning with the left mouse button > Para: dillo-dev(a)dillo.org > Fecha: lunes, 9 marzo, 2009 5:59 > # HG changeset patch > # User Justus Winter > <justus.winter(a)informatik.uni-hamburg.de> > # Date 1236616924 -3600 > # Node ID 46c62dde8967ae87914d0fbcc0ba7df61853750c > # Parent 78c0fa261c84df53da7f69cc8f33dc85fa152f9c > Easy panning with the left mouse button > > This is particulary useful for embedded devices with touch > screens. > In order to select text you have to double click and drag > the pointer. > > Note that this functionality is disabled by default and can > be enabled > by the easy_panning directive in the configuration file > with the > exception of the selection behavior which is located in > dw/selection.cc > and lacks a reference to the prefs struct by design (dw is > a toolkit and > frontend agnostic). > > I think that dw needs an interface to tweak it's > behaviour > ie dw_config(DW_DOUBLECLICK_TO_SELECT, true). Any ideas? > [...]

March 12, 2009

Holiday week

by jcid＠dillo.org

On Wed, Mar 11, 2009 at 06:28:22PM +0100, Hofmann Johannes wrote: > On Sat, Feb 21, 2009 at 11:47:56AM -0300, Jorge Arellano Cid wrote: > > Hi there, > > > > I happen to be enjoying a much needed holiday week! :-) > > > > The plan is to come back around near wednesday 25. > > > > In the meanwhile, I leave you with the following issues lurking > > in my list to be considered. Maybe all of them can be left to the > > release after 2.1, but maybe not: > > > > [ ] https dialog bombing issue. BUG#868 > > When enabled, multiple https requests to the same site result > > in dialog bombing. The https dpi is disabled by default in > > Dillo. Anyway, in Debian, there's a security warning against > > dillo for not checking certificates (I don't know what > > version of dillo they use, nor why they enable https.) > > > > [ ] Jump to #anchor doesn't work correctly. > > The idle timeout doesn't work reliably (an old bug). > > > > [ ] Implement @import statement in STYLE element. > > > > [ ] What will we do with xhtml? FF doesn't validate. BUG#732 > > This would be interesting to define. > > (already suggested as discussion material in another thread). > > > > [ ] "-fno-rtti -fno-exceptions" gcc: 64KB less. > > Enabling this switches reduces the binary size. > > > > [ ] dpi for "view page source" (it re-uses search capability). > > Waiting since a long time... > > Do we really need a dpi for this? As long as we don't do syntax > highlighting (which would be nice) we could also do it in dillo > directly. The "View Stylesheets" code is really minimal. As far as I > can see we would need a way to force a certain mime type > (text/plain in this case). Any ideas how to do this? Yes, the dpi can easily add line numbers which are very handy to have. The extra code inside dillo is very small and the dpi too. -- Cheers Jorge.-

March 11, 2009

Holiday week

by Johannes.Hofmann＠gmx.de

On Sat, Feb 21, 2009 at 11:47:56AM -0300, Jorge Arellano Cid wrote: > Hi there, > > I happen to be enjoying a much needed holiday week! :-) > > The plan is to come back around near wednesday 25. > > In the meanwhile, I leave you with the following issues lurking > in my list to be considered. Maybe all of them can be left to the > release after 2.1, but maybe not: > > [ ] https dialog bombing issue. BUG#868 > When enabled, multiple https requests to the same site result > in dialog bombing. The https dpi is disabled by default in > Dillo. Anyway, in Debian, there's a security warning against > dillo for not checking certificates (I don't know what > version of dillo they use, nor why they enable https.) > > [ ] Jump to #anchor doesn't work correctly. > The idle timeout doesn't work reliably (an old bug). > > [ ] Implement @import statement in STYLE element. > > [ ] What will we do with xhtml? FF doesn't validate. BUG#732 > This would be interesting to define. > (already suggested as discussion material in another thread). > > [ ] "-fno-rtti -fno-exceptions" gcc: 64KB less. > Enabling this switches reduces the binary size. > > [ ] dpi for "view page source" (it re-uses search capability). > Waiting since a long time... Do we really need a dpi for this? As long as we don't do syntax highlighting (which would be nice) we could also do it in dillo directly. The "View Stylesheets" code is really minimal. As far as I can see we would need a way to force a certain mime type (text/plain in this case). Any ideas how to do this? Cheers, Johannes

March 11, 2009