March 2009 - Dillo-dev - lists.mailman3.com

bookmark dpi - cleanups

by jcid＠dillo.org

On Fri, Mar 20, 2009 at 07:36:28PM +0100, Justus Winter wrote: > Hey Folks :) > > the select an operation header line in dpi:/bm/modify contains a number > of no breaking spaces that prevented dillo from wrapping the text making > the page somewhat hard to use on a small screen (the freerunners display > is 480 pixels wide). The third patch fixes this problem. I couldn't help > to clean up some optical inconsistencies and a html bug warning while > fixing the original problem. Good! All committed. -- Cheers Jorge.-

March 24, 2009

bug tracker doesn't work with dillo?

by corvid＠lavabit.com

Scott wrote: > * corvid <corvid(a)lavabit.com> wrote: > > Does using %d or casting the length to a long > > change anything? > > Yes, either one resolves the issue. :) > > > It doesn't seem like adding a ptr arg should > > be able to do anything to alignment, but > > then I don't know what goes on in the > > bowels of the varargs stuff. > > It looks like the alignment was probably off all along, and > adding a parameter just revealed an old bug. I found that simply > adding a "%s" to the format string, with an empty "" as its > parameter, was enough to trigger the problem. > > More generally, I found that it works if I use an even number of > variables in format string, but it fails with an odd number. So, > I think the compiler is probably padding something and the "%ld" > gets the extra zero bits it needs from the padding. Do you have any problems with - reading local files - getting the tiny error pages for nonexistent local files? These cases in dpi/file.c also use %ld for content length, passing in an off_t and a size_t.

March 24, 2009

compiling error on FreeBSD 6.4

by Johannes.Hofmann＠gmx.de

On Tue, Mar 24, 2009 at 08:42:56PM +0900, furaisanjin wrote: > 2009/3/24 Hofmann Johannes <Johannes.Hofmann(a)gmx.de>: > > Oh, maybe getc is a macro in FreeBSD? Can you please try attached > > patch that renames the getc() / ungetc() methods to something > > non-standard. > > Thank you. The patch works fine. I can compile dillo and it's working OK. Committed. Thanks for testing, Johannes

March 24, 2009

compiling error on FreeBSD 6.4

by furaisanjin＠gmail.com

2009/3/24 Hofmann Johannes <Johannes.Hofmann(a)gmx.de>: > Oh, maybe getc is a macro in FreeBSD? Can you please try attached > patch that renames the getc() / ungetc() methods to something > non-standard. Thank you. The patch works fine. I can compile dillo and it's working OK. Regards, furaisanjin

March 24, 2009

bug tracker doesn't work with dillo?

by dillo-dev＠toykeeper.net

* corvid <corvid(a)lavabit.com> wrote: > Does using %d or casting the length to a long > change anything? Yes, either one resolves the issue. :) > It doesn't seem like adding a ptr arg should > be able to do anything to alignment, but > then I don't know what goes on in the > bowels of the varargs stuff. It looks like the alignment was probably off all along, and adding a parameter just revealed an old bug. I found that simply adding a "%s" to the format string, with an empty "" as its parameter, was enough to trigger the problem. More generally, I found that it works if I use an even number of variables in format string, but it fails with an odd number. So, I think the compiler is probably padding something and the "%ld" gets the extra zero bits it needs from the padding. -- Scott

March 24, 2009

[bug]: more CSS margin problems

by onepoint＠starurchin.org

On Tue, Mar 24, 2009 at 08:34:26AM +0100, Hofmann Johannes wrote: > On Sun, Mar 22, 2009 at 07:13:32AM +0000, Jeremy Henty wrote: > > On Sat, Mar 21, 2009 at 10:25:32AM +0100, Hofmann Johannes wrote: > > > > > Maybe we should just disable negative margins for now. [...] > > > Other ideas? > > > > No ideas, I'm afraid. I haven't really looked at Dillo's CSS or > > layout code. > > Ok, I've disabled negative margins for now. And it works very nicely. Excellent! Regards, Jeremy Henty

March 24, 2009

[bug]: more CSS margin problems

by Johannes.Hofmann＠gmx.de

On Sun, Mar 22, 2009 at 07:13:32AM +0000, Jeremy Henty wrote: > On Sat, Mar 21, 2009 at 10:25:32AM +0100, Hofmann Johannes wrote: > > > It seems that dw/* is not designed to handle overlapping widgets. > > Maybe we should just disable negative margins for now. Or at least > > ensure that only margins overlap but not widget contents. Other > > ideas? > > No ideas, I'm afraid. I haven't really looked at Dillo's CSS or > layout code. Ok, I've disabled negative margins for now. Cheers, Johannes

March 24, 2009

compiling error on FreeBSD 6.4

by Johannes.Hofmann＠gmx.de

Hi, On Tue, Mar 24, 2009 at 08:11:00AM +0900, furaisanjin wrote: > Hi all. > > I got compiling error on FreeBSD 6.4. I pulled and updated this > morning and then got this error. > > gmake[3]: Entering directory `/tmp/disk1/src/css/dillo/src' > if g++ -DHAVE_CONFIG_H -I. -I. -I.. > -DDILLORC_SYS='"/usr/local/etc/dillorc"' -I/usr/local/include -I.. > -I/usr/local/include/libpng -O2 -fno-strict-aliasing -pipe > -I/usr/local/include -I/usr/local/include/freetype2 > -I/usr/local/include -I/usr/X11R6/include -Wno-non-virtual-dtor -g -O2 > -Wall -W -Wno-unused-parameter -fno-rtti -fno-exceptions -MT web.o -MD > -MP -MF ".deps/web.Tpo" -c -o web.o web.cc; \ > then mv -f ".deps/web.Tpo" ".deps/web.Po"; else rm -f > ".deps/web.Tpo"; exit 1; fi > In file included from styleengine.hh:7, > from web.cc:25: > cssparser.hh:27: error: expected unqualified-id before '!' token > cssparser.hh:27: error: expected `)' before '!' token > gmake[3]: *** [web.o] Error 1 > gmake[3]: Leaving directory `/tmp/disk1/src/css/dillo/src' > gmake[2]: *** [all-recursive] Error 1 > gmake[2]: Leaving directory `/tmp/disk1/src/css/dillo/src' > gmake[1]: *** [all-recursive] Error 1 > gmake[1]: Leaving directory `/tmp/disk1/src/css/dillo' > gmake: *** [all] Error 2 > > I have no idea when this happned. Oh, maybe getc is a macro in FreeBSD? Can you please try attached patch that renames the getc() / ungetc() methods to something non-standard. Regards, Johannes

March 24, 2009

bug tracker doesn't work with dillo?

by dillo-dev＠toykeeper.net

* Scott Scriven <dillo-dev(a)toykeeper.net> wrote: > The first bad revision is: > changeset: 491:96a14e974cfb Some extra details... when I enable the MSG() call, this is what I get: r490: Query: {POST /paste/paste.php HTTP/1.1\x0D Connection: close\x0D Accept-Charset: utf-8,*;q=0.8\x0D Accept-Encoding: gzip\x0D Host: rafb.net\x0D Referer: http://rafb.net/\x0D User-Agent: Dillo/2.0\x0D Content-Length: 53\x0D Content-Type: application/x-www-form-urlencoded\x0D Cookie2: $Version="1"\x0D Cookie: uid=foo; $Path=/paste/; $Domain=rafb.net\x0D \x0D lang=C%2B%2B&nick=foo&desc=r490+works&text=r490+works} r491: Query: {POST /paste/paste.php HTTP/1.1\x0D Connection: close\x0D Accept-Charset: utf-8,*;q=0.8\x0D Accept-Encoding: gzip\x0D Host: rafb.net\x0D Referer: http://rafb.net/\x0D User-Agent: Dillo/2.0\x0D Content-Length: 47966194761781\x0D Content-Type: application/x-www-form-urlencoded\x0D Cookie2: $Version="1"\x0D Cookie: uid=foo; $Path=/paste/; $Domain=rafb.net\x0D \x0D lang=C%2B%2B&nick=foo&desc=r491+fails&text=r491+fails} So, it looks like the content-length is definitely the issue. I just don't see how it's getting changed. -- Scott

March 24, 2009

bug tracker doesn't work with dillo?

by dillo-dev＠toykeeper.net

* corvid <corvid(a)lavabit.com> wrote: > Oh, also, did 2.0 work for you? Yes. But how about something more specific... I ran 'hg bisect' on it and here is the result: The first bad revision is: changeset: 491:96a14e974cfb tag: 2.1-noCss user: corvid <corvid(a)lavabit.com> date: Thu Jan 15 18:33:04 2009 -0300 summary: Added the "http_language" dillorc option for setting HTTP's Accept-Language. The diff for that revision doesn't really tell me why it broke then... nothing obvious stands out. But r490 works and r491 doesn't. Maybe you'll see something I don't. :) -- Scott

March 24, 2009