March 2009 - Dillo-dev - lists.mailman3.com

[PATCH 3 of 3] Easy panning with the left mouse button

by 4winter＠informatik.uni-hamburg.de

# HG changeset patch # User Justus Winter <justus.winter(a)informatik.uni-hamburg.de> # Date 1236616924 -3600 # Node ID 46c62dde8967ae87914d0fbcc0ba7df61853750c # Parent 78c0fa261c84df53da7f69cc8f33dc85fa152f9c Easy panning with the left mouse button This is particulary useful for embedded devices with touch screens. In order to select text you have to double click and drag the pointer. Note that this functionality is disabled by default and can be enabled by the easy_panning directive in the configuration file with the exception of the selection behavior which is located in dw/selection.cc and lacks a reference to the prefs struct by design (dw is a toolkit and frontend agnostic). I think that dw needs an interface to tweak it's behaviour ie dw_config(DW_DOUBLECLICK_TO_SELECT, true). Any ideas? diff -r 78c0fa261c84 -r 46c62dde8967 dillorc --- a/dillorc Mon Mar 09 17:21:32 2009 +0100 +++ b/dillorc Mon Mar 09 17:42:04 2009 +0100 @@ -223,6 +223,8 @@ # (Such as "TAB character inside <PRE>"). #show_extra_warnings=NO +# Finger panning for embedded devices +#easy_panning=NO # ----------------------------------------------------------------------- # dillorc ends here. diff -r 78c0fa261c84 -r 46c62dde8967 dw/fltkviewport.cc --- a/dw/fltkviewport.cc Mon Mar 09 17:21:32 2009 +0100 +++ b/dw/fltkviewport.cc Mon Mar 09 17:42:04 2009 +0100 @@ -1,3 +1,4 @@ + /* * Dillo Widget * @@ -59,6 +60,8 @@ gadgets = new container::typed::List <object::TypedPointer < ::fltk::Widget> > (true); + + easyPanning = 0; } FltkViewport::~FltkViewport () @@ -140,6 +143,18 @@ scroll (0, vscrollbar->value () - scrollY); } +void FltkViewport::setEasyPanning(int value) +{ + easyPanning = value; + if (easyPanning) { + hscrollbar->hide(); + vscrollbar->hide(); + } else { + hscrollbar->show(); + vscrollbar->show(); + } +} + void FltkViewport::vscrollbarCallback (Widget *vscrollbar, void *viewportPtr) { ((FltkViewport*)viewportPtr)->vscrollbarChanged (); @@ -235,8 +250,9 @@ case ::fltk::PUSH: take_focus(); - if (::fltk::event_button() == ::fltk::MiddleButton) { - /* pass event so that middle click can open link in new window */ + if (::fltk::event_button() == ::fltk::MiddleButton || + (easyPanning && ::fltk::event_button() == ::fltk::LeftButton)) { + /* pass event so that the click can interact with any widgets */ if (FltkWidgetView::handle (event) == 0) { dragScrolling = 1; dragX = ::fltk::event_x(); @@ -248,7 +264,8 @@ break; case ::fltk::DRAG: - if (::fltk::event_button() == ::fltk::MiddleButton) { + if (::fltk::event_button() == ::fltk::MiddleButton || + (easyPanning && ::fltk::event_button() == ::fltk::LeftButton)) { if (dragScrolling) { scroll(dragX - ::fltk::event_x(), dragY - ::fltk::event_y()); dragX = ::fltk::event_x(); @@ -263,7 +280,8 @@ break; case ::fltk::RELEASE: - if (::fltk::event_button() == ::fltk::MiddleButton) { + if (::fltk::event_button() == ::fltk::MiddleButton || + (easyPanning && ::fltk::event_button() == ::fltk::LeftButton)) { dragScrolling = 0; setCursor (core::style::CURSOR_DEFAULT); } diff -r 78c0fa261c84 -r 46c62dde8967 dw/fltkviewport.hh --- a/dw/fltkviewport.hh Mon Mar 09 17:21:32 2009 +0100 +++ b/dw/fltkviewport.hh Mon Mar 09 17:42:04 2009 +0100 @@ -21,7 +21,7 @@ int scrollX, scrollY; int scrollDX, scrollDY; - int dragScrolling, dragX, dragY; + int easyPanning, dragScrolling, dragX, dragY; ::fltk::Scrollbar *vscrollbar, *hscrollbar; @@ -68,6 +68,7 @@ void setGadgetOrientation (bool hscrollbarVisible, bool vscrollbarVisible, GadgetOrientation gadgetOrientation); void addGadget (::fltk::Widget *gadget); + void setEasyPanning(int value); }; } // namespace fltk diff -r 78c0fa261c84 -r 46c62dde8967 dw/selection.cc --- a/dw/selection.cc Mon Mar 09 17:21:32 2009 +0100 +++ b/dw/selection.cc Mon Mar 09 17:42:04 2009 +0100 @@ -141,7 +141,7 @@ } } else { // normal selection handling - if (event && event->button == 1) { + if (event && event->button == 1 && event->numPressed == 2) { highlight (false, 0); resetSelection (); diff -r 78c0fa261c84 -r 46c62dde8967 src/prefs.c --- a/src/prefs.c Mon Mar 09 17:21:32 2009 +0100 +++ b/src/prefs.c Mon Mar 09 17:42:04 2009 +0100 @@ -153,6 +153,7 @@ { "allow_white_bg", &prefs.allow_white_bg, PREFS_BOOL }, { "buffered_drawing", &prefs.buffered_drawing, PREFS_INT32 }, { "contrast_visited_color", &prefs.contrast_visited_color, PREFS_BOOL }, + { "easy_panning", &prefs.easy_panning, PREFS_BOOL }, { "enterpress_forces_submit", &prefs.enterpress_forces_submit, PREFS_BOOL }, { "focus_new_tab", &prefs.focus_new_tab, PREFS_BOOL }, { "font_cursive", &prefs.font_cursive, PREFS_STRING }, diff -r 78c0fa261c84 -r 46c62dde8967 src/prefs.h --- a/src/prefs.h Mon Mar 09 17:21:32 2009 +0100 +++ b/src/prefs.h Mon Mar 09 17:42:04 2009 +0100 @@ -71,6 +71,7 @@ bool_t show_msg; bool_t show_extra_warnings; bool_t middle_click_drags_page; + bool_t easy_panning; }; /* Global Data */ diff -r 78c0fa261c84 -r 46c62dde8967 src/uicmd.cc --- a/src/uicmd.cc Mon Mar 09 17:21:32 2009 +0100 +++ b/src/uicmd.cc Mon Mar 09 17:42:04 2009 +0100 @@ -427,6 +427,10 @@ Layout *layout = new Layout (platform); FltkViewport *viewport = new FltkViewport (0, 0, 1, 1); + if (prefs.easy_panning) { + viewport->setEasyPanning (true); + fprintf(stderr, "easy panning enabled"); + } if (prefs.buffered_drawing == 1) viewport->setBufferedDrawing (true); else

March 9, 2009

Holiday week

by corvid＠lavabit.com

Jorge wrote: > [ ] "-fno-rtti -fno-exceptions" gcc: 64KB less. > Enabling this switches reduces the binary size. Is there more to this than the following:

March 9, 2009

[patch]: remove the BW_* flags

by onepoint＠starurchin.org

a_Bw_stop_clients() is always called with the BW_Root and BW_Img flags set, so we can remove those flags. That leaves only the BW_Force flag, so we can remove that too and change the flags argument to a boolean that indicates whether to force. Regards, Jeremy Henty

March 7, 2009

Server-side CSS detection?

by Johannes.Hofmann＠gmx.de

Hi Richard, On Sat, Mar 07, 2009 at 01:13:11AM +0000, Richard Neill wrote: > Dear All, > > I've just joined this list, so I hope I'm posting this in the right place. > > I'm a webmaster, and I want to make sure that my site works properly in > all browsers including dillo. However, some of the new code (*) in my > site relies on CSS properties such as display:none and does not > gracefully degrade. > > If a browser has no CSS support, the newest stuff breaks in a very ugly > manner, whereas most of the CSS I've written to date fails gracefully > (we don't really care if some text-colour is wrong). > > So my question is, how can I detect CSS support server-side? > I don't need to know precise details of the CSS-support; I just want a > simple yes/no. So Netscape 4.6 would be "yes", whereas Dillo 0.8, and > links/lynx/w3m/googlebot would be "no". > > I don't want to do it by user-agent sniffing, and, if at all possible, I > don't want to rely on javascript (there are plenty of people who have > CSS-capable browsers with JS turned off). > > I've had no luck from google, so I thought I'd ask here, as you'll know > the best way to do this. I don't think there is a way to detect CSS support other than checking the reported user agent, as CSS only changes the appearance on the client side. However dillo is currently getting some initial CSS support, so for dillo this problem may just disappear in the future. Regards, Johannes

March 7, 2009

Server-side CSS detection?

by rn214＠cam.ac.uk

Dear All, I've just joined this list, so I hope I'm posting this in the right place. I'm a webmaster, and I want to make sure that my site works properly in all browsers including dillo. However, some of the new code (*) in my site relies on CSS properties such as display:none and does not gracefully degrade. If a browser has no CSS support, the newest stuff breaks in a very ugly manner, whereas most of the CSS I've written to date fails gracefully (we don't really care if some text-colour is wrong). So my question is, how can I detect CSS support server-side? I don't need to know precise details of the CSS-support; I just want a simple yes/no. So Netscape 4.6 would be "yes", whereas Dillo 0.8, and links/lynx/w3m/googlebot would be "no". I don't want to do it by user-agent sniffing, and, if at all possible, I don't want to rely on javascript (there are plenty of people who have CSS-capable browsers with JS turned off). I've had no luck from google, so I thought I'd ask here, as you'll know the best way to do this. Thank you for your help, Regards, Richard (*) for example, I display HTML tooltips like this: span.tool { position: relative; cursor: help; } span.tool span.tip { display: none;} span.tool:hover span.tip { display: block; z-index: 100; position: absolute; top: 1.6em; left: 0; width: auto; padding: 6px; border: #F00;} <span class='tool'>this is the link <span class='tip'>Here is some <b>html</b> for the tooltip </span> </span> i.e. the tool.tip is normally hidden by display:none, but is displayed as result of the hover action. If a browser doesn't support the CSS display:none property, that will render in a very ugly way, with the tooltip contents displayed inline. So I want to have a way to fall-back (server-side) to: <span title='this is the tooltip, without html'>this is the link </span> My intention is to do this server-side, using a session-variable after testing whether the client supports CSS. But how?

March 7, 2009

[patch]: typo fix

by Johannes.Hofmann＠gmx.de

On Fri, Mar 06, 2009 at 06:55:16PM +0000, Jeremy Henty wrote: > > Nothing else to say, really. Attached. Committed.

March 6, 2009

Css_next_token() bug

by Johannes.Hofmann＠gmx.de

On Fri, Mar 06, 2009 at 05:57:09PM +0000, corvid wrote: > Johannes wrote: > > can someone (corvid?) please have a look at attached patch that > > fixes a bug in Css_next_token() (at least I think so). > > > > Consider: > > > > <div style="font-family: '\''; background-color: red;">foo bar</div> > > > > In firefox the background is red, in current dillo not, because the > > string '\'' is not parsed properly. > > As I'm still uncertain whether to go the re2c way (there the problem > > does not exist), I'd like to have this fixed in the standard version. > > However as the code is pretty subtle it would be nice if someone > > could have a look. > > It seems right to me. Thanks! Committed.

March 6, 2009

[patch]: typo fix

by onepoint＠starurchin.org

Nothing else to say, really. Attached. Regards, Jeremy Henty

March 6, 2009

Css_next_token() bug

by corvid＠lavabit.com

Johannes wrote: > can someone (corvid?) please have a look at attached patch that > fixes a bug in Css_next_token() (at least I think so). > > Consider: > > <div style="font-family: '\''; background-color: red;">foo bar</div> > > In firefox the background is red, in current dillo not, because the > string '\'' is not parsed properly. > As I'm still uncertain whether to go the re2c way (there the problem > does not exist), I'd like to have this fixed in the standard version. > However as the code is pretty subtle it would be nice if someone > could have a look. It seems right to me.

March 6, 2009

Css_next_token() bug

by Johannes.Hofmann＠gmx.de

Hi, can someone (corvid?) please have a look at attached patch that fixes a bug in Css_next_token() (at least I think so). Consider: <div style="font-family: '\''; background-color: red;">foo bar</div> In firefox the background is red, in current dillo not, because the string '\'' is not parsed properly. As I'm still uncertain whether to go the re2c way (there the problem does not exist), I'd like to have this fixed in the standard version. However as the code is pretty subtle it would be nice if someone could have a look. Cheers, Johannes

March 6, 2009